[jira] [Commented] (LOG4NET-350) Support HttpContextBase as a replacement of the HttpContext class in AspNetPatternLayoutConverter

[ https://issues.apache.org/jira/browse/LOG4NET-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424715#comment-13424715 ] Dominik Psenner commented on LOG4NET-350: - Replacing HttpContext with HttpContext

RE: recommendation for AspNetPatternLayoutConverter

I created LOG4NET-350 [1] which reflects this issue. [1] https://issues.apache.org/jira/browse/LOG4NET-350 _ From: Dominik Psenner [mailto:dpsen...@gmail.com] Sent: Monday, July 30, 2012 8:08 AM To: 'Log4NET Dev' Subject: RE: re

[jira] [Created] (LOG4NET-350) Support HttpContextBase as a replacement of the HttpContext class in AspNetPatternLayoutConverter

Dominik Psenner created LOG4NET-350: --- Summary: Support HttpContextBase as a replacement of the HttpContext class in AspNetPatternLayoutConverter Key: LOG4NET-350 URL: https://issues.apache.org/jira/browse/LOG4NE

RE: recommendation for AspNetPatternLayoutConverter

No need to worry George. :-) Personally I prefer to stay on the bleeding edge of development. Though, this issue is currently not a problem to me. Would you try and get something done that is backwards compatible? I will commit any useful patches. Cheers _ From: George Chung [mailt

Re: recommendation for AspNetPatternLayoutConverter

Yes, I completely discounted backwards compatibility, sorry. On Sun, Jul 29, 2012 at 2:13 PM, Dominik Psenner wrote: > On 07/27/2012 10:42 PM, George Chung wrote: > > It currently defines this abstract method: > > > > protected abstract > > void Convert(TextWriter writer, LoggingEvent loggingEve

Re: recommendation for AspNetPatternLayoutConverter

On 07/27/2012 10:42 PM, George Chung wrote: > It currently defines this abstract method: > > protected abstract > void Convert(TextWriter writer, LoggingEvent loggingEvent, HttpContext > httpContext) > > I would recommend changing it to: > > protected abstract void Convert(TextWriter writer, Lo