Re: String Equality Comparison, Broken Tests and .NET-1.x

2016-08-25 Thread Dangling Pointer
Re: String Equality Comparison, Broken Tests and .NET-1.x On 26 Aug 2016 12:36 a.m., "Dangling Pointer" mailto:danglingpoin...@outlook.com>> wrote: > > Dominik, looks good. I just quickly typed that code in email compose box. > Your changes are good enough to get incorp

Re: String Equality Comparison, Broken Tests and .NET-1.x

2016-08-25 Thread Dangling Pointer
t throw away a good 25 year old rum either, would you? :-) 2016-08-25 18:59 GMT+02:00 Dangling Pointer mailto:danglingpoin...@outlook.com>>: > Unfortunately, this doesn't work if `a` is allowed to be null. I made this change in https://github.com/apache/log4net/pull/30. I think we

Re: String Equality Comparison, Broken Tests and .NET-1.x

2016-08-25 Thread Dangling Pointer
> Unfortunately, this doesn't work if `a` is allowed to be null. I made this change in https://github.com/apache/log4net/pull/30. I think we can use: trimmedTargetName?.ToUpperInvariant() in C#6 syntax or the older syntax: string.IsNullOrEmpty(trimmedTargetName) && trimmedTargetName.ToUpperIn

Re: Questions About the .NET Core Build

2016-08-21 Thread Dangling Pointer
We are using signed assemblies in autofac-moq like this: https://github.com/autofac/Autofac.Extras.Moq/blob/d38df6d/src/Autofac.Extras.Moq/project.json#L6. It is just a matter of setting the path to snk file in project.json. You can find full set of options in the project.json published schema h

Re: Proposal - log4net extensions pacakge for ASP.NET Core

2016-08-20 Thread Dangling Pointer
ve. There should be 3 active developers on the project, otherwise a project should be retired and put to attic. Attic can be seen as a dormant state of the project. Are there other logging framework that have been candidated or are already part of .net core? On 21 Aug 2016 12:49 a.m., "Da

Re: Proposal - log4net extensions pacakge for ASP.NET Core

2016-08-20 Thread Dangling Pointer
ASP.NET Core That would once more bring up the discussion of taking over the ownership of the nuget package. On 20 Aug 2016 4:43 p.m., "Dangling Pointer" mailto:danglingpoin...@outlook.com>> wrote: Thanks Stefan! I am working on extensions package. We need a new version of

Re: Proposal - log4net extensions pacakge for ASP.NET Core

2016-08-20 Thread Dangling Pointer
dependency to extensions. :) Thanks again! From: Stefan Bodewig Sent: Thursday, August 18, 2016 4:16:11 AM To: Dangling Pointer Cc: log4net-dev@logging.apache.org Subject: Re: Proposal - log4net extensions pacakge for ASP.NET Core On 2016-08-15, Dangling Pointer

Re: Proposal - log4net extensions pacakge for ASP.NET Core

2016-08-14 Thread Dangling Pointer
ASP.NET Core On 2016-08-14, Dangling Pointer wrote: > ASP.NET Core has a pluggable logging infrastructure which a couple of > known providers are supporting: > https://github.com/aspnet/Logging/blob/dev/README.md#providers > Here is the documentation: > https://docs.asp.net/en/late

Proposal - log4net extensions pacakge for ASP.NET Core

2016-08-13 Thread Dangling Pointer
Hello, ASP.NET Core has a pluggable logging infrastructure which a couple of known providers are supporting: https://github.com/aspnet/Logging/blob/dev/README.md#providers Here is the documentation: https://docs.asp.net/en/latest/fundamentals/logging.html It would be very much appreciated