Re: String Equality Comparison, Broken Tests and .NET-1.x

Hi Jonas On 2016-08-23, wrote: > Stefan Bodewig wrote on 23.08.2016 06:14:32: >> On 2016-08-22, wrote: >>> Should we create some helper in SystemInfo that provides null-aware, >>> ordinal, casing-agnostic

Re: String Equality Comparison, Broken Tests and .NET-1.x

ut this wont be possible realize with the current manpower. > > > From: Dominik Psenner <dpsen...@gmail.com> > Sent: Thursday, August 25, 2016 7:52:37 PM > > To: Log4NET Dev > Subject: Re: String Equality Comparison, Broken Tests and .NET-1.x >

Re: String Equality Comparison, Broken Tests and .NET-1.x

:52:37 PM To: Log4NET Dev Subject: Re: String Equality Comparison, Broken Tests and .NET-1.x At first glance this will not compile: public static bool NeutralizeString(string input) { return string.IsNullOrEmpty(input) && input.ToUpper(CultureInfo.InvariantCulture); }

Re: String Equality Comparison, Broken Tests and .NET-1.x

NET1.1? Why would they care to > update the NuGet package, the next version of log4net, when they don't have > time to upgrade their project to newer version of the framework.. just a > thought.. :p > > ---------- > *From:* jonas.ba...@rohde-schwarz.com &

Re: String Equality Comparison, Broken Tests and .NET-1.x

__ From: jonas.ba...@rohde-schwarz.com <jonas.ba...@rohde-schwarz.com> Sent: Tuesday, August 23, 2016 1:50:29 PM To: Log4NET Dev Subject: Re: String Equality Comparison, Broken Tests and .NET-1.x Stefan Bodewig <bode...@apache.org> wrote on 23.08.2016 06:14:32: &g

Re: String Equality Comparison, Broken Tests and .NET-1.x

Stefan Bodewig <bode...@apache.org> wrote on 23.08.2016 06:14:32: > Von: Stefan Bodewig <bode...@apache.org> > An: "Log4Net Developers List" <log4net-dev@logging.apache.org> > Datum: 23.08.2016 06:14 > Betreff: Re: String Equality Comparison, Brok

Re: String Equality Comparison, Broken Tests and .NET-1.x

On 2016-08-22, wrote: > A recent commit [1] changed, among other things, some string equality > comparisons from `SomeComparer.Compare(a, "B", IgnoreCase) == 0` to > `a.ToUpperInvariant() == "B"`, see also [2]. > > Unfortunately, this doesn't work if `a` is allowed

Re: String Equality Comparison, Broken Tests and .NET-1.x

Thanks for your input Jonas. #30 is all around adding support for .net core and so I believe there might follow a few fixing commits. Anyway, the current status of .NET 1.x support is that we will drop it anytime soon. It is so ancient that people might as well stay with the current state of the