Hi,
Currently we don't throw any exceptions in log4php, but there's a few
places where I think it makes sense to throw an exception. In example
all configurators should yield an exception if something the provided
configuration is wrong.
Should we introduce exceptions in log4php? If so where
Christian Grobmeier wrote:
+1 on all!
Cool :) Then I'll reorganize this soon.
In the config folder is just LoggerPropertyGetter/Setter. This should
be core (as ReflectionUtils) or in the configurators folder too.
LoggerPropertyGetter doesn't provide anything, should be removed.
LoggerProper
Author: grobmeier
Date: Tue May 5 05:16:20 2009
New Revision: 771567
URL: http://svn.apache.org/viewvc?rev=771567&view=rev
Log:
fixed codeflow
Modified:
incubator/log4php/trunk/src/test/php/appenders/LoggerAppenderEchoTest.php
Modified:
incubator/log4php/trunk/src/test/php/appenders/Logger
Author: grobmeier
Date: Tue May 5 05:15:52 2009
New Revision: 771566
URL: http://svn.apache.org/viewvc?rev=771566&view=rev
Log:
added test for echo appender
Added:
incubator/log4php/trunk/src/test/php/appenders/LoggerAppenderEchoTest.php
Added: incubator/log4php/trunk/src/test/php/appenders
[
https://issues.apache.org/jira/browse/LOG4PHP-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Grobmeier reassigned LOG4PHP-30:
--
Assignee: Christian Grobmeier
> Implement LoggerAppenderPDO
> -
Thanks Gavin!
On Tue, May 5, 2009 at 6:36 AM, Gavin wrote:
> Yay,
>
> list now moderated and I've modded your latest changes through, shouldn't
> have any more problems, no idea where they went to before though.
>
> Gav...
>
>> -Original Message-
>> From: grobme...@apache.org [mailto:grob
Yay,
list now moderated and I've modded your latest changes through, shouldn't
have any more problems, no idea where they went to before though.
Gav...
> -Original Message-
> From: grobme...@apache.org [mailto:grobme...@apache.org]
> Sent: Tuesday, 5 May 2009 2:16 PM
> To: log4php-...@lo
Author: grobmeier
Date: Tue May 5 04:07:49 2009
New Revision: 771547
URL: http://svn.apache.org/viewvc?rev=771547&view=rev
Log:
#LOG4PHP-40: Merged LoggerAppender with LoggerAppenderSkeleton - moved methods
around and replaced references to LoggerAppenderSkeleton
Modified:
incubator/log4php
Author: grobmeier
Date: Tue May 5 04:32:59 2009
New Revision: 771557
URL: http://svn.apache.org/viewvc?rev=771557&view=rev
Log:
#LOG4PHP-23: syntax clean up
Modified:
incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderEcho.php
Modified: incubator/log4php/trunk/src/main/php/appende
Author: grobmeier
Date: Tue May 5 04:08:43 2009
New Revision: 771548
URL: http://svn.apache.org/viewvc?rev=771548&view=rev
Log:
#LOG4PHP-40: Merged LoggerAppender with LoggerAppenderSkeleton - removed
LoggerAppenderSkeleton
Removed:
incubator/log4php/trunk/src/main/php/LoggerAppenderSkeleto
Author: grobmeier
Date: Tue May 5 04:14:48 2009
New Revision: 771549
URL: http://svn.apache.org/viewvc?rev=771549&view=rev
Log:
#LOG4PHP-40: Merged LoggerAppender with LoggerAppenderSkeleton - clean up
Modified:
incubator/log4php/trunk/src/main/php/LoggerAppender.php
Modified: incubator/log
Author: grobmeier
Date: Tue May 5 04:15:45 2009
New Revision: 771550
URL: http://svn.apache.org/viewvc?rev=771550&view=rev
Log:
added enh 40
Modified:
incubator/log4php/trunk/CHANGELOG
Modified: incubator/log4php/trunk/CHANGELOG
URL:
http://svn.apache.org/viewvc/incubator/log4php/trunk/CHA
[
https://issues.apache.org/jira/browse/LOG4PHP-40?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Grobmeier resolved LOG4PHP-40.
Resolution: Fixed
Classes merged
> Merge LoggerAppender and LoggerAppenderSkeleton
Hi,
+1 on all!
> xml -> configurators (and move all configurators here)
In the config folder is just LoggerPropertyGetter/Setter. This should
be core (as ReflectionUtils) or in the configurators folder too.
LoggerPropertyGetter doesn't provide anything, should be removed.
LoggerPropertySetter c
Hi,
While cleaning up I'm wondering if we also should care about the naming
convention of the class names and directory structure? If we should do
it, this is the right time to do it.
I propose these changes in class names to align all names with eachother.
LoggerPatternLayout -> LoggerLayou
Merge LoggerAppender and LoggerAppenderSkeleton
---
Key: LOG4PHP-40
URL: https://issues.apache.org/jira/browse/LOG4PHP-40
Project: Log4php
Issue Type: Task
Components: Code
Re
Author: kurdalen
Date: Mon May 4 20:44:29 2009
New Revision: 771436
URL: http://svn.apache.org/viewvc?rev=771436&view=rev
Log:
more fixes to #LOG4PHP-39
Modified:
incubator/log4php/trunk/CHANGELOG
incubator/log4php/trunk/src/main/php/Logger.php
incubator/log4php/trunk/src/main/php/Lo
[
https://issues.apache.org/jira/browse/LOG4PHP-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Urdalen updated LOG4PHP-39:
Summary: Remove deprecated methods (was: Remove deprecated setPriority()
in Logger and LoggerRoot
[
https://issues.apache.org/jira/browse/LOG4PHP-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Urdalen resolved LOG4PHP-39.
-
Resolution: Fixed
> Remove deprecated setPriority() in Logger and LoggerRoot
> -
Author: kurdalen
Date: Mon May 4 20:31:52 2009
New Revision: 771428
URL: http://svn.apache.org/viewvc?rev=771428&view=rev
Log:
fixed #LOG4PHP-39
Modified:
incubator/log4php/trunk/src/main/php/Logger.php
incubator/log4php/trunk/src/main/php/LoggerRoot.php
Modified: incubator/log4php/trun
Remove deprecated setPriority() in Logger and LoggerRoot
-
Key: LOG4PHP-39
URL: https://issues.apache.org/jira/browse/LOG4PHP-39
Project: Log4php
Issue Type: Task
Reporter:
[
https://issues.apache.org/jira/browse/LOG4PHP-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Knut Urdalen updated LOG4PHP-39:
Component/s: Code
Priority: Minor (was: Major)
> Remove deprecated setPriority() in Logger
Siterer Christian Grobmeier :
LoggerAppenderSkeleton extends from LoggerAppender. LoggerAppender is
not used somewhere else in the whole project.
Is there really a need to have both classes? I currently think this is
a bit overkill. Why not having the classes mixed together and just
name it Logg
Hi,
i just saw:
- LoggerAppender
- LoggerAppenderSkeleton
LoggerAppenderSkeleton extends from LoggerAppender. LoggerAppender is
not used somewhere else in the whole project.
Is there really a need to have both classes? I currently think this is
a bit overkill. Why not having the classes mixed to
Author: kurdalen
Date: Mon May 4 10:49:38 2009
New Revision: 771267
URL: http://svn.apache.org/viewvc?rev=771267&view=rev
Log:
refactoring related to #LOG4PHP-32
Modified:
incubator/log4php/trunk/src/main/php/helpers/LoggerOptionConverter.php
Modified: incubator/log4php/trunk/src/main/php/h
Author: kurdalen
Date: Mon May 4 09:54:24 2009
New Revision: 771257
URL: http://svn.apache.org/viewvc?rev=771257&view=rev
Log:
sizeof() -> count()
Modified:
incubator/log4php/trunk/src/main/php/Logger.php
incubator/log4php/trunk/src/main/php/LoggerHierarchy.php
incubator/log4php/trun
>> any idea why my commit notifications come not through while Knuts get
>> through the wire perfectly?
>
> I have no idea. Quite annoying to not get notified. I had a lot of
> conflicting files this morning because I'm fixing the code style while you
> worked on some other ticket.
yes.. i had a c
27 matches
Mail list logo
