svn commit: r776574 - /incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderPDO.php

2009-05-19 Thread grobmeier
Author: grobmeier Date: Wed May 20 06:08:26 2009 New Revision: 776574 URL: http://svn.apache.org/viewvc?rev=776574&view=rev Log: added todo Modified: incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderPDO.php Modified: incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderPD

Segmentation Fault in LoggerLayoutHtmlTest

2009-05-19 Thread Christian Grobmeier
Hi all, i wrote LoggerLayoutHtmlTest. If you look at it, I have the first testcase x-ed out. The follow up testcase is quite the same, just with another LogLevel. If i let both cases run together, a SegmentationFault appears. I am confused why - I thought its cause of the strange LoggerLevel impl

svn commit: r776572 - /incubator/log4php/trunk/src/main/php/layouts/LoggerLayoutHtml.php

2009-05-19 Thread grobmeier
Author: grobmeier Date: Wed May 20 06:04:32 2009 New Revision: 776572 URL: http://svn.apache.org/viewvc?rev=776572&view=rev Log: added space for codestyle :-) Modified: incubator/log4php/trunk/src/main/php/layouts/LoggerLayoutHtml.php Modified: incubator/log4php/trunk/src/main/php/layouts/Lo

svn commit: r776571 - /incubator/log4php/trunk/src/main/php/LoggerLevel.php

2009-05-19 Thread grobmeier
Author: grobmeier Date: Wed May 20 06:03:55 2009 New Revision: 776571 URL: http://svn.apache.org/viewvc?rev=776571&view=rev Log: made properties private made constructor private cleaned up static stuff Modified: incubator/log4php/trunk/src/main/php/LoggerLevel.php Modified: incubator/log4php

svn commit: r776570 - in /incubator/log4php/trunk/src: main/php/LoggerHierarchy.php test/php/LoggerHierarchyTest.php test/php/LoggerLevelTest.php test/php/LoggerRootTest.php

2009-05-19 Thread grobmeier
Author: grobmeier Date: Wed May 20 06:02:45 2009 New Revision: 776570 URL: http://svn.apache.org/viewvc?rev=776570&view=rev Log: encapsulated property access (used already defined method instead of properties) Modified: incubator/log4php/trunk/src/main/php/LoggerHierarchy.php incubator/lo

svn commit: r776564 - /incubator/log4php/trunk/src/test/php/layouts/LoggerLayoutHtmlTest.php

2009-05-19 Thread grobmeier
Author: grobmeier Date: Wed May 20 05:46:27 2009 New Revision: 776564 URL: http://svn.apache.org/viewvc?rev=776564&view=rev Log: added some more tests Modified: incubator/log4php/trunk/src/test/php/layouts/LoggerLayoutHtmlTest.php Modified: incubator/log4php/trunk/src/test/php/layouts/Logger

svn commit: r776553 - /incubator/log4php/trunk/src/test/php/layouts/LoggerLayoutHtmlTest.php

2009-05-19 Thread grobmeier
Author: grobmeier Date: Wed May 20 05:10:27 2009 New Revision: 776553 URL: http://svn.apache.org/viewvc?rev=776553&view=rev Log: added first simple test Added: incubator/log4php/trunk/src/test/php/layouts/LoggerLayoutHtmlTest.php Added: incubator/log4php/trunk/src/test/php/layouts/LoggerLayo

svn commit: r776552 - in /incubator/log4php/trunk/src/main/php: LoggerLoggingEvent.php layouts/LoggerLayoutHtml.php

2009-05-19 Thread grobmeier
Author: grobmeier Date: Wed May 20 05:10:08 2009 New Revision: 776552 URL: http://svn.apache.org/viewvc?rev=776552&view=rev Log: moved time calculation from layout to event Modified: incubator/log4php/trunk/src/main/php/LoggerLoggingEvent.php incubator/log4php/trunk/src/main/php/layouts/L

svn commit: r776548 - /incubator/log4php/trunk/src/test/php/layouts/LoggerLayoutSimpleTest.php

2009-05-19 Thread grobmeier
Author: grobmeier Date: Wed May 20 04:56:14 2009 New Revision: 776548 URL: http://svn.apache.org/viewvc?rev=776548&view=rev Log: corrected name in logging event Modified: incubator/log4php/trunk/src/test/php/layouts/LoggerLayoutSimpleTest.php Modified: incubator/log4php/trunk/src/test/php/l

Re: LoggerAppenderSocket wire format (was Re: Difficult Testcases)

2009-05-19 Thread Curt Arnold
On May 19, 2009, at 2:08 AM, Christian Grobmeier wrote: I haven't looked at this, but I'm guessing that its wire format is not compatible with Chainsaw and log4j since they used their easiest implementation (Java serialization). log4cxx 0.9.7 had its own wire format, but it was dependent o

Re: PEAR package available

2009-05-19 Thread Curt Arnold
On May 19, 2009, at 3:14 AM, Knut Urdalen wrote: Note I had a problem with the "foreach" taskdef in build.xml while developing this. If you just want to run the "pear-package" target you can just comment out line 25 in build.xml. I see that this is some Maven dependency and I tried to run

svn commit: r776532 - /incubator/log4php/trunk/build.xml

2009-05-19 Thread carnold
Author: carnold Date: Wed May 20 03:30:36 2009 New Revision: 776532 URL: http://svn.apache.org/viewvc?rev=776532&view=rev Log: Move foreach taskdef into targets that use foreach and out of top level Modified: incubator/log4php/trunk/build.xml Modified: incubator/log4php/trunk/build.xml URL:

Re: svn commit: r772512 - in /incubator/log4php/trunk/src: main/php/LoggerManager.php main/php/appenders/LoggerAppenderPDO.php test/php/appenders/LoggerAppenderPDOTest.php

2009-05-19 Thread Christian Hammers
On Tue, 19 May 2009 06:51:05 +0200 Christian Grobmeier wrote: > Hi Christian, > > > I've not read the code completely but shouldn't there be a quote() or > > something around the insert statement? Although this is just the > > template, the single quote indicate at least that $sth->quote() is >

Re: Continuous integration with phpUnderControl

2009-05-19 Thread Christian Grobmeier
>> When clicking on appenders, it looks like PDOAppender is not tested. >> is there anything to do for making this work? A testcase is available >> > > Yes, that's right. The test case rely on pdo_sqlite extension. As you may > have noticed I added a markTestSkipped() if this extension is not avail

Re: Continuous integration with phpUnderControl

2009-05-19 Thread Knut Urdalen
Christian Grobmeier wrote: When clicking on appenders, it looks like PDOAppender is not tested. is there anything to do for making this work? A testcase is available Yes, that's right. The test case rely on pdo_sqlite extension. As you may have noticed I added a markTestSkipped() if this exte

Re: Continuous integration with phpUnderControl

2009-05-19 Thread Christian Grobmeier
Btw: http://www.substring.no:8080/cruisecontrol/buildresults/log4php?tab=coverage When clicking on appenders, it looks like PDOAppender is not tested. is there anything to do for making this work? A testcase is available Christian > On Tue, May 19, 2009 at 10:55 AM, Knut Urdalen wrote: >> Hi ag

Re: Continuous integration with phpUnderControl

2009-05-19 Thread Christian Grobmeier
Knut, this is great I love it! Thank you very much!! Best, Christian On Tue, May 19, 2009 at 10:55 AM, Knut Urdalen wrote: > Hi again, > > I've been running phpUnderControl with log4php for some time now [1]. > > For each revision: > - run all unit tests [2] > - and make code coverage report avai

Continuous integration with phpUnderControl

2009-05-19 Thread Knut Urdalen
Hi again, I've been running phpUnderControl with log4php for some time now [1]. For each revision: - run all unit tests [2] - and make code coverage report available from that build [3] - and make api documentation available from that build [4] - run PHP_CodeSniffer [5] (need to improve the sett

[jira] Resolved: (LOG4PHP-44) PEAR package

2009-05-19 Thread Knut Urdalen (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Knut Urdalen resolved LOG4PHP-44. - Resolution: Fixed > PEAR package > > > Key: LOG4PHP-44 >

PEAR package available

2009-05-19 Thread Knut Urdalen
Hi, You should now be able to build and install a valid PEAR package in trunk. This should be a good start. *Build* $ ant pear-package *Install* $ sudo pear install target/pear/log4php-2.0.0.tgz *Uninstall* $ sudo pear uninstall log4php *About the setup* - The packaging is done with PEAR_Pa

svn commit: r776223 - in /incubator/log4php/trunk: CHANGELOG build.xml package-config.php package.php

2009-05-19 Thread kurdalen
Author: kurdalen Date: Tue May 19 07:57:10 2009 New Revision: 776223 URL: http://svn.apache.org/viewvc?rev=776223&view=rev Log: fixed #LOG4PHP-44 (initial version of PEAR packaging) Added: incubator/log4php/trunk/package-config.php incubator/log4php/trunk/package.php Modified: incubat

[jira] Created: (LOG4PHP-44) PEAR package

2009-05-19 Thread Knut Urdalen (JIRA)
PEAR package Key: LOG4PHP-44 URL: https://issues.apache.org/jira/browse/LOG4PHP-44 Project: Log4php Issue Type: Improvement Components: Code Affects Versions: 2.0 Reporter: Knut Urdalen Assi

Re: LoggerAppenderSocket wire format (was Re: Difficult Testcases)

2009-05-19 Thread Christian Grobmeier
> I haven't looked at this, but I'm guessing that its wire format is not > compatible with Chainsaw and log4j since they used their easiest > implementation (Java serialization).  log4cxx 0.9.7 had its own wire format, > but it was dependent on the encoding, sizeof(int) and endianess so you had > t