Re: Thoughts about a comment in LoggerHierarchy...

2009-08-07 Thread Christian Hammers
Hello Apropos: > I also think, that only one instance is needed of LoggerHierarchy. I'm too tired to think about this in dept at the moment but coincidently I just stumbled about the following sentence in the log4j docs: "Recent log4j releases support multiple hierarchy trees. This enhancement a

Re: Log4php-56 - Logger initialization

2009-08-07 Thread Christian Hammers
Hello Am Fri, 7 Aug 2009 07:44:06 +0200 schrieb Christian Grobmeier : > Hi all, > > based on Christian Hammers Issue #56 I have made some thoughts. > > Currently, the initialization of Log4PHP is not objectoriented. Its > some procedural code at the of the Logger script. > Flow is that the scri

Re: Thoughts about a comment in LoggerHierarchy...

2009-08-07 Thread Christian Grobmeier
Hi, please see my other e-mail with refactoring thoughts before a while. Would like to hear your thoughts about that too, since your mail and mine is tied together. I also think, that only one instance is needed of LoggerHierarchy. But its not necessary to have a singleton() method in LoggerHiera

[jira] Resolved: (LOG4PHP-65) Mixing protected and private in Logger and the inheriting LoggerRoot

2009-08-07 Thread Christian Grobmeier (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-65?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Grobmeier resolved LOG4PHP-65. Resolution: Fixed Removed shadowing members from LoggerRoot and used Loggers member

Thoughts about a comment in LoggerHierarchy...

2009-08-07 Thread Christian Hammers
Hello Regarding the TODO comment: class LoggerHierarchy { ... /* TODO: In log4j is this class not a singleton. Why is it in log4php? */ public static function singleton() { static $instance; if(!isset($instance)) {

svn commit: r802170 - in /incubator/log4php/trunk/src: changes/changes.xml main/php/LoggerRoot.php

2009-08-07 Thread grobmeier
Author: grobmeier Date: Fri Aug 7 20:31:25 2009 New Revision: 802170 URL: http://svn.apache.org/viewvc?rev=802170&view=rev Log: LOG4PHP-65: Removed shadowing members from LoggerRoot and used Loggers members were appropriate Modified: incubator/log4php/trunk/src/changes/changes.xml incub

[jira] Resolved: (LOG4PHP-59) LoggerAppenderConsole is initialized wrong

2009-08-07 Thread Christian Grobmeier (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Grobmeier resolved LOG4PHP-59. Resolution: Fixed Thanks for review and the patch! Applied with rv802168 > Logger

svn commit: r802168 - /incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderConsole.php

2009-08-07 Thread grobmeier
Author: grobmeier Date: Fri Aug 7 20:21:16 2009 New Revision: 802168 URL: http://svn.apache.org/viewvc?rev=802168&view=rev Log: LOG4PHP-59 (reopened): patch applied from Christian Hammers. Boolean mixed up Modified: incubator/log4php/trunk/src/main/php/appenders/LoggerAppenderConsole.php Mo

Re: Use of SPL

2009-08-07 Thread Christian Hammers
Am Tue, 4 Aug 2009 13:40:07 +0200 schrieb Christian Grobmeier : > Hi guys, > just realized this: > http://de.php.net/manual/en/book.spl.php > > This makes everything more OOP. Its delivered by default with PHP 5.0 > and cannot be disabled with PHP 5.3. > I really think this makes code cleaner and

[jira] Reopened: (LOG4PHP-59) LoggerAppenderConsole is initialized wrong

2009-08-07 Thread Christian Hammers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4PHP-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Hammers reopened LOG4PHP-59: -- > r801073 | grobmeier | 2009-08-05 08:13:03 +0200 (Mi, 05. Aug 2009) | 1 Zeile > LOG4PHP-59