Littel patch that fix loading configuration file.
Rotem.
-----Original Message-----
From: Jim Jagielski <[email protected]>
To: Log4PHP Dev <[email protected]>
Subject: Re: Current state of log4php
Date: Tue, 20 Jan 2009 18:46:23 -0500
I'm open to champion any patches that come in...
On Jan 20, 2009, at 3:02 AM, Christian Grobmeier wrote:
> Thanks for your answers.
> I believe the code is good, but nothing seems to change. Having the
> email of Marshall in mind, it looks like he felt to make a fork to get
> his changes in and this means, there is space for improvement. To be
> honest, log4php looks a bit dead at the moment. And this is a sad
> thing - i am also trying to get my php project incubated and I hoped
> that here is more community action.
>
> On Fri, Jan 16, 2009 at 9:18 PM, Jim Jagielski <[email protected]>
> wrote:
>> There is not much activity at all. It doesn't mean that the
>> code sucks, it just means that it does what it should
>> do and there hasn't been any real push to add more...
>>
>> On Jan 16, 2009, at 1:50 AM, Christian Grobmeier wrote:
>>
>>> Hi there,
>>>
>>> is there anybody working on log4php?
>>>
>>> Best,
>>> Christian
>>>
>>
>>
>
--- /tmp/old.php 2009-02-07 17:12:56.000000000 +0200
+++ /var/www/pinukation/log4php/code/LoggerPropertyConfigurator.php
2009-02-07 17:05:50.000000000 +0200
@@ -331,7 +331,7 @@
function doConfigure($url, &$repository)
{
$properties = @parse_ini_file($url);
- if ($properties === false) {
+ if (!count($properties)) {
LoggerLog::warn("LoggerPropertyConfigurator::doConfigure() cannot
load '$url' configuration.");
return false;
}
@@ -658,4 +658,3 @@
}
}
-
