Re: Codestyle

2009-04-30 Thread Knut Urdalen
Ok, I'll fix the code style this weekend. We only have 54 source files. Not hard to fix manually since I have "Convert spaces to tabs" in TextMate :) Knut Curt Arnold wrote: If you do formatting changes, I'd suggest doing it as an independent commit not intermixed with any functional changes.

Re: Codestyle

2009-04-30 Thread Knut Urdalen
Yes, Curt, I agree with you, but currently I want to fix bugs instead of "wasting" time on code style ;) We'll clean up the code style later. I don't have good tools at hand to do this change myself (lack of knowledge, I see there is something in Maven, but that's a new tool for me an most PHP

Re: Codestyle

2009-04-30 Thread Curt Arnold
If you do formatting changes, I'd suggest doing it as an independent commit not intermixed with any functional changes. I think doing automated processing on the code base and doing it as one fell swoop either at the start of a development cycle or at the end is better than reformatting in

Re: Codestyle

2009-04-30 Thread Knut Urdalen
Christian Grobmeier wrote: I saw that newer methods hold brackets in the same line as method signature, while older doesnt. I am a fan of method { } like Knut seems to be, so can we agree on that codestyle? Yes, let's use the traditional Unix policy. I also saw _blub for private vari

Codestyle

2009-04-30 Thread Christian Grobmeier
Hi I saw that newer methods hold brackets in the same line as method signature, while older doesnt. I am a fan of method { } like Knut seems to be, so can we agree on that codestyle? I also saw _blub for private variables - i don't need that but can agree to it. Should we talk about any