Re: Now come code changes

2009-10-10 Thread Christian Hammers
Hello I checked all @func() and fixed most. There is one FIXME left that was added by me so I don't know how to fix it. There are print_r, var_dump and var_export but they seem to be ok. There are many TODOs but I think if we try to fix them all we will never release... :) bye, -christian- Am

Re: Now come code changes

2009-10-07 Thread Christian Grobmeier
> I grepped for other occurances: hm interesting. I also think we need to grep for FIXME and TODO and even for echo, print_r or var_dump. Just to make sure there is nothing open for the release :-) Christian > > $ egrep -rsn '@[_a-zA-Z0-9]+\(' . |grep -v .svn > ./main/php/LoggerLoggingEvent

Re: Now come code changes

2009-10-07 Thread Christian Hammers
Am Wed, 7 Oct 2009 06:50:50 +0200 schrieb Christian Grobmeier : > Yes will have > Just one thing, I don't think its good to use @ before commands, for > ex @mail() > > If one doesn't want errors, he should have error_reporting(0). > Otherwirse we surpress the errors even when we want em. Saw

Re: Now come code changes

2009-10-06 Thread Christian Grobmeier
Yes will have Just one thing, I don't think its good to use @ before commands, for ex @mail() If one doesn't want errors, he should have error_reporting(0). Otherwirse we surpress the errors even when we want em. Saw it only one time in testcase, but wanted to mention On Tue, Oct 6, 2009 at 9

Now come code changes

2009-10-06 Thread Christian Hammers
Hello My remaining changes affect actual php code so please start having an eye on the commit message! :) bye, -christian-