Re: Exceptions

2009-05-05 Thread Knut Urdalen
Christian Grobmeier wrote: Agreed. I think a simple LoggerException with appropriate Message inside should do all tricks we need. I don't think a LoggerConfiguratorException is really necessary, but this is a matter of taste. Nothing else than that the name of the exception is more specific to

Re: Exceptions

2009-05-05 Thread Christian Grobmeier
> Our prefix is "Logger". Which means we should have a LoggerException (base > exception class for everything exception class needed in log4php) + > LoggerConfiguratorException (for errors in configurators). > > I currently can't think of others. In general we should only throw > exceptions during

Re: Exceptions

2009-05-05 Thread Knut Urdalen
Christian Grobmeier wrote: you are reading minds. I thought the same when I was under shower this morning. Hehe, probably one of the best places to think about open source contributions ;) I think too that we should introduce exceptions. Basically I don't think we need too much exceptions.

Re: Exceptions

2009-05-05 Thread Christian Grobmeier
Hi, > Currently we don't throw any exceptions in log4php, but there's a few places > where I think it makes sense to throw an exception. In example all > configurators should yield an exception if something the provided > configuration is wrong. you are reading minds. I thought the same when I wa