Re: [Lsr] Pre-writeup review comments

2020-10-08 Thread Joel M. Halpern
Just to confirm, yes, that change Peter has made removing END.T resolves my concerns. Thanks, Joel On 10/8/2020 9:38 AM, Peter Psenak wrote: Hi Chris, please see inline: On 02/10/2020 12:32, Christian Hoppsprotocol= application/pgp-signature wrote: Thanks for the update, a couple issues

Re: [Lsr] Pre-writeup review comments

2020-10-08 Thread Peter Psenak
Hi Chris, please see inline: On 02/10/2020 12:32, Christian Hoppsprotocol= application/pgp-signature wrote: Thanks for the update, a couple issues remain. [ ] 7.1 and 8.1 The reserved bits for "SRv6 Locator TLV" and "SRv6 End.X SID sub-TLV" are defined differently (and probably incorrectly)

Re: [Lsr] Pre-writeup review comments

2020-10-02 Thread Christian Hopps
Thanks for the update, a couple issues remain. [ ] 7.1 and 8.1 The reserved bits for "SRv6 Locator TLV" and "SRv6 End.X SID sub-TLV" are defined differently (and probably incorrectly) than the other reserved bits. Reserved bits "MUST" be set to zero, not "SHOULD", I believe. [ ] 11.

Re: [Lsr] Pre-writeup review comments

2020-09-23 Thread Peter Psenak
Hi Chris, thanks for your comments. Please see inline (##PP): On 18/09/2020 16:08, Christian Hoppsprotocol= application/pgp-signature wrote: During my review and while doing the Shepherd writeup for https://datatracker.ietf.org/doc/draft-ietf-lsr-isis-srv6-extensions/ I came up with the

[Lsr] Pre-writeup review comments

2020-09-18 Thread Christian Hopps
During my review and while doing the Shepherd writeup for https://datatracker.ietf.org/doc/draft-ietf-lsr-isis-srv6-extensions/ I came up with the following comments: 4.3 - Maximum H.Encaps MSD Type: - what is the default if not advertised? 6. Advertising Anycast Property Should "Locator