Re: [LTP] [PATCH] Close fd's to make running on NFS work (part2)

2007-11-14 Thread Subrata Modak
On Wed, 2007-11-14 at 11:07 -0600, Kumar Gala wrote: > Missed this the first go around. > > - k Well, This worked for me and also being Applied. Kindly send your Patches in attachments. This was a small one and i could apply the changes manually without Hardship. --Subrata-- > > --- testcases/

Re: [LTP] fadvise64 and posix_fadvise

2007-11-14 Thread Subrata Modak
On Tue, 2007-11-13 at 12:15 +0530, Subrata Modak wrote: > On Tue, 2007-11-13 at 11:43 +0900, Masatake YAMATO wrote: > > > > Hi, > > > > > > > > I'm interested in writing testcases for fadvise64 > > > > and posix_fadvise. I'd like to get some hints before > > > > starting work. > > > > > > Thanks.

[LTP] [PATCH] Add a lib routine to tell us if we are running on NFS.

2007-11-14 Thread Kumar Gala
Add a helper so tests can determine if they are running on NFS since some tests are not valid if run from NFS or the results may vary. -k diff -Nur ltp.orig/include/test.h ltp/include/test.h --- ltp.orig/include/test.h 2006-05-26 01:17:53.0 -0500 +++ ltp/include/test.h 2007-11-14

[LTP] TCONF vs TBROK

2007-11-14 Thread Kumar Gala
I'm trying to figure what the appropriate result is for some tests. For example, if we run on NFS, the kernel doesn't currently support swap over NFS thus should a swapon test return TCONF or TBROK if the test detects that its being run on a NFS fs? - k --

[LTP] [PATCH] Close fd's to make running on NFS work (part2)

2007-11-14 Thread Kumar Gala
Missed this the first go around. - k --- testcases/kernel/syscalls/creat/creat05.c 2007-11-09 06:12:45.0 -0600 +++ ../ltp-full-20071031/testcases/kernel/syscalls/creat/ creat05.c 2007-11-09 04:23:56.0 -0600 @@ -68,6 +68,7 @@ int exp_enos[] = {EMFILE, 0}; int fd, ifile, m

Re: [LTP] [PATCH] Close fd's to make running on NFS work

2007-11-14 Thread Kumar Gala
On Nov 14, 2007, at 10:23 AM, Subrata Modak wrote: > On Wed, 2007-11-14 at 08:20 -0600, Kumar Gala wrote: >> On Nov 14, 2007, at 6:39 AM, Subrata Modak wrote: >> >>> Would you like to check Brenoś Patch submitted on for nfs mounted >>> problems and then see how best can your below patch be applie

Re: [LTP] [PATCH] Create testfile in tmpdir to be consistent with other tests.

2007-11-14 Thread Kumar Gala
On Nov 14, 2007, at 10:30 AM, Subrata Modak wrote: > On Wed, 2007-11-14 at 08:25 -0600, Kumar Gala wrote: >> I'm running through the testcases that are part of syscall suite at >> this point. I think we should work on cleaning up the others. Having >> control over where temp files are created se

Re: [LTP] [PATCH] Create testfile in tmpdir to be consistent with other tests.

2007-11-14 Thread Subrata Modak
On Wed, 2007-11-14 at 08:25 -0600, Kumar Gala wrote: > I'm running through the testcases that are part of syscall suite at > this point. I think we should work on cleaning up the others. Having > control over where temp files are created seems like a good thing. You are welcome to do all the

Re: [LTP] [PATCH] Close fd's to make running on NFS work

2007-11-14 Thread Subrata Modak
On Wed, 2007-11-14 at 08:20 -0600, Kumar Gala wrote: > On Nov 14, 2007, at 6:39 AM, Subrata Modak wrote: > > > Would you like to check Brenoś Patch submitted on for nfs mounted > > problems and then see how best can your below patch be applied over > > that. I am finding problems in applying your

Re: [LTP] [PATCH] Create testfile in tmpdir to be consistent with other tests.

2007-11-14 Thread Kumar Gala
I'm running through the testcases that are part of syscall suite at this point. I think we should work on cleaning up the others. Having control over where temp files are created seems like a good thing. The issue with splice01 & tee01 is that you can't do certain form of splice on a NFS ro

Re: [LTP] [PATCH] Close fd's to make running on NFS work

2007-11-14 Thread Kumar Gala
On Nov 14, 2007, at 6:39 AM, Subrata Modak wrote: Would you like to check Brenoś Patch submitted on for nfs mounted problems and then see how best can your below patch be applied over that. I am finding problems in applying your patch (you can create a diff with the latest CVS). And also your e

Re: [LTP] [PATCH] Create testfile in tmpdir to be consistent with other tests.

2007-11-14 Thread Subrata Modak
This Seems Fine with me. Applied too. But what about other hundreds of instances in other testcases ?? --Subrata-- On Wed, 2007-11-14 at 00:34 -0600, Kumar Gala wrote: > Create testfile in tmpdir to be consistent with other tests. > > The makes the behavior consistent with other testcases if /tm

Re: [LTP] [PATCH] Close fd's to make running on NFS work

2007-11-14 Thread Subrata Modak
Or you may try resending the patch in an attached file. When you send as an inline text, then several characters get changed due to handling by mail clients at both sides. I might be facing this issue after long time. --Subrata-- On Wed, 2007-11-14 at 18:09 +0530, Subrata Modak wrote: > Would you

Re: [LTP] [PATCH] Close fd's to make running on NFS work

2007-11-14 Thread Subrata Modak
Would you like to check Brenoś Patch submitted on for nfs mounted problems and then see how best can your below patch be applied over that. I am finding problems in applying your patch (you can create a diff with the latest CVS). And also your earlier mail regarding: 1) fchown03 failure on nfs root