[LTP] [PATCH] pthread_cond_signal/1-1: use sched_yield to sync threads

2012-07-18 Thread Kang Kai
This case fails on mips board routerstation randomly. The root cause is that when main thread call usleep(100) after signal the child threads, no child thread is scheduled to run. So the case fails. I update it to set main thread with a lower priority and child threads with a higher one, then cal

[LTP] [POSIX] V2: pthread_cond_signal/1-1: use sched_yield to sync threads

2012-07-18 Thread Kang Kai
Hi Cyril, Version 2 update: 1 remove the set_affinity() 2 drop the use of sched_yield in loop waiting 3 don't remove the usleep(100) after add sched_yield when main thread release the condition variable. Regards, Kai

Re: [LTP] [PATCH] pthread_cond_signal/1-1: use sched_yield to schedule child threads

2012-07-18 Thread Kang Kai
On 2012年07月18日 19:50, chru...@suse.cz wrote: > Hi! This case fails on mips board routerstation randomly. The root cause is that when main thread call usleep(100) after signal the child threads, no child thread is scheduled to run. So the case fails. I update it to set main

Re: [LTP] [PATCH 1/6] /lib/tst_tmpdir indentation and coding style fixes

2012-07-18 Thread Caspar Zhang
On 07/18/2012 10:42 PM, marios.makris wrote: > On 18 July 2012 16:51, Caspar Zhang wrote: >> On 07/18/2012 09:32 PM, marios.makris wrote: >>> >>> On 18 July 2012 11:20, Wanlong Gao wrote: On 07/13/2012 11:51 PM, Marios Makris wrote: > > Identation and coding style fixes as well

Re: [LTP] [PATCH 1/6] /lib/tst_tmpdir indentation and coding style fixes

2012-07-18 Thread marios.makris
On 18 July 2012 16:51, Caspar Zhang wrote: > On 07/18/2012 09:32 PM, marios.makris wrote: >> >> On 18 July 2012 11:20, Wanlong Gao wrote: >>> >>> On 07/13/2012 11:51 PM, Marios Makris wrote: Identation and coding style fixes as well as moved the function descriptions to the he

Re: [LTP] [PATCH 1/6] /lib/tst_tmpdir indentation and coding style fixes

2012-07-18 Thread Caspar Zhang
On 07/18/2012 09:32 PM, marios.makris wrote: > On 18 July 2012 11:20, Wanlong Gao wrote: >> On 07/13/2012 11:51 PM, Marios Makris wrote: >>> Identation and coding style fixes as well as moved the function descriptions >>> to the header file (/include/test.h) >>> >>> Signed-off-by: Marios Makris >

Re: [LTP] [PATCH 1/6] /lib/tst_tmpdir indentation and coding style fixes

2012-07-18 Thread marios.makris
On 18 July 2012 11:20, Wanlong Gao wrote: > On 07/13/2012 11:51 PM, Marios Makris wrote: >> Identation and coding style fixes as well as moved the function descriptions >> to the header file (/include/test.h) >> >> Signed-off-by: Marios Makris >> --- >> include/test.h | 26 +++ >>

Re: [LTP] [PATCH 4/6] /lib/tst_tmpdir.c removed / and * checks

2012-07-18 Thread marios.makris
On 18 July 2012 12:32, Wanlong Gao wrote: > On 07/13/2012 11:51 PM, Marios Makris wrote: >> These checks are implemented in the rmobj.c file therefore there is no >> need to repeat them here since rmobj() is called for deletions. >> >> Signed-off-by: Marios Makris >> --- >> lib/tst_tmpdir.c |

Re: [LTP] [PATCH] pthread_cond_signal/1-1: use sched_yield to schedule child threads

2012-07-18 Thread chrubis
Hi! > >>This case fails on mips board routerstation randomly. The root cause is > >>that when main thread call usleep(100) after signal the child threads, > >>no child thread is scheduled to run. So the case fails. > >> > >>I update it to set main thread with a lower priority and child threads > >

Re: [LTP] [PATCH 5/6] /lib/tst_tmpdir.c removed the TDIRECTORY part

2012-07-18 Thread Wanlong Gao
On 07/13/2012 11:51 PM, Marios Makris wrote: > After recent question to the list, it seems that the TDIRECTORY PART is not > used by anyone, therefore it is removed. OK, we can also use "-d TMPDIR" option, so no objection with removing this. > > Signed-off-by: Marios Makris Reviewed-by: Wanlo

Re: [LTP] [PATCH 4/6] /lib/tst_tmpdir.c removed / and * checks

2012-07-18 Thread Wanlong Gao
On 07/13/2012 11:51 PM, Marios Makris wrote: > These checks are implemented in the rmobj.c file therefore there is no > need to repeat them here since rmobj() is called for deletions. > > Signed-off-by: Marios Makris > --- > lib/tst_tmpdir.c | 17 - > 1 file changed, 17 deletio

Re: [LTP] [PATCH] mm/lib: correct the log messages

2012-07-18 Thread Caspar Zhang
On 07/18/2012 04:51 PM, Zhouping Liu wrote: > commit 5ad42f6cae increased the sleep time of ksmd scanning > inside _wait_ksm_done(), but it forgot to update the log messages. > > Signed-off-by: Zhouping Liu > --- > testcases/kernel/mem/lib/mem.c |2 +- > 1 file changed, 1 insertion(+), 1 de

Re: [LTP] [PATCH] mm/lib: correct the log messages

2012-07-18 Thread Wanlong Gao
On 07/18/2012 04:51 PM, Zhouping Liu wrote: > commit 5ad42f6cae increased the sleep time of ksmd scanning > inside _wait_ksm_done(), but it forgot to update the log messages. > > Signed-off-by: Zhouping Liu Pushed, thank you. Wanlong Gao > --- > testcases/kernel/mem/lib/mem.c |2 +- > 1 f

[LTP] [PATCH] mm/lib: correct the log messages

2012-07-18 Thread Zhouping Liu
commit 5ad42f6cae increased the sleep time of ksmd scanning inside _wait_ksm_done(), but it forgot to update the log messages. Signed-off-by: Zhouping Liu --- testcases/kernel/mem/lib/mem.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testcases/kernel/mem/lib/mem.c b/te

Re: [LTP] [PATCH 1/6] /lib/tst_tmpdir indentation and coding style fixes

2012-07-18 Thread Wanlong Gao
On 07/13/2012 11:51 PM, Marios Makris wrote: > Identation and coding style fixes as well as moved the function descriptions > to the header file (/include/test.h) > > Signed-off-by: Marios Makris > --- > include/test.h | 26 +++ > lib/tst_tmpdir.c | 97 > ++

Re: [LTP] [PATCH 3/6] /lib/tst_tmpdir.c removed mkstemp method

2012-07-18 Thread Wanlong Gao
On 07/13/2012 11:51 PM, Marios Makris wrote: > Removed the mkstemp method keeping only the mkdtemp since it was added in > glibc in 2000, therefore it should be available in every linux distro. > > Signed-off-by: Marios Makris Reviewed-by: Wanlong Gao > --- > lib/tst_tmpdir.c | 37 -

Re: [LTP] [PATCH 2/6] Add mkdtemp check.

2012-07-18 Thread Wanlong Gao
On 07/13/2012 11:51 PM, Marios Makris wrote: > From: Cyril Hrubis > > Added an m4 macro checking for mkdtemp() > > Signed-off-by: Cyril Hrubis > Signed-off-by: Marios Makris Reviewed-by: Wanlong Gao > --- > configure.ac |1 + > m4/ltp-mkdtemp.m4 |2 ++ > 2 files changed, 3 ins

Re: [LTP] [PATCH] pthread_cond_signal/1-1: use sched_yield to schedule child threads

2012-07-18 Thread Kang Kai
On 2012年07月13日 21:07, chru...@suse.cz wrote: > Hi! Hi Cyril, Thanks for your detailed review. Please see my comments. >> This case fails on mips board routerstation randomly. The root cause is >> that when main thread call usleep(100) after signal the child threads, >> no child thread is schedu