Re: [LTP] LTP-cpuset test cases

2021-09-10 Thread Cyril Hrubis
s means that you have found a kernel bug. Which means that the bug in the kernel has to be identified and fixed. -- Cyril Hrubis chru...@suse.cz ___ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] fs/ftest/ftest06.c: Fix too small name string and related failure

2018-08-23 Thread Cyril Hrubis
Hi! This mailing list has been replaced by l...@lists.linux.it long time ago, please send patches to the new list instead. -- Cyril Hrubis chru...@suse.cz -- Check out the vibrant tech community on one of the world&#

Re: [LTP] [PATCH] inotify07: Add test for kernel crash during event notification

2018-05-10 Thread Cyril Hrubis
review will have to wait at least a week or two. -- Cyril Hrubis chru...@suse.cz -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot

Re: [LTP] [PATCH] inotify07: Add test for kernel crash during event notification

2018-05-04 Thread Cyril Hrubis
suppose I should have posted to fsdevel and CC Jan anyway... I do prefer mailing list over pull requests but I work with both. -- Cyril Hrubis chru...@suse.cz -- Check out the vibrant tech community on one of the w

Re: [LTP] [PATCH] inotify07: Add test for kernel crash during event notification

2018-05-03 Thread Cyril Hrubis
Hi! This is the old mailing list that has been abandoned a few years ago when sourceforge had frequent outages, the new one is at l...@lists.linux.it. -- Cyril Hrubis chru...@suse.cz -- Check out the vibrant tech

Re: [LTP] execute group of test cases.

2016-07-25 Thread Cyril Hrubis
4_ioc > netns_comm_ns_exec_ipv6_ioc > netns_comm_ip_ipv4_netlink > netns_comm_ip_ipv6_netlink > netns_comm_ip_ipv4_ioctl > netns_comm_ip_ipv6_ioctl The easiest way is to create custom runtest file, i.e. copy runtest/containers to new file and delete what you do not want to run. Then you can pass the

Re: [LTP] how to cross compile linux test project?

2015-11-09 Thread Cyril Hrubis
shouldn't need anything more than setting up right compiler: $ export CC=arm-buildroot-linux-gnueabi-gcc $ make -- Cyril Hrubis chru...@suse.cz -- Presto, an open source distributed SQL query engine for big data, init

Re: [LTP] error while compiling ltp statically

2015-10-29 Thread Cyril Hrubis
Hi! This list has been retired, please use l...@lists.linux.it (http://lists.linux.it/listinfo/ltp) instead. -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list mailing list Ltp

Re: [LTP] how to cross compile linux test project?

2015-10-22 Thread Cyril Hrubis
7;ve updated all LTP documentation to point to this list so if you, for instance look at README in the LTP git repo it will point you this page as well... -- Cyril Hrubis chru...@suse.cz -- __

Re: [LTP] how to cross compile linux test project?

2015-10-22 Thread Cyril Hrubis
Hi! FYI this list has been abandoned, all discussion now happens on l...@lists.linux.it -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list mailing list Ltp-list

Re: [LTP] [PATCH v2] sched_getattr/sched_getattr01: Add new testcase to test sched_getattr

2015-09-29 Thread Cyril Hrubis
" %u", attr.sched_deadline, DEADLINE_VAL); > + fail++; > + } > + > + if (fail) > + tst_resm(TFAIL, "attributes were read back incorrectly"); > + else > + tst_resm(TPASS, "attributes were read back correctly&q

Re: [LTP] [PATCH] cgroup_fj: fixed exit codes in case of not supported tests

2015-09-24 Thread Cyril Hrubis
fi > > -exit $ret; > +tst_exit Unless the whole script is converted to the test.sh the exit $ret must stay here, otherwise the return status from the test will be always 0. T

Re: [LTP] [PATCH] cgroup_fj: renamed arguments because the previous ones were not clear.

2015-09-24 Thread Cyril Hrubis
sage is: short commit description <= 50 characters [empty line] longer commit description that may span across multiple lines with lines up to 72 chars long... [empty line] Signed-of

Re: [LTP] [PATCH] Enable including config.mk and features.mk for *clean targets

2015-09-16 Thread Cyril Hrubis
Hi! > Seems like it's a better and more concise solution. Need I to prepare and > send a second version of the PATCH? Ideally yes, if you send a patch I will apply it right away. -- Cyril Hrubis chru

Re: [LTP] ltp: thp04.c test case

2015-09-15 Thread Cyril Hrubis
d1cdf04b4 -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] Query related to LTP test suite run

2015-09-15 Thread Cyril Hrubis
l you kernel contains the fix. -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] This list has been moved

2015-09-14 Thread Cyril Hrubis
Hi! I've just set up auto reply for this list that we have moved to the new list at l...@lists.linux.it. Please do not start a new conversations here and if you have pending patches please resend them to the new list. -- Cyril Hrubis chru...@su

Re: [LTP] [PATCH] mprotect04: fix powerpc crash when copying exec_func

2015-09-09 Thread Cyril Hrubis
alid. > * > * Note that, depending on architecture, this function probably just > * checks that the pointer is in the user space range - after calling > * this function, memory access functions may still re

Re: [LTP] [PATCH] mprotect04: fix powerpc crash when copying exec_func

2015-09-09 Thread Cyril Hrubis
Ah, you are right, the memory is not touched in the write_null() function at all. drivers/char/mem.c: static ssize_t write_null(struct file *file, const char __user *buf, size_t count, loff_t *ppos) { ret

Re: [LTP] [PATCH] mprotect04: fix powerpc crash when copying exec_func

2015-09-09 Thread Cyril Hrubis
. > -static void *get_func(void *mem) > +static int page_present(void *p) > { > - memcpy(mem, exec_func, getpagesize()); > + int fd; > + > + fd = SAFE_OPEN(cleanup, "page_present", O_WRONLY|O_CREAT, 0644); Why don't we use "/dev/null"?

[LTP] Moving the mailing list

2015-09-09 Thread Cyril Hrubis
list and then we will move the discusssion there. -- Cyril Hrubis chru...@suse.cz -- Monitor Your Dynamic Infrastructure at Any Scale With Datadog! Get real-time metrics from all of your servers, apps and tools in one

Re: [LTP] [PATCH v2] cpuhotplug_hotplug.sh: fix the return of cpu number

2015-09-08 Thread Cyril Hrubis
nce rest of the file uses four spaces for indentation and pushed, thanks. -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] Enable including config.mk and features.mk for *clean targets

2015-09-08 Thread Cyril Hrubis
rgets. Not that it's apriory wrong but I would rather be more conservative and only include the config.mk and features.mk. One option would be to add the: -include $(abs_top_builddir)/include/mk/config.mk -include $(abs_top_builddir)/include/mk/features

Re: [LTP] [PATCH] Enable including config.mk and features.mk for *clean targets

2015-09-08 Thread Cyril Hrubis
gt; https://github.com/linux-test-project/ltp/blob/master/include/mk/env_pre.mk#L98 > > So I've decided to include these configuration files for "clean" target too. > I've supposed that "clean" target may be invoked even if those files don't > exist

Re: [LTP] [PATCH] cgroup_fj: splited the tests to run them separately

2015-09-08 Thread Cyril Hrubis
+ tst_resm TPASS "case$i($CASETYPE$CASECMD) PASS" > +elif [ $ret -ne 9 ]; then > + tst_resm TFAIL "case$i($CASETYPE$CASECMD)FAIL" > +fi The rest looks good to me. -- Cyril Hrubis chru...@suse.cz

Re: [LTP] [PATCH] include/linux_syscall_numbers.h:Delete linux_syscall_numbers.h

2015-09-08 Thread Cyril Hrubis
low (takes seconds on new enough > machine). Does that still concern anybody? And since Jan pushed a patch that speeds up the script that generates the header significantly we can drop it from git now. I've applied this patch and added a .gitignore record for the header

Re: [LTP] [PATCH] linux_syscall_numbers: speed up generation

2015-09-08 Thread Cyril Hrubis
Hi! > Replace cat with echo, which should be a builtin function > for most shells. Avoiding to spawn 'cat' for every syscall > entry can save time when generating linux_syscall_numbers.h: Nice catch, acked. -- Cyril Hru

Re: [LTP] [PATCH] include/linux_syscall_numbers.h:Delete linux_syscall_numbers.h

2015-09-07 Thread Cyril Hrubis
achine). Does that still concern anybody? I guess that what you are trying to solve is that the file is not up to date and it's not updated automatically because the timestamp for the *.in files is the same as the linux_syscall_numbers.h since the files were created at the same time when the g

Re: [LTP] [PATCH] cpuhotplug_hotplug.sh: fix the return of cpu number

2015-09-07 Thread Cyril Hrubis
; { > -return $(get_present_cpus | wc -w) > + PRESENT_CPUS_NUM=`get_present_cpus | wc -w` > } Passing the value by global variable is ugly. Why don't we echo the value here as: echo $(get_present_cpus |wc -w), or even just call 'get_presnt_cpus |wc -w' and do: if [ $(get_present_cpu

Re: [LTP] [PATCH] Enable including config.mk and features.mk for *clean targets

2015-09-07 Thread Cyril Hrubis
where the mk files generated by configure does not exist but the tree is not clean. Unless one deletes them manually of course. -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list ma

Re: [LTP] [PATCH] cgroup_fj: renamed arguments because the previous ones were not clear.

2015-09-07 Thread Cyril Hrubis
Also we may only want to check that the parameter is a numeric so that we can tune the test parameters later (and for other parameters that can be tuned such as number of subgroup as well). The portable way to do that seems to be case statement: case $mount_times in ''|*[!0

[LTP] [ANNOUNCE] The Linux Test Project has been released for SEPTEMBER 2015

2015-09-03 Thread Cyril Hrubis
bugs, comments or questions should go to to our mailing list at ltp-list@lists.sourceforge.net. PS: We had numerous troubles with mailing list on sourceforge, if you are aware of good and free mailing list hosting service please let us know. -- Cyril Hrubis chru...@su

Re: [LTP] Syscall/io_* tests failing to compile

2015-09-03 Thread Cyril Hrubis
you cannot link against them. If that is the case you can either cross compile the libaio and set right path for linker etc. or set up an arm virtual machine or chroot with qemu arm emulation and compile LTP there. -- Cyril Hrubis chru

Re: [LTP] Syscall/io_* tests failing to compile

2015-09-03 Thread Cyril Hrubis
> make: *** [io_destroy01] Error 1 The -laio is missing from the command line, but since you are seeing the failure the HAVE_LIBAIO_H must be defined in config.h. So it's looks like you have hand edited config.h (which is wrong thing to do) after installing the lib

Re: [LTP] ltp: thp04.c test case

2015-09-02 Thread Cyril Hrubis
Hi! There was no response for about three months. If nobody stands up and fixes the testcase I would go for dropping it since it does not work reliably as it is. -- Cyril Hrubis chru...@suse.cz -- Monitor Your Dynamic

Re: [LTP] LTP release

2015-09-02 Thread Cyril Hrubis
Hi! I've just pushed last patch that has been requested to be included in the relese. Unless anybody objects I will proceed with tagging the git, uploading the tarballs, etc. tomorrow. If you haven't tested latest git yet, now is the last chance to do so. -- Cyril Hrubis chru.

Re: [LTP] Test Anything Protocal output

2015-09-02 Thread Cyril Hrubis
see if there's something I could look at prior > to the final release. Just now I'm still in the planning and designing phase. I will likely want to discuss the changes before they get commited to LTP, either as patches on ML or as sep

Re: [LTP] Test Anything Protocal output

2015-09-01 Thread Cyril Hrubis
iting it, than TAP could be added after that. Is this > re-write > a long term thing, or something your planning to complete in the next couple > months? The tst_res.c is one of the last files under the lib/ that hasn't been cleaned up

Re: [LTP] LTP release

2015-09-01 Thread Cyril Hrubis
declared in the kernel. Should be fixed in latest git, please test (don't forget to regenerate configure script). -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list m

Re: [LTP] [PATCH v2] ltp/pounder: Don't let the testing log output to /dev/tty

2015-09-01 Thread Cyril Hrubis
before the release. -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] LTP release

2015-09-01 Thread Cyril Hrubis
. But I doubt that this will be the case, at least for any released distribution. -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] LTP release

2015-09-01 Thread Cyril Hrubis
t; In RHEL5.11GA, ns_ifmove.c gives compilation error since 'IFLA_NET_NS_PID' > undeclared in the kernel. Looks like we need a configure check for the enum constant and way to propagate TCONF from the ns_ifmove to the netns_helper.s

Re: [LTP] LTP release

2015-09-01 Thread Cyril Hrubis
> network > namespace as it is used in netns testcases. I will rewrite ns_create and > ns_exec > after the release. I was trying to be more defensive and remove everything that is not needed, but I can live with this so

Re: [LTP] Linux 3.10

2015-08-31 Thread Cyril Hrubis
the testcases are of course welcomed. -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] LTP release

2015-08-31 Thread Cyril Hrubis
now and rewriting it after the release? Everybody: If you have issues with the latest git please report them. And if you haven't tested it yet please do so ASAP. -- Cyril Hrubis chru.

Re: [LTP] Test Anything Protocal output

2015-08-31 Thread Cyril Hrubis
o the test library, so that each testcase would fork first, then run the real test in it's own virtual terminal, etc. -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-li

Re: [LTP] [PATCH 1/2 v3] added helper tools for creating and working with namespaces

2015-08-27 Thread Cyril Hrubis
Hi! > ./ns_exec 1234 mnt pid uts ls / > > seems a bit confusing to me. Maybe use just $2 and comma-separate the > names? (Also for ns_create, for consistency.) > > pid=$(./ns_create pid,mnt,uts,net) > ./ns_exec $pid mnt,pid ls / That's a bit harder to parse but you

Re: [LTP] [PATCH 1/2 v3] added helper tools for creating and working with namespaces

2015-08-27 Thread Cyril Hrubis
d pass would actually call the setns() one by one in the order they were specified. -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 1/2 v3] added helper tools for creating and working with namespaces

2015-08-27 Thread Cyril Hrubis
happen only in case I've actually created new user namespace. > In addition, there are probably going to be some problems with > capability bits when calling execve(2) after doing setns on user ns > (see capabilities(7), "Thread

Re: [LTP] [PATCH 1/2 v3] added helper tools for creating and working with namespaces

2015-08-27 Thread Cyril Hrubis
hange the ns_create that creates the handle to create new user namespace as well it can succesfully join it. Why do we attempt to join all namespaces in the ns_exec? I guess that we will have to change it to get a list of namespaces to join the same way the ns_create

Re: [LTP] [PATCH 1/2 v3] added helper tools for creating and working with namespaces

2015-08-26 Thread Cyril Hrubis
argv[1]); > + close_ns_fd(); > + return 1; > + } > + > + for (i = 0; i < ns_fd_index; i++) { > + if (syscall(__NR_setns, ns_fd[i], 0) == -1) { > + tst_resm(TINFO | TERRNO,

Re: [LTP] [PATCH v2] inotify: Add test for inotify mark destruction race

2015-08-25 Thread Cyril Hrubis
Hi! > Interesting, probably SRCU is much slower with this older kernel. From my > experiments 100 iterations isn't quite reliable to trigger the oops in my > testing instance. But 400 seem to be good enough. I've changed the nuber of iterations to 400 and pushed it to git,

Re: [LTP] [PATCH] network/tcp_fastopen: fix typo in check_opt() and check_opt_l()

2015-08-25 Thread Cyril Hrubis
Hi! > Can we apply this patch before release? Sure, acked. (I wonder how we missed that in the review...) -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list mailing list

Re: [LTP] [PATCH v2] inotify: Add test for inotify mark destruction race

2015-08-25 Thread Cyril Hrubis
seconds? -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] ltp/pounder: do some cleanup work for pounder21 test suites

2015-08-20 Thread Cyril Hrubis
Hi! Pushed, thanks. -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 3/3] pounder/cpufreq: Skip the test if processors are not supported by cpufreq

2015-08-20 Thread Cyril Hrubis
> + exit 255 > +fi This part of code was specially disabled in one commit, unfortunately it does not say why exactly it was disabled. So I'm hesitant to enable it unless we are sure tha

Re: [LTP] [PATCH 2/3] ltp/pounder: Don't let the testing log output to /dev/tty

2015-08-20 Thread Cyril Hrubis
quot;); > exit(2); Can't we rather rename the FILE * to 'out' or similar, naming it tty_fp when it does not point to tty is kind of confusing. Also we can simply do FILE *out = stdout; If we reopen it by it's file descriptior we will end up with two d

Re: [LTP] [PATCH 1/3] ltp/tools: remove the scripts/numa_test.sh file

2015-08-20 Thread Cyril Hrubis
Hi! Pushed, thanks. -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] LTP release

2015-08-20 Thread Cyril Hrubis
bugs that should be fixed before we start pre-release testing, please > let us know. If nobody objects I would like to freeze LTP git repository on Monday (24. 08.) and start the pre-release testing. If there are any patches that should be included the release, please let me know. --

Re: [LTP] [PATCH 2/2 v3] containers/netns tests rewritten

2015-08-20 Thread Cyril Hrubis
Hi! Pushed with these changes, thanks. -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo

Re: [LTP] [PATCH] netns: adjust the code corresponding to new version iproute's output format

2015-08-20 Thread Cyril Hrubis
Hi! I've just pushed complete rewrite of the testcases, please make sure that netns testcases from latest git works for you. -- Cyril Hrubis chru...@suse.cz -- ___ Ltp

Re: [LTP] [PATCH] containers: fix dev name in create_veth()

2015-08-20 Thread Cyril Hrubis
Hi! I've just pushed complete rewrite of the testcases, please make sure that netns testcases from latest git works for you. -- Cyril Hrubis chru...@suse.cz -- ___ Ltp

Re: [LTP] [PATCH] Use cpuctl_test* as TCID for cpuctl_test*.c.

2015-08-20 Thread Cyril Hrubis
Hi! Pushed, thanks. -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 2/2 v3] containers/netns tests rewritten

2015-08-20 Thread Cyril Hrubis
t may have been reused if there > > was a lot of forking done on the system meanwhile. Which is unlikely but > > still possible. > > True. Will you remove that kill command on pushing or shoul

Re: [LTP] [PATCH 2/2 v3] containers/netns tests rewritten

2015-08-19 Thread Cyril Hrubis
on. Killing it twice once in the test and once in the cleanup is mistake as well. Since the NS_HANDLE is pid and it may have been reused if there was a lot of forking done on the system meanwhile. Which is unlikely but st

Re: [LTP] [PATCH v4 2/2] umount2/umount2_03.c: add UMOUNT_NOFOLLOW flag test

2015-08-19 Thread Cyril Hrubis
Hi! Both pushed, thanks. -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 2/2 v3] containers/netns tests rewritten

2015-08-19 Thread Cyril Hrubis
/net >sysfs_after > +diff sysfs_before sysfs_after > +if [ $? -eq 0 ]; then > + tst_resm TPASS "sysfs not affected by a separate namespace" > +else > + tst_resm TFAIL "sysfs affected by a separate namespace" > +fi > +

Re: [LTP] Test Patch for diotest6

2015-08-18 Thread Cyril Hrubis
As far as I can see the testcase can work with just two buffers, one gets initialized in each iteration and one is read back and compared with the initialized one. -- Cyri

Re: [LTP] [PATCH] cpuctl: correct wrong TCID

2015-08-18 Thread Cyril Hrubis
ot;; I would rather see the TCID for cpuctl_test* to be renamed to cpuctl_test* to match the filenames. Otherwise these changes looks fine to me. -- Cyril Hrubis chru...@suse.cz -- __

Re: [LTP] [PATCH] Add capset_check_simple in runtest.

2015-08-18 Thread Cyril Hrubis
tionality was missing upon compilation rather than spreading #ifdefs around the code. I.e. #ifdef HAVE_FOO int main(int argc, char *argv[]) {

Re: [LTP] [PATCH] edf-scheduler/edf_test01: Add new testcase to test edf-sched

2015-08-13 Thread Cyril Hrubis
er\n"); > + } > + > + pthread_create(&thread, NULL, run_deadline, NULL); > + > + sleep(1); Do not use sleep this way in testcases ever. The main thread will sleep in the pthread_join() until the thread that does the test exits. This will on

Re: [LTP] [PATCH] mem/thp: skip thp02/thp03 if system not support hugepage

2015-08-13 Thread Cyril Hrubis
Hi! I've reworded the commit message and the TCONF message a bit and pushed, thanks. -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list mailing list Ltp

[LTP] LTP release

2015-08-13 Thread Cyril Hrubis
re we start pre-release testing, please let us know. -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/

Re: [LTP] [PATCH 18/23] network/virt: move checking for command support to virt_lib.sh

2015-08-12 Thread Cyril Hrubis
t standart formats as well. There are at least TAP[1] that comes from perl community and JUnit that comes from Jenkins. [1] https://testanything.org/ -- Cyril Hrubis chru...@suse.cz --

Re: [LTP] [PATCH 16/23] network/virt: add macvtap01 test

2015-08-12 Thread Cyril Hrubis
or no additional value on systems that does not support these options. I guess I can live with that, but I don't like it. -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list

Re: [LTP] [PATCH 09/23] network/virt/vlan03: add new test-case

2015-08-12 Thread Cyril Hrubis
Hi! > We can use tst_resm there and we would need to provide one more > parameter to determine was it PASS or FAIL (the expected result). It > will complicate virt_compare_netperf() a bit but still should be OK. That sounds reasonable to me. -- Cyril Hrubis chru..

Re: [LTP] [PATCH 00/23] Add vlan, ipvlan, gre, macvlan interfaces

2015-08-11 Thread Cyril Hrubis
Hi! > Most interfaces share the same ip command syntax and the same test > scenarious can be applied to them. So rename vxlan directory to more > general 'virt' directory and add those interfaces to it. Apart from the minor nitpicks this patchset looks good to me. --

Re: [LTP] [PATCH 19/23] network/virt: add test-case 02 to virt_lib.sh

2015-08-11 Thread Cyril Hrubis
t; diff --git a/testcases/network/virt/vxlan02.sh > b/testcases/network/virt/vxlan02.sh > index 1470495..0b3a21c 100755 > --- a/testcases/network/virt/vxlan02.sh > +++ b/testcases/network/virt/vxlan02.sh > @@ -16,8

Re: [LTP] [PATCH 18/23] network/virt: move checking for command support to virt_lib.sh

2015-08-11 Thread Cyril Hrubis
TCONF for testcases that only skip one test out of many is annoying, which is why I'm pondering a plan to change bitflags in the test library (both C and bash one) to counters so that we can say how much of the testcase was actually skipped. --

Re: [LTP] [PATCH 17/23] network/virt: add test-case 01 to virt_lib.sh

2015-08-11 Thread Cyril Hrubis
2>&1 > - if [ $? -ne 0 ]; then > - tst_resm TCONF "iproute or kernel doesn't support '$params'" > - params="" > - else > - ROD_SILENT "ip li delete ltp_v0" > - fi > - > - virt_multiple_add_test "$param

Re: [LTP] [PATCH 16/23] network/virt: add macvtap01 test

2015-08-11 Thread Cyril Hrubis
mit Your Business. Reach for the Cloud. > GigeNET's Cloud Solutions provide you with the tools and support that > you need to offload your IT needs and focus on growing your business. > Configured For All Businesses. Start Your Cloud Today. > https://www.gigenetcloud.com/ >

Re: [LTP] [PATCH 09/23] network/virt/vlan03: add new test-case

2015-08-11 Thread Cyril Hrubis
NFO "different VLAN ID shall not work together" > +res="TPASS" > +virt_setup "id 4093" "id 4094" > +virt_compare_netperf && res="TFAIL" > + > +tst_resm $res "done" I would rather see

Re: [LTP] [PATCH 04/23] network/virt_lib.sh: use ROD_SILENT in cleanup

2015-08-11 Thread Cyril Hrubis
x27;` > for vx in $viface; do > - ip link delete $vx > + ROD_SILENT "ip link set $vx down" > + ROD_SILENT "ip link delete $vx" Do we really want to exit the cleanup if deleting

Re: [LTP] [PATCH v2] inotify: Add test for inotify mark destruction race

2015-08-11 Thread Cyril Hrubis
ENOSYS etc. * Added inotify06 binary to gitignore. And checked that it still Opses kernel after these changes, thanks. -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list mailing list

Re: [LTP] [PATCH] Add tst_wait_record_childstatus function.

2015-08-11 Thread Cyril Hrubis
ps://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#227-doing-real-test-in-the-child-process -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list mailing list Ltp-list@

Re: [LTP] [PATCH V2] container: new testcase pidns32

2015-08-11 Thread Cyril Hrubis
Hi! > Hi, > > I'm still not entirely convinced about this test. So am I. What about checking that we can do at least MAXNEST levels? -- Cyril Hrubis c

Re: [LTP] Lachesis Linux tests

2015-08-11 Thread Cyril Hrubis
Hi! > Does the Lachesis is part of LTP? or Its a standalone linux test > framework available in opensource. Never heard of it. There is an pdf on lwn net about it but the links to repository are dead. I'm afraid that the project does not exist anymore. -- Cyril Hrubis chru

Re: [LTP] [PATCH v3 2/2] umount2/umount2_03.c: add UMOUNT_NOFOLLOW flag test

2015-08-10 Thread Cyril Hrubis
test_cases[i].string); > + return; > + } And here. Thinkig of it the best way would have been setting the string in the structure to: "umount2('symlink', UMOUNT_NOFOLLOW) %s expected EINVAL" and do tst_resm(...,

Re: [LTP] [PATCH v3 1/2] umount2/umount2_02.c: add MNT_EXPIRE flag test

2015-08-10 Thread Cyril Hrubis
e we succesfully failed with? > +} > + > +static void verify_success(int i) > +{ > + if (TEST_RETURN != 0) { > + tst_resm(TFAIL | TTERRNO, "umount2(2) failed, %s", > + test_cases[i].string); This would create pretty ugly messages i.e.

Re: [LTP] [PATCH] Add tst_wait_record_childstatus function.

2015-08-10 Thread Cyril Hrubis
tst_resm(TINFO, "Child process returned TBROK"); > + > + if (ttype_result & TCONF) > + tst_resm(TINFO, "Child process returned TCONF"); > + > + } else { > + tst_brkm(TBROK, cleanup, "child process killed by &

Re: [LTP] [PATCH 2/2] fcntl/fcntl33.c: add new test

2015-08-06 Thread Cyril Hrubis
ret = write(STDOUT_FILENO, > + "fcntl(2) failed\n", > + sizeof("fcntl(2) failed\n")); > + } > + break; > + default

Re: [LTP] [PATCH v2] fcntl/fcntl32.c: add new test

2015-08-06 Thread Cyril Hrubis
= 0; > + SAFE_CLOSE(cleanup, fd2); > + fd2 = 0; > + > + if (TEST_RETURN != -1) { > + tst_resm(TFAIL, "fcntl(2) succeeded unexpectedly"); ^

Re: [LTP] [PATCH v2] ipc/msgrcv: add new testcase msgrcv08

2015-08-06 Thread Cyril Hrubis
the sizeof()). Fixed the commit message and pushed, thanks. -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforg

Re: [LTP] [PATCH v5 01/11] SAFE_MACROS: Add socket(), bind(), listen(), connect() and getsockname()

2015-08-06 Thread Cyril Hrubis
CP connection stay in the TIME_WAIT state, googling around suggests that it's 1 minute for Linux. So IMHO anything greater than 1 minute should do. So 2 minutes looks like good choice to me. -- Cyril Hrubis chru...@suse.cz --

Re: [LTP] [PATCH v5 02/11] lib6/runcc.c: Cleanup

2015-08-05 Thread Cyril Hrubis
api_07.c and fixing the rest of the testcases. -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH v5 02/11] lib6/runcc.c: Cleanup

2015-08-05 Thread Cyril Hrubis
. Do we want to really keep these? Because they would need a bit more work to make them less ugly... -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list mailing list Ltp-list

Re: [LTP] [PATCH v5 01/11] SAFE_MACROS: Add socket(), bind(), listen(), connect() and getsockname()

2015-08-05 Thread Cyril Hrubis
; + } > + > + return rval; > +} > + > +int safe_getsockname(const char *file, const int lineno, > + void (cleanup_fn)(void), int sockfd, struct sockaddr *addr, > + socklen_t *addrlen) > +{ > + int rval; > + > + rva

Re: [LTP] [PATCH 2/2] open_posix/shm_unlink: sanity checking after calling pathconf

2015-08-05 Thread Cyril Hrubis
e shortened this error message to "pathconf() failed" here and in 10-2.c and pushed both patches, thanks. -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] netns, make a verfication to name of virtul network interface card

2015-08-05 Thread Cyril Hrubis
Hi! > The current ltp version get name of virtul network interface card > with "veth62@veth63" in the newest kernel version, > But we need a file name with "veth62". That looks suspicious, Alexey have you seen this? --

Re: [LTP] [PATCH] memcg_functinon: testcase_30 function

2015-08-05 Thread Cyril Hrubis
igned-off-by: Michal Hocko Signed-off-by: Cyril Hrubis -- Cyril Hrubis chru...@suse.cz -- ___ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforg

  1   2   3   4   5   6   7   8   9   10   >