Re: [LTP] PATCH : test_fs_bind testscript for busybox machines

2010-05-04 Thread Matt Helsley
both the implementations of xargs. > > > Attached the patch here. > > Thanks > > Suzuki Just noticed this thread. Looks good, thanks! Acked-by: Matt Helsley > > Signed-off-by: Suzuki K P > > Index: ltp/testscripts/test_fs_bind.sh > =

Re: [LTP] [PATCH] Filecaps: Update error message for recent kernels

2009-09-15 Thread Matt Helsley
cmp 2 6 27 ; then + echo recompile your kernel with CONFIG_SECURITY_CAPABILITIES=y. + else + echo recompile your kernel with CONFIG_SECURITY_FILE_CAPABILITIES=y. + fi Cheers, -Matt Helsley ---

Re: [LTP] [PATCH] Add new testcases for cgroup

2009-08-26 Thread Matt Helsley
like this should be 12. Why not just use the subsystem names both to iterate over and to print out? Then it will be a little clearer what test has[n't] passed. e.g.: SUBSYSTEMS=( debug cpuset ns cpu cpuacct memory debug,debug freezer \ devices nonexistent none all ) Then when

Re: [LTP] [PATCH] Fixed static build which needs to link the pthread library in pidns and pipeio.

2009-07-31 Thread Matt Helsley
On Thu, Jul 30, 2009 at 11:59:25PM +0530, Subrata Modak wrote: > On Fri, 2009-07-24 at 11:24 -0700, Matt Helsley wrote: > > On Wed, Jul 22, 2009 at 10:22:05PM +0800, nobuhiro wrote: > > > > > > Signed-off-by: nobuhiro > > > --- > > > test

Re: [LTP] [PATCH] Fixed static build which needs to link the pthread library in pidns and pipeio.

2009-07-24 Thread Matt Helsley
CFLAGS += -Wall > CPPFLAGS += -I../../../../include > -LDLIBS += -L../../../../lib -lltp -lrt > +LDLIBS += -L../../../../lib -lltp -lrt -lpthread Same here. Cheers, -Matt Helsley -- ___

Re: [LTP] [PATCH] Remove bashisms (WAS Re: [PATCH 4/4] netns: Change interpretters from sh to bash)

2009-07-06 Thread Matt Helsley
On Tue, Jul 07, 2009 at 01:10:36AM +0200, Jiří Paleček wrote: > Hi > > On Mon, 06 Jul 2009 23:51:12 +0200, Matt Helsley > wrote: > >> On Thu, Jul 02, 2009 at 06:09:16PM -0400, Mike Frysinger wrote: >>> On Thursday 02 July 2009 16:32:53 Matt Helsley wrote: >>&g

Re: [LTP] [PATCH 4/4] Make makefiles more autoconf friendly

2009-07-06 Thread Matt Helsley
> +# autoconf. Haven't figured it out yet... > +# > +ifeq ($(strip $(prefix)),) > +prefix = /opt/ltp > +endif I thought the point was not having to run autoconf to get the default build and install via Makefiles. > + > +datarootdir = @datarootdir@ > +

[LTP] [PATCH] Remove bashisms (WAS Re: [PATCH 4/4] netns: Change interpretters from sh to bash)

2009-07-06 Thread Matt Helsley
On Thu, Jul 02, 2009 at 06:09:16PM -0400, Mike Frysinger wrote: > On Thursday 02 July 2009 16:32:53 Matt Helsley wrote: > > On Thu, Jul 02, 2009 at 02:35:46PM -0400, Mike Frysinger wrote: > > > in general, converting sh to bash is a bad idea as it can cause issues > >

Re: [LTP] [RFC][PATCH] Use prefix and other autoconf variables uniformly

2009-07-02 Thread Matt Helsley
On Thu, Jul 02, 2009 at 07:18:58PM -0700, Garrett Cooper wrote: > I understand what you're trying to accomplish, but part of the > point behind the current design with the Makefile system was in fact > for it to be run without intervention from autotools. Hence, the > directions noted in INSTAL

Re: [LTP] [PATCH 4/4] netns: Change interpretters from sh to bash

2009-07-02 Thread Matt Helsley
On Thu, Jul 02, 2009 at 02:35:46PM -0400, Mike Frysinger wrote: > On Thursday 02 July 2009 05:05:32 Matt Helsley wrote: > > As best I can tell these tests do not use true sh syntax -- they use bash > > syntax. Rather than bother hunting down all the bash-isms just convert > >

[LTP] [PATCH 4/4] netns: Change interpretters from sh to bash

2009-07-02 Thread Matt Helsley
As best I can tell these tests do not use true sh syntax -- they use bash syntax. Rather than bother hunting down all the bash-isms just convert them to use bash as their interpretter. Also found with my fedora 10 KVM image. Signed-off-by: Matt Helsley Cc: Daniel Lezcano Cc: Poornima Nayak Cc

[LTP] [PATCH 3/4] netns: Fixup non-sh syntax

2009-07-02 Thread Matt Helsley
Fixup some non-sh syntax which seems to trigger problems on my fedora 10 KVM image. Signed-off-by: Matt Helsley Cc: Daniel Lezcano Cc: Poornima Nayak Cc: Sudhir Kumar Cc: Veerendra C Cc: Munipradeep Cc: l...@list.sourceforge.net --- testcases/kernel/containers/netns/parentns.sh |2

[LTP] [PATCH 2/4] netns: Add ip tools check to netns tests.

2009-07-02 Thread Matt Helsley
Use ip -V to exclude the network namespace testcases since they require version ("snapshot") ss080725 or higher to set the network namespace of interfaces used for testing. Signed-off-by: Matt Helsley Signed-off-by: Sachin P. Sant Cc: Daniel Lezcano Cc: Poornima Nayak Cc: Sudhir

[LTP] [PATCH 1/4] netns: Report version of iproute2 tools in ver_linux

2009-07-02 Thread Matt Helsley
Report the version of the ip route tools in ver_linux with ip -V. The version is important to the netns testcases for example. Since it would be useful for other testcases add it to the ver_linux script. Signed-off-by: Matt Helsley Cc: Daniel Lezcano Cc: Poornima Nayak Cc: Sudhir Kumar Cc

[LTP] [RFC][PATCH] Update unzip command test: build and run successfully without unzip

2009-02-25 Thread Matt Helsley
"describing" the test are totally incorrect -- they appear to be a copy-paste artifact. So I updated them. Signed-off-by: Matt Helsley --- runtest/commands |2 testcases/commands/unzip/Makefile | 33 --- testcases/commands/unzip/unzip_

[LTP] [PATCH] Fix spelling and grammar nits

2009-02-25 Thread Matt Helsley
Fix spelling and grammar nits. Signed-off-by: Matt Helsley --- runltp|2 +- testcases/commands/gzip/gzip_tests.sh |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Index: ltp/testcases/commands/gzip/gzip_tests.sh

[LTP] [RFC][PATCH] containers: Remove capability dependency

2009-02-25 Thread Matt Helsley
Review of these test source files suggests that absolutley no capability APIs are in use. I suspect these #ifdefs were added because the original tests had unnecessarily included sys/capability.h Signed-off-by: Matt Helsley --- testcases/kernel/containers/pidns/pidns14.c | 17

Re: [LTP] [PATCH] Add Freezer Controller Testcases

2009-02-25 Thread Matt Helsley
On Wed, Feb 25, 2009 at 03:30:22AM -0800, Matt Helsley wrote: > These testcases cover the basic functionality of the kernel cgroup > freezer controller described in the kernel's > Documentation/cgroups/freezer-subsystem.txt file. Briefly: > > The freezer subsystem in the cgrou

Re: [LTP] [PATCH 03/03] Creating the script that executes when 'make prep' is called

2009-02-16 Thread Matt Helsley
se that means this script has to keep code describing which version of which distro used which tool with which package name(s). This kind of supports Garret Cooper's point... More comments interleaved below. Cheers, -Matt Helsley > -- > > diff -uprN ltp-full-20090131.orig/i

[LTP] [PATCH] Fix parallel build problem in testcases/network/lib6/Makefile

2009-01-21 Thread Matt Helsley
asapi_01.c -L../../../lib runcc.a -lltp -lpthread -o asapi_01 cc: runcc.a: No such file or directory This patch fixes the problem by properly expressing the build depdency between the TARGET objects and runcc.a Signed-off-by: Matt Helsley --- Changlog: v2: Rely on the implicit

Re: [LTP] [PATCH] Fix parallel build problem in testcases/network/lib6/Makefile

2009-01-21 Thread Matt Helsley
On Tue, 2009-01-20 at 20:06 -0800, Garrett Cooper wrote: > On Jan 20, 2009, at 15:34, Matt Helsley wrote: > > > The dependency description in testcases/network/lib6/Makefile breaks > > parallel builds: > > > >make autoconf > >

[LTP] [PATCH] Fix parallel build problem in testcases/network/lib6/Makefile

2009-01-20 Thread Matt Helsley
asapi_01.c -L../../../lib runcc.a -lltp -lpthread -o asapi_01 cc: runcc.a: No such file or directory This patch fixes the problem by properly expressing the build depdency between the TARGET objects and runcc.a Signed-off-by: Matt Helsley --- --- ltp-full-20081231/testcases/network

Re: [LTP] [RFC][PATCH 8/9] Remove LTPROOT definitions

2008-09-08 Thread Matt Helsley
s. Right. 8 & 9 were for my own testing purposes and got sent out accidentally. Please feel free to ignore them. Cheers, -Matt > Regards-- > Subrata > > On Wed, 2008-09-03 at 14:34 -0700, Matt Helsley wrote: > > plain text document attachment (fixup-process-events-conn

Re: [LTP] [PATCH] Tests for Process Event Connector

2008-09-02 Thread Matt Helsley
On Tue, 2008-09-02 at 19:50 -0700, Matt Helsley wrote: > > Rishi > > I'd guess LTPROOT is being setup by the connectors test scripts > improperly. Please give this patch a try -- I haven't tested it myself > yet. > > The patch does some additional

Re: [LTP] [PATCH] Tests for Process Event Connector

2008-09-02 Thread Matt Helsley
S > LTP Version: LTP-20080831 > > === > > Thanks > > Rishi I'd guess LTPROOT is being setup by the connectors test scripts improperly. Please give this patch a try -- I haven't test

Re: [LTP] test_fs_bind.sh testcases BROK error

2008-08-30 Thread Matt Helsley
Hi Rishi, When I ran the August intermediate release on a single-cpu i386 machine I was not able to reproduce your results. I did: $ make $ make install $ ./runltp -f fs_bind $ ./runltp -f fs_bind > run.out > run.err $ grep PASSED run.out | wc -l 90 $ wc -l run.err 0 $ grep -i brok run.* | wc -l

Re: [LTP] test_fs_bind.sh testcases BROK error

2008-08-25 Thread Matt Helsley
On Tue, 2008-08-26 at 10:12 +0530, Rishikesh K Rajak wrote: > > > > Is this is an expected behaviour ? i should not run two times, i also > > > > tried with different combination, individually also it is failing > now. > > > > It's not expected behavior. It should be able to run twice. > > Matt, c

Re: [LTP] [PATCH] Tests for Process Event Connector

2008-06-25 Thread Matt Helsley
addr_nl)); > + if (ret == -1) { > + fprintf(stderr, "failed to bind socket\n"); > + exit(1); > + } In subsequent email echanges Li and Subrata wrote: > Subrata Modak 写道: > > Li, > > > > Will you be resendin

Re: [LTP] [PATCH] Tests for Process Event Connector

2008-06-13 Thread Matt Helsley
> >## > > +## This program is free software; you can redistribute it and#or modify > >## > > +## it under the terms of the GNU General Public License as published by > >## > > +#

Re: [LTP] fs_bind testcases failing

2008-06-04 Thread Matt Helsley
see i > ran on RHEL 4 kernel. > > Thanks > Rishi Hi Rishi, You could try this patch and see if it solves the problem. I may not have a chance to test if for a while. Cheers, -Matt Helsley Subject: Test kernel version in all fs_bind tests Distribute tst_kvercm

Re: [LTP] fs_bind testcases failing

2008-06-04 Thread Matt Helsley
are present in the output? I'll work on a patch adding kernel version comparison to each testcase as that will help folks who want to run the individual testxx scripts. In the meantime, only basic --bind and --move mounts are expected to work on that kernel; none of the --make-* mount

Re: [LTP] fs_bind testcases failing

2008-06-03 Thread Matt Helsley
quot; and "makedir" are too generic to place in the global testcases/bin directory -- hence the scripts need "${FS_BIND_ROOT}/bin" in your PATH. Keep in mind that depending on the test results the scripts may leave mounts behind (though I tried to prevent this as best I cou

Re: [LTP] [PATCH] Filesystem Bind Mount Tests

2008-05-12 Thread Matt Helsley
On Mon, 2008-05-12 at 14:13 -0500, Serge E. Hallyn wrote: > Quoting Subrata Modak ([EMAIL PROTECTED]): > > On Fri, 2008-05-09 at 09:32 -0500, Serge E. Hallyn wrote: > > > Quoting Matt Helsley ([EMAIL PROTECTED]): > > > > Hi All, > > > > > > >

Re: [LTP] [PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-19 Thread Matt Helsley
on is best? Cheers, -Matt Helsley - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse01