Re: [lttng-dev] [PATCH] lttng-tools add_context.c : Fixing memory leaks

2012-01-30 Thread David Goulet
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Finally merged! :) Thanks David On 12-01-30 04:58 PM, Thibault, Daniel wrote: >> For some reason, this patch does not apply ... > >Okay, my git repository is now properly connected, and below is the patch > rewritten for the current commit. Be

Re: [lttng-dev] [PATCH] lttng-tools add_context.c : Fixing memory leaks

2012-01-30 Thread Thibault, Daniel
> For some reason, this patch does not apply ... Okay, my git repository is now properly connected, and below is the patch rewritten for the current commit. Besides enforcing the return values and outputting --help to stdout, the problem lay with the instances of struct ctx_type *type being

Re: [lttng-dev] [PATCH] lttng-tools add_context.c : Fixing memory leaks

2012-01-30 Thread David Goulet
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Those are already upstream ;) David On 12-01-30 04:39 PM, Thibault, Daniel wrote: > -Message d'origine- > Envoyé : 30 janvier 2012 16:18 > >> For some reason, this patch does not apply ... >> >> Applying: lttng-tools add_context.c : Fixing m

Re: [lttng-dev] [PATCH] lttng-tools add_context.c : Fixing memory leaks

2012-01-30 Thread Thibault, Daniel
-Message d'origine- Envoyé : 30 janvier 2012 16:18 > For some reason, this patch does not apply ... > > Applying: lttng-tools add_context.c : Fixing memory leaks > error: patch failed: src/bin/lttng/commands/add_context.c:520 > error: src/bin/lttng/commands/add_context.c: patch does not ap

Re: [lttng-dev] [PATCH] Rewrites lttng-ctl's set_session_daemon_path(), fix snprintf() return value tests so the code works with both GNU C < 2.1 and >= 2.1

2012-01-30 Thread David Goulet
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Merged thanks! We did indeed validate the function and it's seems ok and test passes. If you are changing good portion of code, you can run "make check" to start the tests and you'll see if you break something. It's not very complete tests but it's a

[lttng-dev] [PATCH] Rewrites lttng-ctl's set_session_daemon_path(), fix snprintf() return value tests so the code works with both GNU C < 2.1 and >= 2.1

2012-01-30 Thread Thibault, Daniel
This fifth patch rewrites lttng-ctl's set_session_daemon_path() to avoid duplicating snippets of code. It also fixes the snprintf return value test so the code works with both GNU C < 2.1 and >= 2.1. With GNU C < 2.1, snprintf returns -1 if the target buffer is too small; with GNU C >= 2.1,

Re: [lttng-dev] [PATCH] lttng-tools bin/lttng/conf.c : Document and enforce return values; bin/lttng/commands/create.c : Likewise

2012-01-30 Thread David Goulet
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Merged thanks! David On 12-01-27 02:33 PM, Thibault, Daniel wrote: > bin/lttng/commands/create.c : Completing the return values overhaul, setting > --help usage() to stdout > bin/lttng/conf.c: > * In config_read_session_name(), moved the malloc to t

Re: [lttng-dev] [PATCH] lttng-tools add_context.c : Fixing memory leaks

2012-01-30 Thread David Goulet
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, For some reason, this patch does not apply ... Applying: lttng-tools add_context.c : Fixing memory leaks error: patch failed: src/bin/lttng/commands/add_context.c:520 error: src/bin/lttng/commands/add_context.c: patch does not apply In the meant

[lttng-dev] git: vs http:

2012-01-30 Thread Thibault, Daniel
-Message d'origine- Envoyé : 30 janvier 2012 15:27 > You can pull over HTTP, for example: > > git clone http://git.lttng.org//lttng-tools.git > > This usually gets through corporate firewalls. One problem solved, I guess. My problem was that I only tried the git: path (git://git.lttn

[lttng-dev] [PATCH] lttng-tools : create.c : Simplify create_session()

2012-01-30 Thread Thibault, Daniel
This fourth patch simplifies create_session() in create.c -- >From e81d91e548bc9dc94dc9e89ff0bf1150f43ebbda Mon, 30 Jan 2012 16:03:10 -0500 From: Daniel U. Thibault Date: Mon, 30 Jan 2012 16:02:53 -0500 Subject: [PATCH] lttng-tools : create.c : Simplify create_sessi

Re: [lttng-dev] [PATCH] lttng-tools Catching up on miscellaneous string and comment fixes (from 5c73c59)

2012-01-30 Thread David Goulet
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Merged thanks! David On 12-01-30 03:27 PM, Thibault, Daniel wrote: >As promised, here is the first of a new set of patches, starting from the > 2012-01-30 18:27 commit (2.0-pre18+-5c73c59). > >This first patch fixes miscellaneous little thi

[lttng-dev] [PATCH] lttng-tools lttng-ctl, calibrate and create : Document return values

2012-01-30 Thread Thibault, Daniel
This third patch documents (and in one instance, enforces) return values for functions of lttng-ctl, calibrate and create. It also fixes the test of getgroups(), which cannot return (grp_id < -1). -- >From 6739ca025c89937cd4e37c933715532fdc39ced0 Mon, 30 Jan 201

[lttng-dev] [PATCH] lttng-tools add_context.c : Fixing memory leaks

2012-01-30 Thread Thibault, Daniel
This second patch fixes a memory leak in lttng-consumerd.c, various strings and comments, directs usage to stdout for --help, and enforces the return values of cmd_add_context(). -- >From 39726bfddd9dc1cd8931eb1bbddc54b78c2d16e3 Mon, 30 Jan 2012 15:22:28 -0500 From

Re: [lttng-dev] [PATCH] [RESUBMISSION] lttng-tools lib/lttng-ctl/lttng-ctl.c : Document return values and more

2012-01-30 Thread Alexandre Montplaisir
On 12-01-30 01:52 PM, Thibault, Daniel wrote: > -Message d'origine- > De : David Goulet [mailto:david.gou...@polymtl.ca] > Envoyé : 30 janvier 2012 13:12 > > >Now, out here we have a separate problem getting at the git repositories > using the git: protocol. The port isn't open in ou

[lttng-dev] [PATCH] lttng-tools Catching up on miscellaneous string and comment fixes (from 5c73c59)

2012-01-30 Thread Thibault, Daniel
As promised, here is the first of a new set of patches, starting from the 2012-01-30 18:27 commit (2.0-pre18+-5c73c59). This first patch fixes miscellaneous little things wrong with strings and comments. -- >From cb6916eb52786f8caf1612c576500ca6bb6f4e76 Mon, 30

Re: [lttng-dev] [PATCH] [RESUBMISSION] lttng-tools lib/lttng-ctl/lttng-ctl.c : Document return values and more

2012-01-30 Thread Thibault, Daniel
-Message d'origine- De : David Goulet [mailto:david.gou...@polymtl.ca] Envoyé : 30 janvier 2012 13:12 > I'm having problem applying those patches. It fails at the third one and I > think > it's because you change lttng-ctl.c in the second patch and the third one is > not > based on thos

Re: [lttng-dev] [PATCH] [RESUBMISSION] lttng-tools lib/lttng-ctl/lttng-ctl.c : Document return values and more

2012-01-30 Thread David Goulet
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 H, I'm having problem applying those patches. It fails at the third one and I think it's because you change lttng-ctl.c in the second patch and the third one is not based on those changes. Can you please send me three separate emails for those pa

Re: [lttng-dev] LTTng 2.0 -rc1 coming soon

2012-01-30 Thread Yannick Brosseau
On 2012-01-30 08:35, Miceli, Carlo J. wrote: > Will this release work with LTTV-GUI program ? > > Does it support GUI viewing? We hope to have a version of LTTV working for this release. We are still early in its development, so it would be very experimental. We should have a better estimate by the

Re: [lttng-dev] LTTng 2.0 -rc1 coming soon

2012-01-30 Thread Miceli, Carlo J.
Will this release work with LTTV-GUI program ? Does it support GUI viewing? Thanks, Carlo -Original Message- From: lttng-dev-boun...@lists.lttng.org [mailto:lttng-dev-boun...@lists.lttng.org] On Behalf Of Mathieu Desnoyers Sent: Monday, January 30, 2012 8:12 AM To: Tony Jones; Greg KH C

[lttng-dev] LTTng 2.0 -rc1 coming soon

2012-01-30 Thread Mathieu Desnoyers
Hi, I just wanted to let you know that the current target for LTTng 2.0 final release is mid-February, so we are aiming for feature freeze (rc1) in a matter of 2-3 days. Please let us know if things work fine in your environment. Best regards, Mathieu -- Mathieu Desnoyers Operating System Eff