[lttng-dev] [PATCH v2 lttng-tools] Fix: Do not install health tests helper libraries

2012-11-06 Thread Christian Babeux
The libraries libhealthexit and libhealthstall should not be installed on the user system. They are only useful for the health check tests. Furthermore, when adding libraries to noinst_LTLIBRARIES, libtool will only build these as static libraries (see [1] for a workaround). This is fine for most

Re: [lttng-dev] [PATCH v2 lttng-tools] Fix: Do not install health tests helper libraries

2012-11-06 Thread Mathieu Desnoyers
* Christian Babeux (christian.bab...@efficios.com) wrote: > The libraries libhealthexit and libhealthstall should not be > installed on the user system. They are only useful for the > health check tests. > > Furthermore, when adding libraries to noinst_LTLIBRARIES, > libtool will only build these

Re: [lttng-dev] [PATCH lttng-tools] Fix: Do not install health tests helper libraries

2012-11-06 Thread David Goulet
Merged! Thanks! David Mathieu Desnoyers: > * Christian Babeux (christian.bab...@efficios.com) wrote: >> The libraries libhealthexit and libhealthstall should not be >> installed on the user system. They are only useful for the >> health check tests. >> >> Signed-off-by: Christian Babeux > > Ack

[lttng-dev] [PATCH lttng-tools] Fix: Proper teardown of thread_manage_clients on failure of listen/create_poll

2012-11-06 Thread Christian Babeux
Currently, if the call to lttcomm_listen_unix_sock or create_thread_poll_set fails, the error handling and thread teardown code path is triggered via a jump to an error label. This error handling path closes the sockets that were used and cleanup the poll set. If the listen fails, the poll set will

[lttng-dev] Fix filter: pointer to string, not string, should be on stack -- query

2012-11-06 Thread David Bryant
Hi, I'm trying to understand the following changeset: commit 27f4b6094f399f2fe231b58801dce98cbd21baa9 Author: Mathieu Desnoyers Date: Tue Sep 4 12:17:07 2012 -0400 Fix filter: pointer to string, not string, should be on stack Fixes #329 Signed-off-by: Mathieu Desnoyers Bug link: https://bu