* Simon Marchi (simon.mar...@polymtl.ca) wrote:
> Hi David,
>
> I just sent my v2 for this patch. I changed the logic so that it still
> uses the DEFAULT_*_SUBBUF_SIZE defines, but check that it is >= page
> size. It should answer your first two comments/questions.
>
> I don't think it would help
Forgot to remove the dot at the end of the title...
On Sun, Nov 11, 2012 at 8:28 PM, Simon Marchi wrote:
> Use the functions added by the previous commit. All the occurences of
> the previous defines were replaced.
>
> Signed-off-by: Simon Marchi
> ---
> src/bin/lttng-sessiond/channel.c
Hi David,
I just sent my v2 for this patch. I changed the logic so that it still
uses the DEFAULT_*_SUBBUF_SIZE defines, but check that it is >= page
size. It should answer your first two comments/questions.
I don't think it would help to put these inline, since they are only
called in slow paths
Use the functions added by the previous commit. All the occurences of
the previous defines were replaced.
Signed-off-by: Simon Marchi
---
src/bin/lttng-sessiond/channel.c |4 ++--
src/bin/lttng-sessiond/trace-kernel.c|2 +-
src/bin/lttng-sessiond/trace-ust.c |2 +-
This patch adds src/common/defaults.c file. It contains functions to
retrieve defaults subbuf sizes. It uses the DEFAULT_*_SUBBUF_SIZE
defines from defaults.h but also make sure that the values are at least
as big as the page size.
Signed-off-by: Simon Marchi
---
src/common/Makefile.am |2 +-
