[lttng-dev] [PATCH lttng-tools 3/4] Update coding style document for macro style

2016-05-19 Thread Mathieu Desnoyers
Signed-off-by: Mathieu Desnoyers --- CodingStyle | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/CodingStyle b/CodingStyle index 1d8bd9b..6ff931b 100644 --- a/CodingStyle +++ b/CodingStyle @@ -31,14 +31,22 @@ enum my_enum { #define DEFAULT_VALUE_OF_SOME_SO

[lttng-dev] [PATCH lttng-tools 0/4] error.h message printing fixes

2016-05-19 Thread Mathieu Desnoyers
Mathieu Desnoyers (4): Fix: add missing semicolons after MSG, DBG, ERR print macros Fix: coding style document has erroneous semicolon at end of macro Update coding style document for macro style Cleanup error.h __lttng_print() used for message printing CodingStyle

[lttng-dev] [PATCH lttng-tools 1/4] Fix: add missing semicolons after MSG, DBG, ERR print macros

2016-05-19 Thread Mathieu Desnoyers
Signed-off-by: Mathieu Desnoyers --- src/bin/lttng/commands/add_context.c | 2 +- src/common/consumer/consumer.c | 2 +- src/common/runas.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/bin/lttng/commands/add_context.c b/src/bin/lttng/commands

[lttng-dev] [PATCH lttng-tools 2/4] Fix: coding style document has erroneous semicolon at end of macro

2016-05-19 Thread Mathieu Desnoyers
Signed-off-by: Mathieu Desnoyers --- CodingStyle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CodingStyle b/CodingStyle index 8833180..1d8bd9b 100644 --- a/CodingStyle +++ b/CodingStyle @@ -36,7 +36,7 @@ Use space to indent the '\' at the end but tabs at the beginning. #d

[lttng-dev] [PATCH lttng-tools 4/4] Cleanup error.h __lttng_print() used for message printing

2016-05-19 Thread Mathieu Desnoyers
The loglevels have never really been a mask, and it is useless to try to use them as masks, because the compiler statically knows the value of the loglevel requested, and can therefore optimise away all the logic. This takes care of Coverity warning about mixed bitwise and boolean logic, which was

Re: [lttng-dev] [PATCH lttng-tools 1/4] Fix: add missing semicolons after MSG, DBG, ERR print macros

2016-05-19 Thread Jérémie Galarneau
All four patches merged, thanks! Jérémie On Thu, May 19, 2016 at 11:57 AM, Mathieu Desnoyers wrote: > Signed-off-by: Mathieu Desnoyers > --- > src/bin/lttng/commands/add_context.c | 2 +- > src/common/consumer/consumer.c | 2 +- > src/common/runas.c | 2 +- > 3 files ch

Re: [lttng-dev] question about rcu_bp_exit()

2016-05-19 Thread Paul E. McKenney
On Wed, May 18, 2016 at 06:40:03PM +, Mathieu Desnoyers wrote: > - On May 18, 2016, at 5:44 AM, songxin wrote: > > > Hi, > > Now I get a crash because receiving signal SIGSEGV as below. > > > #0 arena_alloc (arena=) at > > /usr/src/debug/liburcu/0.9.1+git5fd33b1e5003ca316bd314ec3fd1447f

[lttng-dev] [PATCH babletrace 1.3/1.4] Fix: segmentation fault with multi-trace having non-correlated clocks

2016-05-19 Thread Mathieu Desnoyers
This bugfix is extracted from commit commit 61cf588beae752e5ddfc60b6b5310f769ac9e852 Author: Mathieu Desnoyers Date: Tue Feb 9 13:27:24 2016 -0500 Handle negative time and offset from Epoch Which was fixing this issue, amongst other things. [ This fix should be applied to Babeltrace stab

[lttng-dev] [PATCH babeltrace 1.3/1.4 v2] Fix: segmentation fault with multi-trace having non-correlated clocks

2016-05-19 Thread Mathieu Desnoyers
This bugfix is extracted from commit commit 61cf588beae752e5ddfc60b6b5310f769ac9e852 Author: Mathieu Desnoyers Date: Tue Feb 9 13:27:24 2016 -0500 Handle negative time and offset from Epoch Which was fixing this issue, amongst other things. [ This fix should be applied to Babeltrace stab