Re: [lttng-dev] [PATCH babeltrace] Fix: bitfield: left shift undefined behavior

2019-05-07 Thread Simon Marchi
On 2019-05-07 4:40 p.m., Mathieu Desnoyers wrote: > bitfield.h uses the left shift operator with a left operand which > may be negative. The C99 standard states that shifting a negative > value is undefined. Please add a reference to the original problem that prompted you to do this change in the

[lttng-dev] default sub-buf size and count

2019-05-07 Thread Mosleh Uddin
Hello, I was just wondering what the default values for the sub-buffer size and the number of sub-buffers are. I attempted to print them out after setting the channel with default attr, however both values appear 0. Thanks for any insight, Mosleh ___

[lttng-dev] [PATCH lttng-modules] Fix: bitfield: left shift undefined behavior

2019-05-07 Thread Mathieu Desnoyers
bitfield.h uses the left shift operator with a left operand which may be negative. The C99 standard states that shifting a negative value is undefined. We also need to cast the result explicitly into the left hand side type to deal with: warning: large integer implicitly truncated to unsigned

[lttng-dev] [PATCH lttng-ust] Fix: bitfield: left shift undefined behavior

2019-05-07 Thread Mathieu Desnoyers
bitfield.h uses the left shift operator with a left operand which may be negative. The C99 standard states that shifting a negative value is undefined. We also need to cast the result explicitly into the left hand side type to deal with: warning: large integer implicitly truncated to unsigned

[lttng-dev] [PATCH babeltrace] Fix: bitfield: left shift undefined behavior

2019-05-07 Thread Mathieu Desnoyers
bitfield.h uses the left shift operator with a left operand which may be negative. The C99 standard states that shifting a negative value is undefined. We also need to cast the result explicitly into the left hand side type to deal with: warning: large integer implicitly truncated to unsigned

Re: [lttng-dev] [PATCH lttng-tools v6 0/8] Change in compat (e)poll

2019-05-07 Thread Jérémie Galarneau
All merged in master and stable-2.11. I made some minor changes to the messages of the unit tests. "Fix: lttng_poll_mod calls compat_(e)poll_add" was backported to stable-2.10. Thanks! Jérémie On Thu, Apr 25, 2019 at 06:23:26PM -0400, Yannick Lamarre wrote: > From v5, fixed compilation problem