bitfield.h uses the left shift operator with a left operand which
may be negative. The C99 standard states that shifting a negative
value is undefined.
When building with -Wshift-negative-value, we get this gcc warning:
In file included from
/home/smarchi/src/babeltrace/include/babeltrace/ctfser
bitfield.h uses the left shift operator with a left operand which
may be negative. The C99 standard states that shifting a negative
value is undefined.
When building with -Wshift-negative-value, we get this gcc warning:
In file included from
/home/smarchi/src/babeltrace/include/babeltrace/ctfser
Compiling the bitfield test with gcc -Wextra generates those warnings:
../../include/babeltrace/bitfield-internal.h:38:45: warning: comparison of
unsigned expression < 0 is always false [-Wtype-limits]
#define _bt_is_signed_type(type) ((type) -1 < (type) 0)
This is the intent of the macro. Dis
Compiling the bitfield test with gcc -Wextra generates those warnings:
../../include/babeltrace/bitfield-internal.h:38:45: warning: comparison of
unsigned expression < 0 is always false [-Wtype-limits]
#define _bt_is_signed_type(type) ((type) -1 < (type) 0)
This is the intent of the macro. Dis
bitfield.h uses the left shift operator with a left operand which
may be negative. The C99 standard states that shifting a negative
value is undefined.
When building with -Wshift-negative-value, we get this gcc warning:
In file included from
/home/smarchi/src/babeltrace/include/babeltrace/ctfser
It is a good practice to pass arguments as parameters rather
than through global variables.
Signed-off-by: Mathieu Desnoyers
Change-Id: I0d7cc94b1d492ca53ad29b1d39831ee6288b2672
---
tests/lib/test_bitfield.c | 85 +--
1 file changed, 30 insertions(+),
test_bitfield was mainly testing various write unit size. Add
variations of read unit size as well.
Previously, the test was only covering input from a 32-bit integer.
Additionally test source and destination of 64-bit.
Signed-off-by: Mathieu Desnoyers
Change-Id: Ic2b7849140e04fe7cca3de576e31bfe
bitfield.h uses the left shift operator with a left operand which
may be negative. The C99 standard states that shifting a negative
value is undefined.
When building with -Wshift-negative-value, we get this gcc warning:
In file included from
/home/smarchi/src/babeltrace/include/babeltrace/ctfser
Compiling the bitfield test with gcc -Wextra generates those warnings:
../../include/babeltrace/bitfield-internal.h:38:45: warning: comparison of
unsigned expression < 0 is always false [-Wtype-limits]
#define _bt_is_signed_type(type) ((type) -1 < (type) 0)
This is the intent of the macro. Dis
>
> >
> >
> > I'm running under a 32 bit (x86) vanilla, 4.9.20 kernel with busybox
> > with the following lttng versions:
I took some time to at least test on a 32 bit system (buildroot) just in case
and everything seems to be working fine on a base installation.
The log from lttng-sessiond sh
On 2019-05-13 4:20 p.m., Mathieu Desnoyers wrote:
> bitfield.h uses the left shift operator with a left operand which
> may be negative. The C99 standard states that shifting a negative
> value is undefined.
>
> When building with -Wshift-negative-value, we get this gcc warning:
>
> In file inclu
Hi,
On Tue, May 14, 2019 at 03:20:31PM +0300, Zvi Vered wrote:
> Hello,
>
> I ran the following command on the target (where my kernel is running):
>
> ~ # ./lttng create my-kernel-session --output=/tmp/my-kernel-trace
>
> and then:
>
>
> ~ # ./lttng enable-event --kernel --syscall open,close
Hello,
I ran the following command on the target (where my kernel is running):
~ # ./lttng create my-kernel-session --output=/tmp/my-kernel-trace
and then:
~ # ./lttng enable-event --kernel --syscall open,close
and got:
Error: Spawning consumerd failed
Error: Event open: Kernel consumer star
13 matches
Mail list logo