[lttng-dev] [Babeltrace PATCH] Add BT_SEEK_LAST type to bt_iter_pos.

2012-08-10 Thread Francis Deslauriers
Signed-off-by: Francis Deslauriers --- include/babeltrace/iterator.h |1 + lib/iterator.c| 189 + 2 files changed, 190 insertions(+) diff --git a/include/babeltrace/iterator.h b/include/babeltrace/iterator.h index aa6470e..c13055d

[lttng-dev] [Babeltrace patch] Add BT_SEEK_LAST type to bt_iter_pos.

2012-08-16 Thread Francis Deslauriers
Signed-off-by: Francis Deslauriers --- include/babeltrace/iterator.h |1 + lib/iterator.c| 190 + 2 files changed, 191 insertions(+) diff --git a/include/babeltrace/iterator.h b/include/babeltrace/iterator.h index aa6470e..c13055d

[lttng-dev] [RFC-PATCH] Adding trap tracepoints definitions

2013-03-14 Thread Francis Deslauriers
tches they apply to. Thanks, Francis Deslauriers ___ lttng-dev mailing list lttng-dev@lists.lttng.org http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

[lttng-dev] [RFC-PATCH] Adding trap tracepoints definitions

2013-03-14 Thread Francis Deslauriers
This patch adds new trap tracepoint definitions. Both trap entry and trap exit tracepoints can be added. Signed-off-by: Francis Deslauriers --- include/trace/events/trap.h | 39 +++ 1 file changed, 39 insertions(+) create mode 100644 include/trace/events

[lttng-dev] [RFC-PATCH] Adding trap tracepoints definitions

2013-03-20 Thread Francis Deslauriers
This patch adds new trap tracepoint definitions. Both trap entry and trap exit tracepoints can be added. Signed-off-by: Francis Deslauriers --- include/trace/events/trap.h | 45 +++ 1 file changed, 45 insertions(+) create mode 100644 include/trace

Re: [lttng-dev] [RFC-PATCH] Adding trap tracepoints definitions

2013-03-20 Thread Francis Deslauriers
Here is reworked version on the trap tracepoints. If it looks good, i will go on by sending a lttng-modules patch adding the trap-probe. Comments are welcome. Francis On Wed, Mar 20, 2013 at 3:55 PM, Francis Deslauriers wrote: > This patch adds new trap tracepoint definitions. Both t

[lttng-dev] [RFC-PATCH] Adding trap tracepoints definitions

2013-03-20 Thread Francis Deslauriers
This patch adds new trap tracepoint definitions. Both trap entry and trap exit tracepoints can be added. Signed-off-by: Francis Deslauriers --- include/trace/events/trap.h | 45 +++ 1 file changed, 45 insertions(+) create mode 100644 include/trace

[lttng-dev] [RFC-PATCH] Adding trap tracepoints definitions

2013-03-20 Thread Francis Deslauriers
This patch adds new trap tracepoint definitions. It enables each architecture to add trap instrumentation. Signed-off-by: Francis Deslauriers --- include/trace/events/trap.h | 47 +++ 1 file changed, 47 insertions(+) create mode 100644 include/trace

Re: [lttng-dev] [RFC-PATCH] Adding trap tracepoints definitions

2013-03-20 Thread Francis Deslauriers
than usual as you notice given that this > patch is targeting lkml. > > Thanks, > > Mathieu > >> >> Signed-off-by: Francis Deslauriers >> --- >> include/trace/events/trap.h | 47 >> +++ >> 1 file chan

[lttng-dev] [trap-probe] Add lttng-probe-trap

2013-03-21 Thread Francis Deslauriers
This probe monitors trap entry and trap exit trace event. Signed-off-by: Francis Deslauriers --- instrumentation/events/lttng-module/trap.h | 46 +++ instrumentation/events/mainline/trap.h | 47 probes/Makefile

[lttng-dev] [RFC-Patch 1/2] Add page fault trace event definitions

2013-04-07 Thread Francis Deslauriers
Add page_fault_entry and page_fault_exit event definitions. It will allow each architecture to instrument their page faults. Signed-off-by: Francis Deslauriers Reviewed-by: Raphaël Beamonte --- include/trace/events/fault.h | 51 ++ 1 file changed, 51

[lttng-dev] [RFC-Patch 2/2] x86:Instruments page fault trace event

2013-04-07 Thread Francis Deslauriers
Signed-off-by: Francis Deslauriers Reviewed-by: Raphaël Beamonte --- arch/x86/mm/fault.c |5 + 1 file changed, 5 insertions(+) diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c index 2b97525..f41a5a0 100644 --- a/arch/x86/mm/fault.c +++ b/arch/x86/mm/fault.c @@ -20,6 +20,9

[lttng-dev] [RFC-Patch 2/2] x86:Instruments page fault trace event

2013-04-09 Thread Francis Deslauriers
Signed-off-by: Francis Deslauriers Reviewed-by: Raphaël Beamonte --- arch/x86/mm/fault.c |7 +++ mm/memory.c |5 + 2 files changed, 12 insertions(+) diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c index 2b97525..6ce 100644 --- a/arch/x86/mm/fault.c +++ b/arch

[lttng-dev] [RFC-Patch 1/2] Add page fault trace event definitions

2013-04-09 Thread Francis Deslauriers
Add page_fault_entry and page_fault_exit event definitions. It will allow each architecture to instrument their page faults. Signed-off-by: Francis Deslauriers Reviewed-by: Raphaël Beamonte --- include/trace/events/fault.h | 51 ++ 1 file changed, 51

[lttng-dev] [PATCH lttng-tools] Add vpid, vppid and vtid explanation in add-context help menu

2014-06-18 Thread francis . deslauriers
From: Francis Deslauriers Signed-off-by: Francis Deslauriers --- src/bin/lttng/commands/add_context.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/bin/lttng/commands/add_context.c b/src/bin/lttng/commands/add_context.c index 405b782..52d0db4 100644 --- a/src/bin/lttng/commands

Re: [lttng-dev] [PATCH lttng-tools] Add vpid, vppid and vtid explanation in add-context help menu

2014-06-19 Thread Francis Deslauriers
On Thu, Jun 19, 2014 at 2:21 PM, David Goulet wrote: > On 18 Jun (22:19:40), francis.deslauri...@efficios.com wrote: >> From: Francis Deslauriers >> >> Signed-off-by: Francis Deslauriers >> --- >> src/bin/lttng/commands/add_context.c | 3 +++ >> 1 file ch

[lttng-dev] [PATCH lttng-ust] Move enablers syncing after the channel registration

2014-07-10 Thread francis . deslauriers
From: Francis Deslauriers Fixes possible race condition where an event registration is received before its channel registration by the consumer. Signed-off-by: Francis Deslauriers --- liblttng-ust/lttng-events.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a

Re: [lttng-dev] babeltrace-python bindings

2014-11-04 Thread Francis Deslauriers
Hi, Do you get any errors at configure or compile time? Cheers, Francis On Tue, Nov 4, 2014 at 5:37 PM, Bin YE wrote: > Hi there > > i have installed Lttng and babeltrace > my system:Ubuntu 14.04LTS > I have made following steps > > sudo apt-add-repository ppa:lttng/ppa > sudo apt-get update >

Re: [lttng-dev] lttng for android

2014-12-05 Thread Francis Deslauriers
Hi Chao, There has been some work going on to port LTTng to Android but I don't think it's upstream yet. You can try to apply the patchset that Charles Brière has submitted earlier this fall[1] but since those are big changes it takes more time the review and test them. Don't hesitate to share you

Re: [lttng-dev] Can lttng support kernel function tracer

2015-02-16 Thread Francis Deslauriers
Hi Zhenyu, If I understandd your question correctly, I can think of two ways to trace an arbitrary kernel function. First, you can hook the tracer on a dynamic probe[1] using something like this: "lttng enable-event customEventName -k --probe kernelFunctionName". You can also hook the tracer on bo

Re: [lttng-dev] 答复: Can lttng support kernel function tracer

2015-02-17 Thread Francis Deslauriers
nel function in the write() time window.However,I > want to know is it possible that lttng can be useful in this case. > > Thanks > zhenyu.ren > > > ---------- > 发件人:Francis Deslauriers > 发送时间:2015年2月17日(星期二) 00:53 >

Re: [lttng-dev] 答复:答复: Can lttng support kernel function tracer

2015-02-19 Thread Francis Deslauriers
ite instances to > capture the deviant ones. > > Thanks > zhenyu.ren > > > > > > > ---------- > 发件人:Francis Deslauriers > > > 发送时间:2015年2月17日(星期二) 23:09 > 收件人:zhenyu.ren > 抄 送:lttng-dev@

Re: [lttng-dev] Beginner question: how to inspect scheduling of multi-threaded user application?

2016-08-24 Thread Francis Deslauriers
Hi David, If you specifically want to trace the scheduling of the threads of your app, you don't need custom tracepoints. Enabling the sched_switch kernel event will give you both of cpu id and thread id. Look at the cpu_id and next_tid fields. You can enable the sched_switch event using : lttng e

[lttng-dev] LTTng User Survey 2016

2016-11-03 Thread Francis Deslauriers
really short survey of 7 multiple choices questions. I would really appreciate it if you took a little bit of your time to fill it up. https://goo.gl/forms/mqbAGSU2TIVZEySk1 I will keep it opened for two weeks and then reply to this message with a summary of the results. Thank you, -- Francis

[lttng-dev] [PATCH lttng-tools] Fix: test case can not rely on sched_process_free, use _fork instead

2016-11-08 Thread Francis Deslauriers
sched_process_free may not be called during the tracing session if there is very little activity on the machine the test is run on. We change this validate to sched_process_fork since we are sure there will be atleast one generated by the final lttng stop. Signed-off-by: Francis Deslauriers

Re: [lttng-dev] [PATCH lttng-tools] Fix: test case can not rely on sched_process_free, use _fork instead

2016-11-08 Thread Francis Deslauriers
Please omit this patch. I am preparing a more generic one. Thank you, -- Francis Deslauriers Software developer EfficiOS inc. 2016-11-08 11:05 GMT-05:00 Francis Deslauriers < francis.deslauri...@efficios.com>: > sched_process_free may not be called during the tracing session if there

[lttng-dev] [PATCH lttng-tools] Fix: test cases now rely on explicit workloads

2016-11-08 Thread Francis Deslauriers
Run a process explicitly in the tracing session to generate the enabled events rather than relying on the events generated by the lttng CLI. Signed-off-by: Francis Deslauriers --- tests/regression/kernel/test_all_events | 6 ++ tests/regression/kernel/test_event_basic | 14

[lttng-dev] [PATCH lttng-tools v2] Fix: test cases now rely on explicit workloads

2016-11-08 Thread Francis Deslauriers
Run a process explicitly in the tracing session to generate the enabled events rather than relying on the events generated by the lttng CLI. Signed-off-by: Francis Deslauriers --- tests/regression/kernel/test_all_events | 6 ++ tests/regression/kernel/test_event_basic | 14

Re: [lttng-dev] [PATCH lttng-tools v2] Fix: test cases now rely on explicit workloads

2016-11-08 Thread Francis Deslauriers
2016-11-08 15:06 GMT-05:00 Nathan Lynch : > On 11/08/2016 01:49 PM, Francis Deslauriers wrote: > > Run a process explicitly in the tracing session to generate the enabled > events > > rather than relying on the events generated by the lttng CLI. > > [...] > > &

Re: [lttng-dev] [PATCH lttng-tools v2] Fix: test cases now rely on explicit workloads

2016-11-10 Thread Francis Deslauriers
Agreed. Let me send this in a final version of this patch. Thanks, Francis 2016-11-08 16:07 GMT-05:00 Mathieu Desnoyers : > - On Nov 8, 2016, at 3:46 PM, Francis Deslauriers < > francis.deslauri...@efficios.com> wrote: > > 2016-11-08 15:06 GMT-05:00 Nathan Lynch : > &

[lttng-dev] [PATCH lttng-tools v3] Fix: test cases now rely on explicit workloads

2016-11-10 Thread Francis Deslauriers
Run a process explicitly in the tracing session to generate the enabled events rather than relying on the events generated by the lttng CLI. --- tests/regression/kernel/test_all_events | 6 ++ tests/regression/kernel/test_event_basic | 14 -- 2 files changed, 18 insertions(+), 2

[lttng-dev] [PATCH lttng-tools] Fix: add missing refcount of loaded modules

2016-11-21 Thread Francis Deslauriers
Signed-off-by: Francis Deslauriers --- src/bin/lttng-sessiond/modprobe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/lttng-sessiond/modprobe.c b/src/bin/lttng-sessiond/modprobe.c index 0502740..03545ef 100644 --- a/src/bin/lttng-sessiond/modprobe.c +++ b/src/bin

[lttng-dev] [PATCH lttng-tools] Fix: support for older versions of Babeltrace in test script

2016-12-20 Thread Francis Deslauriers
. Signed-off-by: Francis Deslauriers CC: Philippe Proulx --- tests/utils/babelstats.pl | 31 +-- 1 file changed, 9 insertions(+), 22 deletions(-) diff --git a/tests/utils/babelstats.pl b/tests/utils/babelstats.pl index 37a9b06..16766ba 100755 --- a/tests/utils

[lttng-dev] [PATCH babeltrace] Build Python bindings with distutils for consistent installs

2017-02-17 Thread Francis Deslauriers
include it. It uses Distutils which is part of the Python standard library. To be applied on top of 1.5. Signed-off-by: Francis Deslauriers --- .gitignore| 10 +++-- bindings/python/Makefile.am | 39 +++- bindings/python/babeltrace

Re: [lttng-dev] [PATCH babeltrace] Build Python bindings with distutils for consistent installs

2017-02-20 Thread Francis Deslauriers
I noticed some shortcomings for this patch. I will send an updated version shortly. Francis 2017-02-17 15:59 GMT-05:00 Francis Deslauriers : > This patch changes the build system used to compile and install the > Python Bindings. Distutils is used to find the right install directory. >

[lttng-dev] [PATCH babeltrace v2] Build Python bindings with distutils for consistent installs

2017-02-21 Thread Francis Deslauriers
include it. It uses Distutils which is part of the Python standard library. To be applied on Babeltrace v1.5 Signed-off-by: Francis Deslauriers --- .gitignore| 10 +++- bindings/python/Makefile.am | 58 +- bindings/python

[lttng-dev] [PATCH babeltrace] Set the minimum Python version to 3.0

2017-02-21 Thread Francis Deslauriers
To be applied on Babeltrace v1.5 Signed-off-by: Francis Deslauriers --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index fd80fd9..7d9b66e 100644 --- a/configure.ac +++ b/configure.ac @@ -239,7 +239,7 @@ AM_CONDITIONAL([USE_PYTHON

[lttng-dev] [PATCH babeltrace v3] Build Python bindings with distutils for consistent installs

2017-02-27 Thread Francis Deslauriers
the Python search path (PYTHONPATH), we print a warning explaining what can be done to include it. It uses Distutils which is part of the Python standard library. Signed-off-by: Francis Deslauriers --- .gitignore| 10 +++- bindings/python/Makefile

[lttng-dev] [PATCH lttng-ust] Fix: (un)install targets of Python agent

2017-02-28 Thread Francis Deslauriers
tively not uninstalling. We now save the paths of the installed files and use this information during the uninstallation. Also, we print a warning if the install directory is not included in the PYTHONPATH variable. Signed-off-by: Francis Deslauriers --- .gitignore | 1 + pytho

[lttng-dev] [PATCH lttng-ust v2] Fix: (un)install targets of Python agent

2017-03-02 Thread Francis Deslauriers
H variable. Signed-off-by: Francis Deslauriers --- python-lttngust/Makefile.am | 38 --- python-lttngust/setup.py.in | 64 + 2 files changed, 77 insertions(+), 25 deletions(-) diff --git a/python-lttngust/Makefile.am b/python-lttngust/M

[lttng-dev] [PATCH babeltrace v4] Build Python bindings with distutils for consistent installs

2017-03-06 Thread Francis Deslauriers
), we print a warning explaining what can be done to include it. It uses Distutils which is part of the Python standard library. Signed-off-by: Francis Deslauriers --- .gitignore| 10 +++- bindings/python/Makefile.am | 58

[lttng-dev] [PATCH lttng-modules] Fix: section mismatch warning caused by __exit annotation

2017-03-07 Thread Francis Deslauriers
lttng_logger_exit is used in a non-exit function so it can not be annotated with `__exit` Signed-off-by: Francis Deslauriers --- probes/lttng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/probes/lttng.c b/probes/lttng.c index 58aa515..8810fa2 100644 --- a/probes/lttng.c

[lttng-dev] [PATCH lttng-modules] Fix: update mm_vmscan instrumentation for kernel 4.11

2017-03-07 Thread Francis Deslauriers
Signed-off-by: Francis Deslauriers --- instrumentation/events/lttng-module/mm_vmscan.h | 62 - 1 file changed, 60 insertions(+), 2 deletions(-) diff --git a/instrumentation/events/lttng-module/mm_vmscan.h b/instrumentation/events/lttng-module/mm_vmscan.h index 36ebd5c

[lttng-dev] [PATCH lttng-modules] Fix: update btrfs instrumentation for kernel 4.11

2017-03-07 Thread Francis Deslauriers
Signed-off-by: Francis Deslauriers --- instrumentation/events/lttng-module/btrfs.h | 9 + 1 file changed, 9 insertions(+) diff --git a/instrumentation/events/lttng-module/btrfs.h b/instrumentation/events/lttng-module/btrfs.h index cc7ba50..2955e28 100644 --- a/instrumentation/events

[lttng-dev] [PATCH lttng-modules] Fix: changes to the vm_op fault cb prototype in libringbuffer

2017-03-07 Thread Francis Deslauriers
Signed-off-by: Francis Deslauriers --- lib/ringbuffer/ring_buffer_mmap.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/ringbuffer/ring_buffer_mmap.c b/lib/ringbuffer/ring_buffer_mmap.c index 35d30e7..1ca45a7 100644 --- a/lib/ringbuffer/ring_buffer_mmap.c +++ b/lib/ringbuffer

[lttng-dev] [PATCH lttng-modules v2] Fix: update btrfs instrumentation for kernel 4.11

2017-03-07 Thread Francis Deslauriers
Signed-off-by: Francis Deslauriers --- instrumentation/events/lttng-module/btrfs.h | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/instrumentation/events/lttng-module/btrfs.h b/instrumentation/events/lttng-module/btrfs.h index cc7ba50..ecaf382

[lttng-dev] [PATCH lttng-modules v2] Fix: changes to the vm_op fault cb prototype in libringbuffer

2017-03-07 Thread Francis Deslauriers
Signed-off-by: Francis Deslauriers --- lib/ringbuffer/ring_buffer_mmap.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/lib/ringbuffer/ring_buffer_mmap.c b/lib/ringbuffer/ring_buffer_mmap.c index 35d30e7..4b1b7b3 100644 --- a/lib/ringbuffer

[lttng-dev] [PATCH lttng-modules] Fix: update scsi instrumentation for kernel 4.11

2017-03-07 Thread Francis Deslauriers
Signed-off-by: Francis Deslauriers --- instrumentation/events/lttng-module/block.h | 154 ++-- 1 file changed, 146 insertions(+), 8 deletions(-) diff --git a/instrumentation/events/lttng-module/block.h b/instrumentation/events/lttng-module/block.h index 4373edf..152609c

[lttng-dev] [PATCH lttng-modules] Fix: timers cputime_t arguments replaced by ull in kernel 4.11

2017-03-07 Thread Francis Deslauriers
cputime_t was changed to ull in the kernel commit: 858cf3a Signed-off-by: Francis Deslauriers --- instrumentation/events/lttng-module/timer.h | 38 + 1 file changed, 38 insertions(+) diff --git a/instrumentation/events/lttng-module/timer.h b/instrumentation/events

[lttng-dev] [PATCH lttng-modules] Fix: atomic_add_unless() already returns zero on overflow

2017-03-07 Thread Francis Deslauriers
Signed-off-by: Francis Deslauriers --- wrapper/kref.h | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/wrapper/kref.h b/wrapper/kref.h index eedefbf..f30a9ae 100644 --- a/wrapper/kref.h +++ b/wrapper/kref.h @@ -36,11 +36,7 @@ */ static inline int lttng_kref_get(struct

[lttng-dev] [PATCH lttng-modules] Fix: kref changes for kernel 4.11

2017-03-07 Thread Francis Deslauriers
The underlying type of `struct kref` changed in kernel 4.11 from an atomic_t to a refcount_t. This change was introduced in kernel commit:10383ae. This commit also added a builtin overflow checks to `kref_get()` so we use it. Signed-off-by: Francis Deslauriers --- wrapper/kref.h | 8 1

[lttng-dev] [PATCH lttng-modules] Fix: atomic_add_unless() returns true/false rather than prior value

2017-03-08 Thread Francis Deslauriers
successful. This issue had a low likelihood of being triggered since the two refcounts of the counters used with this call are both bounded by the maximum number of file descriptors on the system. Signed-off-by: Francis Deslauriers --- wrapper/kref.h | 6 +- 1 file changed, 1 insertion(+), 5

[lttng-dev] [PATCH lttng-modules v3] Fix: atomic_add_unless() returns true/false rather than prior value

2017-03-08 Thread Francis Deslauriers
was successful. This issue had a low likelihood of being triggered since the two refcounts of the counters used with this call are both bounded by the maximum number of file descriptors on the system. Signed-off-by: Francis Deslauriers --- wrapper/kref.h | 6 +- 1 file changed, 1 insertion

[lttng-dev] [PATCH lttng-modules] Fix: use of uninitialized ret value in lttng_abi_open_metadata_stream

2017-03-08 Thread Francis Deslauriers
Fixes the following compiler warning: lttng-abi.c: In function ‘lttng_metadata_ioctl’: lttng-abi.c:971:6: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized] int ret; ^ Signed-off-by: Francis Deslauriers --- lttng-abi.c | 5 - 1 file changed, 4

[lttng-dev] [PATCH lttng-ust] Fix formatting in strutils_star_glob_match explanation

2017-03-17 Thread Francis Deslauriers
Replace tabs for spaces in example scenario Signed-off-by: Francis Deslauriers --- liblttng-ust/string-utils.c | 108 ++-- 1 file changed, 54 insertions(+), 54 deletions(-) diff --git a/liblttng-ust/string-utils.c b/liblttng-ust/string-utils.c index

[lttng-dev] [PATCH lttng-modules] Fix formatting in strutils_star_glob_match_char_cb explanation

2017-03-17 Thread Francis Deslauriers
Replace tabs for spaces in example scenario Signed-off-by: Francis Deslauriers --- lttng-string-utils.c | 108 +-- 1 file changed, 54 insertions(+), 54 deletions(-) diff --git a/lttng-string-utils.c b/lttng-string-utils.c index 94de1cf..7485380

[lttng-dev] [PATCH babeltrace v5] Build Python bindings with distutils for consistent installs

2017-04-11 Thread Francis Deslauriers
search path (PYTHONPATH), we print a warning explaining what can be done to include it. It uses Distutils which is part of the Python standard library. Signed-off-by: Francis Deslauriers --- .gitignore| 10 +++- bindings/python/Makefile.am | 57

[lttng-dev] [PATCH] Test: Replace test relying pselect6(2) man page error

2017-05-11 Thread Francis Deslauriers
ent testcase with one that checks the behaviour of the syscall when passed an invalid FD. [1]:https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/select.c#n619 [2]:https://patchwork.kernel.org/patch/9345805/ Signed-off-by: Francis Deslauriers Signed-off-by: Julien Desfos

Re: [lttng-dev] [PATCH] Test: Replace test relying pselect6(2) man page error

2017-05-11 Thread Francis Deslauriers
Sorry for the missing [PATCH lttng-tools] 2017-05-11 15:36 GMT-04:00 Francis Deslauriers < francis.deslauri...@efficios.com>: > The `pselect_fd_too_big` test is checking for the case where the `nfds` > is larger than the number of open files allowed for this process > (RLIMIT_NOF

Re: [lttng-dev] Adding kernel events

2017-05-12 Thread Francis Deslauriers
__ > lttng-dev mailing list > lttng-dev@lists.lttng.org > https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev > -- Francis Deslauriers Software developer EfficiOS inc. ___ lttng-dev mailing list lttng-dev@lists.lttng.org https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

[lttng-dev] [PATCH lttng-modules] Fix: NULL pointer dereference of THIS_MODULE with built-in modules

2017-05-17 Thread Francis Deslauriers
this piece of code will end up in a module and not in the kernel itself. [1]: linux/include/linux/export.h:32 Fixes: #1107 Signed-off-by: Francis Deslauriers --- wrapper/tracepoint.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/wrapper/tracepoint.h b/wrapper

Re: [lttng-dev] tracing page_faults with lttng?

2017-05-24 Thread Francis Deslauriers
kernel 4.10.13-1. > > Thanks > -- > Milian Wolff | milian.wo...@kdab.com | Software Engineer > KDAB (Deutschland) GmbH&Co KG, a KDAB Group company > Tel: +49-30-521325470 > KDAB - The Qt Experts > ___ > lttng-dev mailing

[lttng-dev] [PATCH lttng-modules] Fix: Build ftrace probe on kernels prior to 4.12

2017-05-30 Thread Francis Deslauriers
Signed-off-by: Francis Deslauriers --- probes/Kbuild | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/probes/Kbuild b/probes/Kbuild index fe869d0..78bf3fb 100644 --- a/probes/Kbuild +++ b/probes/Kbuild @@ -267,8 +267,9 @@ ifneq ($(CONFIG_DYNAMIC_FTRACE),) echo

[lttng-dev] [PATCH lttng-tools V2] Test: Replace test relying pselect6(2) man page ambiguity

2017-05-31 Thread Francis Deslauriers
hen passed an invalid FD. [1]:http://man7.org/linux/man-pages/man2/pselect6.2.html [2]:https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/select.c#n619 [3]:https://patchwork.kernel.org/patch/9345805/ Signed-off-by: Francis Deslauriers Signed-off-by: Julien Desfos

Re: [lttng-dev] How to user perf probes and module tracepoints in lttng

2017-10-11 Thread Francis Deslauriers
you get? Thank you, Francis > > > Thanks > > > > > > ___________ > lttng-dev mailing list > lttng-dev@lists.lttng.org > https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev > -- Francis Deslauriers Software

Re: [lttng-dev] How to user perf probes and module tracepoints in lttng

2017-10-12 Thread Francis Deslauriers
LDIR to the root of the source > files ( compiled) it worked. > > Thanks > > > > On Wed, Oct 11, 2017 at 4:49 PM, Francis Deslauriers > wrote: >> >> Hi, >> 2017-10-11 17:10 GMT-04:00 avkumar : >> > >> > Perf probes: >> > How can

[lttng-dev] [PATCH lttng-ust 4/8] Add probe provider unregister function

2018-02-02 Thread Francis Deslauriers
Signed-off-by: Francis Deslauriers --- include/lttng/ust-events.h | 1 + liblttng-ust/lttng-events.c | 89 + 2 files changed, 90 insertions(+) diff --git a/include/lttng/ust-events.h b/include/lttng/ust-events.h index caf7e63..019b0eb 100644 --- a

[lttng-dev] [PATCH lttng-ust 1/8] Remove duplicate provider name checks

2018-02-02 Thread Francis Deslauriers
e the newly register event has a different probe payload. Taking a simple case where a probe provider is registered twice, the tracepoint call site will have two probes registered to it and thus will generate two events in the trace. Signed-off-by: Mathieu Desnoyers Signed-off-by: Francis Deslau

[lttng-dev] [PATCH lttng-ust 5/8] Fix: missing enum removal from the enum hashtable

2018-02-02 Thread Francis Deslauriers
Signed-off-by: Francis Deslauriers --- liblttng-ust/lttng-events.c | 1 + 1 file changed, 1 insertion(+) diff --git a/liblttng-ust/lttng-events.c b/liblttng-ust/lttng-events.c index e8d4857..2b679b5 100644 --- a/liblttng-ust/lttng-events.c +++ b/liblttng-ust/lttng-events.c @@ -990,6 +990,7

[lttng-dev] [PATCH lttng-ust 8/8] Support unloading of probe providers

2018-02-02 Thread Francis Deslauriers
With this commit, it's now possible to dlclose() a library containing an actively used probe provider. The destructor of such library will now iterate over all the sessions and over all probe definitions to unregister them from the respective callsites in the process. Signed-off-by: Fr

[lttng-dev] [PATCH lttng-ust 7/8] Rename lttng_ust_enum_get to lttng_ust_enum_get_from_desc

2018-02-02 Thread Francis Deslauriers
Change the prototype to take a descriptor instead of a char *. Now that provider names can have duplicates enum names are not necessarily unique. Signed-off-by: Francis Deslauriers --- include/lttng/ust-events.h | 5 +++-- liblttng-ust-comm/lttng-ust-comm.c | 3 +-- liblttng-ust/lttng

[lttng-dev] [PATCH lttng-ust 6/8] Manually dlopen() liblttng-ust.so to prevent unloading

2018-02-02 Thread Francis Deslauriers
dlopen() increments the refcount of the library thus preventing the refcount to reach zero in the case of dlclose; Signed-off-by: Francis Deslauriers --- configure.ac | 1 + liblttng-ust/Makefile.am | 2 ++ liblttng-ust/lttng-ust-comm.c | 22 ++ 3

[lttng-dev] [PATCH lttng-ust 3/8] Cleanup: Move version numbers in separate variables in configure script

2018-02-02 Thread Francis Deslauriers
Signed-off-by: Francis Deslauriers --- configure.ac | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index fb2f278..b0b4157 100644 --- a/configure.ac +++ b/configure.ac @@ -20,7 +20,11 @@ AC_SUBST([PATCHLEVEL_VERSION], [V_PATCH]) # Following

[lttng-dev] [PATCH lttng-ust 0/8] Support provider duplicates and unloading

2018-02-02 Thread Francis Deslauriers
dlclose() the previous one. All this without stop tracing. A patch set for lttng-tools project is necessary to take advantage of those changes. The lttng-tools changes can be found on this branch of my Github fork: https://github.com/frdeso/lttng-tools/commits/multi-lib-support Francis

[lttng-dev] [PATCH lttng-ust 2/8] Fix: missing event removal from the event hashtable

2018-02-02 Thread Francis Deslauriers
Signed-off-by: Francis Deslauriers --- liblttng-ust/lttng-events.c | 4 1 file changed, 4 insertions(+) diff --git a/liblttng-ust/lttng-events.c b/liblttng-ust/lttng-events.c index f4a7ccc..7419f78 100644 --- a/liblttng-ust/lttng-events.c +++ b/liblttng-ust/lttng-events.c @@ -883,7 +883,11

[lttng-dev] [PATCH lttng-tools 4/5] Tests: add function to validate the number of an event name in metadata

2018-02-07 Thread Francis Deslauriers
Signed-off-by: Francis Deslauriers --- tests/utils/utils.sh | 23 +++ 1 file changed, 23 insertions(+) diff --git a/tests/utils/utils.sh b/tests/utils/utils.sh index 9bf1fcc..60df376 100644 --- a/tests/utils/utils.sh +++ b/tests/utils/utils.sh @@ -1343,6 +1343,29 @@ function

[lttng-dev] [PATCH lttng-tools 0/5] Support probes with the same name but different event payload

2018-02-07 Thread Francis Deslauriers
dlclose probe provider and callsite libraries during tracing. This patch set also includes regression tests for both the deep comparaison and the newly added dlclose capability. [1]: https://github.com/frdeso/lttng-ust/tree/dlclose-support Francis Deslauriers (5): Fix: probes should not be

[lttng-dev] [PATCH lttng-tools 5/5] Tests: add duplicated providers tests

2018-02-07 Thread Francis Deslauriers
Signed-off-by: Francis Deslauriers --- configure.ac| 1 + tests/fast_regression | 1 + tests/regression/ust/multi-lib/Makefile.am | 114 +++ tests/regression/ust/multi-lib/README | 21 ++ tests/regression

[lttng-dev] [PATCH lttng-tools 3/5] Tests: allow the use of regular expressions to match events

2018-02-07 Thread Francis Deslauriers
Signed-off-by: Francis Deslauriers --- tests/utils/utils.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/utils/utils.sh b/tests/utils/utils.sh index e8dfcda..9bf1fcc 100644 --- a/tests/utils/utils.sh +++ b/tests/utils/utils.sh @@ -1457,7 +1457,7 @@ function

[lttng-dev] [PATCH lttng-tools 1/5] Fix: probes should not be compared by their names and callsite signatures

2018-02-07 Thread Francis Deslauriers
is the same. Signed-off-by: Francis Deslauriers --- src/bin/lttng-sessiond/Makefile.am | 3 +- src/bin/lttng-sessiond/ust-field-utils.c | 261 +++ src/bin/lttng-sessiond/ust-field-utils.h | 29 src/bin/lttng-sessiond/ust-registry.c| 40 - tests

[lttng-dev] [PATCH lttng-tools 2/5] Fix: should pass the reg_enum_lookup pointer directly

2018-02-07 Thread Francis Deslauriers
As the ht_hash_enum and ht_match_enum functions are not changing the pointer there is no need to pass the address of the pointer. Signed-off-by: Francis Deslauriers --- src/bin/lttng-sessiond/ust-registry.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/bin/lttng

Re: [lttng-dev] [PATCH lttng-tools 1/5] Fix: probes should not be compared by their names and callsite signatures

2018-02-08 Thread Francis Deslauriers
2018-02-07 15:43 GMT-05:00 Mathieu Desnoyers : > - On Feb 7, 2018, at 2:36 PM, Francis Deslauriers > francis.deslauri...@efficios.com wrote: > >> Events with different payloads but identical name and signatures could >> lead to corrupted trace as the Session Daemo

Re: [lttng-dev] [PATCH lttng-tools 2/5] Fix: should pass the reg_enum_lookup pointer directly

2018-02-08 Thread Francis Deslauriers
2018-02-07 15:48 GMT-05:00 Mathieu Desnoyers : > - On Feb 7, 2018, at 2:36 PM, Francis Deslauriers > francis.deslauri...@efficios.com wrote: > >> As the ht_hash_enum and ht_match_enum functions are not changing the >> pointer there is no need to pass the address of

Re: [lttng-dev] [PATCH lttng-ust 4/8] Add probe provider unregister function

2018-02-08 Thread Francis Deslauriers
2018-02-07 15:54 GMT-05:00 Mathieu Desnoyers : > > - On Feb 2, 2018, at 2:48 PM, Francis Deslauriers > francis.deslauri...@efficios.com wrote: > >> Signed-off-by: Francis Deslauriers >> --- >> include/lttng/ust-events.h | 1 + >&

Re: [lttng-dev] [PATCH lttng-ust 6/8] Manually dlopen() liblttng-ust.so to prevent unloading

2018-02-08 Thread Francis Deslauriers
2018-02-07 15:59 GMT-05:00 Mathieu Desnoyers : > - On Feb 2, 2018, at 2:48 PM, Francis Deslauriers > francis.deslauri...@efficios.com wrote: > >> dlopen() increments the refcount of the library thus preventing the >> refcount to reach zero in the case of dlclose; > >

Re: [lttng-dev] [PATCH lttng-ust 2/8] Fix: missing event removal from the event hashtable

2018-02-08 Thread Francis Deslauriers
2018-02-07 15:50 GMT-05:00 Mathieu Desnoyers : > > > - On Feb 2, 2018, at 2:48 PM, Francis Deslauriers > francis.deslauri...@efficios.com wrote: > > Is this really a fix ? Or is it a preparation step in order to be able to > remove events before the end of the session l

Re: [lttng-dev] [PATCH lttng-ust 5/8] Fix: missing enum removal from the enum hashtable

2018-02-08 Thread Francis Deslauriers
2018-02-07 15:55 GMT-05:00 Mathieu Desnoyers : > - On Feb 2, 2018, at 2:48 PM, Francis Deslauriers > francis.deslauri...@efficios.com wrote: > > Is it a fix or a preparation step for a new feature ? Same thought process that with: cds_hlist_del(&event->hlist); Thanks,

[lttng-dev] [PATCH lttng-ust v2 6/6] Support unloading of probe providers

2018-02-09 Thread Francis Deslauriers
With this commit, it's now possible to dlclose() a library containing an actively used probe provider. The destructor of such library will now iterate over all the sessions and over all probe definitions to unregister them from the respective callsites in the process. Signed-off-by: Fr

[lttng-dev] [PATCH lttng-ust v2 3/6] Add probe provider unregister function

2018-02-09 Thread Francis Deslauriers
Also, ensure that enumerations and events are removed from their respective hashtables when _lttng_{event, enum}_destroy functions are called. Signed-off-by: Francis Deslauriers --- v2: use of cds_hlist_for_each_entry_safe to safely delete event from hashtable during iteration Various coding

[lttng-dev] [PATCH lttng-ust v2 1/6] Remove duplicate provider name checks

2018-02-09 Thread Francis Deslauriers
e the newly register event has a different probe payload. Taking a simple case where a probe provider is registered twice, the tracepoint call site will have two probes registered to it and thus will generate two events in the trace. Signed-off-by: Mathieu Desnoyers Signed-off-by: Francis Deslau

[lttng-dev] [PATCH lttng-ust v2 5/6] Rename lttng_ust_enum_get to lttng_ust_enum_get_from_desc

2018-02-09 Thread Francis Deslauriers
Change the prototype to take a descriptor instead of a char *. Now that provider names can have duplicates enum names are not necessarily unique. Signed-off-by: Francis Deslauriers --- include/lttng/ust-events.h | 5 +++-- liblttng-ust-comm/lttng-ust-comm.c | 3 +-- liblttng-ust/lttng

[lttng-dev] [PATCH lttng-ust v2 0/6] Support provider duplicates and unloading

2018-02-09 Thread Francis Deslauriers
dlclose() the previous one. All this without stop tracing. A patch set for lttng-tools project is necessary to take advantage of those changes. The lttng-tools changes can be found on this branch of my Github fork: https://github.com/frdeso/lttng-tools/commits/multi-lib-support Francis

[lttng-dev] [PATCH lttng-ust v2 4/6] Manually dlopen() liblttng-ust.so to prevent unloading

2018-02-09 Thread Francis Deslauriers
ld set the detached state accordingly. To prevent that unloading, we pin it in memory by grabbing an extra reference on the library, with a RTLD_NODELETE flag. This will prevent the dynamic loader from ever removing the liblttng-ust.so library from the process' address space. Signed-off-by: Fran

[lttng-dev] [PATCH lttng-ust v2 2/6] Cleanup: Move version numbers in separate variables in configure script

2018-02-09 Thread Francis Deslauriers
Signed-off-by: Francis Deslauriers --- configure.ac | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index fb2f278..b0b4157 100644 --- a/configure.ac +++ b/configure.ac @@ -20,7 +20,11 @@ AC_SUBST([PATCHLEVEL_VERSION], [V_PATCH]) # Following

[lttng-dev] [PATCH lttng-tools v2 4/5] Tests: add function to validate the number of an event name in metadata

2018-02-09 Thread Francis Deslauriers
Signed-off-by: Francis Deslauriers --- tests/utils/utils.sh | 23 +++ 1 file changed, 23 insertions(+) diff --git a/tests/utils/utils.sh b/tests/utils/utils.sh index 9bf1fcc..60df376 100644 --- a/tests/utils/utils.sh +++ b/tests/utils/utils.sh @@ -1343,6 +1343,29 @@ function

[lttng-dev] [PATCH lttng-tools v2 2/5] Fix: calling ht_{hash, match}_enum with wrong argument

2018-02-09 Thread Francis Deslauriers
ht_hash_enum and ht_match_enum are currently called with the address of the pointer to a ust_registry_enum rather than the expected pointer to a ust_registry_enum. This means that those function calls would end up using garbage for hashing and comparing. Signed-off-by: Francis Deslauriers

[lttng-dev] [PATCH lttng-tools v2 1/5] Fix: probes should be compared strictly by events metadata

2018-02-09 Thread Francis Deslauriers
, fields and model_emf_uri to ensure that their respective metadata is the same. Signed-off-by: Francis Deslauriers --- src/bin/lttng-sessiond/Makefile.am | 3 +- src/bin/lttng-sessiond/ust-field-utils.c | 289 +++ src/bin/lttng-sessiond/ust-field-utils.h | 29

[lttng-dev] [PATCH lttng-tools v2 0/5] Support probes with the same name but different event payload

2018-02-09 Thread Francis Deslauriers
added dlclose capability. [1]: https://github.com/frdeso/lttng-ust/tree/dlclose-support Francis Deslauriers (5): Fix: probes should be compared strictly by events metadata Fix: calling ht_{hash, match}_enum with wrong argument Tests: allow the use of regular expressions to match events Tests

[lttng-dev] [PATCH lttng-tools v2 3/5] Tests: allow the use of regular expressions to match events

2018-02-09 Thread Francis Deslauriers
Signed-off-by: Francis Deslauriers --- tests/utils/utils.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/utils/utils.sh b/tests/utils/utils.sh index e8dfcda..9bf1fcc 100644 --- a/tests/utils/utils.sh +++ b/tests/utils/utils.sh @@ -1457,7 +1457,7 @@ function

[lttng-dev] [PATCH lttng-tools v2 5/5] Tests: add duplicated providers tests

2018-02-09 Thread Francis Deslauriers
Signed-off-by: Francis Deslauriers --- configure.ac| 1 + tests/fast_regression | 1 + tests/regression/ust/multi-lib/Makefile.am | 114 +++ tests/regression/ust/multi-lib/README | 21 ++ tests/regression

  1   2   >