This patch adds src/common/defaults.c file. It contains functions to
retrieve defaults subbuf sizes based on the architecture page size.
Signed-off-by: Simon Marchi
---
src/common/Makefile.am |2 +-
src/common/defaults.c | 86
src/common/de
Hi Simon,
Can you please rename the get_default_* function family to default_get_*
in order to respect the name spacing of files.
Comment below:
Simon Marchi:
> This patch adds src/common/defaults.c file. It contains functions to
> retrieve defaults subbuf sizes based on the architecture page si
* David Goulet (dgou...@efficios.com) wrote:
> Hi Simon,
>
> Can you please rename the get_default_* function family to default_get_*
> in order to respect the name spacing of files.
Also, Simon, please remove the "dot" at the end of the Title line of
your patch.
Thanks,
Mathieu
>
> Comment b
Hi David,
I just sent my v2 for this patch. I changed the logic so that it still
uses the DEFAULT_*_SUBBUF_SIZE defines, but check that it is >= page
size. It should answer your first two comments/questions.
I don't think it would help to put these inline, since they are only
called in slow paths
* Simon Marchi (simon.mar...@polymtl.ca) wrote:
> Hi David,
>
> I just sent my v2 for this patch. I changed the logic so that it still
> uses the DEFAULT_*_SUBBUF_SIZE defines, but check that it is >= page
> size. It should answer your first two comments/questions.
>
> I don't think it would help
