Re: [lttng-dev] [PATCH lttng-modules] Add support for i2c tracepoints

2016-10-04 Thread Mathieu Desnoyers
- On Oct 4, 2016, at 3:48 PM, Simon Marchi simon.mar...@ericsson.com wrote: > On 16-10-04 01:37 PM, Mathieu Desnoyers wrote: >> Perhaps we could rename the option to "trace_sensitive_payload" ? > > Of all those: > > - trace_sensitive_data > - trace_sensitive_payload > -

Re: [lttng-dev] [PATCH lttng-modules] Add support for i2c tracepoints

2016-10-04 Thread Simon Marchi
On 16-10-04 01:37 PM, Mathieu Desnoyers wrote: > Perhaps we could rename the option to "trace_sensitive_payload" ? Of all those: - trace_sensitive_data - trace_sensitive_payload - allow_sensitive_payload_extraction - extract_sensitive_payload I prefer "extract_sensitive_payload". But it's your

Re: [lttng-dev] [PATCH lttng-modules] Add support for i2c tracepoints

2016-10-04 Thread Simon Marchi
On 16-10-03 06:21 PM, Mathieu Desnoyers wrote: > - On Oct 3, 2016, at 2:21 PM, Simon Marchi simon.mar...@ericsson.com > wrote: > >> This patch teaches lttng-modules about the i2c tracepoints in the Linux >> kernel. >> >> It contains the following tracepoints: >> >> * i2c_write >> *

Re: [lttng-dev] [PATCH lttng-modules] Add support for i2c tracepoints

2016-10-04 Thread Mathieu Desnoyers
- On Oct 4, 2016, at 1:08 PM, Simon Marchi simon.mar...@ericsson.com wrote: > On 16-10-03 06:21 PM, Mathieu Desnoyers wrote: >> - On Oct 3, 2016, at 2:21 PM, Simon Marchi simon.mar...@ericsson.com >> wrote: >> >>> This patch teaches lttng-modules about the i2c tracepoints in the Linux

Re: [lttng-dev] [PATCH lttng-modules] Add support for i2c tracepoints

2016-10-03 Thread Mathieu Desnoyers
- On Oct 3, 2016, at 2:21 PM, Simon Marchi simon.mar...@ericsson.com wrote: > This patch teaches lttng-modules about the i2c tracepoints in the Linux > kernel. > > It contains the following tracepoints: > > * i2c_write > * i2c_read > * i2c_reply > * i2c_result > > I translated the

[lttng-dev] [PATCH lttng-modules] Add support for i2c tracepoints

2016-10-03 Thread Simon Marchi
This patch teaches lttng-modules about the i2c tracepoints in the Linux kernel. It contains the following tracepoints: * i2c_write * i2c_read * i2c_reply * i2c_result I translated the fields and assignments from the kernel's include/trace/events/i2c.h as well as I could. I also tried