[lttng-dev] [PATCH lttng-tools] Fix: Use SOL_SOCKET level for SO_KEEPALIVE on all platform

2018-02-21 Thread Jonathan Rajotte
COMPAT_SOCKET_LEVEL is not needed. Should not have been there in the first place. On Linux, the setsockopt for SO_KEEPALIVE would result in an actual call to: setsockopt(22, SOL_TCP, TCP_DEFER_ACCEPT, [1], 4) Signed-off-by: Jonathan Rajotte --- src/bin/lttng-relayd/tcp_keep_alive.c | 5 +---

Re: [lttng-dev] [PATCH lttng-tools] Fix: Use SOL_SOCKET level for SO_KEEPALIVE on all platform

2018-02-21 Thread Mathieu Desnoyers
- On Feb 21, 2018, at 4:40 PM, Jonathan Rajotte jonathan.rajotte-jul...@efficios.com wrote: > COMPAT_SOCKET_LEVEL is not needed. Should not have been > there in the first place. This changelog is incomplete. It should state that the linux wrapper had a bug: it mixed up SOL_SOCKET with SOL_TC