Re: [jira] Updated: (LUCENENET-246) FSDirectory bug

2009-11-13 Thread Michael Garski
Forgot to add that if you could review and commit if it looks good, that would be great. Thanks, Michael On Nov 13, 2009, at 5:15 PM, "Michael Garski" inc.com> wrote: Digy, The patch in 244 fixes all issues in Store, including this one. Michael On Nov 13, 2009, at 5:12 PM, "Digy (JIRA)"

Re: [jira] Updated: (LUCENENET-246) FSDirectory bug

2009-11-13 Thread Michael Garski
Digy, The patch in 244 fixes all issues in Store, including this one. Michael On Nov 13, 2009, at 5:12 PM, "Digy (JIRA)" wrote: [ https://issues.apache.org/jira/browse/LUCENENET-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Digy updated LUCENENET-246:

[jira] Updated: (LUCENENET-246) FSDirectory bug

2009-11-13 Thread Digy (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Digy updated LUCENENET-246: --- Attachment: FSDirectory.patch First part of the patch is related with the creation of an object with non

[jira] Created: (LUCENENET-246) FSDirectory bug

2009-11-13 Thread Digy (JIRA)
FSDirectory bug --- Key: LUCENENET-246 URL: https://issues.apache.org/jira/browse/LUCENENET-246 Project: Lucene.Net Issue Type: Bug Reporter: Digy Pathes made recently changed the behaviour of the tests in the index

Store & Util

2009-11-13 Thread Michael Garski
I just posted the patch to fix all of the remaining failures in Lucene.Net.Store (LUCENENET-244). There is a fix in there as well for LuceneTestCase to properly tear down the test by resetting seed_init to false. I thought it was in another patch, however it is not committed in the trunk yet.

[jira] Updated: (LUCENENET-244) Remaining Tests in Lucene.Net.Store

2009-11-13 Thread Michael Garski (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Garski updated LUCENENET-244: - Comment: was deleted (was: Here's the patch! Tested it against a clean trunk copy to

[jira] Updated: (LUCENENET-244) Remaining Tests in Lucene.Net.Store

2009-11-13 Thread Michael Garski (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Garski updated LUCENENET-244: - Comment: was deleted (was: Here's the patch! Tested it against a clean trunk copy to

[jira] Updated: (LUCENENET-244) Remaining Tests in Lucene.Net.Store

2009-11-13 Thread Michael Garski (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Garski updated LUCENENET-244: - Attachment: (was: LUCENENET-244.patch) > Remaining Tests in Lucene.Net.Store > ---

[jira] Updated: (LUCENENET-244) Remaining Tests in Lucene.Net.Store

2009-11-13 Thread Michael Garski (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Garski updated LUCENENET-244: - Attachment: LUCENENET-244.patch Here's the patch! Tested it against a clean trunk cop

[jira] Updated: (LUCENENET-244) Remaining Tests in Lucene.Net.Store

2009-11-13 Thread Michael Garski (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Garski updated LUCENENET-244: - Attachment: LUCENENET-244.patch Here's the patch! Tested it against a clean trunk cop

[jira] Updated: (LUCENENET-244) Remaining Tests in Lucene.Net.Store

2009-11-13 Thread Michael Garski (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Garski updated LUCENENET-244: - Attachment: LUCENENET-244.patch Here's the patch! Tested it against a clean trunk cop

[jira] Updated: (LUCENENET-244) Remaining Tests in Lucene.Net.Store

2009-11-13 Thread Michael Garski (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Garski updated LUCENENET-244: - Attachment: (was: LUCENENET-244.patch) > Remaining Tests in Lucene.Net.Store > ---

[jira] Updated: (LUCENENET-216) FSDirectory.Sync Fix to Ensure Flush to Disk

2009-11-13 Thread Robert Jordan (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Jordan updated LUCENENET-216: Attachment: FSDirectory-Sync-PlatformIndep2.patch FSDirectory-Sync-PlatformIndep2.patch

[jira] Updated: (LUCENENET-216) FSDirectory.Sync Fix to Ensure Flush to Disk

2009-11-13 Thread Robert Jordan (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Jordan updated LUCENENET-216: Attachment: (was: FSDirectory-Sync-PlatformIndep.patch) > FSDirectory.Sync Fix to En

[jira] Resolved: (LUCENENET-240) TestSortedVIntList

2009-11-13 Thread George Aroush (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] George Aroush resolved LUCENENET-240. - Resolution: Fixed Patched. Thanks Mike! > TestSortedVIntList > -- >

[jira] Resolved: (LUCENENET-239) TestPriorityQueue failures

2009-11-13 Thread George Aroush (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] George Aroush resolved LUCENENET-239. - Resolution: Fixed Patched. Thanks Mike! > TestPriorityQueue failures > -

[jira] Resolved: (LUCENENET-238) TestNumericUtils failing

2009-11-13 Thread George Aroush (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] George Aroush resolved LUCENENET-238. - Resolution: Fixed Applied. Thanks Mike! > TestNumericUtils failing > ---

[jira] Resolved: (LUCENENET-236) TestDateFilter tests

2009-11-13 Thread George Aroush (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] George Aroush resolved LUCENENET-236. - Resolution: Fixed Committed. Thanks Mike! > TestDateFilter tests > -

[jira] Commented: (LUCENENET-216) FSDirectory.Sync Fix to Ensure Flush to Disk

2009-11-13 Thread Robert Jordan (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1211#action_1211 ] Robert Jordan commented on LUCENENET-216: - I'm on it. > FSDirectory.Sync Fix

[jira] Commented: (LUCENENET-235) TestIndexWriter + SegmentMerger bug

2009-11-13 Thread Digy (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1209#action_1209 ] Digy commented on LUCENENET-235: I committed SegmentMerger patch. But I am not comfortab

RE: [jira] Resolved: (LUCENENET-218) Lucene.Net.Util.TestAttributeSource.TestCloneAttributes

2009-11-13 Thread Michael Garski
Hmmm... as that class is a helper that abstracts the differences b/w the Java collection and the .NET implementation, I feel the opposite. At a minimum it might be worth updating the comment for the class to reflect its purpose and where it is used. Michael -Original Message- From: Ge

[jira] Commented: (LUCENENET-235) TestIndexWriter + SegmentMerger bug

2009-11-13 Thread George Aroush (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777698#action_12777698 ] George Aroush commented on LUCENENET-235: - Looks good. Commit away. Thanks DIG

[jira] Resolved: (LUCENENET-234) TestBoolean2 failing test

2009-11-13 Thread George Aroush (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] George Aroush resolved LUCENENET-234. - Resolution: Fixed Patch delivered. Thanks Mike! > TestBoolean2 failing test > --

[jira] Closed: (LUCENENET-233) TestDirectoryReader bug

2009-11-13 Thread Digy (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Digy closed LUCENENET-233. -- Resolution: Fixed Assignee: Digy Committed. DIGY > TestDirectoryReader bug > ---

[jira] Commented: (LUCENENET-233) TestDirectoryReader bug

2009-11-13 Thread George Aroush (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777679#action_12777679 ] George Aroush commented on LUCENENET-233: - Commit away. Thanks DIGY! Regarding

[jira] Resolved: (LUCENENET-218) Lucene.Net.Util.TestAttributeSource.TestCloneAttributes

2009-11-13 Thread George Aroush (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] George Aroush resolved LUCENENET-218. - Resolution: Fixed Committed. Thanks Mike! One small change I made is moved the class

[jira] Commented: (LUCENENET-216) FSDirectory.Sync Fix to Ensure Flush to Disk

2009-11-13 Thread George Aroush (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777643#action_12777643 ] George Aroush commented on LUCENENET-216: - Nice work Mike and Robert. I'm ready

[jira] Commented: (LUCENENET-210) FSDirectory - DirectoryInfo vs. FileInfo

2009-11-13 Thread George Aroush (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777639#action_12777639 ] George Aroush commented on LUCENENET-210: - Committed. Thanks Mike! Two points:

[jira] Resolved: (LUCENENET-210) FSDirectory - DirectoryInfo vs. FileInfo

2009-11-13 Thread George Aroush (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] George Aroush resolved LUCENENET-210. - Resolution: Fixed Now really closing this issue. > FSDirectory - DirectoryInfo vs. Fi

[jira] Created: (LUCENENET-245) Query Fixes

2009-11-13 Thread Michael Garski (JIRA)
Query Fixes --- Key: LUCENENET-245 URL: https://issues.apache.org/jira/browse/LUCENENET-245 Project: Lucene.Net Issue Type: Bug Reporter: Michael Garski I'm working on the tests regarding queries in Lucene.Net.Search.

[jira] Created: (LUCENENET-244) Remaining Tests in Lucene.Net.Store

2009-11-13 Thread Michael Garski (JIRA)
Remaining Tests in Lucene.Net.Store --- Key: LUCENENET-244 URL: https://issues.apache.org/jira/browse/LUCENENET-244 Project: Lucene.Net Issue Type: Bug Reporter: Michael Garski I have finished up

[jira] Commented: (LUCENENET-230) TestOpenBitSet

2009-11-13 Thread Nicholas Paldino (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777602#action_12777602 ] Nicholas Paldino commented on LUCENENET-230: I believe I commented on this e

[jira] Resolved: (LUCENENET-230) TestOpenBitSet

2009-11-13 Thread George Aroush (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] George Aroush resolved LUCENENET-230. - Resolution: Fixed Patch applied. Thanks Mike! As part of this fix, I also eliminated