[jira] Resolved: (LUCENENET-341) Fix "Compiler warnings to worry about"

2010-02-19 Thread Digy (JIRA)
[ https://issues.apache.org/jira/browse/LUCENENET-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Digy resolved LUCENENET-341. Resolution: Fixed Thanks Andy. All paches applied. DIGY > Fix "Compiler warnings to wor

[jira] Commented: (LUCENENET-341) Fix "Compiler warnings to worry about"

2010-02-19 Thread Andy Pook (JIRA)
was confirmed by running _SupportClass.TestBooleanQuerySerialization nunit test which is marked as testing LUCENENET-338 mentioned by Digy in original email thread > Fix "Compiler warnings to worry about" > -- > >

[jira] Updated: (LUCENENET-341) Fix "Compiler warnings to worry about"

2010-02-19 Thread Andy Pook (JIRA)
628: 'Lucene.Net.Search.NumericRangeQuery.NumericRangeQuery(System.Runtime.Serialization.SerializationInfo, System.Runtime.Serialization.StreamingContext)': new protected member declared in sealed class > Fix "Compiler warnings to worry about" > -- > &

[jira] Updated: (LUCENENET-341) Fix "Compiler warnings to worry about"

2010-02-19 Thread Andy Pook (JIRA)
: 'SupportClass.ThreadClass' defines operator == or operator != but does not override Object.GetHashCode()' > Fix "Compiler warnings to worry about" > -- > > Key: LUCENENET-341 > URL: https:/

[jira] Created: (LUCENENET-341) Fix "Compiler warnings to worry about"

2010-02-19 Thread Andy Pook (JIRA)
Fix "Compiler warnings to worry about" -- Key: LUCENENET-341 URL: https://issues.apache.org/jira/browse/LUCENENET-341 Project: Lucene.Net Issue Type: Bug Reporter:

Re: Compiler warnings to worry about?

2010-02-19 Thread digy digy
instead > of protected. ( > http://msdn.microsoft.com/en-us/library/ms182343(VS.80).aspx > - "For a sealed class, make the constructor private; otherwise, make > it protected.") > > Should I create a separate issue for each or a single issue with three > patches? > > --An

Re: Compiler warnings to worry about?

2010-02-19 Thread Andy Pook
e, make it protected.") Should I create a separate issue for each or a single issue with three patches? --Andy From"Digy" Subject RE: Compiler warnings to worry about? DateThu, 18 Feb 2010 17:06:39 GMT Hi Andy, 1- No we can not remove the protected constructors. They

RE: Compiler warnings to worry about?

2010-02-18 Thread Digy
ndy.p...@gmail.com] Sent: Thursday, February 18, 2010 12:35 PM To: lucene-net-dev@lucene.apache.org Subject: Compiler warnings to worry about? We get a lot of compiler warnings. This has been discussed before and the result seemed to be that it would be a lot of effort and would make it difficult to mai

Compiler warnings to worry about?

2010-02-18 Thread Andy Pook
We get a lot of compiler warnings. This has been discussed before and the result seemed to be that it would be a lot of effort and would make it difficult to maintain across versions as we have previously always used the automated process. And as most of them are just to do with xml comments it's n