Re: Document class improvements

2010-05-05 Thread Leonardo Azize Martins
So, change is not only acceptable, but necessary too, for future versions. Which version is the path below? https://svn.apache.org/repos/asf/lucene/lucene.net/trunk/C#/src/Lucene.Net/Document/Document.cs Regards Leo 2010/5/5 Robert Jordan > On 05.05.2010 14:01, Leonardo Azize Martins wrote: >

Re: Document class improvements

2010-05-05 Thread Leonardo Azize Martins
is a good approach? > No, It would be better to open a JIRA issue. > > DIGY > > > > > > -Original Message- > From: Leonardo Azize Martins [mailto:laz...@gmail.com] > Sent: Tuesday, May 04, 2010 10:35 PM > To: lucene-net-dev@lucene.apache.org > Subject

Re: Document class improvements

2010-05-04 Thread Leonardo Azize Martins
Hi DIGY, Thanks for your feedback. I am new in Lucene.Net and with open source project, so I did not know about test cases that I would run to verify. Sorry. How can I run it? I agree with you about divergences, but what is the limit of, what is good for the project and compatibility with origina

RE: Document class improvements

2010-05-04 Thread Digy
Hi Leo, Your code seems to be fine but there are two problems with it: * Some of the test cases fail(for ex, "TestRemoveForNewDocument"). I don't think it is a big problem and it can be fixed somehow but most importantly, * It includes a lot of divergence from Lucene.Java which would make l