Re: [lwip-users] [LwIP 1.4.1] Ping length of 92 bytes via PPP crashes LwIP core/pbuf.c

2017-05-16 Thread Sylvain Rochet
Hi, On Tue, May 16, 2017 at 09:13:56PM +0200, goldsi...@gmx.de wrote: > Sylvain Rochet wrote: > >I checked if the issue was still there is the current master/2.0 branch, > >you are right, this bug was fixed in commit fb07a28c99 ("fixed bug > >#36388 (PPP: checksum-only in last pbuf leads to pbuf

Re: [lwip-users] [LwIP 1.4.1] Ping length of 92 bytes via PPP crashes LwIP core/pbuf.c

2017-05-16 Thread Marco Jakobs
Hi Simon, >Marco, I know you always say you don't have the time to re-evaluate new  >verisons, but you could save us *and* yourself much time hunting those  >old bugs by just taking the time to upgrage ;-) There have been *many*  >bugs fixed since 1.4.1!  >The possibility of code size

Re: [lwip-users] low_level_output() tries to send data bigger than MSS

2017-05-16 Thread goldsi...@gmx.de
Simeon Trifonov wrote: My function low_level_output() sometimes tries to send data bigger than MSS. First of all you're mixing up things: the low_level_output() function must *always* be prepared to handle packets larger than MSS: MSS limits TCP data while your netif has to send MTU + ETH

Re: [lwip-users] LWIP RAW API tcpip_callback()

2017-05-16 Thread goldsi...@gmx.de
Werner Motz wrote: In my freertos task (outside lwip) I do following: [..] tcpip_callback_with_block(WTF, tcp_active_pcbs, 0); Why on earth would you pass 'tcp_active_pcbs'? Wherever you got that from: tell them this is wrong and they should stop spreading such horrible code

Re: [lwip-users] [LwIP 1.4.1] Ping length of 92 bytes via PPP crashes LwIP core/pbuf.c

2017-05-16 Thread goldsi...@gmx.de
Sylvain Rochet wrote: I checked if the issue was still there is the current master/2.0 branch, you are right, this bug was fixed in commit fb07a28c99 ("fixed bug #36388 (PPP: checksum-only in last pbuf leads to pbuf with zero length)") *FIVE* years ago. :-)) Thanks, for jumping in, Sylvain!

[lwip-users] LWIP RAW API tcpip_callback()

2017-05-16 Thread Werner Motz
Hello, I am using lwip 2.0.2 RAW API + freertos 8.2.3 I am able to establish a connection and I can receive data without any problems. I would like to know what is the best way to send data outside the lwip thread. In my freertos task (outside lwip) I do following: void

Re: [lwip-users] [LwIP 1.4.1] Ping length of 92 bytes via PPP crashes LwIP core/pbuf.c

2017-05-16 Thread Sylvain Rochet
Hi, On Tue, May 16, 2017 at 10:48:26AM +0200, Simon Goldschmidt wrote: > Marco Jakobs wrote: > > That one deals with this: > > > > LWIP_ERROR("p_to != NULL", (p_to != NULL) || (p_from == NULL) || > > (p_from->len == NULL) , return ERR_ARG;); > > WTF? "-len == NULL"??? > > > The assert comes

Re: [lwip-users] [LwIP 1.4.1] Ping length of 92 bytes via PPP crashes LwIP core/pbuf.c

2017-05-16 Thread Simon Goldschmidt
Marco Jakobs wrote: > That one deals with this: > > LWIP_ERROR("p_to != NULL", (p_to != NULL) || (p_from == NULL) || (p_from->len > == NULL) , return ERR_ARG;); WTF? "-len == NULL"??? > The assert comes from the ICMP routine ;-) : I rather guess the bug is in PPP (from 1.4.1) allocating a