Re: [lwip-users] LWIP_RAND in dns.c

2015-10-01 Thread goldsi...@gmx.de
Gennady Shmakov wrote: Thanks for clarification. Does it make sense to move these defines in opt.h to avoid editing *.c files when these features are not needed? #define LWIP_DNS_SECURE_RAND_XID1 #define LWIP_DNS_SECURE_NO_MULTIPLE_OUTSTANDING 2 #define LWIP_DNS_SECURE_RAND_SRC_

Re: [lwip-users] LWIP_RAND in dns.c

2015-10-01 Thread Gennady Shmakov
Krzysztof, Both are defined little earlier in dns.c: = /* A list of DNS security features follows */ #define LWIP_DNS_SECURE_RAND_XID1 #define LWIP_DNS_SECURE_NO_MULTIPLE_OUTSTANDING 2 #define LWIP_DNS_SECURE_RAND_SRC_PORT 4 /** Use all DNS

Re: [lwip-users] LWIP_RAND in dns.c

2015-10-01 Thread Krzysztof Wesołowski
> > #ifndef DNS_RAND_TXID > #if ((LWIP_DNS_SECURE & LWIP_DNS_SECURE_RAND_XID) != 0) > #define DNS_RAND_TXID *LWIP_RAND* >From reading code above I would guess it is required when both LWIP_DNS_SECURE & LWIP_DNS_SECURE_RAND_XID are defined, so why are you defining them? Regards, Krzysztof Wesołow

Re: [lwip-users] LWIP_RAND in dns.c

2015-10-01 Thread Simon Goldschmidt
Gennady Shmakov wrote: > I have an error compiling dns.c because of LWIP_RAND function is not defined. > I've checked git log and looks like this function is optional. > Is there any reason why it necessarily has to be used in dns.c? Yes, see here: https://www.kb.cert.org/vuls/id/210620 Simon _

[lwip-users] LWIP_RAND in dns.c

2015-09-30 Thread Gennady Shmakov
I have an error compiling dns.c because of LWIP_RAND function is not defined. I've checked git log and looks like this function is optional. Is there any reason why it necessarily has to be used in dns.c? dns.c listing from line 88: === /* A li