Re: [lwip-users] lwip_getsockopt_impl() return type

2017-02-17 Thread Joan Lledó
Hi Simon, I was trying to compile LwIP in the Hurd and many warnings like this one raised when compiling sockets.c: ./api/sockets.c: In function 'lwip_getsockopt_impl': ./api/sockets.c:1892:12: warning: large integer implicitly truncated to unsigned type [-Woverflow] return EBADF;

Re: [lwip-users] lwip_getsockopt_impl() return type

2017-02-16 Thread goldsi...@gmx.de
Joan, the return type is related to the type of struct lwip_sock's 'err' member. reading the comment /** last error that occurred on this socket (in fact, all our errnos fit into an u8_t) */ makes it clear this is just a size improvement which holds for our error definitions but might not

[lwip-users] lwip_getsockopt_impl() return type

2017-02-16 Thread Joan Lledó
Hello, lwip_getsockopt_impl() in api/sockets.c returns u8_t, which is enough for most errno implementations, but some implementations need all 32 bits. Please, take a look at this thread: https://lists.debian.org/debian-hurd/2002/01/msg00022.html I've changed return type to u32_t and have also