[lxc-devel] [PATCH] plamo: Improve template for lxc-stop

2013-12-24 Thread KATOH Yasufumi
patch /etc/inittab in plamo container to shutdown when it receives SIGPWR. (By default, plamo shutdowns to single user mode after 5minutes) Signed-off-by: KATOH Yasufumi --- templates/lxc-plamo.in | 6 ++ 1 file changed, 6 insertions(+) diff --git a/templates/lxc-plamo.in b/templates/lxc-pl

[lxc-devel] [PATCH] add travis-ci support to LXC github repo (v2)

2013-12-24 Thread S . Çağlar Onur
Travis is a free hosted CI platform for the open source community. It integrates well with github and enables continous builds/tests for both repository itself and all the pull requests so that one can quickly see the result of the possible merge. This yml file is one of the few required steps to

Re: [lxc-devel] [PATCH] add travis-ci support to LXC github repo

2013-12-24 Thread S . Çağlar Onur
Hi, On Mon, Dec 23, 2013 at 2:34 PM, Stéphane Graber wrote: > On Mon, Dec 23, 2013 at 02:18:18PM -0500, S.Çağlar Onur wrote: >> Hi Stéphane, >> >> On Mon, Dec 23, 2013 at 2:13 PM, Stéphane Graber wrote: >> > On Mon, Dec 23, 2013 at 02:03:56PM -0500, S.Çağlar Onur wrote: >> >> Hi Serge, >> >> >>

Re: [lxc-devel] [PATCH] [cosmetic] adjust include statements

2013-12-24 Thread S . Çağlar Onur
Hi, On Mon, Dec 23, 2013 at 2:17 PM, Stéphane Graber wrote: > On Mon, Dec 23, 2013 at 02:11:22PM -0500, S.Çağlar Onur wrote: >> Hey Serge, >> >> On Mon, Dec 23, 2013 at 11:09 AM, Serge Hallyn >> wrote: >> > >> > Why? >> >> I've no good reason to justify this change as it's purely cosmetic. >> T

Re: [lxc-devel] [PATCH] remove static_lock()/static_unlock() and start to use thread local storage (v2)

2013-12-24 Thread S . Çağlar Onur
Hi, What about reverting the revert and then do something like following? diff --git a/src/lxc/utils.c b/src/lxc/utils.c index e00c47c..c94ee24 100644 --- a/src/lxc/utils.c +++ b/src/lxc/utils.c @@ -270,7 +270,11 @@ const char *lxc_global_config_value(const char *option_name) } /

[lxc-devel] [PATCH 1/3] Allow use of public API from C++

2013-12-24 Thread Andrey Mazo
Signed-off-by: Andrey Mazo --- src/lxc/attach_options.h | 8 src/lxc/lxccontainer.h | 8 2 files changed, 16 insertions(+) diff --git a/src/lxc/attach_options.h b/src/lxc/attach_options.h index 70a39a9..c7295fb 100644 --- a/src/lxc/attach_options.h +++ b/src/lxc/attach_option

[lxc-devel] [PATCH 3/3] Remove unused functions

2013-12-24 Thread Andrey Mazo
After 95ee490bbdb97ab2b4f1dfa63a0a26e0dd1c2f17 they are not in public API and are not used throughout the lxc codebase. This has a bonus of removing workaround for bionic. Signed-off-by: Andrey Mazo --- src/lxc/parse.c | 48 src/lxc/parse.h | 3 -

[lxc-devel] [PATCH 2/3] Mark functions as static and arguments/arrays as const where possible

2013-12-24 Thread Andrey Mazo
Mark most of functions that are used within only one file as static. After 95ee490bbdb97ab2b4f1dfa63a0a26e0dd1c2f17 it's easy to prove they are not in public API. Several arrays and structs are also marked static. This prevents them from being exported from liblxc.so List of removed previously exp

Re: [lxc-devel] [PATCH] lxc-autostart: don't set timeout if user requested -s

2013-12-24 Thread Serge Hallyn
Quoting KATOH Yasufumi (ka...@jazz.email.ne.jp): > same as the commit 25070b660187b61aa4e969db01b55d1360639543 > > Signed-off-by: KATOH Yasufumi Thanks, looks good. (Note you could have simply done c->shutdown(c, 0) but this works to :) Acked-by: Serge E. Hallyn > --- > doc/ja/lxc-autostart

[lxc-devel] [lxc/lxc] 2da1f5: lxc-autostart: don't set timeout if user requested...

2013-12-24 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 2da1f56ce304ad8dbd651d1305de9b6d58dd19db https://github.com/lxc/lxc/commit/2da1f56ce304ad8dbd651d1305de9b6d58dd19db Author: KATOH Yasufumi Date: 2013-12-24 (Tue, 24 Dec 2013) Changed paths: M doc/ja/lxc-a

Re: [lxc-devel] [PATCH 2/2] Use getmntent_r() for thread-safety

2013-12-24 Thread Andrey Mazo
Thank you for pushing this! On Tue, 24 Dec 2013 19:07:43 +0400, Serge Hallyn wrote: Quoting Andrey Mazo (m...@telum.ru): Signed-off-by: Andrey Mazo Acked-by: Serge E. Hallyn --- src/lxc/conf.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) -- Andrey Mazo.

[lxc-devel] [lxc/lxc] 37c410: coverity: make sure not to close file handle twice

2013-12-24 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 37c41004f77b6e5ad2f1d278a41720497841bca9 https://github.com/lxc/lxc/commit/37c41004f77b6e5ad2f1d278a41720497841bca9 Author: Serge Hallyn Date: 2013-12-24 (Tue, 24 Dec 2013) Changed paths: M src/lxc/lxc_st

Re: [lxc-devel] hwaddr tuning in templates

2013-12-24 Thread Serge Hallyn
Quoting Guillaume ZITTA (l...@zitta.fr): > Le 24/12/2013 15:32, Stéphane Graber a écrit : > >On Tue, Dec 24, 2013 at 03:01:38PM +0100, Guillaume ZITTA wrote: > >>Hi, > >> > >>I'm coding a new template (for gentoo). > >> > >>I saw this kind of tweak in many templates : > >> > >>if [ "$nics" -eq

[lxc-devel] [lxc/lxc] dd1d77: Remove process_lock() except where actually needed

2013-12-24 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: dd1d77f91b3eb5b9b02f97d81c6c1c6c29563c03 https://github.com/lxc/lxc/commit/dd1d77f91b3eb5b9b02f97d81c6c1c6c29563c03 Author: Andrey Mazo Date: 2013-12-24 (Tue, 24 Dec 2013) Changed paths: M src/lxc/af_unix

Re: [lxc-devel] [PATCH 2/2] Use getmntent_r() for thread-safety

2013-12-24 Thread Serge Hallyn
Quoting Andrey Mazo (m...@telum.ru): > Signed-off-by: Andrey Mazo Acked-by: Serge E. Hallyn > --- > src/lxc/conf.c | 19 ++- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --git a/src/lxc/conf.c b/src/lxc/conf.c > index 68f9716..ed1056d 100644 > --- a/src/lxc/conf

Re: [lxc-devel] hwaddr tuning in templates

2013-12-24 Thread Guillaume ZITTA
Le 24/12/2013 15:32, Stéphane Graber a écrit : On Tue, Dec 24, 2013 at 03:01:38PM +0100, Guillaume ZITTA wrote: Hi, I'm coding a new template (for gentoo). I saw this kind of tweak in many templates : if [ "$nics" -eq 1 ] && ! grep -q "^lxc.network.hwaddr" $path/config; then # see

[lxc-devel] [PATCH] lxc-autostart: don't set timeout if user requested -s

2013-12-24 Thread KATOH Yasufumi
same as the commit 25070b660187b61aa4e969db01b55d1360639543 Signed-off-by: KATOH Yasufumi --- doc/ja/lxc-autostart.sgml.in | 7 +++ doc/lxc-autostart.sgml.in| 3 +-- src/lxc/lxc_autostart.c | 1 + 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/doc/ja/lxc-autostart.sg

Re: [lxc-devel] hwaddr tuning in templates

2013-12-24 Thread Stéphane Graber
On Tue, Dec 24, 2013 at 03:01:38PM +0100, Guillaume ZITTA wrote: > Hi, > > I'm coding a new template (for gentoo). > > I saw this kind of tweak in many templates : > > if [ "$nics" -eq 1 ] && ! grep -q "^lxc.network.hwaddr" > $path/config; then > # see > http://sourceforge.net/track

[lxc-devel] hwaddr tuning in templates

2013-12-24 Thread Guillaume ZITTA
Hi, I'm coding a new template (for gentoo). I saw this kind of tweak in many templates : if [ "$nics" -eq 1 ] && ! grep -q "^lxc.network.hwaddr" $path/config; then # see http://sourceforge.net/tracker/?func=detail&aid=3411497&group_id=163076&atid=826303 hwaddr="fe:$(dd if=

Re: [lxc-devel] [Q] different from behavior of lxc-stop and description of man page

2013-12-24 Thread Serge Hallyn
Quoting KATOH Yasufumi (ka...@jazz.email.ne.jp): > >>> On Mon, 23 Dec 2013 10:26:38 -0600 > in message "Re: [lxc-devel] [Q] different from behavior of lxc-stop and > description of man page" > Serge Hallyn-san wrote: > > > I've pushed the following patch to line up the doc

[lxc-devel] [lxc/lxc] e339d6: doc: Fix the description of -n option in lxc-info(...

2013-12-24 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: e339d6b9c1b85e6341c0d230ac68c5958f28cf08 https://github.com/lxc/lxc/commit/e339d6b9c1b85e6341c0d230ac68c5958f28cf08 Author: KATOH Yasufumi Date: 2013-12-24 (Tue, 24 Dec 2013) Changed paths: M doc/ja/lxc-i

Re: [lxc-devel] [PATCH] doc: Fix the description of -n option in lxc-info(1)

2013-12-24 Thread Stéphane Graber
On Tue, Dec 24, 2013 at 03:56:23PM +0900, KATOH Yasufumi wrote: > Commit 5444216 revised -n option from allowing to specify multiple > containers using regex to specifying only one container. But > lxc-info(1) remains original. so > - mark -n required > - remove the description of -n that is includ

[lxc-devel] [lxc/lxc] fe8e3a: doc: Update Japanese lxc-stop(1) for -s option

2013-12-24 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: fe8e3acfa28a4ce0ab6d53d0417884c5124d04fc https://github.com/lxc/lxc/commit/fe8e3acfa28a4ce0ab6d53d0417884c5124d04fc Author: KATOH Yasufumi Date: 2013-12-24 (Tue, 24 Dec 2013) Changed paths: M doc/ja/lxc-s

Re: [lxc-devel] [PATCH] doc: Update Japanese lxc-stop(1) for -s option

2013-12-24 Thread Stéphane Graber
On Tue, Dec 24, 2013 at 01:46:35PM +0900, KATOH Yasufumi wrote: > Update for commit 25070b660187b61aa4e969db01b55d1360639543 > > Signed-off-by: KATOH Yasufumi Acked-by: Stéphane Graber > --- > doc/ja/lxc-stop.sgml.in | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --g

Re: [lxc-devel] Translate man pages to portuguese (pt-br)

2013-12-24 Thread Stéphane Graber
On Tue, Dec 24, 2013 at 12:53:17AM -0200, Julio Faracco wrote: > Hi everybody! > > What do you think about translate the lxc man pages to portuguese? > I'm from Brazil and I started to translate the man pages to understand more > about other lxc comands and the core itself. > > Do you think it wo

[lxc-devel] [PATCH 2/2] Use getmntent_r() for thread-safety

2013-12-24 Thread Andrey Mazo
Signed-off-by: Andrey Mazo --- src/lxc/conf.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/lxc/conf.c b/src/lxc/conf.c index 68f9716..ed1056d 100644 --- a/src/lxc/conf.c +++ b/src/lxc/conf.c @@ -1859,7 +1859,7 @@ static int mount_entry(const char *f

[lxc-devel] Remove process_lock() except where actually needed

2013-12-24 Thread Andrey Mazo
This patchset is a follow-up to the pull request [1] summarizing a long discussion there. First patch removes most of process_lock()/process_unlock() usage. Second patch replaces getmntent() usage with getmntent_r() to ensure this piece is thread-safe. These patches may be applied independently.