Re: [lxc-devel] Pull request: make ubuntu templates apt proxy aware

2014-01-15 Thread Chris Glass
Thanks for merging this in! As suggested, here's a trivial commit adding a commented hook to the common Ubuntu template: https://github.com/lxc/lxc/pull/137 - Chris On Tue, Jan 14, 2014 at 6:21 PM, Stéphane Graber stgra...@ubuntu.com wrote: On Tue, Jan 14, 2014 at 06:07:32PM +0100, Chris Glass

Re: [lxc-devel] Last minute template addition - universal image based template

2014-01-15 Thread KATOH Yasufumi
Hi, I checked rootfs.tar.xz of plamo. But this rootfs is not build correctly. configure_plamo() in lxc-plamo edits $rootfs/etc/rc.d/rc.S,rc.M, but a part of it was not performed. I guess that a part of editing rc.S,M is doesn't performed. ed command is installed on jenkins host? --

Re: [lxc-devel] [PATCH] lxc-download: POSIX doesn't specify -f for chown

2014-01-15 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): Signed-off-by: Stéphane Graber stgra...@ubuntu.com and you were already sending output to /dev/null anyway :) Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com Though I would also point out that the man page shows options coming before the

Re: [lxc-devel] [PATCH] lxc-download: Fix wrong option parsing

2014-01-15 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): Signed-off-by: Stéphane Graber stgra...@ubuntu.com Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com --- templates/lxc-download.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/lxc-download.in

Re: [lxc-devel] [PATCH] lxc-download: Fix undefined DOWNLOAD_FORCE_CACHE

2014-01-15 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): Signed-off-by: Stéphane Graber stgra...@ubuntu.com Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com --- templates/lxc-download.in | 1 + 1 file changed, 1 insertion(+) diff --git a/templates/lxc-download.in b/templates/lxc-download.in

Re: [lxc-devel] [PATCH] Always try to create lxcpath

2014-01-15 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): Signed-off-by: Stéphane Graber stgra...@ubuntu.com Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com (An error msg there might save some frustration in the future though) --- src/lxc/lxc_create.c | 3 +++ 1 file changed, 3 insertions(+)

Re: [lxc-devel] [PATCH] install only lxc-user-nic setuid

2014-01-15 Thread Stéphane Graber
On Wed, Jan 15, 2014 at 08:36:28AM -0500, Dwight Engen wrote: Signed-off-by: Dwight Engen dwight.en...@oracle.com Acked-by: Stéphane Graber stgra...@ubuntu.com --- lxc.spec.in | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/lxc.spec.in b/lxc.spec.in index

Re: [lxc-devel] [PATCH] doc: Update Japanese lxc.conf(5)

2014-01-15 Thread Stéphane Graber
On Wed, Jan 15, 2014 at 06:50:43PM +0900, KATOH Yasufumi wrote: Update for commit df2d4205073d3f57543951ca7ffabf891b230634 Signed-off-by: KATOH Yasufumi ka...@jazz.email.ne.jp Acked-by: Stéphane Graber stgra...@ubuntu.com --- doc/ja/lxc.conf.sgml.in | 14 ++ 1 file changed,

Re: [lxc-devel] [PATCH] lxc-download: POSIX doesn't specify -f for chown

2014-01-15 Thread Stéphane Graber
On Wed, Jan 15, 2014 at 08:48:52AM -0600, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): Signed-off-by: Stéphane Graber stgra...@ubuntu.com and you were already sending output to /dev/null anyway :) Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com Though I would

Re: [lxc-devel] [PATCH] Always try to create lxcpath

2014-01-15 Thread Stéphane Graber
On Wed, Jan 15, 2014 at 08:53:52AM -0600, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): Signed-off-by: Stéphane Graber stgra...@ubuntu.com Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com (An error msg there might save some frustration in the future though) I didn't

[lxc-devel] [PATCH 2/2] cgroup.h: unify the nameing and comments

2014-01-15 Thread Qiang Huang
From: Qiang Huang h.huangqi...@huawei.com Signed-off-by: Qiang Huang h.huangqi...@huawei.com --- src/lxc/cgroup.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/cgroup.h b/src/lxc/cgroup.h index 3aab12d..a252123 100644 --- a/src/lxc/cgroup.h +++ b/src/lxc/cgroup.h @@

[lxc-devel] [PATCH 1/2] cgroup.c: add static keywords as they declared

2014-01-15 Thread Qiang Huang
From: Qiang Huang h.huangqi...@huawei.com Signed-off-by: Qiang Huang h.huangqi...@huawei.com --- src/lxc/cgroup.c | 47 +-- 1 file changed, 29 insertions(+), 18 deletions(-) diff --git a/src/lxc/cgroup.c b/src/lxc/cgroup.c index 6d837f9..8030a8b

[lxc-devel] Bug reports

2014-01-15 Thread Stéphane Graber
Hey everyone, So as you noticed, between yesterday and today, I caught up a bit on all our pending pull requests, patches and some bug reports. We however still have quite a few reports, both actual bugs and minor features that I think would be worthwhile to get into LXC 1.0. The current list is

[lxc-devel] [PATCH 1/3] oracle template: convert to common.conf style

2014-01-15 Thread Dwight Engen
Signed-off-by: Dwight Engen dwight.en...@oracle.com --- config/templates/Makefile.am | 2 ++ config/templates/oracle.common.conf.in | 45 ++ config/templates/oracle.userns.conf.in | 17 + configure.ac | 2 ++

[lxc-devel] [PATCH 3/3] oracle template: default to 6.5 when no release given or detected

2014-01-15 Thread Dwight Engen
Signed-off-by: Dwight Engen dwight.en...@oracle.com --- templates/lxc-oracle.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/templates/lxc-oracle.in b/templates/lxc-oracle.in index 6df328d..80c2df2 100644 --- a/templates/lxc-oracle.in +++ b/templates/lxc-oracle.in @@

Re: [lxc-devel] [PATCH 3/3] oracle template: default to 6.5 when no release given or detected

2014-01-15 Thread Stéphane Graber
On Wed, Jan 15, 2014 at 12:21:57PM -0500, Dwight Engen wrote: Signed-off-by: Dwight Engen dwight.en...@oracle.com Acked-by: Stéphane Graber stgra...@ubuntu.com --- templates/lxc-oracle.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/templates/lxc-oracle.in

Re: [lxc-devel] [PATCH 1/1] Initial support for cgmanager

2014-01-15 Thread Stéphane Graber
On Wed, Jan 15, 2014 at 11:19:41AM -0600, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): On Tue, Jan 14, 2014 at 04:41:36PM -0600, Serge Hallyn wrote: This patch splits out most of the cgroupfs-specific code, so that cgroup-manager versions can be plugged in. The case

[lxc-devel] [PATCH 2/1] implement cgmanager_remove_cgroup

2014-01-15 Thread Serge Hallyn
Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com --- src/lxc/cgmanager.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/lxc/cgmanager.c b/src/lxc/cgmanager.c index 92745dc..53a1802 100644 --- a/src/lxc/cgmanager.c +++ b/src/lxc/cgmanager.c @@ -130,10

[lxc-devel] [PATCH] oracle: Fix running template unprivileged

2014-01-15 Thread Stéphane Graber
Without this /dev/console won't exist and upstart will fail to start any job marking as console output including the rather important rcS. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- config/templates/oracle.userns.conf.in | 1 + 1 file changed, 1 insertion(+) diff --git

[lxc-devel] [PATCH] Disable logpath for unprivileged containers

2014-01-15 Thread Stéphane Graber
Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/log.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/lxc/log.c b/src/lxc/log.c index b09885c..4a2b7eb 100644 --- a/src/lxc/log.c +++ b/src/lxc/log.c @@ -318,6 +318,11 @@ extern int lxc_log_init(const char *name, const

[lxc-devel] [lxc/lxc] ceceea: Disable logpath for unprivileged containers

2014-01-15 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: ceceea1e967453d513484516aab4593f21cdbd89 https://github.com/lxc/lxc/commit/ceceea1e967453d513484516aab4593f21cdbd89 Author: Stéphane Graber stgra...@ubuntu.com Date: 2014-01-15 (Wed, 15 Jan 2014) Changed

[lxc-devel] [PATCH] debian: Switch to config includes

2014-01-15 Thread Stéphane Graber
Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- config/templates/Makefile.am | 2 ++ config/templates/debian.common.conf.in | 62 ++ config/templates/debian.userns.conf.in | 9 + configure.ac | 2 ++

[lxc-devel] [lxc/lxc] 13d8bd: lxc_unshare -u argument useful even with USER name...

2014-01-15 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 13d8bde96f0a21da92bcf353ad5db3f6f83172c2 https://github.com/lxc/lxc/commit/13d8bde96f0a21da92bcf353ad5db3f6f83172c2 Author: Seth Robertson srobert...@appcomsci.com Date: 2014-01-15 (Wed, 15 Jan 2014) Changed

[lxc-devel] [lxc/lxc] 31a120: lxc-unshare: uid_t is unsigned.

2014-01-15 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 31a1209de9633c9ac235e46fcd913f04ea629ca4 https://github.com/lxc/lxc/commit/31a1209de9633c9ac235e46fcd913f04ea629ca4 Author: Serge Hallyn serge.hal...@ubuntu.com Date: 2014-01-15 (Wed, 15 Jan 2014) Changed

[lxc-devel] [lxc/lxc] deccac: change version to 1.0.0.beta2 in configure.ac

2014-01-15 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: deccacff34d31fef8fd6c2c30d40faa354aefa32 https://github.com/lxc/lxc/commit/deccacff34d31fef8fd6c2c30d40faa354aefa32 Author: Stéphane Graber stgra...@ubuntu.com Date: 2014-01-15 (Wed, 15 Jan 2014) Changed

[lxc-devel] [Passed] lxc/lxc#80 (lxc-1.0.0.beta2 - deccacf)

2014-01-15 Thread Travis CI
Build Update for lxc/lxc - Build: #80 Status: Passed Duration: 2 minutes and 39 seconds Commit: deccacf (lxc-1.0.0.beta2) Author: Stéphane Graber Message: change version to 1.0.0.beta2 in configure.ac Signed-off-by: Stéphane Graber stgra...@ubuntu.com View

[lxc-devel] [PATCH] lxc-create: Don't print the help message twice

2014-01-15 Thread Stéphane Graber
The forking logic was wrong, causing both the child and the parent to call the template with -h. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc_create.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/lxc/lxc_create.c b/src/lxc/lxc_create.c

Re: [lxc-devel] [PATCH] lxc-create: Don't print the help message twice

2014-01-15 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): The forking logic was wrong, causing both the child and the parent to call the template with -h. Signed-off-by: Stéphane Graber stgra...@ubuntu.com chuckle Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com --- src/lxc/lxc_create.c | 9

[lxc-devel] [lxc/lxc] 19668d: lxc-create: Don't print the help message twice

2014-01-15 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 19668d8b0798d4078f17f83241b6c113a0ed1bb0 https://github.com/lxc/lxc/commit/19668d8b0798d4078f17f83241b6c113a0ed1bb0 Author: Stéphane Graber stgra...@ubuntu.com Date: 2014-01-15 (Wed, 15 Jan 2014) Changed

Re: [lxc-devel] [PATCH] ubuntu: Don't fail on invalid locale

2014-01-15 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): Signed-off-by: Stéphane Graber stgra...@ubuntu.com Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com --- templates/lxc-ubuntu.in | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/templates/lxc-ubuntu.in

[lxc-devel] [lxc/lxc] 3fefd6: ubuntu: Don't fail on invalid locale

2014-01-15 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 3fefd6e6d5bdd38a0e29587896b9b8bb6db6af2e https://github.com/lxc/lxc/commit/3fefd6e6d5bdd38a0e29587896b9b8bb6db6af2e Author: Stéphane Graber stgra...@ubuntu.com Date: 2014-01-15 (Wed, 15 Jan 2014) Changed

[lxc-devel] [lxc/lxc] d4ef7c: Initial support for cgmanager

2014-01-15 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: d4ef7c50ae980d13f6e7a44c595228a8cba9d8f2 https://github.com/lxc/lxc/commit/d4ef7c50ae980d13f6e7a44c595228a8cba9d8f2 Author: Serge Hallyn serge.hal...@ubuntu.com Date: 2014-01-15 (Wed, 15 Jan 2014) Changed

[lxc-devel] [PATCH] skip rootfs pinning for unprivileged containers

2014-01-15 Thread S . Çağlar Onur
Signed-off-by: S.Çağlar Onur cag...@10ur.org --- src/lxc/start.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/lxc/start.c b/src/lxc/start.c index 6c07e43..fbdfc05 100644 --- a/src/lxc/start.c +++ b/src/lxc/start.c @@ -782,11 +782,14 @@ static int

Re: [lxc-devel] [PATCH 1/1] Initial support for cgmanager

2014-01-15 Thread S . Çağlar Onur
Hi Serge, On Wed, Jan 15, 2014 at 12:19 PM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): On Tue, Jan 14, 2014 at 04:41:36PM -0600, Serge Hallyn wrote: This patch splits out most of the cgroupfs-specific code, so that cgroup-manager versions can

[lxc-devel] [PATCH] lxc_init.c: error handing for sigaction and sigprocmask

2014-01-15 Thread Qiang Huang
Look through all LXC code and seems like only here are missed. Signed-off-by: Qiang Huang h.huangqi...@huawei.com --- Maybe this bug can be marked resolved: https://github.com/lxc/lxc/issues/83 --- src/lxc/lxc_init.c | 46 +++--- 1 file changed, 31

[lxc-devel] [PATCH] doc: Update Japanese man pages

2014-01-15 Thread KATOH Yasufumi
* lxc-unshare(1): Update for commit c1bb25a831fdd568fb8c899b67a7be63c21f4a10 and 13d8bde96f0a21da92bcf353ad5db3f6f83172c2 * lxc.conf(5): Update for commit 04a243f11d5d4891b427107774d30d058bb191e7 Signed-off-by: KATOH Yasufumi ka...@jazz.email.ne.jp --- doc/ja/lxc-unshare.sgml.in | 93