Re: [lxc-devel] [PATCH 1/1] cgroupfs: support older kernels without cgroup.clone_children

2014-01-23 Thread Robert Vogelgesang
Hi Serge, your patch uses the same concept as mine, but it won't work, as noted below. If you can wait until Monday, I could send you a cleaned-up and tested version of my patch; I have to do other things today and tomorrow. On Wed, Jan 22, 2014 at 10:49:00AM -0600, Serge Hallyn wrote: When

Re: [lxc-devel] [PATCH] doc: Try to clear some confusion about lxc.conf

2014-01-23 Thread KATOH Yasufumi
Hi! I have translated these man pages into Japanese, and sent pull request on github. https://github.com/lxc/lxc/pull/144 -- KATOH Yasufumi / ka...@jazz.email.ne.jp ___ lxc-devel mailing list lxc-devel@lists.linuxcontainers.org

[lxc-devel] [PATCH] doc: Add manpage for lxc-config

2014-01-23 Thread Stéphane Graber
Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- configure.ac | 1 + doc/Makefile.am| 1 + doc/lxc-config.sgml.in | 114 + 3 files changed, 116 insertions(+) create mode 100644 doc/lxc-config.sgml.in diff --git

Re: [lxc-devel] [PATCH] cgroupfs: get rid of the redundant error info

2014-01-23 Thread Serge Hallyn
Quoting Qiang Huang (h.huangqi...@huawei.com): Signed-off-by: Qiang Huang h.huangqi...@huawei.com --- Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com src/lxc/cgroup.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/lxc/cgroup.c b/src/lxc/cgroup.c index

Re: [lxc-devel] [PATCH 1/3] lxc-start: fix the container leak when daemonize

2014-01-23 Thread Serge Hallyn
Quoting Qiang Huang (h.huangqi...@huawei.com): I already reasoned in the added comment, we need this because if not, lxc_container won't be freed when daemon exits, and PID file won't be unlinked either. I see, but What about this: From 80f3862f9c4dbc8a05e79e50c50e79e30ffebc25 Mon Sep 17

[lxc-devel] [lxc/lxc] a8117b: cgroupfs: get rid of the redundant error info

2014-01-23 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: a8117b3361c9caf1397f4dc9bbb5e6de3af3cdff https://github.com/lxc/lxc/commit/a8117b3361c9caf1397f4dc9bbb5e6de3af3cdff Author: Qiang Huang h.huangqi...@huawei.com Date: 2014-01-23 (Thu, 23 Jan 2014) Changed

Re: [lxc-devel] [PATCH 1/1] cgroupfs: support older kernels without cgroup.clone_children

2014-01-23 Thread Serge Hallyn
Quoting Robert Vogelgesang (vo...@users.sourceforge.net): +static long get_value(const char *dir, const char *file) +{ + FILE *f; + char path[MAXPATHLEN]; + int ret, retv; + + retv = snprintf(path, MAXPATHLEN, %s/%s, dir, file); + if (retv 0 || retv = MAXPATHLEN) +

Re: [lxc-devel] [PATCH] doc: Add manpage for lxc-config

2014-01-23 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): Signed-off-by: Stéphane Graber stgra...@ubuntu.com Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com --- configure.ac | 1 + doc/Makefile.am| 1 + doc/lxc-config.sgml.in | 114

[lxc-devel] [lxc/lxc] ff5e27: doc: Add manpage for lxc-config

2014-01-23 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: ff5e27510540a2ee3c66d8496996313d01bb848f https://github.com/lxc/lxc/commit/ff5e27510540a2ee3c66d8496996313d01bb848f Author: Stéphane Graber stgra...@ubuntu.com Date: 2014-01-23 (Thu, 23 Jan 2014) Changed

[lxc-devel] [PATCH] Drop runapitests.sh

2014-01-23 Thread Stéphane Graber
This script is outdated and unused. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- Makefile.am| 3 +-- runapitests.sh | 50 -- 2 files changed, 1 insertion(+), 52 deletions(-) delete mode 100644 runapitests.sh diff --git

Re: [lxc-devel] [PATCH] Drop runapitests.sh

2014-01-23 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): This script is outdated and unused. Signed-off-by: Stéphane Graber stgra...@ubuntu.com Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com --- Makefile.am| 3 +-- runapitests.sh | 50 -- 2

[lxc-devel] [lxc/lxc] fec822: Revert cgroupfs: need the full path to setup cpus...

2014-01-23 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: fec822c4a0612211ed8f32e662183e1cee4f1489 https://github.com/lxc/lxc/commit/fec822c4a0612211ed8f32e662183e1cee4f1489 Author: Serge Hallyn serge.hal...@ubuntu.com Date: 2014-01-23 (Thu, 23 Jan 2014) Changed

[lxc-devel] [lxc/lxc] bfb1bb: Drop runapitests.sh

2014-01-23 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: bfb1bb94c8d86c5e09ff3624aaa6a4bfb2c4c807 https://github.com/lxc/lxc/commit/bfb1bb94c8d86c5e09ff3624aaa6a4bfb2c4c807 Author: Stéphane Graber stgra...@ubuntu.com Date: 2014-01-23 (Thu, 23 Jan 2014) Changed

Re: [lxc-devel] [PATCH 1/1] cgroupfs: support older kernels without cgroup.clone_children

2014-01-23 Thread Robert Vogelgesang
Hi Serge, On Thu, Jan 23, 2014 at 11:28:46AM -0600, Serge Hallyn wrote: Quoting Robert Vogelgesang (vo...@users.sourceforge.net): +static long get_value(const char *dir, const char *file) +{ + FILE *f; + char path[MAXPATHLEN]; + int ret, retv; + + retv = snprintf(path,

[lxc-devel] [lxc/lxc] f6639e: cgm_get: support NULL value

2014-01-23 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: f6639e3bee908381e5d36732c847e5f22affc278 https://github.com/lxc/lxc/commit/f6639e3bee908381e5d36732c847e5f22affc278 Author: Serge Hallyn serge.hal...@ubuntu.com Date: 2014-01-23 (Thu, 23 Jan 2014) Changed

[lxc-devel] [lxc/lxc] 135495: lxc-clone: support unprivileged use

2014-01-23 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 1354955b02bca17d72162f2d61f38e72edea792f https://github.com/lxc/lxc/commit/1354955b02bca17d72162f2d61f38e72edea792f Author: Serge Hallyn serge.hal...@ubuntu.com Date: 2014-01-23 (Thu, 23 Jan 2014) Changed

[lxc-devel] [lxc/lxc] 0b3a65: get_mapped_rootid: fix description

2014-01-23 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 0b3a6504e51795e738de8e017c22d209a93bc169 https://github.com/lxc/lxc/commit/0b3a6504e51795e738de8e017c22d209a93bc169 Author: Serge Hallyn serge.hal...@ubuntu.com Date: 2014-01-23 (Thu, 23 Jan 2014) Changed

Re: [lxc-devel] [PATCH] Update Fedora and CentOS templates for common conf includes.

2014-01-23 Thread Michael H. Warfield
On Wed, 2014-01-22 at 10:35 -0500, Stéphane Graber wrote: On Wed, Jan 22, 2014 at 09:29:23AM -0500, Michael H. Warfield wrote: On Tue, 2014-01-21 at 20:25 -0500, Stéphane Graber wrote: On Tue, Jan 21, 2014 at 11:56:56AM -0500, Michael H. Warfield wrote: Update Fedora and CentOS

[lxc-devel] [PATCH] tests: Update lxc-test-unpriv

2014-01-23 Thread Stéphane Graber
Update lxc-test-unpriv to be a bit simpler and more reliable. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/tests/lxc-test-unpriv | 71 ++- 1 file changed, 39 insertions(+), 32 deletions(-) diff --git a/src/tests/lxc-test-unpriv

Re: [lxc-devel] Last minute template addition - universal image based

2014-01-23 Thread TAMUKI Shoichi
Hello, Due to the recent changes in lxc-plamo.in related to environment variables, lxc-plamo is now able to create variant containers with additional environment variables other than the default configuration. For example: # Add 09_kernel category to the default configuration CATEGORIES=00_base

[lxc-devel] [PATCH] tests: Fix cleanup in lxc-test-unpriv

2014-01-23 Thread Stéphane Graber
Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/tests/lxc-test-unpriv | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tests/lxc-test-unpriv b/src/tests/lxc-test-unpriv index ff2a44a..1e75eea 100755 --- a/src/tests/lxc-test-unpriv +++ b/src/tests/lxc-test-unpriv

[lxc-devel] [PATCH] tests: Tweak lxc-test-ubuntu to be faster

2014-01-23 Thread Stéphane Graber
Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/tests/lxc-test-ubuntu | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/tests/lxc-test-ubuntu b/src/tests/lxc-test-ubuntu index 7fa1c89..be69eec 100755 --- a/src/tests/lxc-test-ubuntu +++

[lxc-devel] [PATCH] tests: Speed up lxc-test-usernic

2014-01-23 Thread Stéphane Graber
Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/tests/lxc-test-usernic | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/tests/lxc-test-usernic b/src/tests/lxc-test-usernic index f3194dd..d00b223 100755 --- a/src/tests/lxc-test-usernic +++

[lxc-devel] [PATCH] Fix destroy() crash when no config is loaded

2014-01-23 Thread Stéphane Graber
Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxccontainer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/lxccontainer.c b/src/lxc/lxccontainer.c index 1520cd3..fbf0824 100644 --- a/src/lxc/lxccontainer.c +++ b/src/lxc/lxccontainer.c @@ -1957,7

[lxc-devel] [PATCH] tests: Fix lxc-test-saveconfig cleanup

2014-01-23 Thread Stéphane Graber
Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/tests/saveconfig.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/tests/saveconfig.c b/src/tests/saveconfig.c index a455294..e87c74d 100644 --- a/src/tests/saveconfig.c +++ b/src/tests/saveconfig.c @@ -98,6 +98,16 @@

[lxc-devel] [PATCH] tests: Drop 60s delay in shutdowntest

2014-01-23 Thread Stéphane Graber
Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/tests/shutdowntest.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/tests/shutdowntest.c b/src/tests/shutdowntest.c index e8a7126..6e4bb31 100644 --- a/src/tests/shutdowntest.c +++ b/src/tests/shutdowntest.c @@ -68,8 +68,6 @@

[lxc-devel] [PATCH 1/1] idmap_add_id: fix broken behavior

2014-01-23 Thread Serge Hallyn
The geteuid() addition is being made the first element of the lxc_list, but the first element is just a head whose entry is ignored. Therefore userns_exec_1() was starting its tasks without the caller's uid mapped into the namespace. Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com ---

Re: [lxc-devel] [PATCH 1/3] lxc-start: fix the container leak when daemonize

2014-01-23 Thread Qiang Huang
On 2014/1/24 1:17, Serge Hallyn wrote: Quoting Qiang Huang (h.huangqi...@huawei.com): I already reasoned in the added comment, we need this because if not, lxc_container won't be freed when daemon exits, and PID file won't be unlinked either. I see, but What about this: From

[lxc-devel] [PATCH] tests: Remove containers after running clonetest

2014-01-23 Thread Stéphane Graber
Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/tests/clonetest.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/tests/clonetest.c b/src/tests/clonetest.c index b04ab3c..efd673e 100644 --- a/src/tests/clonetest.c +++ b/src/tests/clonetest.c @@ -80,9

[lxc-devel] [PATCH] tests: Fix createtest

2014-01-23 Thread Stéphane Graber
Drop 60s delay and clear config before loading it. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/tests/createtest.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/tests/createtest.c b/src/tests/createtest.c index b53c963..ba3a387 100644 ---

Re: [lxc-devel] [PATCH] tests: Fix cleanup in lxc-test-unpriv

2014-01-23 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): Signed-off-by: Stéphane Graber stgra...@ubuntu.com Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com --- src/tests/lxc-test-unpriv | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tests/lxc-test-unpriv

Re: [lxc-devel] [PATCH] tests: Tweak lxc-test-ubuntu to be faster

2014-01-23 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): Signed-off-by: Stéphane Graber stgra...@ubuntu.com Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com --- src/tests/lxc-test-ubuntu | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/tests/lxc-test-ubuntu

Re: [lxc-devel] [PATCH] tests: Rework lxc-test-usernic

2014-01-23 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): Signed-off-by: Stéphane Graber stgra...@ubuntu.com Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com --- src/tests/lxc-test-usernic | 136 - 1 file changed, 74 insertions(+), 62 deletions(-) diff

Re: [lxc-devel] [PATCH] tests: Speed up lxc-test-usernic

2014-01-23 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): Signed-off-by: Stéphane Graber stgra...@ubuntu.com Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com --- src/tests/lxc-test-usernic | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/tests/lxc-test-usernic

Re: [lxc-devel] [PATCH] tests: Fix shutdown test

2014-01-23 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): Signed-off-by: Stéphane Graber stgra...@ubuntu.com Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com --- src/tests/shutdowntest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/tests/shutdowntest.c b/src/tests/shutdowntest.c index

Re: [lxc-devel] [PATCH] Fix destroy() crash when no config is loaded

2014-01-23 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): Signed-off-by: Stéphane Graber stgra...@ubuntu.com Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com --- src/lxc/lxccontainer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/lxccontainer.c

Re: [lxc-devel] [PATCH] tests: Remove containers after running clonetest

2014-01-23 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): Signed-off-by: Stéphane Graber stgra...@ubuntu.com Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com --- src/tests/clonetest.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/tests/clonetest.c

Re: [lxc-devel] [PATCH] tests: Fix createtest

2014-01-23 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): Drop 60s delay and clear config before loading it. Signed-off-by: Stéphane Graber stgra...@ubuntu.com Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com --- src/tests/createtest.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)