[lxc-devel] [lxc/lxc] 6edbfc: logging: Add lxc_log_options_no_override function

2014-02-04 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 6edbfc86508fb07d2b8377dce40f36f3032c32a5 https://github.com/lxc/lxc/commit/6edbfc86508fb07d2b8377dce40f36f3032c32a5 Author: Stéphane Graber Date: 2014-02-04 (Tue, 04 Feb 2014) Changed paths: M src/lxc/con

Re: [lxc-devel] [PATCH] logging: Add lxc_log_options_no_override function

2014-02-04 Thread Stéphane Graber
On Tue, Feb 04, 2014 at 04:52:16PM -0600, Serge Hallyn wrote: > Quoting Stéphane Graber (stgra...@ubuntu.com): > > > Perhaps the right thing to do is > > > . make loglevel and logfile per-thread > > > . store the lxc.loglevel from config file into c->loglevel, and NOT set > > > it globally (in pe

Re: [lxc-devel] [PATCH] logging: Add lxc_log_options_no_override function

2014-02-04 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > > Perhaps the right thing to do is > > . make loglevel and logfile per-thread > > . store the lxc.loglevel from config file into c->loglevel, and NOT set > > it globally (in per-thread) > > . at lxcapi_create and lxcapi_start, set the global loglev

Re: [lxc-devel] [PATCH] logging: Add lxc_log_options_no_override function

2014-02-04 Thread Stéphane Graber
On Tue, Feb 04, 2014 at 03:53:48PM -0600, Serge Hallyn wrote: > Quoting Stéphane Graber (stgra...@ubuntu.com): > > In current LXC, loglevel and logfile are write-once functions. > > That behaviour was appropriate when those two were first introduced > > (pre-API) but with current API, one would exp

Re: [lxc-devel] [PATCH] logging: Add lxc_log_options_no_override function

2014-02-04 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > In current LXC, loglevel and logfile are write-once functions. > That behaviour was appropriate when those two were first introduced > (pre-API) but with current API, one would expect to be able to > set_config_item those multiple times. > > So inst

[lxc-devel] [lxc/lxc] 2133f5: create: pass --mapped-gid to templates next to --m...

2014-02-04 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 2133f58c66ab7627a4159fafbb75106c556b014d https://github.com/lxc/lxc/commit/2133f58c66ab7627a4159fafbb75106c556b014d Author: Serge Hallyn Date: 2014-02-04 (Tue, 04 Feb 2014) Changed paths: M src/lxc/conf.c

Re: [lxc-devel] [PATCH 1/1] create: pass --mapped-gid to templates next to --mapped-uid

2014-02-04 Thread Stéphane Graber
On Tue, Feb 04, 2014 at 01:33:10PM -0600, Serge Hallyn wrote: > That way templates can fix group ownership alongside uid ownership. > > Signed-off-by: Serge Hallyn As discussed on IRC, Ack but with a small inline change that I'll do to fix invalid --mapped-uid value with the current patch. Acke

[lxc-devel] [PATCH] logging: Add lxc_log_options_no_override function

2014-02-04 Thread Stéphane Graber
In current LXC, loglevel and logfile are write-once functions. That behaviour was appropriate when those two were first introduced (pre-API) but with current API, one would expect to be able to set_config_item those multiple times. So instead, introduce lxc_log_options_no_override which when calle

[lxc-devel] [PATCH 1/1] create: pass --mapped-gid to templates next to --mapped-uid

2014-02-04 Thread Serge Hallyn
That way templates can fix group ownership alongside uid ownership. Signed-off-by: Serge Hallyn --- src/lxc/conf.c| 14 +++--- src/lxc/conf.h| 4 ++-- src/lxc/lxccontainer.c| 35 +++ templates/lxc-download.in |

[lxc-devel] [lxc/lxc] 8ec981: templates: Refuse to run unprivileged

2014-02-04 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 8ec981fc8b0105da5f071e40811e0c2472a6c3c9 https://github.com/lxc/lxc/commit/8ec981fc8b0105da5f071e40811e0c2472a6c3c9 Author: Stéphane Graber Date: 2014-02-04 (Tue, 04 Feb 2014) Changed paths: M templates/l

Re: [lxc-devel] [PATCH] templates: Refuse to run unprivileged

2014-02-04 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > Only the download and ubuntu-cloud templates work with unprivileged > containers, for all others, detect --mapped-uid and error out as early > as possible, recommending the use of the download template. > > Signed-off-by: Stéphane Graber Acked-by:

Re: [lxc-devel] Fwd: Re: [lxc-users] container/config: why "lxc." in front of config option names?

2014-02-04 Thread lxc
Le 04/02/2014 16:10, Stéphane Graber a écrit : > On Tue, Feb 04, 2014 at 04:02:40PM +0100, l...@zitta.fr wrote: >> Le 01/02/2014 17:13, Michael H. Warfield a écrit : >>> On Sat, 2014-02-01 at 12:59 +0100, Harald Dunkel wrote: Hi folks, The "lxc." in the config option names seems to be c

[lxc-devel] [PATCH] templates: Refuse to run unprivileged

2014-02-04 Thread Stéphane Graber
Only the download and ubuntu-cloud templates work with unprivileged containers, for all others, detect --mapped-uid and error out as early as possible, recommending the use of the download template. Signed-off-by: Stéphane Graber --- templates/lxc-alpine.in | 9 + templates/lxc-al

Re: [lxc-devel] [PATCH] support a custom CentOS repository

2014-02-04 Thread Michael H. Warfield
On Tue, 2014-02-04 at 15:02 +0100, Harald Dunkel wrote: > On 02/04/14 14:53, Serge Hallyn wrote: > > > > Thanks everyone. I guess my main question was whether '--repo' would > > conflict with the 'additional repos' interpretation (sort of like > > proxy vs. ppa in ubuntu, where one is for fast l

Re: [lxc-devel] [PATCH] support a custom CentOS repository

2014-02-04 Thread Dwight Engen
On Tue, 4 Feb 2014 10:31:47 + John Peacock wrote: > I would very much like to have this functionality be able to replace > the repository files completely. For performance purposes, we have a > local clone of the entire Centos 5/6 trees (for limited > architectures). There are no circumstan

Re: [lxc-devel] Fwd: Re: [lxc-users] container/config: why "lxc." in front of config option names?

2014-02-04 Thread Stéphane Graber
On Tue, Feb 04, 2014 at 04:02:40PM +0100, l...@zitta.fr wrote: > > Le 01/02/2014 17:13, Michael H. Warfield a écrit : > > On Sat, 2014-02-01 at 12:59 +0100, Harald Dunkel wrote: > >> Hi folks, > >> The "lxc." in the config option names seems to be constant, so I wonder > >> what it is good for? >

[lxc-devel] Fwd: Re: [lxc-users] container/config: why "lxc." in front of config option names?

2014-02-04 Thread lxc
Le 01/02/2014 17:13, Michael H. Warfield a écrit : > On Sat, 2014-02-01 at 12:59 +0100, Harald Dunkel wrote: >> Hi folks, >> The "lxc." in the config option names seems to be constant, so I wonder >> what it is good for? > It allows us to extend the configuration file for other scripts and > such

Re: [lxc-devel] [PATCH] support a custom CentOS repository

2014-02-04 Thread Michael H. Warfield
On Tue, 2014-02-04 at 07:53 -0600, Serge Hallyn wrote: > Quoting Michael H. Warfield (m...@wittsend.com): > > On Mon, 2014-02-03 at 19:18 -0600, Serge Hallyn wrote: > > > Quoting Harald Dunkel (ha...@afaics.de): > > > > This change introduces a flag --repo to the lxc-centos template > > > > to al

Re: [lxc-devel] [PATCH] support a custom CentOS repository

2014-02-04 Thread Harald Dunkel
On 02/04/14 14:53, Serge Hallyn wrote: > > Thanks everyone. I guess my main question was whether '--repo' would > conflict with the 'additional repos' interpretation (sort of like > proxy vs. ppa in ubuntu, where one is for fast local mirror while the > other is for testing upgraded packages befo

Re: [lxc-devel] [PATCH] support a custom CentOS repository

2014-02-04 Thread Serge Hallyn
Quoting Michael H. Warfield (m...@wittsend.com): > On Mon, 2014-02-03 at 19:18 -0600, Serge Hallyn wrote: > > Quoting Harald Dunkel (ha...@afaics.de): > > > This change introduces a flag --repo to the lxc-centos template > > > to allow using a local repository (e.g. a loop mounted installer > > >

[lxc-devel] [lxc/lxc] 3a6ef6: support a custom CentOS repository

2014-02-04 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 3a6ef65aa29206b2f2061fdb020c32118f6d74f2 https://github.com/lxc/lxc/commit/3a6ef65aa29206b2f2061fdb020c32118f6d74f2 Author: Harald Dunkel Date: 2014-02-04 (Tue, 04 Feb 2014) Changed paths: M templates/lxc

Re: [lxc-devel] [PATCH] support a custom CentOS repository

2014-02-04 Thread John Peacock
I would very much like to have this functionality be able to replace the repository files completely. For performance purposes, we have a local clone of the entire Centos 5/6 trees (for limited architectures). There are no circumstances where I want our instances to hit the upstream mirror lis