[lxc-devel] [lxc/lxc] 05f9e7: lxc-debian: Don't eat the argument after -c

2014-03-21 Thread GitHub
Branch: refs/heads/stable-1.0 Home: https://github.com/lxc/lxc Commit: 05f9e74300c2a6ff3a9762ba235c84cb564ff879 https://github.com/lxc/lxc/commit/05f9e74300c2a6ff3a9762ba235c84cb564ff879 Author: Stéphane Graber Date: 2014-03-21 (Fri, 21 Mar 2014) Changed paths: M templat

Re: [lxc-devel] [PATCH RFC] log: introduce container logging

2014-03-21 Thread Serge Hallyn
Quoting S.Çağlar Onur (cag...@10ur.org): > Hi Serge, > > On Wed, Mar 12, 2014 at 11:02 AM, Serge Hallyn > wrote: > > Quoting S.Çağlar Onur (cag...@10ur.org): > >> Hi Serge, > >> > >> On Tue, Mar 11, 2014 at 8:13 PM, Serge Hallyn > >> wrote: > >> > This is not intended to be applied yet. > >> >

Re: [lxc-devel] [PATCH v3] fix console stdin,stdout,stderr fds

2014-03-21 Thread Dwight Engen
On Fri, 21 Mar 2014 15:00:11 -0400 Stéphane Graber wrote: > On Fri, Mar 21, 2014 at 11:19:21AM -0400, Dwight Engen wrote: > > On Tue, 11 Mar 2014 23:06:22 -0500 > > Serge Hallyn wrote: > > > > > Quoting Dwight Engen (dwight.en...@oracle.com): > > > > The fds for stdin,stdout,stderr that we were

Re: [lxc-devel] [PATCH RFC] log: introduce container logging

2014-03-21 Thread S . Çağlar Onur
Hi Serge, On Wed, Mar 12, 2014 at 11:02 AM, Serge Hallyn wrote: > Quoting S.Çağlar Onur (cag...@10ur.org): >> Hi Serge, >> >> On Tue, Mar 11, 2014 at 8:13 PM, Serge Hallyn >> wrote: >> > This is not intended to be applied yet. >> > >> > This patch adds real per-container, thread-safe log prefer

[lxc-devel] [lxc/lxc] c43e97: Update Japanese lxc-create(1) for 'best' option

2014-03-21 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: c43e979d66e6eb7ec5d01b7b417a78272d46bc09 https://github.com/lxc/lxc/commit/c43e979d66e6eb7ec5d01b7b417a78272d46bc09 Author: KATOH Yasufumi Date: 2014-03-21 (Fri, 21 Mar 2014) Changed paths: M doc/ja/lxc-c

Re: [lxc-devel] [PATCH v3] fix console stdin,stdout,stderr fds

2014-03-21 Thread Stéphane Graber
On Fri, Mar 21, 2014 at 11:19:21AM -0400, Dwight Engen wrote: > On Tue, 11 Mar 2014 23:06:22 -0500 > Serge Hallyn wrote: > > > Quoting Dwight Engen (dwight.en...@oracle.com): > > > The fds for stdin,stdout,stderr that we were leaving open > > > for /sbin/init in the container were those from /dev

Re: [lxc-devel] [PATCH] Update Japanese lxc-create(1) for 'best' option

2014-03-21 Thread Stéphane Graber
On Sat, Mar 22, 2014 at 02:19:33AM +0900, KATOH Yasufumi wrote: > Update for commit a526a632e007c0d666dbe953cf7b39fbf26b63db > > Signed-off-by: KATOH Yasufumi Acked-by: Stéphane Graber > --- > doc/ja/lxc-create.sgml.in | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > d

[lxc-devel] [PATCH] Update Japanese lxc-create(1) for 'best' option

2014-03-21 Thread KATOH Yasufumi
Update for commit a526a632e007c0d666dbe953cf7b39fbf26b63db Signed-off-by: KATOH Yasufumi --- doc/ja/lxc-create.sgml.in | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/doc/ja/lxc-create.sgml.in b/doc/ja/lxc-create.sgml.in index 13a9c1a..b6a078d 100644 --- a/doc/ja/

Re: [lxc-devel] [PATCH v3] fix console stdin,stdout,stderr fds

2014-03-21 Thread Dwight Engen
On Tue, 11 Mar 2014 23:06:22 -0500 Serge Hallyn wrote: > Quoting Dwight Engen (dwight.en...@oracle.com): > > The fds for stdin,stdout,stderr that we were leaving open > > for /sbin/init in the container were those from /dev/tty or > > lxc.console (if given), which wasn't right. Inside the contain

[lxc-devel] [lxc/lxc] ef5362: lxc-debian: Don't eat the argument after -c

2014-03-21 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: ef53625fe1b7d29fc0676564ddc28c96008384ac https://github.com/lxc/lxc/commit/ef53625fe1b7d29fc0676564ddc28c96008384ac Author: Stéphane Graber Date: 2014-03-21 (Fri, 21 Mar 2014) Changed paths: M templates/l

Re: [lxc-devel] Missing packet in archlinux template

2014-03-21 Thread Stéphane Graber
On Thu, Mar 20, 2014 at 11:30:42AM -0400, Leonid Isaev wrote: > On Thu, 20 Mar 2014 10:19:53 -0400 > Stéphane Graber wrote: > > > On Thu, Mar 20, 2014 at 03:05:58PM +0100, Julien Delaborde wrote: > > > Hi, > > > > > > I used the archlinux template to create an archlinux container but the > > > s

Re: [lxc-devel] [PATCH RFC] mutex cgmanager access

2014-03-21 Thread Stéphane Graber
On Wed, Mar 19, 2014 at 11:55:00PM -0500, Serge Hallyn wrote: > It looks like either libdbus or libnih is showing some corruption with > threaded access to the cgmanager-client library. Until we can > straighten that out, mutex access to the cgmanager. > > The worst part of this is having to take

Re: [lxc-devel] [PATCH] debian: Symlink /etc/mtab

2014-03-21 Thread Holger Amann
Am 21.03.2014 um 15:34 schrieb Stéphane Graber : > I'm surprised Debian doesn't do an initial /proc/mounts to /etc/mtab > copy at boot time, but apparently it doesn't (just tried with a Jessie > container), so I guess we'll need that workaround… /etc/init.d/checkroot.sh does it, but checkroot.sh

Re: [lxc-devel] [PATCH] debian: Symlink /etc/mtab

2014-03-21 Thread Stéphane Graber
On Wed, Mar 19, 2014 at 07:06:13AM +0100, Holger Amann wrote: > /etc/mtab doesn’t exist after bootstrapping a debian container, and will be > created as regular file after first start. > That leads to at least two errors: > > - output of `mount` is wrong and get messed up the more often you start

Re: [lxc-devel] [PATCH] lxc-create manpage: specify -B best option

2014-03-21 Thread Stéphane Graber
On Fri, Mar 21, 2014 at 09:01:48AM -0500, Serge Hallyn wrote: > Signed-off-by: Serge Hallyn Acked-by: Stéphane Graber > --- > doc/lxc-create.sgml.in | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/doc/lxc-create.sgml.in b/doc/lxc-create.sgml.in > index 1c17c1a..2

Re: [lxc-devel] [PATCH] lxc-debian: Don't eat the argument after -c

2014-03-21 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > Reported-by: Robie Basak > Signed-off-by: Stéphane Graber Acked-by: Serge E. Hallyn > --- > templates/lxc-debian.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/templates/lxc-debian.in b/templates/lxc-debian.in > in

[lxc-devel] [PATCH] lxc-debian: Don't eat the argument after -c

2014-03-21 Thread Stéphane Graber
Reported-by: Robie Basak Signed-off-by: Stéphane Graber --- templates/lxc-debian.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/lxc-debian.in b/templates/lxc-debian.in index 7ad8e3c..aadfe25 100644 --- a/templates/lxc-debian.in +++ b/templates/lxc-debian.in @@ -

Re: [lxc-devel] [PATCH] criu: Add exec-cmd option (v2)

2014-03-21 Thread Andrew Vagin
On Fri, Mar 21, 2014 at 02:02:43PM +0400, Pavel Emelyanov wrote: > On 03/21/2014 01:39 PM, Deyan Doychev wrote: > > > > On 03/21/2014 11:14 AM, Pavel Emelyanov wrote: > ... > wait(NULL); > > return 0; > @@ -1600,6 +1600,9 @@ int cr_resto

Re: [lxc-devel] [PATCH] criu: Add exec-cmd option (v2)

2014-03-21 Thread Andrew Vagin
On Thu, Mar 20, 2014 at 10:38:27PM +0400, Pavel Emelyanov wrote: > On 03/20/2014 08:24 PM, Deyan Doychev wrote: > > From: Deyan Doychev > > > > The --exec-cmd option specifies a command that will be execvp()-ed on > > successful > > restore. This way the command specified here will become the pa

[lxc-devel] [PATCH] lxc-create manpage: specify -B best option

2014-03-21 Thread Serge Hallyn
Signed-off-by: Serge Hallyn --- doc/lxc-create.sgml.in | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/lxc-create.sgml.in b/doc/lxc-create.sgml.in index 1c17c1a..2cb6bb5 100644 --- a/doc/lxc-create.sgml.in +++ b/doc/lxc-create.sgml.in @@ -126,7 +126,7 @@ Foundation, I

Re: [lxc-devel] [PATCH] criu: Add exec-cmd option (v2)

2014-03-21 Thread Deyan Doychev
On 03/21/2014 01:56 PM, Pavel Emelyanov wrote: > On 03/21/2014 03:51 PM, Andrew Vagin wrote: > 1. we cannot check the exec call >>> This is hardly required, since even if it fails, we cannot abort the >>> restored tree. >> Can we resume the restored tree before executing "exec-cmd". >> My opin

Re: [lxc-devel] [PATCH] criu: Add exec-cmd option (v2)

2014-03-21 Thread Pavel Emelyanov
On 03/21/2014 03:51 PM, Andrew Vagin wrote: >>> 1. we cannot check the exec call >> >> This is hardly required, since even if it fails, we cannot abort the >> restored tree. > > Can we resume the restored tree before executing "exec-cmd". > My opinion is that we can't, because it may fail. > > S

Re: [lxc-devel] [PATCH] criu: Add exec-cmd option (v2)

2014-03-21 Thread Pavel Emelyanov
On 03/21/2014 01:39 PM, Deyan Doychev wrote: > > On 03/21/2014 11:14 AM, Pavel Emelyanov wrote: ... wait(NULL); return 0; @@ -1600,6 +1600,9 @@ int cr_restore_tasks(void) { int ret = -1;

Re: [lxc-devel] [PATCH] criu: Add exec-cmd option (v2)

2014-03-21 Thread Deyan Doychev
On 03/21/2014 11:14 AM, Pavel Emelyanov wrote: >>> ... >>>wait(NULL); >>> >>>return 0; >>> @@ -1600,6 +1600,9 @@ int cr_restore_tasks(void) >>> { >>>int ret = -1; >>> >>> + if (opts.exec_cmd && opts.restore_detach &&

Re: [lxc-devel] [PATCH] criu: Add exec-cmd option (v2)

2014-03-21 Thread Pavel Emelyanov
On 03/21/2014 12:57 PM, Deyan Doychev wrote: > Hi Pavel, > > On 03/20/2014 08:38 PM, Pavel Emelyanov wrote: >> On 03/20/2014 08:24 PM, Deyan Doychev wrote: >>> From: Deyan Doychev >>> ... >>> --- a/cr-restore.c >>> +++ b/cr-restore.c >>> @@ -1552,7 +1552,7 @@ static int restore_root_task(struct p

Re: [lxc-devel] [PATCH] criu: Add exec-cmd option (v2)

2014-03-21 Thread Deyan Doychev
Hi Pavel, On 03/20/2014 08:38 PM, Pavel Emelyanov wrote: > On 03/20/2014 08:24 PM, Deyan Doychev wrote: >> From: Deyan Doychev >> ... >> --- a/cr-restore.c >> +++ b/cr-restore.c >> @@ -1552,7 +1552,7 @@ static int restore_root_task(struct pstree_item *init) >> >> write_stats(RESTORE_STATS)