Re: [lxc-devel] [PATCH 1/1] snapshots: move snapshot directory

2014-04-30 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > On Wed, Apr 30, 2014 at 08:29:14PM +, John Peacock wrote: > > On Wed, 2014-04-30 at 20:25 +, Serge Hallyn wrote: > > > I was wanting to keep them out of the container itself, but I > > > can't really make a good case for wanting that. So +1,

Re: [lxc-devel] [PATCH 1/1] snapshots: move snapshot directory

2014-04-30 Thread Stéphane Graber
On Wed, Apr 30, 2014 at 08:29:14PM +, John Peacock wrote: > On Wed, 2014-04-30 at 20:25 +, Serge Hallyn wrote: > > I was wanting to keep them out of the container itself, but I > > can't really make a good case for wanting that. So +1, let's > > do that - if someone else wants to write the

[lxc-devel] [lxc/lxc] c607b1: alpinelinux: set correct lxc_arch for x86

2014-04-30 Thread GitHub
Branch: refs/heads/stable-1.0 Home: https://github.com/lxc/lxc Commit: c607b1944bf33a92ebccdc265b22f0733e90e478 https://github.com/lxc/lxc/commit/c607b1944bf33a92ebccdc265b22f0733e90e478 Author: Carlo Landmeter Date: 2014-04-30 (Wed, 30 Apr 2014) Changed paths: M templat

[lxc-devel] [lxc/lxc] 91828b: alpinelinux: set correct lxc_arch for x86

2014-04-30 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 91828b0e1f7b2c88dab7708694e3d93ac6e6cf80 https://github.com/lxc/lxc/commit/91828b0e1f7b2c88dab7708694e3d93ac6e6cf80 Author: Carlo Landmeter Date: 2014-04-30 (Wed, 30 Apr 2014) Changed paths: M templates/l

Re: [lxc-devel] [PATCH 1/1] snapshots: move snapshot directory

2014-04-30 Thread John Peacock
On Wed, 2014-04-30 at 20:25 +, Serge Hallyn wrote: > I was wanting to keep them out of the container itself, but I > can't really make a good case for wanting that. So +1, let's > do that - if someone else wants to write the patch before I get to > it, shout. I think the benefit of having all

Re: [lxc-devel] [PATCH 1/1] snapshots: move snapshot directory

2014-04-30 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > On Wed, Apr 16, 2014 at 02:04:45PM -0500, Serge Hallyn wrote: > > Originally we kept snapshots under /var/lib/lxcsnaps. If a > > separate btrfs is mounted at /var/lib/lxc, then we can't > > make btrfs snapshots under /var/lib/lxcsnaps. > > > > This

[lxc-devel] [lxc/lxc] debfa8: cppcheck: fix unchecked realloc in lxc_info.c

2014-04-30 Thread GitHub
Branch: refs/heads/stable-1.0 Home: https://github.com/lxc/lxc Commit: debfa8b6159fcd42ff562e0f4630bed95e974fa9 https://github.com/lxc/lxc/commit/debfa8b6159fcd42ff562e0f4630bed95e974fa9 Author: Serge Hallyn Date: 2014-04-30 (Wed, 30 Apr 2014) Changed paths: M src/lxc/lx

[lxc-devel] Cherry-picking to stable-1.0

2014-04-30 Thread Stéphane Graber
Hello, I intend to release 1.0.4 next week and am currently going through all the commits in master which should be included in the bugfix release. Most of them applied cleanly except for two: - [PATCH] Convert punctuation marks in Japanese man pages This one we thought was identical for both

[lxc-devel] [lxc/lxc] 178af5: fix minor typo in .gitignore

2014-04-30 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 178af55b1c8c2a478983e5c6e45c8c642fc3f7d2 https://github.com/lxc/lxc/commit/178af55b1c8c2a478983e5c6e45c8c642fc3f7d2 Author: S.Çağlar Onur Date: 2014-04-30 (Wed, 30 Apr 2014) Changed paths: M .gitignore

Re: [lxc-devel] [PATCH 1/1] snapshots: move snapshot directory

2014-04-30 Thread Stéphane Graber
On Wed, Apr 16, 2014 at 02:04:45PM -0500, Serge Hallyn wrote: > Originally we kept snapshots under /var/lib/lxcsnaps. If a > separate btrfs is mounted at /var/lib/lxc, then we can't > make btrfs snapshots under /var/lib/lxcsnaps. > > This patch moves the default directory to /var/lib/lxc/lxcsnaps

[lxc-devel] [Fixed] lxc/lxc#442 (master - 13aad0a)

2014-04-30 Thread Travis CI
Build Update for lxc/lxc - Build: #442 Status: Fixed Duration: 2 minutes and 26 seconds Commit: 13aad0a (master) Author: Stéphane Graber Message: clang: Fix build warnings for 3.4 Signed-off-by: Stéphane Graber View the changeset: https://github.com/lxc/lxc

[lxc-devel] [lxc/lxc] 13aad0: clang: Fix build warnings for 3.4

2014-04-30 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 13aad0ae78b39a481f4c3f465a525264747cc92a https://github.com/lxc/lxc/commit/13aad0ae78b39a481f4c3f465a525264747cc92a Author: Stéphane Graber Date: 2014-04-30 (Wed, 30 Apr 2014) Changed paths: M src/lxc/log

Re: [lxc-devel] [PATCH] clang: Fix build warnings for 3.4

2014-04-30 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > Signed-off-by: Stéphane Graber Acked-by: Serge E. Hallyn > --- > src/lxc/log.h | 11 +-- > src/lxc/lxc_autostart.c | 2 +- > src/lxc/lxc_start.c | 2 +- > src/lxc/lxccontainer.c | 2 +- > 4 files changed, 12 insertions(

[lxc-devel] [PATCH] clang: Fix build warnings for 3.4

2014-04-30 Thread Stéphane Graber
Signed-off-by: Stéphane Graber --- src/lxc/log.h | 11 +-- src/lxc/lxc_autostart.c | 2 +- src/lxc/lxc_start.c | 2 +- src/lxc/lxccontainer.c | 2 +- 4 files changed, 12 insertions(+), 5 deletions(-) diff --git a/src/lxc/log.h b/src/lxc/log.h index 5252869..d9f3ebc 1006

[lxc-devel] [Broken] lxc/lxc#438 (master - 9e607c2)

2014-04-30 Thread Travis CI
Build Update for lxc/lxc - Build: #438 Status: Broken Duration: 5 minutes and 22 seconds Commit: 9e607c2 (master) Author: Dwight Engen Message: lxc-oracle: fix warnings/errors from some rpm scriptlets - Some scriptlets expect fstab to exist so create it before

Re: [lxc-devel] [RFC] lxc-start: daemonize by default

2014-04-30 Thread Stéphane Graber
I think our original plan to have LXC bind /dev/lxc in the container as a standard unix socket with a basic plain text communication protocol is still our best option. I think initially we probably should allow three additional states: - READY - BROKEN - HALTING Those would be the only states

Re: [lxc-devel] [RFC] lxc-start: daemonize by default

2014-04-30 Thread Serge Hallyn
Note that this would not work generically. Each distro - and presumably until we standardize things, each user - will need to separately (1) install the init job to write to the pipe, (2) set up the container config to create and bind in the fifo, and (3) write the program to wait on the fifo wr

Re: [lxc-devel] [RFC] lxc-start: daemonize by default

2014-04-30 Thread Guido Jäkel
Dear Serge, Nice - a long time ago we discussed such a feature. The wrapper for my current LXC 0.8.4 production environment scan the log for a special console message to treat a container as "up and running". greetings Guido On 2014-04-30 15:56, Serge Hallyn wrote: > [...] and another to only

Re: [lxc-devel] [PATCH] lxc-oracle: fix warnings/errors from some rpm scriptlets

2014-04-30 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > - Some scriptlets expect fstab to exist so create it before doing the > yum install > > - Set the rootfs selinux label same as the hosts or else the PREIN script > from initscripts will fail when running groupadd utmp, which prevents > creati

[lxc-devel] [lxc/lxc] 9e607c: lxc-oracle: fix warnings/errors from some rpm scri...

2014-04-30 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 9e607c2f35926993719addd22be0d718e007cfa2 https://github.com/lxc/lxc/commit/9e607c2f35926993719addd22be0d718e007cfa2 Author: Dwight Engen Date: 2014-04-30 (Wed, 30 Apr 2014) Changed paths: M templates/lxc-

Re: [lxc-devel] ioctl CAP_LINUX_IMMUTABLE is checked in the wrong namespace

2014-04-30 Thread Marian Marinov
On 04/29/2014 09:52 PM, Serge Hallyn wrote: Quoting Theodore Ts'o (ty...@mit.edu): On Tue, Apr 29, 2014 at 04:49:14PM +0300, Marian Marinov wrote: I'm proposing a fix to this, by replacing the capable(CAP_LINUX_IMMUTABLE) check with ns_capable(current_cred()->user_ns, CAP_LINUX_IMMUTABLE). U

Re: [lxc-devel] ioctl CAP_LINUX_IMMUTABLE is checked in the wrong namespace

2014-04-30 Thread Marian Marinov
On 04/30/2014 01:02 AM, Serge Hallyn wrote: Quoting Marian Marinov (m...@1h.com): On 04/29/2014 09:52 PM, Serge Hallyn wrote: Quoting Theodore Ts'o (ty...@mit.edu): On Tue, Apr 29, 2014 at 04:49:14PM +0300, Marian Marinov wrote: I'm proposing a fix to this, by replacing the capable(CAP_LINUX

Re: [lxc-devel] [RFC] lxc-start: daemonize by default

2014-04-30 Thread John Peacock
On Wed, 2014-04-30 at 13:56 +, Serge Hallyn wrote: > And make -F mean 'foreground a console'? Yes, Yes, 1024 times Yes! I have the same issue; -d should be the default and you should have to ask if you want it to be in the foreground. The old default may have made sense during early developm

Re: [lxc-devel] [RFC] lxc-start: daemonize by default

2014-04-30 Thread Serge Hallyn
Quoting Christian Seiler (christ...@iwakd.de): > Hi, > > I'd like to hear some comments about the following: > > With the release of LXC 1.0, lxc-shutdown and lxc-stop were merged > and now we have a really nice sane default to stopping containers: > Just run lxc-stop -n $container and LXC will t

[lxc-devel] [RFC] lxc-start: daemonize by default

2014-04-30 Thread Christian Seiler
Hi, I'd like to hear some comments about the following: With the release of LXC 1.0, lxc-shutdown and lxc-stop were merged and now we have a really nice sane default to stopping containers: Just run lxc-stop -n $container and LXC will try to shut down the container and after a default of 60s it