Re: [lxc-devel] [PATCH] [RFC] snapshots: move snapshot directory (v3)

2014-05-24 Thread S . Çağlar Onur
On Sat, May 24, 2014 at 11:37 PM, Serge Hallyn wrote: > Quoting S.Çağlar Onur (cag...@10ur.org): >> Hey Serge, >> >> On Sat, May 24, 2014 at 8:15 PM, Serge Hallyn >> wrote: >> > Quoting Serge Hallyn (serge.hal...@ubuntu.com): >> >> Quoting Serge Hallyn (serge.hal...@ubuntu.com): >> >> > Original

Re: [lxc-devel] [PATCH] destroy the original container after making sure the snapshot exists (fixes #224)

2014-05-24 Thread Serge Hallyn
Quoting S.Çağlar Onur (cag...@10ur.org): > Signed-off-by: S.Çağlar Onur Acked-by: Serge E. Hallyn > --- > src/lxc/lxccontainer.c | 17 ++--- > 1 file changed, 10 insertions(+), 7 deletions(-) > > diff --git a/src/lxc/lxccontainer.c b/src/lxc/lxccontainer.c > index fdac433..8e611c7

Re: [lxc-devel] [PATCH] [RFC] snapshots: move snapshot directory (v3)

2014-05-24 Thread Serge Hallyn
Quoting S.Çağlar Onur (cag...@10ur.org): > Hey Serge, > > On Sat, May 24, 2014 at 8:15 PM, Serge Hallyn wrote: > > Quoting Serge Hallyn (serge.hal...@ubuntu.com): > >> Quoting Serge Hallyn (serge.hal...@ubuntu.com): > >> > Originally we kept snapshots under /var/lib/lxcsnaps. If a > >> > separat

[lxc-devel] [PATCH 1/1] snapshots: move snapshot directory (v4)

2014-05-24 Thread Serge Hallyn
Originally we kept snapshots under /var/lib/lxcsnaps. If a separate btrfs is mounted at /var/lib/lxc, then we can't make btrfs snapshots under /var/lib/lxcsnaps. This patch moves the default directory to /var/lib/lxc/c/snaps. If /var/lib/lxcsnaps already exists, then use that. lxclock: use ".$lx

Re: [lxc-devel] [PATCH] [RFC] snapshots: move snapshot directory (v3)

2014-05-24 Thread S . Çağlar Onur
Hey Serge, On Sat, May 24, 2014 at 8:15 PM, Serge Hallyn wrote: > Quoting Serge Hallyn (serge.hal...@ubuntu.com): >> Quoting Serge Hallyn (serge.hal...@ubuntu.com): >> > Originally we kept snapshots under /var/lib/lxcsnaps. If a >> > separate btrfs is mounted at /var/lib/lxc, then we can't >> >

[lxc-devel] [PATCH] destroy the original container after making sure the snapshot exists (fixes #224)

2014-05-24 Thread S . Çağlar Onur
Signed-off-by: S.Çağlar Onur --- src/lxc/lxccontainer.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/src/lxc/lxccontainer.c b/src/lxc/lxccontainer.c index fdac433..8e611c7 100644 --- a/src/lxc/lxccontainer.c +++ b/src/lxc/lxccontainer.c @@ -3083,13 +3083,

Re: [lxc-devel] [PATCH] destroy the original container after making sure the snapshot exists (fixes #224)

2014-05-24 Thread S . Çağlar Onur
On Sat, May 24, 2014 at 6:18 PM, Serge Hallyn wrote: > Quoting S.Çağlar Onur (cag...@10ur.org): > > Hi, > > could you please add a Signed-off-by when you resend? > >> --- >> src/lxc/lxccontainer.c | 16 +--- >> 1 file changed, 9 insertions(+), 7 deletions(-) >> >> diff --git a/src/lxc

Re: [lxc-devel] -L option with lxc-start

2014-05-24 Thread Michael H. Warfield
On Sat, 2014-05-24 at 22:15 +, Serge Hallyn wrote: > Quoting William Dauchy (wdau...@gmail.com): > > Hello, > > > > lxc1 did a modification in the lxc.console behaviour (compared to the > > previous version) > > Indeed, in the config file lxc.console now accept a tty and not a file. > > I now

Re: [lxc-devel] [PATCH] [RFC] snapshots: move snapshot directory (v3)

2014-05-24 Thread Serge Hallyn
Quoting Serge Hallyn (serge.hal...@ubuntu.com): > Quoting Serge Hallyn (serge.hal...@ubuntu.com): > > Originally we kept snapshots under /var/lib/lxcsnaps. If a > > separate btrfs is mounted at /var/lib/lxc, then we can't > > make btrfs snapshots under /var/lib/lxcsnaps. > > > > This patch moves

Re: [lxc-devel] -L option with lxc-start

2014-05-24 Thread William Dauchy
Hi Serge, Thanks for your answer. On Sun, May 25, 2014 at 12:15 AM, Serge Hallyn wrote: > Indeed, it looks like we need a patch to confile.c to add a > config_console_logfile() helper to set that. Would you be > interested in writing that patch? Yes I can give a try. -- William _

Re: [lxc-devel] [RFC PATCH 00/11] Add support for devtmpfs in user namespaces

2014-05-24 Thread Serge Hallyn
Quoting James Bottomley (james.bottom...@hansenpartnership.com): > On Fri, 2014-05-23 at 11:20 +0300, Marian Marinov wrote: > > On 05/20/2014 05:19 PM, Serge Hallyn wrote: > > > Quoting Andy Lutomirski (l...@amacapital.net): > > >> On May 15, 2014 1:26 PM, "Serge E. Hallyn" wrote: > > >>> > > >>>

Re: [lxc-devel] [PATCH] destroy the original container after making sure the snapshot exists (fixes #224)

2014-05-24 Thread Serge Hallyn
Quoting S.Çağlar Onur (cag...@10ur.org): Hi, could you please add a Signed-off-by when you resend? > --- > src/lxc/lxccontainer.c | 16 +--- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git a/src/lxc/lxccontainer.c b/src/lxc/lxccontainer.c > index fdac433..029daf7 1

Re: [lxc-devel] -L option with lxc-start

2014-05-24 Thread Serge Hallyn
Quoting William Dauchy (wdau...@gmail.com): > Hello, > > lxc1 did a modification in the lxc.console behaviour (compared to the > previous version) > Indeed, in the config file lxc.console now accept a tty and not a file. > I now need to use -L with lxc-start to get logs in a file. > > The problem