Re: [lxc-devel] [PATCH 1/3] gitignore: add TAGS files

2015-08-12 Thread Serge Hallyn
Quoting Tycho Andersen (tycho.ander...@canonical.com): > Somehow our `make tags` target generates TAGS and not tags, so let's ignore > that too. > > Signed-off-by: Tycho Andersen 'make tags'? Never heard of it... ctags still creates 'tags'. but whatever :) Acked-by: Serge E. Hallyn > --- >

Re: [lxc-devel] [PATCH 2/3] c/r: get rid of dump_net_info()

2015-08-12 Thread Serge Hallyn
Quoting Tycho Andersen (tycho.ander...@canonical.com): > This was originally used to propagate the bridge and veth names across > hosts, but now we extract both from the container's config file, and Is that the right thing to do? > nothing reads the files that dump_net_info() writes, so let's jus

Re: [lxc-devel] [PATCH 2/3] c/r: get rid of dump_net_info()

2015-08-12 Thread Tycho Andersen
On Wed, Aug 12, 2015 at 02:54:14PM +, Serge Hallyn wrote: > Quoting Tycho Andersen (tycho.ander...@canonical.com): > > This was originally used to propagate the bridge and veth names across > > hosts, but now we extract both from the container's config file, and > > Is that the right thing to

Re: [lxc-devel] [PATCH 3/3] c/r: allow empty networks to be checkpointed/restored

2015-08-12 Thread Serge Hallyn
Quoting Tycho Andersen (tycho.ander...@canonical.com): > Empty networks don't have anything (besides lo) for us to dump and restore, > so we should allow these as well. > > Reported-by: Dietmar Maurer > Signed-off-by: Tycho Andersen Acked-by: Serge E. Hallyn Do you know whether the distinctio

Re: [lxc-devel] [PATCH 2/3] c/r: get rid of dump_net_info()

2015-08-12 Thread Serge Hallyn
Quoting Tycho Andersen (tycho.ander...@canonical.com): > On Wed, Aug 12, 2015 at 02:54:14PM +, Serge Hallyn wrote: > > Quoting Tycho Andersen (tycho.ander...@canonical.com): > > > This was originally used to propagate the bridge and veth names across > > > hosts, but now we extract both from th

Re: [lxc-devel] [PATCH 3/3] c/r: allow empty networks to be checkpointed/restored

2015-08-12 Thread Tycho Andersen
On Wed, Aug 12, 2015 at 03:05:19PM +, Serge Hallyn wrote: > Quoting Tycho Andersen (tycho.ander...@canonical.com): > > Empty networks don't have anything (besides lo) for us to dump and restore, > > so we should allow these as well. > > > > Reported-by: Dietmar Maurer > > Signed-off-by: Tycho

Re: [lxc-devel] [PATCH 2/3] c/r: get rid of dump_net_info()

2015-08-12 Thread Tycho Andersen
On Wed, Aug 12, 2015 at 03:09:22PM +, Serge Hallyn wrote: > Quoting Tycho Andersen (tycho.ander...@canonical.com): > > On Wed, Aug 12, 2015 at 02:54:14PM +, Serge Hallyn wrote: > > > Quoting Tycho Andersen (tycho.ander...@canonical.com): > > > > This was originally used to propagate the bri

Re: [lxc-devel] [PATCH 3/3] c/r: allow empty networks to be checkpointed/restored

2015-08-12 Thread Serge Hallyn
Quoting Tycho Andersen (tycho.ander...@canonical.com): > On Wed, Aug 12, 2015 at 03:05:19PM +, Serge Hallyn wrote: > > Quoting Tycho Andersen (tycho.ander...@canonical.com): > > > Empty networks don't have anything (besides lo) for us to dump and > > > restore, > > > so we should allow these a

Re: [lxc-devel] [PATCH 2/3] c/r: get rid of dump_net_info()

2015-08-12 Thread Serge Hallyn
Quoting Tycho Andersen (tycho.ander...@canonical.com): > On Wed, Aug 12, 2015 at 03:09:22PM +, Serge Hallyn wrote: > > Quoting Tycho Andersen (tycho.ander...@canonical.com): > > > On Wed, Aug 12, 2015 at 02:54:14PM +, Serge Hallyn wrote: > > > > Quoting Tycho Andersen (tycho.ander...@canoni

Re: [lxc-devel] [PATCH 2/3] c/r: get rid of dump_net_info()

2015-08-12 Thread Tycho Andersen
On Wed, Aug 12, 2015 at 03:28:07PM +, Serge Hallyn wrote: > Quoting Tycho Andersen (tycho.ander...@canonical.com): > > On Wed, Aug 12, 2015 at 03:09:22PM +, Serge Hallyn wrote: > > > Quoting Tycho Andersen (tycho.ander...@canonical.com): > > > > On Wed, Aug 12, 2015 at 02:54:14PM +, Ser

Re: [lxc-devel] [PATCH 2/3] c/r: get rid of dump_net_info()

2015-08-12 Thread Serge Hallyn
Quoting Tycho Andersen (tycho.ander...@canonical.com): > On Wed, Aug 12, 2015 at 03:28:07PM +, Serge Hallyn wrote: > > Quoting Tycho Andersen (tycho.ander...@canonical.com): > > > On Wed, Aug 12, 2015 at 03:09:22PM +, Serge Hallyn wrote: > > > > Quoting Tycho Andersen (tycho.ander...@canoni