Use pwrite() to write terminating \0-byte
This allows us to use standard string handling functions and we can avoid using
the GNU-extension memmem(). This simplifies removing the container from the
lxc_snapshots file. Wrap strstr() in a while loop to remove duplicate entries.
Signed-off-by:
I want to avoid having to use the GNU-extension memmem() when removing the
container entry. As mmap() does not guarantee us a \0-terminated string we
pwrite() a single terminating \0-byte after the end of the file and the mmap()
the file. The terminating \0-byte will then be removed when we
When creating ephemeral containers that have the option lxc.ephemeral = 1 set
in their config, they will be destroyed on shutdown. As they are simple overlay
clones of an existing container they should be registered in the lxc_snapshots
file of the original container to stay consistent and adhere
When creating ephemeral containers that have the option lxc.ephemeral = 1 set
in their config, they will be destroyed on shutdown. As they are simple overlay
clones of an existing container they should be registered in the lxc_snapshots
file of the original container to stay consistent and adhere
Updated patch to follow.
On Thu, Sep 10, 2015 at 11:20:44PM +, Serge Hallyn wrote:
> Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > This allows us to use standard string handling functions and we can avoid
> > using
> > the GNU-extension memmem(). This simplifies removing the
When creating ephemeral containers that have the option lxc.ephemeral = 1 set
in their config, they will be destroyed on shutdown. As they are simple overlay
clones of an existing container they should be registered in the lxc_snapshots
file of the original container to stay consistent and adhere
When creating ephemeral containers that have the option lxc.ephemeral = 1 set
in their config, they will be destroyed on shutdown. As they are simple overlay
clones of an existing container they should be registered in the lxc_snapshots
file of the original container to stay consistent and adhere
I have no idea what this file is, but the build system seems to be
generating it, so let's ignore it.
Signed-off-by: Tycho Andersen
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index 9c60c92..5ec52c5 100644
---
Here's some more config options that we do actually require to be able to
boot containers.
Signed-off-by: Tycho Andersen
---
src/lxc/lxc-checkconfig.in | 19 +++
1 file changed, 19 insertions(+)
diff --git a/src/lxc/lxc-checkconfig.in
Signed-off-by: Tycho Andersen
---
.gitignore | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.gitignore b/.gitignore
index 35d89f2..9c60c92 100644
--- a/.gitignore
+++ b/.gitignore
@@ -135,6 +135,9 @@ doc/ja/*.5
doc/ja/*.7
doc/ja/legacy/*.1
doc/legacy/*.1
Quoting Christian Brauner (christianvanbrau...@gmail.com):
> Use pwrite() to write terminating \0-byte
>
> This allows us to use standard string handling functions and we can avoid
> using
> the GNU-extension memmem(). This simplifies removing the container from the
> lxc_snapshots file. Wrap
11 matches
Mail list logo