Re: [lxc-devel] [PATCH v2] Add lxc-copy executable

2015-11-06 Thread Christian Brauner
On Thu, Nov 05, 2015 at 11:15:08PM +, Serge Hallyn wrote: > Quoting Christian Brauner (christianvanbrau...@gmail.com): > > This is a complete reimplementation of lxc-clone and lxc-start-ephemeral. > > lxc-copy merges the functionalities of lxc-clone + lxc-start-ephemeral into > > one > > execu

[lxc-devel] [PATCH v3] Add lxc-copy executable

2015-11-06 Thread Christian Brauner
Changes v3 (only changes in the commit message): (1) Make it explicit that the flag -e / --ephemeral starts ephemeral containers. (2) Fix missing -e flag in examples (c) and (d). (3) Fix example (d). The flag to create a non-ephemeral container is -D and not -K. (4) Add some more exampled to i

[lxc-devel] [PATCH v3] Add lxc-copy executable

2015-11-06 Thread Christian Brauner
This is a complete reimplementation of lxc-clone and lxc-start-ephemeral. lxc-copy merges the functionalities of lxc-clone + lxc-start-ephemeral. (1) Cloning containers: (a) as copy: lxc-copy -n aa -N bb (b) as snapshot: lxc-copy -n aa -N bb -s

Re: [lxc-devel] [PATCH] only re-open fds if stdin is a tty

2015-11-06 Thread Stéphane Graber
On Fri, Oct 30, 2015 at 05:14:12AM +, Serge Hallyn wrote: > Signed-off-by: Serge Hallyn Acked-by: Stéphane Graber > --- > src/lxc/lxc_usernsexec.c | 30 -- > 1 file changed, 16 insertions(+), 14 deletions(-) > > diff --git a/src/lxc/lxc_usernsexec.c b/src/lxc/l

Re: [lxc-devel] [PATCH] doc: Add the description of lxc.hook.stop to Korean lxc.container.conf(5)

2015-11-06 Thread Stéphane Graber
On Mon, Nov 02, 2015 at 05:32:48PM +0900, Sungbae Yoo wrote: > Update for commit 0a2b5ab > > Signed-off-by: Sungbae Yoo Acked-by: Stéphane Graber > > diff --git a/doc/ko/lxc.container.conf.sgml.in > b/doc/ko/lxc.container.conf.sgml.in > index f06e559..741003b 100644 > --- a/doc/ko/lxc.contai

Re: [lxc-devel] [PATCH] Unify the polite word style in Korean manpages

2015-11-06 Thread Stéphane Graber
On Mon, Nov 02, 2015 at 06:29:31PM +0900, Sungbae Yoo wrote: > Signed-off-by: Sungbae Yoo Acked-by: Stéphane Graber > > diff --git a/doc/ko/lxc-attach.sgml.in b/doc/ko/lxc-attach.sgml.in > index c40dba9..f8e23f8 100644 > --- a/doc/ko/lxc-attach.sgml.in > +++ b/doc/ko/lxc-attach.sgml.in > @@ -8

Re: [lxc-devel] [PATCH] support arguments in lxc.init_cmd

2015-11-06 Thread Stéphane Graber
On Thu, Nov 05, 2015 at 10:18:52PM +, Serge Hallyn wrote: > Otherwise something like > lxc.init_cmd = /sbin/init debug verbose > fails trying to execute a file called "/sbin/init debug verbose" > > Signed-off-by: Serge Hallyn Acked-by: Stéphane Graber > --- > src/lxc/lxccontainer.c

Re: [lxc-devel] [PATCH v2 lxc] hooks: put binary hooks into $libexecdir/lxc/hooks

2015-11-06 Thread Stéphane Graber
On Thu, Nov 05, 2015 at 03:02:11PM +0100, Wolfgang Bumiller wrote: > Signed-off-by: Wolfgang Bumiller Acked-by: Stéphane Graber > --- > Changes: >1) Use libexecdir instead of libdir. >2) Variables renamed: > 2a) LXCLIBHOOKDIR => LXCBINHOOKDIR (s/LIB/BIN/) > 2b) libhooksdir =>

[lxc-devel] [lxc/lxc] 4a3110: lxc-ubuntu-cloud: Never exit 0 when no container i...

2015-11-06 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 4a3110456051b5b018a73507ba4f56adb81006ee https://github.com/lxc/lxc/commit/4a3110456051b5b018a73507ba4f56adb81006ee Author: Stéphane Graber Date: 2015-11-06 (Fri, 06 Nov 2015) Changed paths: M templates/l

[lxc-devel] [PATCH] use PR_SET_MM_MAP instead of PR_SET_MM

2015-11-06 Thread Tycho Andersen
PR_SET_MM_MAP can be called as non-root, which we are in the unprivileged (or nested) case. Also, let's not do the strcpy() for the new cmdline until after we're sure the prctl succeeded. This means that even if it does fail, we won't mutilate the command line like we did before, it just won't be

[lxc-devel] [PATCH v2] use PR_SET_MM_MAP instead of PR_SET_MM

2015-11-06 Thread Tycho Andersen
PR_SET_MM_MAP can be called as non-root, which we are in the unprivileged (or nested) case. Also, let's not do the strcpy() for the new cmdline until after we're sure the prctl succeeded. This means that even if it does fail, we won't mutilate the command line like we did before, it just won't be

Re: [lxc-devel] [PATCH v2] use PR_SET_MM_MAP instead of PR_SET_MM

2015-11-06 Thread Serge Hallyn
Quoting Tycho Andersen (tycho.ander...@canonical.com): > PR_SET_MM_MAP can be called as non-root, which we are in the unprivileged > (or nested) case. > > Also, let's not do the strcpy() for the new cmdline until after we're sure > the prctl succeeded. This means that even if it does fail, we won'

[lxc-devel] [lxc/lxc] 93525c: use PR_SET_MM_MAP instead of PR_SET_MM

2015-11-06 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 93525c00c76b2804c46cf3c275d610ebe71cb4be https://github.com/lxc/lxc/commit/93525c00c76b2804c46cf3c275d610ebe71cb4be Author: Tycho Andersen Date: 2015-11-06 (Fri, 06 Nov 2015) Changed paths: M src/lxc/util

[lxc-devel] [lxc/lxc] 8dc255: Make mount_entry_create_*_dirs() more robust

2015-11-06 Thread GitHub
Branch: refs/heads/stable-1.1 Home: https://github.com/lxc/lxc Commit: 8dc25557dbc6fc95b7084cfcf3fd5bbeeb9266cf https://github.com/lxc/lxc/commit/8dc25557dbc6fc95b7084cfcf3fd5bbeeb9266cf Author: Christian Brauner Date: 2015-11-06 (Fri, 06 Nov 2015) Changed paths: M src/l

[lxc-devel] [PATCH] c/r: don't require a veth link to c/r

2015-11-06 Thread Tycho Andersen
veths can be unconnected in the container's config, and we should handle this case. Signed-off-by: Tycho Andersen --- src/lxc/criu.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/lxc/criu.c b/src/lxc/criu.c index 798036a..7ee6cbe 100644 --- a/src/lxc/criu.c +++ b/sr

Re: [lxc-devel] [PATCH] c/r: don't require a veth link to c/r

2015-11-06 Thread Stéphane Graber
On Fri, Nov 06, 2015 at 12:58:02PM -0700, Tycho Andersen wrote: > veths can be unconnected in the container's config, and we should handle > this case. > > Signed-off-by: Tycho Andersen Acked-by: Stéphane Graber > --- > src/lxc/criu.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-

[lxc-devel] Broken: lxc/lxc#1305 (master - 93525c0)

2015-11-06 Thread Travis CI
Build Update for lxc/lxc - Build: #1305 Status: Broken Duration: 54 seconds Commit: 93525c0 (master) Author: Tycho Andersen Message: use PR_SET_MM_MAP instead of PR_SET_MM PR_SET_MM_MAP can be called as non-root, which we are in the unprivileged (or nested) ca

Re: [lxc-devel] question about /sys/fs/cgroup/cgmanager

2015-11-06 Thread Serge Hallyn
Quoting Dietmar Maurer (diet...@proxmox.com): > seems directory /sys/fs/cgroup/cgmanager is directly mounted from host, so any > container > can simply remove the cgmanager socket on the host from inside the container: > > # rm /sys/fs/cgroup/cgmanager/sock > > I guess this should not be possible

[lxc-devel] Broken: lxc/lxc#1306 (stable-1.1 - eac6837)

2015-11-06 Thread Travis CI
Build Update for lxc/lxc - Build: #1306 Status: Broken Duration: 59 seconds Commit: eac6837 (stable-1.1) Author: Tycho Andersen Message: use PR_SET_MM_MAP instead of PR_SET_MM PR_SET_MM_MAP can be called as non-root, which we are in the unprivileged (or nested

[lxc-devel] [PATCH] define PR_SET_MM_MAP & friends if necessary

2015-11-06 Thread Tycho Andersen
PR_SET_MM_MAP only went in to the kernel at 3.18 (or 3.19), so we need to define these for kernels before then. If there was an error, the code simply logs the failure and continues on. Also, we can drop the PR_SET_MM_otherstuff contstants since those were dropped in 93525c00c76b2804c46cf3c275d610

Re: [lxc-devel] [PATCH] define PR_SET_MM_MAP & friends if necessary

2015-11-06 Thread Stéphane Graber
On Fri, Nov 06, 2015 at 01:50:33PM -0700, Tycho Andersen wrote: > PR_SET_MM_MAP only went in to the kernel at 3.18 (or 3.19), so we need to > define these for kernels before then. If there was an error, the code > simply logs the failure and continues on. > > Also, we can drop the PR_SET_MM_others

[lxc-devel] [lxc/lxc] c1fd64: c/r: don't require a veth link to c/r

2015-11-06 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: c1fd648dd85fd254e31bb8d3503cb6b7009cfcfc https://github.com/lxc/lxc/commit/c1fd648dd85fd254e31bb8d3503cb6b7009cfcfc Author: Tycho Andersen Date: 2015-11-06 (Fri, 06 Nov 2015) Changed paths: M src/lxc/criu

[lxc-devel] Fixed: lxc/lxc#1307 (master - 8d2ede5)

2015-11-06 Thread Travis CI
Build Update for lxc/lxc - Build: #1307 Status: Fixed Duration: 2 minutes and 21 seconds Commit: 8d2ede5 (master) Author: Tycho Andersen Message: define PR_SET_MM_MAP & friends if necessary PR_SET_MM_MAP only went in to the kernel at 3.18 (or 3.19), so we need

[lxc-devel] [lxc/lxc] ad6072: c/r: don't require a veth link to c/r

2015-11-06 Thread GitHub
Branch: refs/heads/stable-1.1 Home: https://github.com/lxc/lxc Commit: ad60725eeac68317e9ab28ea5d0d5d7fd90e2f4c https://github.com/lxc/lxc/commit/ad60725eeac68317e9ab28ea5d0d5d7fd90e2f4c Author: Tycho Andersen Date: 2015-11-06 (Fri, 06 Nov 2015) Changed paths: M src/lxc/

[lxc-devel] Fixed: lxc/lxc#1308 (stable-1.1 - 5ce1db7)

2015-11-06 Thread Travis CI
Build Update for lxc/lxc - Build: #1308 Status: Fixed Duration: 2 minutes and 44 seconds Commit: 5ce1db7 (stable-1.1) Author: Tycho Andersen Message: define PR_SET_MM_MAP & friends if necessary PR_SET_MM_MAP only went in to the kernel at 3.18 (or 3.19), so we

[lxc-devel] [lxc/lxc] cb4c20: lxc-create: Require --template be passed

2015-11-06 Thread GitHub
Branch: refs/heads/stable-1.0 Home: https://github.com/lxc/lxc Commit: cb4c20629e746485f42e9e59ba70a846d3b19796 https://github.com/lxc/lxc/commit/cb4c20629e746485f42e9e59ba70a846d3b19796 Author: Stéphane Graber Date: 2015-11-06 (Fri, 06 Nov 2015) Changed paths: M doc/lxc

[lxc-devel] [PATCH] c/r: use freezer to seize tasks

2015-11-06 Thread Tycho Andersen
Instead of relying on the old ptrace loop, we should instead put all the tasks in the container into the freezer. This will stop them all at the same time, preventing fork bombs from causing criu to infinite loop (and is also simply a lot faster). Note that this uses --freeze-cgroup which isn't in

[lxc-devel] [lxc/lxc] dc2593: c/r: use freezer to seize tasks

2015-11-06 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: dc259399a453b68811a9c62fcf739b8e77e3fbe8 https://github.com/lxc/lxc/commit/dc259399a453b68811a9c62fcf739b8e77e3fbe8 Author: Tycho Andersen Date: 2015-11-06 (Fri, 06 Nov 2015) Changed paths: M src/lxc/criu

Re: [lxc-devel] [PATCH] c/r: use freezer to seize tasks

2015-11-06 Thread Stéphane Graber
On Fri, Nov 06, 2015 at 05:26:43PM -0700, Tycho Andersen wrote: > Instead of relying on the old ptrace loop, we should instead put all the > tasks in the container into the freezer. This will stop them all at the > same time, preventing fork bombs from causing criu to infinite loop (and is > also s