Re: [lxc-devel] [PATCH lxcfs] Fix busted swap usage

2016-01-08 Thread Serge Hallyn
Quoting Nehal J Wani (nehaljw.k...@gmail.com): > When no limit is specified using lxc.cgroup.memory.memsw.limit_in_bytes, > overflow occurs while calculating Swap{Total,Free}. Commit a2de34b tried > to fix this, but introduced another bug, wherein if > memory.memsw.limit_in_bytes >= memory.limit_in

Re: [lxc-devel] [PATCH lxcfs 4/5] cgfs: fix dorealloc's batch allocation

2016-01-08 Thread Serge Hallyn
Thanks, I'll push a new 0.16 release tonight. ___ lxc-devel mailing list lxc-devel@lists.linuxcontainers.org http://lists.linuxcontainers.org/listinfo/lxc-devel

Re: [lxc-devel] [PATCH lxcfs 4/5] cgfs: fix dorealloc's batch allocation

2016-01-08 Thread Mathias Gibbens
Yes, the current git head for lxcfs (3beb534) works for me. On Fri, 2016-01-08 at 21:13 +, Serge Hallyn wrote: > It makes sense. > > I was going to give this a few hours before releasing 0.16. > > There's one more new commit in git head, can you try the very latest > and make sure it works

Re: [lxc-devel] [PATCH lxcfs 4/5] cgfs: fix dorealloc's batch allocation

2016-01-08 Thread Serge Hallyn
It makes sense. I was going to give this a few hours before releasing 0.16. There's one more new commit in git head, can you try the very latest and make sure it works for you? Quoting Mathias Gibbens (math...@calenhad.com): > This patch also seems to fix a segfault I encountered today after >

Re: [lxc-devel] [PATCH lxcfs 4/5] cgfs: fix dorealloc's batch allocation

2016-01-08 Thread Mathias Gibbens
This patch also seems to fix a segfault I encountered today after upgrading to lxcfs-0.15. My host is Debian jessie 64bit running unprivileged jessie containers with systemd as their init. lxcfs-0.13 works, lxcfs-0.15 segfaults, and lxcfs-git@1204f57 works again. In the short time since lxcfs-

[lxc-devel] [lxc/lxc] 8b5fb7: detect which cgroups we cannot use

2016-01-08 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 8b5fb7f3d8ff0c93f11b935b92e737305f98680d https://github.com/lxc/lxc/commit/8b5fb7f3d8ff0c93f11b935b92e737305f98680d Author: Serge Hallyn Date: 2016-01-08 (Fri, 08 Jan 2016) Changed paths: M src/lxc/cgmana

Re: [lxc-devel] [PATCH lxcfs 4/5] cgfs: fix dorealloc's batch allocation

2016-01-08 Thread Serge Hallyn
Quoting Wolfgang Bumiller (w.bumil...@proxmox.com): > > > On January 8, 2016 at 11:23 AM Wolfgang Bumiller > > wrote: > > > > > > > > > On January 8, 2016 at 9:50 AM Wolfgang Bumiller > > > wrote: > > > > > > > > > > > > > On January 7, 2016 at 8:20 PM Serge Hallyn > > > > wrote: > > > >

Re: [lxc-devel] [PATCH] lxc_setup_fs: Create /dev/shm folder if it doesn't exist

2016-01-08 Thread Serge Hallyn
Quoting Bogdan Purcareata (bogdan.purcare...@nxp.com): > When running application containers with lxc-execute, /dev is > populated only with device entries. Since /dev is a tmpfs mount in > the container environment, the /dev/shm folder not being present is not > a sufficient reason for the /dev/sh

Re: [lxc-devel] [PATCH] safe_mount: Handle mounting proc and refactor

2016-01-08 Thread Serge Hallyn
Quoting Bogdan Purcareata (bogdan.purcare...@nxp.com): > The safe_mount primitive will mount the fs in the new container > environment by using file descriptors referred in /proc/self/fd. > However, when the mounted filesystem is proc itself, it will have > been previously unmounted, therefore resu

Re: [lxc-devel] [PATCH] open_without_symlink: Account when prefix is empty string

2016-01-08 Thread Serge Hallyn
Quoting Bogdan Purcareata (bogdan.purcare...@nxp.com): > In the current implementation, the open_without_symlink function > will default to opening the root mount only if the passed rootfs > prefix is null. It doesn't account for the case where this prefix > is passed as an empty string. > > Prope

[lxc-devel] [PATCH lxcfs] Fix busted swap usage

2016-01-08 Thread Nehal J Wani
When no limit is specified using lxc.cgroup.memory.memsw.limit_in_bytes, overflow occurs while calculating Swap{Total,Free}. Commit a2de34b tried to fix this, but introduced another bug, wherein if memory.memsw.limit_in_bytes >= memory.limit_in_bytes, then Swap{Total,Free} are not shown as expected

[lxc-devel] [PATCH] safe_mount: Handle mounting proc and refactor

2016-01-08 Thread Bogdan Purcareata
The safe_mount primitive will mount the fs in the new container environment by using file descriptors referred in /proc/self/fd. However, when the mounted filesystem is proc itself, it will have been previously unmounted, therefore resulting in an error when searching for these file descriptors. Th

[lxc-devel] [PATCH] open_without_symlink: Account when prefix is empty string

2016-01-08 Thread Bogdan Purcareata
In the current implementation, the open_without_symlink function will default to opening the root mount only if the passed rootfs prefix is null. It doesn't account for the case where this prefix is passed as an empty string. Properly handle this second case as well. Signed-off-by: Bogdan Purcare

[lxc-devel] [PATCH] lxc_setup_fs: Create /dev/shm folder if it doesn't exist

2016-01-08 Thread Bogdan Purcareata
When running application containers with lxc-execute, /dev is populated only with device entries. Since /dev is a tmpfs mount in the container environment, the /dev/shm folder not being present is not a sufficient reason for the /dev/shm mount to fail. Create the /dev/shm directory if not present.

Re: [lxc-devel] [PATCH lxcfs 4/5] cgfs: fix dorealloc's batch allocation

2016-01-08 Thread Wolfgang Bumiller
> On January 8, 2016 at 11:23 AM Wolfgang Bumiller > wrote: > > > > > On January 8, 2016 at 9:50 AM Wolfgang Bumiller > > wrote: > > > > > > > > > On January 7, 2016 at 8:20 PM Serge Hallyn > > > wrote: > > > Quoting Wolfgang Bumiller (w.bumil...@proxmox.com): > > > > > On January 7, 2016

Re: [lxc-devel] [PATCH lxcfs 4/5] cgfs: fix dorealloc's batch allocation

2016-01-08 Thread Wolfgang Bumiller
> On January 8, 2016 at 11:23 AM Wolfgang Bumiller > wrote: > > On January 8, 2016 at 9:50 AM Wolfgang Bumiller > > wrote: > > > On January 7, 2016 at 8:20 PM Serge Hallyn > > > wrote: > > > Quoting Wolfgang Bumiller (w.bumil...@proxmox.com): > > > > > On January 7, 2016 at 7:42 PM Serge Hallyn

Re: [lxc-devel] [PATCH lxcfs 4/5] cgfs: fix dorealloc's batch allocation

2016-01-08 Thread Wolfgang Bumiller
> On January 8, 2016 at 9:50 AM Wolfgang Bumiller > wrote: > > > > > On January 7, 2016 at 8:20 PM Serge Hallyn wrote: > > Quoting Wolfgang Bumiller (w.bumil...@proxmox.com): > > > > On January 7, 2016 at 7:42 PM Serge Hallyn > > > > wrote: > > > > Quoting Wolfgang Bumiller (w.bumil...@proxm

Re: [lxc-devel] [PATCH lxcfs 3/5] fix leak in realloc loop in must_strcat_pid

2016-01-08 Thread Serge Hallyn
Quoting Wolfgang Bumiller (w.bumil...@proxmox.com): > > > On January 8, 2016 at 2:55 AM Serge Hallyn wrote: > > Quoting Wolfgang Bumiller (w.bumil...@proxmox.com): > > > Signed-off-by: Wolfgang Bumiller > > > --- > > > lxcfs.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >

Re: [lxc-devel] [PATCH lxcfs 3/5] fix leak in realloc loop in must_strcat_pid

2016-01-08 Thread Wolfgang Bumiller
> On January 8, 2016 at 2:55 AM Serge Hallyn wrote: > Quoting Wolfgang Bumiller (w.bumil...@proxmox.com): > > Signed-off-by: Wolfgang Bumiller > > --- > > lxcfs.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lxcfs.c b/lxcfs.c > > index 8605000..d738e79 100644

Re: [lxc-devel] [PATCH lxcfs 4/5] cgfs: fix dorealloc's batch allocation

2016-01-08 Thread Wolfgang Bumiller
> On January 7, 2016 at 8:20 PM Serge Hallyn wrote: > Quoting Wolfgang Bumiller (w.bumil...@proxmox.com): > > > On January 7, 2016 at 7:42 PM Serge Hallyn > > > wrote: > > > Quoting Wolfgang Bumiller (w.bumil...@proxmox.com): > > > > - if (newlen % BATCH_SIZE <= oldlen % BATCH_SIZE) > > >