Hello @all,
currently, I'm testing lxc 4.0.5 with multiple Linux distro's,
and on some of them lxc-create(1) segfaulted.
When I run lxc-create(1) in GDB, I get:
Program received signal SIGSEGV, Segmentation fault.
x0i00077b6be79 in do_lxcapi_create (c=c@entry=0x6980b0,
t=t@entry=0x7fffe
Hi Christian,
On Tue, Jun 23, 2020 at 11:15:47AM +0200, Christian Brauner wrote:
> On Tue, Jun 23, 2020 at 10:47:44AM +0200, Robert Vogelgesang wrote:
> > Hello @all,
> >
> > in 4.0 and master branches, the lxc-stop command is currently a
> > no-op when using the --
Hello @all,
in 4.0 and master branches, the lxc-stop command is currently a
no-op when using the --nowait flag. Patch against current 4.0
branch attached, should apply to master, too.
Best regards,
Robert
diff -up lxc-stable-4.0/src/lxc/lxccontainer.c.nowait
lxc-stable-4.0/src/lxc/lxccontaine
Hello Stéphane,
On Mon, Nov 09, 2015 at 05:53:59PM -0500, Stéphane Graber wrote:
> Hello everyone,
>
> The eighth LXC 1.0 bugfix release is now out!
>
> This includes all bugfixes committed to master since the release of
> LXC 1.0.7 almost a year ago!
sorry to spoil the party, but you've missed
Hi,
On Wed, Jun 10, 2015 at 12:04:24PM +, Serge Hallyn wrote:
> Quoting Robert Vogelgesang (vo...@users.sourceforge.net):
[...]
> > > + * Here, we're taking advantage of C's short circuiting of
> > > + * conditions: we shoul
Hi Tycho,
thank you for the updated patch, but you missed my intention, see below.
On Tue, Jun 09, 2015 at 10:09:28AM -0600, Tycho Andersen wrote:
> In various places throughout the code, we want to "nullify" the std fds,
> opening them to /dev/null or zero or so. Instead, let's unify this code a
Hi Tycho,
On Tue, Jun 09, 2015 at 05:48:52AM -0600, Tycho Andersen wrote:
> On Tue, Jun 09, 2015 at 11:48:05AM +0200, Robert Vogelgesang wrote:
> > Hi,
> >
> > On Mon, Jun 08, 2015 at 07:59:54PM -0600, Tycho Andersen wrote:
> > > In various places throughout the
Hi,
On Mon, Jun 08, 2015 at 07:59:54PM -0600, Tycho Andersen wrote:
> In various places throughout the code, we want to "nullify" the std fds,
> opening them to /dev/null or zero or so. Instead, let's unify this code and
> do it in such a way that Coverity (probably) won't complain.
>
> Reported-
Hi,
if you really want to enforce a certain character set, please note:
On Thu, Feb 05, 2015 at 08:06:14PM +0100, Robert Vogelgesang wrote:
> Hi Serge,
>
> On Thu, Feb 05, 2015 at 05:40:54PM +, Serge Hallyn wrote:
> > Quoting Robert Vogelgesang (vo...@users.sourceforge.net):
Hi Serge,
On Thu, Feb 05, 2015 at 05:40:54PM +, Serge Hallyn wrote:
> Quoting Robert Vogelgesang (vo...@users.sourceforge.net):
> > Hello,
> >
> > On Thu, Feb 05, 2015 at 05:50:39PM +0200, Joel Nider wrote:
> > > The name used to identify the container o
Hello,
On Thu, Feb 05, 2015 at 05:50:39PM +0200, Joel Nider wrote:
> The name used to identify the container on the host is also used as the
> host
> name of the container itself. Therefore, the name should be restricted to
> a
> legal Linux hostname, which is specified in RFC 1123
no, this sho
Hi Serge,
On Fri, Jun 20, 2014 at 02:56:12PM +, Serge Hallyn wrote:
> Quoting Robert Vogelgesang (vo...@users.sourceforge.net):
> > Hi Serge,
> >
> > sorry for being late with this issue - we had a holiday here yesterday,
> > and I didn't read your mail un
Hi Serge,
sorry for being late with this issue - we had a holiday here yesterday,
and I didn't read your mail until now.
On Wed, Jun 18, 2014 at 07:39:07PM +, Serge Hallyn wrote:
> Blacklist module loading, kexec, and open_by_handle_at (the cause of the
> not-docker-specific dockerinit mounts
Hi Stéphane,
On Fri, Apr 04, 2014 at 01:30:35PM -0400, Stéphane Graber wrote:
> On Fri, Apr 04, 2014 at 07:04:03PM +0200, Robert Vogelgesang wrote:
> > Place log file into LOGPATH instead of LXCPATH (but still use the
> > given lxcpath if the latter differs from LXCPATH).
>
&g
Fix parsing of /etc/lxc/default.conf, i. e. ignore comments, and don't
require whitespace left and right of the equal sign.
Make the early return actually work.
Signed-off-by: Robert Vogelgesang
diff -up lxc-1.0.2/config/init/sysvinit/lxc.fix_wfb
lxc-1.0.2/config/init/sysvinit/lxc
--
Place log file into LOGPATH instead of LXCPATH (but still use the
given lxcpath if the latter differs from LXCPATH).
Signed-off-by: Robert Vogelgesang
diff -up lxc-1.0.2/src/lxc/lxc_monitord.c.monitordlogpath
lxc-1.0.2/src/lxc/lxc_monitord.c
--- lxc-1.0.2/src/lxc/lxc_monitord.c.monitordlogpath
Fix lxc-stop's -W / --nowait handling.
Note that this explicitely changes --nokill to imply waiting forever,
which was the implicit behaviour prior to my fix from today for
lxcapi_shutdown().
Signed-off-by: Robert Vogelgesang
diff -up lxc-lxc-1.0.0.beta3/src/lxc/lxc_stop.c.orig
lxc-lxc-
The timeout argument should be handled as follows:
-1 => Wait forever
0 => Don't wait
> 0 => Wait for timeout seconds
Without this patch, the 0 case is mapped to -1.
Signed-off-by: Robert Vogelgesang
diff -up lxc-lxc-1.0.0.beta3/src/lxc/lxccontainer.c.orig
lxc-lxc-1.
Hi,
On Thu, Jan 30, 2014 at 05:42:04PM +0100, Robert Vogelgesang wrote:
> On Thu, Jan 30, 2014 at 04:14:39PM +, Stéphane Graber wrote:
> > On Thu, Jan 30, 2014 at 04:40:17PM +0100, Robert Vogelgesang wrote:
> > > On Thu, Jan 30, 2014 at 03:36:35PM +, Stéphane Graber wro
On Thu, Jan 30, 2014 at 04:14:39PM +, Stéphane Graber wrote:
> On Thu, Jan 30, 2014 at 04:40:17PM +0100, Robert Vogelgesang wrote:
> > Stéphane,
> >
> > On Thu, Jan 30, 2014 at 03:36:35PM +, Stéphane Graber wrote:
> > > On Thu, Jan 30, 2014 at 04:32:52PM +
Stéphane,
On Thu, Jan 30, 2014 at 03:36:35PM +, Stéphane Graber wrote:
> On Thu, Jan 30, 2014 at 04:32:52PM +0100, Robert Vogelgesang wrote:
> > Hi Serge,
> >
> > On Thu, Jan 30, 2014 at 12:19:53PM +, Serge Hallyn wrote:
> > > Quoting Robert Vogelgesan
Hi Serge,
On Thu, Jan 30, 2014 at 12:19:53PM +, Serge Hallyn wrote:
> Quoting Robert Vogelgesang (vo...@users.sourceforge.net):
> > Hi,
> >
> > during my tests today I found some inconsistencies between the documented
> > and the actual behaviour of some lxc
Change lxc-stop's argument parsing so that it matches what the help option
and the man page both describe.
Signed-off-by: Robert Vogelgesang
diff -up lxc-lxc-1.0.0.beta3/src/lxc/lxc_stop.c.fix_noargs
lxc-lxc-1.0.0.beta3/src/lxc/lxc_stop.c
--- lxc-lxc-1.0.0.beta3/src/lxc/lxc_stop.c.fix_n
Hi Serge,
first, thank you for accepting and cleaning up my patch.
I'd like to submit two small changes on top of your work; please
see my inline notes, and the patch at the end.
Robert
On Wed, Jan 29, 2014 at 10:01:06AM +, Serge Hallyn wrote:
> Quoting Robert Vogelge
Hi,
during my tests today I found some inconsistencies between the documented
and the actual behaviour of some lxc-stop options.
The documentation says that you could use --nokill to prevent hard-killing
the container's processes; actually you have to use --no-kill, or else
lxc-stop will complain
Hi Serge,
On Tue, Jan 28, 2014 at 04:32:30PM +, Serge Hallyn wrote:
> Quoting Robert Vogelgesang (vo...@users.sourceforge.net):
> > Hi,
> >
> > as promised last week, here's my patch for cpuset cgroup support for
> > kernels without the cgroup.clone_children
Hi,
On Tue, Jan 28, 2014 at 10:22:36AM -0500, Dwight Engen wrote:
> On Tue, 28 Jan 2014 12:01:54 +0100
> Robert Vogelgesang wrote:
>
> > lxc_monitord_spawn() in src/lxc/monitor.c contained "umask(0);", and
> > because of this, lxc-monitord created lxc-monitor
lxc_monitord_spawn() in src/lxc/monitor.c contained "umask(0);", and
because of this, lxc-monitord created lxc-monitord.log with mode 0666.
World-writeable log files are bad, so remove this umask(0).
Signed-off-by: Robert Vogelgesang
diff -u lxc-lxc-1.0.0.beta3/src/lxc/monitor.c.ori
Hi,
during the last week I found some minor issues with 1.0.0.beta2 that
still exist with 1.0.0.beta3; for all issues I'd like to hear if
anyone has already a patch for them, and if not, how they should be
resolved "upstream".
1. sysvinit script
--
In RHEL-6 (and derived distri
gmanager
(I've so far not tried to use cgmanager in RHEL-6).
In addition to fixing the cpuset cgroup setup, this patch also fixes a
wrong argument in a call to handle_cgroup_settings() in the same context.
Robert
Signed-off-by: Robert Vogelgesang
diff -u lxc-lxc-1.0.0.beta3/src/lx
Hi Serge,
On Thu, Jan 23, 2014 at 11:28:46AM -0600, Serge Hallyn wrote:
> Quoting Robert Vogelgesang (vo...@users.sourceforge.net):
> > > +static long get_value(const char *dir, const char *file)
> > > +{
> > > + FILE *f;
> > > + char path[MAXPATHLEN];
>
Hi Serge,
your patch uses the same concept as mine, but it won't work, as noted
below.
If you can wait until Monday, I could send you a cleaned-up and tested
version of my patch; I have to do other things today and tomorrow.
On Wed, Jan 22, 2014 at 10:49:00AM -0600, Serge Hallyn wrote:
> When c
Hi Serge,
On Wed, Jan 22, 2014 at 09:46:55AM -0600, Serge Hallyn wrote:
> Quoting Robert Vogelgesang (vo...@users.sourceforge.net):
> > I'm currently developing a patch for 1.0.0.beta2 which should fix this,
> > but neither does it work ATM, nor am I sure that it is the s
Hi Serge,
On Wed, Jan 22, 2014 at 09:46:55AM -0600, Serge Hallyn wrote:
> Quoting Robert Vogelgesang (vo...@users.sourceforge.net):
> > I'm currently developing a patch for 1.0.0.beta2 which should fix this,
> > but neither does it work ATM, nor am I sure that it is the s
Hi Serge,
On Wed, Jan 22, 2014 at 08:39:13AM -0600, Serge Hallyn wrote:
> Quoting Robert Vogelgesang (vo...@users.sourceforge.net):
> > Hello Serge,
> >
> > thank you for your clear explanation.
> >
> > On Fri, Jan 17, 2014 at 04:21:49PM -0600, Serge Hallyn w
Include the IPv4/IPv6 prefix if it's set.
Signed-off-by: Robert Vogelgesang
diff -u lxc-lxc-1.0.0.beta2/src/lxc/confile.c.writeprefix
lxc-lxc-1.0.0.beta2/src/lxc/confile.c
--- lxc-lxc-1.0.0.beta2/src/lxc/confile.c.writeprefix 2014-01-16
01:07:33.0 +0100
+++ lxc-lxc-1.0.0.beta
Hello Serge,
thank you for your clear explanation.
On Fri, Jan 17, 2014 at 04:21:49PM -0600, Serge Hallyn wrote:
[...]
> When you're not allowed to set clone_children, it is likely because
> there are already other child cgroups. You cannot change clone_children
> in that case.
Sorry, no, this
Hello all,
since yesterday I'm testing lxc-1.0.0.beta2 on a RHEL-6.5, but I
failed to get any container to start.
I've set up a RHEL-6.5 test server with the "cgconfig" service enabled
in default configuration. When I try to start a container (with root
privileges), I get:
# lxc-start -n test -
38 matches
Mail list logo