Re: [lxc-devel] [PATCH] Changed double check in if for [x86_64]

2015-07-18 Thread S . Çağlar Onur
Hi Thomas, FYI, It's not checking the same string twice, notice the case change (X86 vs x86) Best, On Sat, Jul 18, 2015 at 4:28 PM Thomas Lamprecht t.lampre...@proxmox.com wrote: Instead of checking if it's [x86_64] twice, check for [x86_64] or [amd64] Signed-off-by: Thomas Lamprecht

[lxc-devel] [PATCH] enable cgmanager support for Travis CI

2015-05-12 Thread S . Çağlar Onur
Signed-off-by: S.Çağlar Onur cag...@10ur.org --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index dfb1ac1..974130d 100644 --- a/.travis.yml +++ b/.travis.yml @@ -5,7 +5,7 @@ compiler: before_install: - sudo add-apt-repository

Re: [lxc-devel] [PATCH] Create lxcpath if it's missing

2015-05-12 Thread S . Çağlar Onur
Hey, On Tue, May 12, 2015 at 2:43 PM, Stéphane Graber stgra...@ubuntu.com wrote: On Tue, May 12, 2015 at 02:27:48PM -0400, S.Çağlar Onur wrote: Otherwise calling list_defined_containers just after installing LXC ends up with the following error lxc: lxccontainer.c: list_defined_containers:

[lxc-devel] [PATCH] Create lxcpath if it's missing

2015-05-12 Thread S . Çağlar Onur
Otherwise calling list_defined_containers just after installing LXC ends up with the following error lxc: lxccontainer.c: list_defined_containers: 4310 No such file or directory - opendir on lxcpath $ /home/caglar/go/src/gopkg.in/lxc/go-lxc.v2/examples/list 2015/05/12 14:23:08 Defined

[lxc-devel] [PATCH] use mkdir_p instead of mkdir at do_create_container_dir

2015-05-12 Thread S . Çağlar Onur
Otherwise trying to create an unprivileged container just after installing LXC fails with following; lxc_container: lxccontainer.c: do_create_container_dir: 772 No such file or directory - failed to create container path /home/caglar/.local/share/lxc/rubik $ ./create 2015/05/12 14:37:19

Re: [lxc-devel] [PATCH 1/1] logs: introduce a thread-local 'current' lxc_config

2015-04-06 Thread S . Çağlar Onur
On Mon, Apr 6, 2015 at 11:48 AM, Stéphane Graber stgra...@ubuntu.com wrote: On Wed, Mar 11, 2015 at 10:10:55PM +, Serge Hallyn wrote: The logging code uses a global log_fd and log_level to direct logging (ERROR(), etc). While the container configuration file allows for lxc.loglevel and

Re: [lxc-devel] `top` within unprivileged container breaks host

2015-01-24 Thread S . Çağlar Onur
On Sat, Jan 24, 2015 at 2:29 PM, Stéphane Graber stgra...@ubuntu.com wrote: On Sat, Jan 24, 2015 at 02:14:15PM -0500, S.Çağlar Onur wrote: Hey Stéphane, On Fri, Jan 23, 2015 at 1:47 PM, Stéphane Graber stgra...@ubuntu.com wrote: On Fri, Jan 23, 2015 at 06:19:46PM +, Serge Hallyn wrote:

Re: [lxc-devel] `top` within unprivileged container breaks host

2015-01-24 Thread S . Çağlar Onur
Hey Stéphane, On Fri, Jan 23, 2015 at 1:47 PM, Stéphane Graber stgra...@ubuntu.com wrote: On Fri, Jan 23, 2015 at 06:19:46PM +, Serge Hallyn wrote: Quoting Mathias Gibbens (math...@calenhad.com): On Fri, 2015-01-23 at 00:48 +, Mathias Gibbens wrote: Hello, I've been testing

Re: [lxc-devel] LXC 1.1 rc1 has been released

2015-01-21 Thread S . Çağlar Onur
Hey Stéphane, On Wed, Jan 21, 2015 at 4:27 PM, Stéphane Graber stgra...@ubuntu.com wrote: Hey everyone, So after doing a fair amount of additional manual testing on it, I've just released LXC 1.1 rc1. That means that from now on, we won't be taking new features and will instead work on

Re: [lxc-devel] LXC 1.1 rc1 has been released

2015-01-21 Thread S . Çağlar Onur
On Wed, Jan 21, 2015 at 10:15 PM, S.Çağlar Onur cag...@10ur.org wrote: Hey Stéphane, On Wed, Jan 21, 2015 at 4:27 PM, Stéphane Graber stgra...@ubuntu.com wrote: Hey everyone, So after doing a fair amount of additional manual testing on it, I've just released LXC 1.1 rc1. That means that

Re: [lxc-devel] LXC 1.1 rc1 has been released

2015-01-21 Thread S . Çağlar Onur
On Wed, Jan 21, 2015 at 10:24 PM, Stéphane Graber stgra...@ubuntu.com wrote: On Wed, Jan 21, 2015 at 10:20:32PM -0500, S.Çağlar Onur wrote: On Wed, Jan 21, 2015 at 10:15 PM, S.Çağlar Onur cag...@10ur.org wrote: Hey Stéphane, On Wed, Jan 21, 2015 at 4:27 PM, Stéphane Graber

[lxc-devel] [PATCH] restore the dropped bits of 1c1bb85ad2b6 and also implement the logic suggested at https://lists.linuxcontainers.org/pipermail/lxc-devel/2014-December/010985.html

2015-01-17 Thread S . Çağlar Onur
--- config/init/common/lxc-net.in | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/config/init/common/lxc-net.in b/config/init/common/lxc-net.in index 5567fee..dcbe155 100644 --- a/config/init/common/lxc-net.in +++ b/config/init/common/lxc-net.in @@ -115,7 +115,15 @@

[lxc-devel] [PATCH] restore the dropped bits of 1c1bb85ad2b6 and also implement the logic suggested at https://lists.linuxcontainers.org/pipermail/lxc-devel/2014-December/010985.html

2015-01-17 Thread S . Çağlar Onur
Signed-off-by: S.Çağlar Onur cag...@10ur.org --- config/init/common/lxc-net.in | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/config/init/common/lxc-net.in b/config/init/common/lxc-net.in index 5567fee..dcbe155 100644 --- a/config/init/common/lxc-net.in +++

Re: [lxc-devel] [PATCH] tests: try again when waitpid() sets errno as EINTR

2014-12-04 Thread S . Çağlar Onur
On Thu, Dec 4, 2014 at 11:47 AM, Stéphane Graber stgra...@ubuntu.com wrote: On Thu, Dec 04, 2014 at 02:26:04PM +0530, Arjun Sreedharan wrote: when waitpid() is interrupted, errno is not set to the negative value -EINTR. It is set to EINTR. check against EINTR. Signed-off-by: Arjun Sreedharan

[lxc-devel] [PATCH] rmdir and lxc_unpriv returns non-negative error codes

2014-12-04 Thread S . Çağlar Onur
Signed-off-by: S.Çağlar Onur cag...@10ur.org --- src/lxc/bdev.c | 4 ++-- src/lxc/log.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/lxc/bdev.c b/src/lxc/bdev.c index 75e6896..822d62c 100644 --- a/src/lxc/bdev.c +++ b/src/lxc/bdev.c @@ -1419,7 +1419,7 @@ static int

[lxc-devel] [PATCH] add support for openvswitch bridge and restore the dropped bits of 1c1bb85ad2b6

2014-12-04 Thread S . Çağlar Onur
Signed-off-by: S.Çağlar Onur cag...@10ur.org --- config/init/common/lxc-net.in | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/config/init/common/lxc-net.in b/config/init/common/lxc-net.in index 5567fee..5ca2eb2 100644 ---

Re: [lxc-devel] [PATCH] add support for openvswitch bridge and restore the dropped bits of 1c1bb85ad2b6

2014-12-04 Thread S . Çağlar Onur
On Thu, Dec 4, 2014 at 2:15 PM, Stéphane Graber stgra...@ubuntu.com wrote: On Thu, Dec 04, 2014 at 01:21:24PM -0500, S.Çağlar Onur wrote: Signed-off-by: S.Çağlar Onur cag...@10ur.org --- config/init/common/lxc-net.in | 26 ++ 1 file changed, 22 insertions(+), 4

Re: [lxc-devel] [PATCH] add support for openvswitch bridge and restore the dropped bits of 1c1bb85ad2b6

2014-12-04 Thread S . Çağlar Onur
On Thu, Dec 4, 2014 at 3:28 PM, Stéphane Graber stgra...@ubuntu.com wrote: On Thu, Dec 04, 2014 at 03:13:44PM -0500, S.Çağlar Onur wrote: On Thu, Dec 4, 2014 at 2:15 PM, Stéphane Graber stgra...@ubuntu.com wrote: On Thu, Dec 04, 2014 at 01:21:24PM -0500, S.Çağlar Onur wrote: Signed-off-by:

Re: [lxc-devel] stable-1.0 broken on 14.04

2014-12-03 Thread S . Çağlar Onur
On Wed, Dec 3, 2014 at 12:05 PM, Stéphane Graber stgra...@ubuntu.com wrote: On Tue, Dec 02, 2014 at 10:34:56PM -0500, Stéphane Graber wrote: On Tue, Dec 02, 2014 at 10:02:34PM -0500, S.Çağlar Onur wrote: Hey, Seems like [1] is causing problems for trusty (I'm using daily stable builds)

[lxc-devel] stable-1.0 broken on 14.04

2014-12-02 Thread S . Çağlar Onur
Hey, Seems like [1] is causing problems for trusty (I'm using daily stable builds) as its AppArmor version does not understand unix directive [root@eleksi:~/eleksi(master)] /etc/init.d/apparmor reload * Reloading AppArmor profiles ppArmor parser error for /etc/apparmor.d/lxc-containers in

Re: [lxc-devel] lxc-dnsmasq user

2014-10-02 Thread S . Çağlar Onur
On Thu, Oct 2, 2014 at 5:00 PM, Dwight Engen dwight.en...@oracle.com wrote: Hi Mike, I was just wondering what the reason was for choosing to create a lxc-dnsmasq user? If I read the dnsmasq man-page right, it will normally drop privileges and switch to user 'nobody', so was there some

[lxc-devel] [PATCH] add src/python-lxc/setup.py into .gitignore

2014-09-24 Thread S . Çağlar Onur
Signed-off-by: S.Çağlar Onur cag...@10ur.org --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 2b478cd..10fe58d 100644 --- a/.gitignore +++ b/.gitignore @@ -74,6 +74,7 @@ src/lxc/legacy/lxc-ls src/lxc/lxc-user-nic src/lxc/version.h

Re: [lxc-devel] Planning for LXC 1.0.6 to be released on Wednesday

2014-09-23 Thread S . Çağlar Onur
Hey Stéphane, On Tue, Sep 23, 2014 at 12:21 AM, Stéphane Graber stgra...@ubuntu.com wrote: Hey everyone, So I've finally caught up on all the master patches and pushed everything to the stable-1.0 branch. All tests pass on all architectures and a tiny bit of manual testing didn't find any

Re: [lxc-devel] Planning for LXC 1.0.6 to be released on Wednesday

2014-09-23 Thread S . Çağlar Onur
On Wed, Sep 24, 2014 at 12:18 AM, Stéphane Graber stgra...@ubuntu.com wrote: On Wed, Sep 24, 2014 at 12:10:16AM -0400, S.Çağlar Onur wrote: Hey Stéphane, On Tue, Sep 23, 2014 at 12:21 AM, Stéphane Graber stgra...@ubuntu.com wrote: Hey everyone, So I've finally caught up on all the

[lxc-devel] images.linuxcontainers.org broken?

2014-09-17 Thread S . Çağlar Onur
Hey, Is images.linuxcontainers.org broken? It looks like it stopped generating trusty images about a month ago. [1] http://images.linuxcontainers.org/images/ubuntu/trusty/arm64/default/ Cheers, -- S.Çağlar Onur cag...@10ur.org ___ lxc-devel mailing

Re: [lxc-devel] [PATCH] handle hashed command socket names

2014-08-25 Thread S . Çağlar Onur
On Mon, Aug 25, 2014 at 9:39 AM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting S.Çağlar Onur (cag...@10ur.org): With the new hashed command socket names (e85898415c), it possible to have have something like below; [caglar@qop:~/go/src/github.com/lxc/go-lxc(master)] cat /proc/net/unix |

[lxc-devel] [PATCH] handle hashed command socket names (v2)

2014-08-25 Thread S . Çağlar Onur
With the new hashed command socket names (e85898415c), it's possible to have something like below; [caglar@qop:~/go/src/github.com/lxc/go-lxc(master)] cat /proc/net/unix | grep lxc : 0002 0001 0001 01 53465 @lxc/d086e835c86f4b8d/command [...]

[lxc-devel] [PATCH] handle hashed command socket names

2014-08-23 Thread S . Çağlar Onur
With the new hashed command socket names (e85898415c), it possible to have have something like below; [caglar@qop:~/go/src/github.com/lxc/go-lxc(master)] cat /proc/net/unix | grep lxc : 0002 0001 0001 01 53465 @lxc/d086e835c86f4b8d/command [...]

[lxc-devel] [PATCH] ignore SIGKILL (CTRL-C) and SIGQUIT (CTRL-\) - issue #313

2014-08-22 Thread S . Çağlar Onur
Signed-off-by: S.Çağlar Onur cag...@10ur.org --- src/lxc/attach.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/lxc/attach.c b/src/lxc/attach.c index 1a753c7..923c497 100644 --- a/src/lxc/attach.c +++ b/src/lxc/attach.c @@ -26,6 +26,7 @@ #include stdio.h #include

[lxc-devel] [PATCH] use lxcpath as unprivileged containers log directory

2014-08-22 Thread S . Çağlar Onur
Signed-off-by: S.Çağlar Onur cag...@10ur.org --- src/lxc/log.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/lxc/log.c b/src/lxc/log.c index d5b862e..b6b3931 100644 --- a/src/lxc/log.c +++ b/src/lxc/log.c @@ -329,11 +329,6 @@ extern int lxc_log_init(const char

Re: [lxc-devel] [PATCH 1/2] command socket: use hash if needed

2014-08-08 Thread S . Çağlar Onur
Hey Serge, On Fri, Aug 8, 2014 at 8:28 PM, Serge Hallyn serge.hal...@ubuntu.com wrote: The container command socket is an abstract unix socket containing the lxcpath and container name. Those can be too long. In that case, use the hash of the lxcpath and lxcname. Continue to use the path

[lxc-devel] [PATCH] introduce --with-distro=raspbian

2014-08-08 Thread S . Çağlar Onur
Raspberry Pi kernel finally supports all the bits required by LXC [1] This patch makes ./configure --with-distro=raspbian to install lxcbr0 based config file and upstart jobs. Also src/lxc/lxc.net now checks the existence of the lxc-dnsmasq user (and fallbacks to dnsmasq) RPI users still need

Re: [lxc-devel] [PATCH] Fix to work lxc-destroy with unprivileged containers on recent kernel

2014-07-01 Thread S . Çağlar Onur
Hey Stéphane, On Mon, Jun 30, 2014 at 10:20 PM, Stéphane Graber stgra...@ubuntu.com wrote: On Mon, Jun 30, 2014 at 10:09:49PM -0400, S.Çağlar Onur wrote: Hey there, This change set caused my go test suite to fail unexpectedly. Some of my tests produced errors like === RUN TestClone

Re: [lxc-devel] [PATCH] snapshots: move snapshot directory (v5)

2014-06-04 Thread S . Çağlar Onur
On Tue, May 27, 2014 at 5:24 PM, Serge Hallyn serge.hal...@ubuntu.com wrote: Originally we kept snapshots under /var/lib/lxcsnaps. If a separate btrfs is mounted at /var/lib/lxc, then we can't make btrfs snapshots under /var/lib/lxcsnaps. This patch moves the default directory to

Re: [lxc-devel] [PATCH] snapshots: move snapshot directory (v5)

2014-06-01 Thread S . Çağlar Onur
On Sat, May 31, 2014 at 8:11 PM, S.Çağlar Onur cag...@10ur.org wrote: On Fri, May 30, 2014 at 11:54 PM, S.Çağlar Onur cag...@10ur.org wrote: On Fri, May 30, 2014 at 6:41 PM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting Serge Hallyn (serge.hal...@ubuntu.com): Quoting S.Çağlar Onur

Re: [lxc-devel] [PATCH] snapshots: move snapshot directory (v5)

2014-05-31 Thread S . Çağlar Onur
On Fri, May 30, 2014 at 11:54 PM, S.Çağlar Onur cag...@10ur.org wrote: On Fri, May 30, 2014 at 6:41 PM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting Serge Hallyn (serge.hal...@ubuntu.com): Quoting S.Çağlar Onur (cag...@10ur.org): On Wed, May 28, 2014 at 8:32 PM, S.Çağlar Onur

Re: [lxc-devel] [PATCH] snapshots: move snapshot directory (v5)

2014-05-30 Thread S . Çağlar Onur
On Fri, May 30, 2014 at 6:41 PM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting Serge Hallyn (serge.hal...@ubuntu.com): Quoting S.Çağlar Onur (cag...@10ur.org): On Wed, May 28, 2014 at 8:32 PM, S.Çağlar Onur cag...@10ur.org wrote: Hi Serge, On Tue, May 27, 2014 at 5:24 PM, Serge

Re: [lxc-devel] [PATCH] snapshots: move snapshot directory (v5)

2014-05-28 Thread S . Çağlar Onur
Hi Serge, On Tue, May 27, 2014 at 5:24 PM, Serge Hallyn serge.hal...@ubuntu.com wrote: Originally we kept snapshots under /var/lib/lxcsnaps. If a separate btrfs is mounted at /var/lib/lxc, then we can't make btrfs snapshots under /var/lib/lxcsnaps. This patch moves the default directory to

Re: [lxc-devel] [PATCH] destroy the original container after making sure the snapshot exists (fixes #224)

2014-05-24 Thread S . Çağlar Onur
On Sat, May 24, 2014 at 6:18 PM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting S.Çağlar Onur (cag...@10ur.org): Hi, could you please add a Signed-off-by when you resend? --- src/lxc/lxccontainer.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git

Re: [lxc-devel] [PATCH] [RFC] snapshots: move snapshot directory (v3)

2014-05-24 Thread S . Çağlar Onur
Hey Serge, On Sat, May 24, 2014 at 8:15 PM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting Serge Hallyn (serge.hal...@ubuntu.com): Quoting Serge Hallyn (serge.hal...@ubuntu.com): Originally we kept snapshots under /var/lib/lxcsnaps. If a separate btrfs is mounted at /var/lib/lxc, then

[lxc-devel] [PATCH] move bdev_specs struct into lxccontainer.h to allow API users to use it

2014-05-20 Thread S . Çağlar Onur
Signed-off-by: S.Çağlar Onur cag...@10ur.org --- src/lxc/bdev.h | 17 - src/lxc/lxccontainer.h | 18 ++ 2 files changed, 18 insertions(+), 17 deletions(-) diff --git a/src/lxc/bdev.h b/src/lxc/bdev.h index 0893c11..9d03b10 100644 --- a/src/lxc/bdev.h +++

Re: [lxc-devel] [PATCH 2/3] execute: bind init.lxc.static into container

2014-05-13 Thread S . Çağlar Onur
On Tue, May 13, 2014 at 6:39 PM, Dwight Engen dwight.en...@oracle.com wrote: On Tue, 13 May 2014 11:46:00 + Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting Serge Hallyn (serge.hal...@ubuntu.com): Quoting Dwight Engen (dwight.en...@oracle.com): On Mon, 12 May 2014 18:04:00 +

[lxc-devel] [PATCH] [cosmetic] use same ifndef/define format for all headers

2014-05-08 Thread S . Çağlar Onur
Signed-off-by: S.Çağlar Onur cag...@10ur.org --- src/lxc/af_unix.h| 4 src/lxc/arguments.h | 4 ++-- src/lxc/attach.h | 4 ++-- src/lxc/attach_options.h | 4 ++-- src/lxc/caps.h | 4 ++-- src/lxc/cgroup.h | 4 ++-- src/lxc/commands.h | 4 ++--

Re: [lxc-devel] [PATCH 1/1] cgmanager: use absolute cgroup path to switch cgroups at attach

2014-05-02 Thread S . Çağlar Onur
On Fri, May 2, 2014 at 12:14 PM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting Serge Hallyn (serge.hal...@ubuntu.com): If an unprivileged user does 'lxc-start -n u1' in one login session, followed by 'lxc-attach -n u1' in another session, the attach will fail if the sessions are in

Re: [lxc-devel] [PATCH 1/1] cgmanager: use absolute cgroup path to switch cgroups at attach

2014-05-02 Thread S . Çağlar Onur
On Fri, May 2, 2014 at 4:26 PM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting S.Çağlar Onur (cag...@10ur.org): On Fri, May 2, 2014 at 12:14 PM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting Serge Hallyn (serge.hal...@ubuntu.com): If an unprivileged user does 'lxc-start -n u1'

[lxc-devel] [PATCH] fix minor typo in .gitignore

2014-04-28 Thread S . Çağlar Onur
Signed-off-by: S.Çağlar Onur cag...@10ur.org --- .gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 2c050b0..8145f81 100644 --- a/.gitignore +++ b/.gitignore @@ -79,7 +79,7 @@ src/python-lxc/lxc/__pycache__/

[lxc-devel] [PATCH] [RFC] revert 1d16785 - fixes #191

2014-04-28 Thread S . Çağlar Onur
According to Serge, we no longer need to keep cgmanager connection open. As long as my tests go it seems to be working fine. Signed-off-by: S.Çağlar Onur cag...@10ur.org --- src/lxc/start.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/lxc/start.c

[lxc-devel] [PATCH] add init.lxc to .gitignore

2014-04-04 Thread S . Çağlar Onur
Signed-off-by: S.Çağlar Onur cag...@10ur.org --- .gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 2ee10b1..2c050b0 100644 --- a/.gitignore +++ b/.gitignore @@ -43,7 +43,7 @@ templates/lxc-sshd templates/lxc-ubuntu

Re: [lxc-devel] [PATCH] RFC: commands: handle epipe

2014-03-25 Thread S . Çağlar Onur
Hey Stéphane, On Tue, Mar 25, 2014 at 6:38 PM, Stéphane Graber stgra...@ubuntu.com wrote: On Tue, Mar 25, 2014 at 03:50:06PM -0500, Serge Hallyn wrote: If we start a lxc_wait on a container while it is exiting, it is possible that we open the command socket, then the monitor closes all its

Re: [lxc-devel] [PATCH RFC] log: introduce container logging

2014-03-24 Thread S . Çağlar Onur
On Fri, Mar 21, 2014 at 4:54 PM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting S.Çağlar Onur (cag...@10ur.org): Hi Serge, On Wed, Mar 12, 2014 at 11:02 AM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting S.Çağlar Onur (cag...@10ur.org): Hi Serge, On Tue, Mar 11, 2014 at

Re: [lxc-devel] [PATCH RFC] log: introduce container logging

2014-03-21 Thread S . Çağlar Onur
Hi Serge, On Wed, Mar 12, 2014 at 11:02 AM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting S.Çağlar Onur (cag...@10ur.org): Hi Serge, On Tue, Mar 11, 2014 at 8:13 PM, Serge Hallyn serge.hal...@ubuntu.com wrote: This is not intended to be applied yet. This patch adds real

Re: [lxc-devel] [PATCH RFC] log: introduce container logging

2014-03-11 Thread S . Çağlar Onur
Hi Serge, On Tue, Mar 11, 2014 at 8:13 PM, Serge Hallyn serge.hal...@ubuntu.com wrote: This is not intended to be applied yet. This patch adds real per-container, thread-safe log preferences. Currently if a program loads two containers which both set a lxc.logfile, and start then start them

Re: [lxc-devel] [PATCH] fix fd leak in test-concurrent

2014-03-10 Thread S . Çağlar Onur
On Mon, Mar 10, 2014 at 10:58 AM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting S.Çağlar Onur (cag...@10ur.org): On Fri, Mar 7, 2014 at 5:12 PM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting Dwight Engen (dwight.en...@oracle.com): Opening a debug log for every thread at every

Re: [lxc-devel] [PATCH] fix fd leak in test-concurrent

2014-03-08 Thread S . Çağlar Onur
Hey Dwight, On Fri, Mar 7, 2014 at 6:48 PM, Dwight Engen dwight.en...@oracle.com wrote: On Fri, 7 Mar 2014 16:12:23 -0600 Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting Dwight Engen (dwight.en...@oracle.com): Opening a debug log for every thread at every iteration of test-concurrent

Re: [lxc-devel] [PATCH] fix fd leak in test-concurrent

2014-03-08 Thread S . Çağlar Onur
Hey Dwight, On Sat, Mar 8, 2014 at 9:14 PM, S.Çağlar Onur cag...@10ur.org wrote: Hey Dwight, On Fri, Mar 7, 2014 at 6:48 PM, Dwight Engen dwight.en...@oracle.com wrote: On Fri, 7 Mar 2014 16:12:23 -0600 Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting Dwight Engen

Re: [lxc-devel] [PATCH] put shared variables into thread-local storage

2014-03-06 Thread S . Çağlar Onur
On Thu, Mar 6, 2014 at 11:58 PM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting S.Çağlar Onur (cag...@10ur.org): This doesn't solve the general design problem of the log.c (eg; some log lines got lost or scattered into multiple files) but at least prevent multithreaded code from

[lxc-devel] [PATCH] add shared lxc_log_fd into TLS

2014-03-06 Thread S . Çağlar Onur
Signed-off-by: S.Çağlar Onur cag...@10ur.org --- src/lxc/log.c | 3 ++- src/lxc/log.h | 6 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/lxc/log.c b/src/lxc/log.c index 1dd1aa8..a9f98a4 100644 --- a/src/lxc/log.c +++ b/src/lxc/log.c @@ -40,8 +40,8 @@ #define

[lxc-devel] [PATCH] Call dbus_threads_init_default before doing any other dbus calls

2014-03-05 Thread S . Çağlar Onur
Otherwise concurrent start/stop operations fails Signed-off-by: S.Çağlar Onur cag...@10ur.org --- src/lxc/cgmanager.c | 4 1 file changed, 4 insertions(+) diff --git a/src/lxc/cgmanager.c b/src/lxc/cgmanager.c index e7407d8..b4abb47 100644 --- a/src/lxc/cgmanager.c +++

Re: [lxc-devel] Priorities for LXC 1.0.1

2014-03-05 Thread S . Çağlar Onur
On Wed, Mar 5, 2014 at 11:08 PM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting S.Çağlar Onur (cag...@10ur.org): On Wed, Mar 5, 2014 at 3:58 PM, Stéphane Graber stgra...@ubuntu.com wrote: On Wed, Mar 05, 2014 at 10:38:49AM -0500, Stéphane Graber wrote: On Tue, Feb 25, 2014 at 07:53:06PM

Re: [lxc-devel] Priorities for LXC 1.0.1

2014-03-05 Thread S . Çağlar Onur
On Wed, Mar 5, 2014 at 11:16 PM, S.Çağlar Onur cag...@10ur.org wrote: On Wed, Mar 5, 2014 at 11:08 PM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting S.Çağlar Onur (cag...@10ur.org): On Wed, Mar 5, 2014 at 3:58 PM, Stéphane Graber stgra...@ubuntu.com wrote: On Wed, Mar 05, 2014 at

Re: [lxc-devel] [PATCH] use btrfs snapshot feature to restore snapshots (fixes #131)

2014-02-28 Thread S . Çağlar Onur
Hi, On Fri, Feb 28, 2014 at 12:57 PM, John Peacock jpeac...@messagesystems.com wrote: On Fri, 2014-02-28 at 11:52 -0600, Serge Hallyn wrote: + if (bdevtype strcmp(orig-type, btrfs) == 0 strcmp(new-type, btrfs) == 0) { Is it possible to hit this case when a user does lxc-clone -p

Re: [lxc-devel] possible lxc-attach problem

2014-02-28 Thread S . Çağlar Onur
On Fri, Feb 28, 2014 at 12:20 PM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting Serge Hallyn (serge.hal...@ubuntu.com): It seems to me these are the right things to do, but they'll take some experimentation with the many possible hosts: 1. If / is not shared, do nothing 2. if / is

Re: [lxc-devel] [PATCH] use btrfs snapshot feature to restore snapshots (v2)

2014-02-28 Thread S . Çağlar Onur
On Fri, Feb 28, 2014 at 7:14 PM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting S.Çağlar Onur (cag...@10ur.org): fixes #131 changes since v1; * uses btrfs snapshot feature only if src and dest are on same fs Signed-off-by: S.Çağlar Onur cag...@10ur.org Thanks! Looks good except for

Re: [lxc-devel] possible lxc-attach problem

2014-02-28 Thread S . Çağlar Onur
On Fri, Feb 28, 2014 at 7:21 PM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): On Fri, Feb 28, 2014 at 06:11:25PM -0600, Serge Hallyn wrote: Quoting S.Çağlar Onur (cag...@10ur.org): On Fri, Feb 28, 2014 at 12:20 PM, Serge Hallyn

[lxc-devel] [PATCH] do not crash if specs is NULL

2014-02-27 Thread S . Çağlar Onur
Signed-off-by: S.Çağlar Onur cag...@10ur.org --- src/lxc/bdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/bdev.c b/src/lxc/bdev.c index 18f1770..627c09a 100644 --- a/src/lxc/bdev.c +++ b/src/lxc/bdev.c @@ -484,7 +484,7 @@ static int dir_destroy(struct bdev *orig)

[lxc-devel] possible lxc-attach problem

2014-02-27 Thread S . Çağlar Onur
Hi, I was working on Fedora 20 system to investigate a possible go bindings bug and realized that lxc-attach is not working as I expected. [1] is some output captured with LXC@master on top of Fedora 20 running a Fedora 20 container. I haven't tested this on my ubuntu machine and I'm wondering if

[lxc-devel] [PATCH] hash command unix socket name

2014-02-19 Thread S . Çağlar Onur
Signed-off-by: S.Çağlar Onur cag...@10ur.org --- src/lxc/commands.c | 33 +++-- 1 file changed, 27 insertions(+), 6 deletions(-) diff --git a/src/lxc/commands.c b/src/lxc/commands.c index 6b46c2c..dbfa23e 100644 --- a/src/lxc/commands.c +++ b/src/lxc/commands.c @@

[lxc-devel] [PATCH] hash command unix socket name (v2)

2014-02-19 Thread S . Çağlar Onur
Changes since v1; * Address Stéphane's comments Signed-off-by: S.Çağlar Onur cag...@10ur.org --- src/lxc/commands.c | 34 +- 1 file changed, 29 insertions(+), 5 deletions(-) diff --git a/src/lxc/commands.c b/src/lxc/commands.c index 6b46c2c..e5d8a8e 100644 ---

Re: [lxc-devel] [PATCH] hash command unix socket name (v2)

2014-02-19 Thread S . Çağlar Onur
Hmm just realized that this breaks list_active_containers as it parses /proc/unix/net to find names. So please ignore this for 1.0 as it's too risky. Will try to address that incoming days. On Wed, Feb 19, 2014 at 5:09 PM, S.Çağlar Onur cag...@10ur.org wrote: Changes since v1; * Address

[lxc-devel] [PATCH] fix aufs mount for some fs types via adding the xino parameter

2014-02-19 Thread S . Çağlar Onur
Signed-off-by: S.Çağlar Onur cag...@10ur.org --- src/lxc/bdev.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/src/lxc/bdev.c b/src/lxc/bdev.c index 67fe72b..a06ad52 100644 --- a/src/lxc/bdev.c +++ b/src/lxc/bdev.c @@ -2064,7 +2064,7 @@ static int

[lxc-devel] [PATCH] close correct side of the pipe and increase buffer size by one to handle \n

2014-02-17 Thread S . Çağlar Onur
Signed-off-by: S.Çağlar Onur cag...@10ur.org --- src/lxc/conf.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/lxc/conf.c b/src/lxc/conf.c index 10f46ae..175a82f 100644 --- a/src/lxc/conf.c +++ b/src/lxc/conf.c @@ -3011,13 +3011,14 @@ void

[lxc-devel] [PATCH] move fnv_64a_buf to utils.c and remove mutliple copies

2014-02-13 Thread S . Çağlar Onur
Signed-off-by: S.Çağlar Onur cag...@10ur.org --- src/lxc/conf.c| 32 src/lxc/monitor.c | 25 - src/lxc/utils.c | 26 +- src/lxc/utils.h | 3 +++ 4 files changed, 28 insertions(+), 58 deletions(-) diff --git

[lxc-devel] [PATCH] find veth name for unprivileged containers

2014-02-13 Thread S . Çağlar Onur
unprivileged containers uses lxc-user-nic to create the underlying network. And because of that reason netdev struct misses some information (like the name of the interface seen from the host side) Find that information by parsing /proc/self/net/dev and return to caller. With this patch lxc-info

Re: [lxc-devel] [PATCH] export lxc_cmd_get_config_item via API and use in for lxc-info

2014-01-27 Thread S . Çağlar Onur
On Jan 27, 2014 4:31 AM, Stéphane Graber stgra...@ubuntu.com wrote: On Mon, Jan 27, 2014 at 12:59:53AM -0500, S.Çağlar Onur wrote: This allows external users to query network related config items from the running containers. Signed-off-by: S.Çağlar Onur cag...@10ur.org Looks

[lxc-devel] [PATCH] close the fd on error

2014-01-24 Thread S . Çağlar Onur
Signed-off-by: S.Çağlar Onur cag...@10ur.org --- src/lxc/lxccontainer.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/lxc/lxccontainer.c b/src/lxc/lxccontainer.c index fbf0824..6ea7c11 100644 --- a/src/lxc/lxccontainer.c +++ b/src/lxc/lxccontainer.c @@ -2486,8

Re: [lxc-devel] [PATCH 1/1] lxcapi_get_interfaces and lxcapi_get_ips: stricter read check

2014-01-22 Thread S . Çağlar Onur
On Wed, Jan 22, 2014 at 2:19 PM, Serge Hallyn serge.hal...@ubuntu.com wrote: Coverity warns of the danger of a short read otherwise. (Untested, but should be correct; Tossing over to you :) Cc: S.Çağlar Onur cag...@10ur.org Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Acked-by:

Re: [lxc-devel] [PATCH 1/1] cgmanager: implement setting of cgroup limits

2014-01-21 Thread S . Çağlar Onur
Hey Serge, On Mon, Jan 20, 2014 at 10:09 AM, Serge Hallyn serge.hal...@ubuntu.com wrote: Also replace a wrong free of nih-allocated variable with nih_free. Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Looks like after this commit unprivileged containers are not starting while using

Re: [lxc-devel] [PATCH] make lxcapi_get_interfaces and lxcapi_get_ips unprivileged container aware

2014-01-21 Thread S . Çağlar Onur
On Tue, Jan 21, 2014 at 11:38 PM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): On Tue, Jan 21, 2014 at 09:36:06PM -0500, S.Çağlar Onur wrote: On Tue, Jan 21, 2014 at 6:41 PM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting S.Çağlar Onur

Re: [lxc-devel] Unprivileged setns

2014-01-20 Thread S . Çağlar Onur
Hi Stéphane, On Mon, Jan 20, 2014 at 4:06 PM, S.Çağlar Onur cag...@10ur.org wrote: Hi Stéphane, On Mon, Jan 20, 2014 at 3:08 PM, Stéphane Graber stgra...@ubuntu.com wrote: Hey everyone, So I spent some time this morning trying to figure out if setns to unprivileged containers was even

[lxc-devel] [PATCH] make lxcapi_get_interfaces and lxcapi_get_ips unprivileged container aware

2014-01-20 Thread S . Çağlar Onur
Based on Stéphane's suggestion, those two API methods now; * fork a new process, * switch to appropriate namespace(s), * do what we want, * return the data over a pipe to the parent which returns the result to the original caller. For the whole thread please see;

[lxc-devel] [PATCH] remove no-longer neeeded check from lxcapi_attach_run_waitl

2014-01-20 Thread S . Çağlar Onur
commit f4364484454c754ed905bfb85bd2727a0a5d0475 introduced attach functionality to unprivileged containers so remove this check like the rest of the attach functions. Signed-off-by: S.Çağlar Onur cag...@10ur.org --- src/lxc/lxccontainer.c | 5 - 1 file changed, 5 deletions(-) diff --git

Re: [lxc-devel] [PATCH] exclude non-existing signals from the loop

2014-01-17 Thread S . Çağlar Onur
On Fri, Jan 17, 2014 at 9:24 AM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting Qiang Huang (h.huangqi...@huawei.com): On 2014/1/17 5:38, Serge Hallyn wrote: Quoting S.Çağlar Onur (cag...@10ur.org): On Thu, Jan 16, 2014 at 4:24 PM, Serge Hallyn serge.hal...@ubuntu.com wrote:

Re: [lxc-devel] [PATCH] handle unprivileged user calls more gracefully (v2)

2014-01-17 Thread S . Çağlar Onur
On Fri, Jan 17, 2014 at 11:49 PM, Stéphane Graber stgra...@ubuntu.com wrote: On Fri, Jan 17, 2014 at 11:34:50PM -0500, S.Çağlar Onur wrote: Return an error if the function is not supposed to be called by an unprivileged user. Otherwise those calls fail in the middle of their execution with

Re: [lxc-devel] [PATCH] handle unprivileged user calls more gracefully (v2)

2014-01-17 Thread S . Çağlar Onur
On Sat, Jan 18, 2014 at 12:12 AM, Stéphane Graber stgra...@ubuntu.com wrote: On Sat, Jan 18, 2014 at 12:03:19AM -0500, S.Çağlar Onur wrote: On Sat, Jan 18, 2014 at 12:00 AM, Stéphane Graber stgra...@ubuntu.com wrote: On Fri, Jan 17, 2014 at 11:58:17PM -0500, S.Çağlar Onur wrote: On Fri,

Re: [lxc-devel] [PATCH] exclude non-existing signals from the loop

2014-01-16 Thread S . Çağlar Onur
On Thu, Jan 16, 2014 at 4:38 PM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting S.Çağlar Onur (cag...@10ur.org): On Thu, Jan 16, 2014 at 4:24 PM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting S.Çağlar Onur (cag...@10ur.org): 32 and 33 are not defined and causing sigaction to

[lxc-devel] [PATCH] skip rootfs pinning for unprivileged containers

2014-01-15 Thread S . Çağlar Onur
Signed-off-by: S.Çağlar Onur cag...@10ur.org --- src/lxc/start.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/lxc/start.c b/src/lxc/start.c index 6c07e43..fbdfc05 100644 --- a/src/lxc/start.c +++ b/src/lxc/start.c @@ -782,11 +782,14 @@ static int

Re: [lxc-devel] [PATCH 1/1] Initial support for cgmanager

2014-01-15 Thread S . Çağlar Onur
Hi Serge, On Wed, Jan 15, 2014 at 12:19 PM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): On Tue, Jan 14, 2014 at 04:41:36PM -0600, Serge Hallyn wrote: This patch splits out most of the cgroupfs-specific code, so that cgroup-manager versions can

Re: [lxc-devel] Last minute template addition - universal image based template

2014-01-14 Thread S . Çağlar Onur
Hey Stéphane, On Tue, Jan 14, 2014 at 6:52 PM, Stéphane Graber stgra...@ubuntu.com wrote: On Tue, Jan 14, 2014 at 06:38:43PM -0500, Dwight Engen wrote: On Mon, 13 Jan 2014 20:56:23 -0500 Stéphane Graber stgra...@ubuntu.com wrote: [...] Yeah, I did a few last-minute changes. fstab is

Re: [lxc-devel] Last minute template addition - universal image based template

2014-01-14 Thread S . Çağlar Onur
On Tue, Jan 14, 2014 at 9:24 PM, Stéphane Graber stgra...@ubuntu.com wrote: On Tue, Jan 14, 2014 at 09:12:31PM -0500, S.Çağlar Onur wrote: Hey Stéphane, On Tue, Jan 14, 2014 at 6:52 PM, Stéphane Graber stgra...@ubuntu.com wrote: On Tue, Jan 14, 2014 at 06:38:43PM -0500, Dwight Engen wrote:

Re: [lxc-devel] Last minute template addition - universal image based template

2014-01-14 Thread S . Çağlar Onur
On Tue, Jan 14, 2014 at 9:50 PM, Stéphane Graber stgra...@ubuntu.com wrote: On Tue, Jan 14, 2014 at 09:48:13PM -0500, Stéphane Graber wrote: On Tue, Jan 14, 2014 at 09:30:50PM -0500, S.Çağlar Onur wrote: On Tue, Jan 14, 2014 at 9:24 PM, Stéphane Graber stgra...@ubuntu.com wrote: On Tue,

Re: [lxc-devel] Last minute template addition - universal image based template

2014-01-10 Thread S . Çağlar Onur
Hey Stéphane, On Fri, Jan 10, 2014 at 3:10 PM, Stéphane Graber stgra...@ubuntu.com wrote: Hey everyone, First of all, sorry for coming up with that so late in the 1.0 development cycle. I tried to convince myself for a long time that this wasn't necessary but reality is that with

Re: [lxc-devel] [PATCH] hwaddr templating

2014-01-06 Thread S . Çağlar Onur
On Mon, Jan 6, 2014 at 11:46 AM, Serge Hallyn serge.hal...@ubuntu.com wrote: Quoting Serge Hallyn (serge.hal...@ubuntu.com): Quoting Guillaume ZITTA (l...@zitta.fr): This change introduce mac address templating. By setting lxc.network.hwaddr to something like fe:xx:xx:xx:xx:xx each x

Re: [lxc-devel] [PATCH] Use pthread_atfork() to unlock mutexes after fork()

2014-01-03 Thread S . Çağlar Onur
Hi, On Fri, Jan 3, 2014 at 3:13 PM, Stéphane Graber stgra...@ubuntu.com wrote: On Thu, Jan 02, 2014 at 08:59:10AM -0600, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): On Wed, Jan 01, 2014 at 11:37:32PM -0600, Serge Hallyn wrote: Quoting Stéphane Graber

Re: [lxc-devel] [PATCH] Use pthread_atfork() to unlock mutexes after fork()

2014-01-03 Thread S . Çağlar Onur
Hi, On Fri, Jan 3, 2014 at 4:32 PM, Stéphane Graber stgra...@ubuntu.com wrote: On Fri, Jan 03, 2014 at 04:22:51PM -0500, S.Çağlar Onur wrote: Hi, On Fri, Jan 3, 2014 at 3:13 PM, Stéphane Graber stgra...@ubuntu.com wrote: On Thu, Jan 02, 2014 at 08:59:10AM -0600, Serge Hallyn wrote:

[lxc-devel] [PATCH] check pthread_atfork and thread-local storage support

2014-01-03 Thread S . Çağlar Onur
This patch; Adds pthread_atfork check to configure.ac and uses it when necessary, Introduces tls.m4 macro for checking thread-local storage support, Puts values array into thread-local storage (lxc_global_config_value@src/lxc/utils.c), Removes static_lock/static_unlock from LXC code, Lastly, it

Re: [lxc-devel] [Errored] caglar10ur/lxc-upstream#8 (master - 9a97d4e)

2014-01-02 Thread S . Çağlar Onur
Hi Stéphane, On Wed, Jan 1, 2014 at 5:14 PM, S.Çağlar Onur cag...@10ur.org wrote: Hey Stéphane, On Wed, Jan 1, 2014 at 4:47 PM, Stéphane Graber stgra...@ubuntu.com wrote: Caglar, any chance you can drop that travis job so we don't get notified twice of every failure? Ah of course, I

Re: [lxc-devel] [Errored] caglar10ur/lxc-upstream#8 (master - 9a97d4e)

2014-01-01 Thread S . Çağlar Onur
Hey Stéphane, On Wed, Jan 1, 2014 at 4:47 PM, Stéphane Graber stgra...@ubuntu.com wrote: Caglar, any chance you can drop that travis job so we don't get notified twice of every failure? Ah of course, I thought I already disabled the travis for my fork but apparently I haven't. Doing now...

Re: [lxc-devel] [PATCH] CentOS and Fedora Templates: Harden root passwords and add static MAC network addresses.

2013-12-31 Thread S . Çağlar Onur
Hi Michael, On Thu, Dec 26, 2013 at 6:08 PM, Michael H. Warfield m...@wittsend.com wrote: CentOS and Fedora Templates: Harden root passwords and add static MAC network addresses. 1) Add logic to root password setting. Root password is now set to Root-${name}-${RANDOM} to defeat

Re: [lxc-devel] nested containers

2013-12-27 Thread S . Çağlar Onur
Hey Pauk, On Fri, Dec 27, 2013 at 6:49 PM, Paul Wexler p...@prometheusresearch.com wrote: Hello lxc community, Has anyone used nested containers? I am trying with limited success. I cannot re-start them. I can: 1. create a container. 2. configure it for nesting (I uncomment 2 lines

[lxc-devel] [PATCH] add travis-ci support to LXC github repo (v2)

2013-12-24 Thread S . Çağlar Onur
Travis is a free hosted CI platform for the open source community. It integrates well with github and enables continous builds/tests for both repository itself and all the pull requests so that one can quickly see the result of the possible merge. This yml file is one of the few required steps to

  1   2   >