The following pull request was submitted through Github. It can be accessed and reviewed at: https://github.com/lxc/lxc/pull/1102
This e-mail was sent by the LXC bot, direct replies will not reach the author unless they happen to be subscribed to this list. === Description (from pull-request) === The process created by lxc-attach has incorrect cgroup ns. It fails lxc-checkpoint as reported in [criu issue](https://github.com/xemul/criu/issues/174). A real example for this issue, which is used to update ip address: 1. start lxc instance with debian image 2. lxc-attach -n <lxc name> -- service networking restart 3. lxc-checkpoint -n <lxc name> -D <dump dir> lxc-checkpoint will fail because dhclient process has incorrect cgroup ns. It needs to use setns instead of unshare to set cgroup ns. "setns" already supports cgroup ns in kernel of ubuntu 16.04.
<!DOCTYPE html> <html lang="en" class=""> <head prefix="og: http://ogp.me/ns# fb: http://ogp.me/ns/fb# object: http://ogp.me/ns/object# article: http://ogp.me/ns/article# profile: http://ogp.me/ns/profile#";> <meta charset='utf-8'> <link crossorigin="anonymous" href="https://assets-cdn.github.com/assets/frameworks-5fc7c6e8cf4372103a3e557a9fd70de7ffb44c643a350ece5b400060b64141e7.css"; media="all" rel="stylesheet" /> <link crossorigin="anonymous" href="https://assets-cdn.github.com/assets/github-54376e73a24bff19599f19fe4524211d26a13a89e0a3662bd707496b1f918579.css"; media="all" rel="stylesheet" /> <link crossorigin="anonymous" href="https://assets-cdn.github.com/assets/site-f4b3d32cffc56de06873b8a6d88ae6139de92dc0fc31574232803d68729f6fac.css"; media="all" rel="stylesheet" /> <link as="script" href="https://assets-cdn.github.com/assets/frameworks-404cdd1add1f710db016a02e5e31fff8a9089d14ff0c227df862b780886db7d5.js"; rel="preload" /> <link as="script" href="https://assets-cdn.github.com/assets/github-3f5d9e94c6a78a31e0a2e7d99731e864821a0cdbd82d28bc6948ef8cc4675f0b.js"; rel="preload" /> <meta http-equiv="X-UA-Compatible" content="IE=edge"> <meta http-equiv="Content-Language" content="en"> <meta name="viewport" content="width=device-width"> <title>setns instead of unshare in lxc-attach by chenhaiq · Pull Request #1102 · lxc/lxc · GitHub</title> <link rel="search" type="application/opensearchdescription+xml" href="/opensearch.xml" title="GitHub"> <link rel="fluid-icon" href="https://github.com/fluidicon.png"; title="GitHub"> <link rel="apple-touch-icon" href="/apple-touch-icon.png"> <link rel="apple-touch-icon" sizes="57x57" href="/apple-touch-icon-57x57.png"> <link rel="apple-touch-icon" sizes="60x60" href="/apple-touch-icon-60x60.png"> <link rel="apple-touch-icon" sizes="72x72" href="/apple-touch-icon-72x72.png"> <link rel="apple-touch-icon" sizes="76x76" href="/apple-touch-icon-76x76.png"> <link rel="apple-touch-icon" sizes="114x114" href="/apple-touch-icon-114x114.png"> <link rel="apple-touch-icon" sizes="120x120" href="/apple-touch-icon-120x120.png"> <link rel="apple-touch-icon" sizes="144x144" href="/apple-touch-icon-144x144.png"> <link rel="apple-touch-icon" sizes="152x152" href="/apple-touch-icon-152x152.png"> <link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon-180x180.png"> <meta property="fb:app_id" content="1401488693436528"> <meta content="https://avatars3.githubusercontent.com/u/4373761?v=3&s=400"; name="twitter:image:src" /><meta content="@github" name="twitter:site" /><meta content="summary" name="twitter:card" /><meta content="setns instead of unshare in lxc-attach by chenhaiq · Pull Request #1102 · lxc/lxc" name="twitter:title" /><meta content="The process created by lxc-attach has incorrect cgroup ns. It fails lxc-checkpoint as reported in criu issue. A real example for this issue, which is used to update ip address: start lxc instance..." name="twitter:description" /> <meta content="https://avatars3.githubusercontent.com/u/4373761?v=3&s=400"; property="og:image" /><meta content="GitHub" property="og:site_name" /><meta content="object" property="og:type" /><meta content="setns instead of unshare in lxc-attach by chenhaiq · Pull Request #1102 · lxc/lxc" property="og:title" /><meta content="https://github.com/lxc/lxc/pull/1102"; property="og:url" /><meta content="The process created by lxc-attach has incorrect cgroup ns. It fails lxc-checkpoint as reported in criu issue. A real example for this issue, which is used to update ip address: start lxc instance..." property="og:description" /> <meta name="browser-stats-url" content="https://api.github.com/_private/browser/stats";> <meta name="browser-errors-url" content="https://api.github.com/_private/browser/errors";> <link rel="assets" href="https://assets-cdn.github.com/";> <meta name="pjax-timeout" content="1000"> <meta name="msapplication-TileImage" content="/windows-tile.png"> <meta name="msapplication-TileColor" content="#ffffff"> <meta name="selected-link" value="repo_pulls" data-pjax-transient> <meta name="google-site-verification" content="KT5gs8h0wvaagLKAVWq8bbeNwnZZK1r1XQysX3xurLU"> <meta name="google-site-verification" content="ZzhVyEFwb7w3e0-uOTltm8Jsck2F5StVihD0exw2fsA"> <meta name="google-analytics" content="UA-3769691-2"> <meta content="collector.githubapp.com" name="octolytics-host" /><meta content="github" name="octolytics-app-id" /><meta content="95389400:37EE:28A865B:5798CEC2" name="octolytics-dimension-request_id" /> <meta content="/<user-name>/<repo-name>/pull_requests/show" data-pjax-transient="true" name="analytics-location" /> <meta class="js-ga-set" name="dimension1" content="Logged Out"> <meta name="hostname" content="github.com"> <meta name="user-login" content=""> <meta name="expected-hostname" content="github.com"> <meta name="js-proxy-site-detection-payload" content="NGU0NTYwOWZiNTc1OTg5MTE3NDA3ZDQyMGE0YTI2YzdiOWZlMmJjZDZhNWM2Y2U0NzNhYzc2NWUzM2Y5MjVjMnx7InJlbW90ZV9hZGRyZXNzIjoiMTQ5LjU2LjE0OC4wIiwicmVxdWVzdF9pZCI6Ijk1Mzg5NDAwOjM3RUU6MjhBODY1Qjo1Nzk4Q0VDMiIsInRpbWVzdGFtcCI6MTQ2OTYzMjE5NH0="> <link rel="mask-icon" href="https://assets-cdn.github.com/pinned-octocat.svg"; color="#4078c0"> <link rel="icon" type="image/x-icon" href="https://assets-cdn.github.com/favicon.ico";> <meta name="html-safe-nonce" content="e9f7da4b6358c834f7874fc08a00326c468fdde5"> <meta content="4a6252b86ab51151d851e7df9b4c8066b5c638f0" name="form-nonce" /> <meta http-equiv="x-pjax-version" content="6690a24c5af99934add8d7b87404231d"> <style type="text/css" media="screen"> span.labelstyle-006b75, .linked-labelstyle-006b75 { background-color: #006b75 !important; color: #fff !important;}.labelstyle-006b75.selected { background-color: #006b75 !important; color: #fff !important;}.label-select-menu .labelstyle-006b75.selected { background:rgba(0, 107, 117, 0.12) !important; color: #008b99 !important;} span.labelstyle-eb6420, .linked-labelstyle-eb6420 { background-color: #eb6420 !important; color: #fff !important;}.labelstyle-eb6420.selected { background-color: #eb6420 !important; color: #fff !important;}.label-select-menu .labelstyle-eb6420.selected { background:rgba(235, 100, 32, 0.12) !important; color: #994114 !important;} span.labelstyle-009800, .linked-labelstyle-009800 { background-color: #009800 !important; color: #fff !important;}.labelstyle-009800.selected { background-color: #009800 !important; color: #fff !important;}.label-select-menu .labelstyle-009800.selected { background:rgba(0, 152, 0, 0.12) !important; color: #009900 !important;} span.labelstyle-84b6eb, .linked-labelstyle-84b6eb { background-color: #84b6eb !important; color: #1c2733 !important;}.labelstyle-84b6eb.selected { background-color: #84b6eb !important; color: #1c2733 !important;}.label-select-menu .labelstyle-84b6eb.selected { background:rgba(132, 182, 235, 0.12) !important; color: #557699 !important;} span.labelstyle-5319e7, .linked-labelstyle-5319e7 { background-color: #5319e7 !important; color: #fff !important;}.labelstyle-5319e7.selected { background-color: #5319e7 !important; color: #fff !important;}.label-select-menu .labelstyle-5319e7.selected { background:rgba(83, 25, 231, 0.12) !important; color: #361099 !important;} span.labelstyle-e6e6e6, .linked-labelstyle-e6e6e6 { background-color: #e6e6e6 !important; color: #333333 !important;}.labelstyle-e6e6e6.selected { background-color: #e6e6e6 !important; color: #333333 !important;}.label-select-menu .labelstyle-e6e6e6.selected { background:rgba(230, 230, 230, 0.12) !important; color: #999999 !important;} span.labelstyle-e11d21, .linked-labelstyle-e11d21 { background-color: #e11d21 !important; color: #fff !important;}.labelstyle-e11d21.selected { background-color: #e11d21 !important; color: #fff !important;}.label-select-menu .labelstyle-e11d21.selected { background:rgba(225, 29, 33, 0.12) !important; color: #991316 !important;} span.labelstyle-fbca04, .linked-labelstyle-fbca04 { background-color: #fbca04 !important; color: #332900 !important;}.labelstyle-fbca04.selected { background-color: #fbca04 !important; color: #332900 !important;}.label-select-menu .labelstyle-fbca04.selected { background:rgba(251, 202, 4, 0.12) !important; color: #997b02 !important;} </style> <meta name="description" content="lxc - LXC - Linux Containers"> <meta name="go-import" content="github.com/lxc/lxc git https://github.com/lxc/lxc.git";> <meta content="2301756" name="octolytics-dimension-user_id" /><meta content="lxc" name="octolytics-dimension-user_login" /><meta content="5720995" name="octolytics-dimension-repository_id" /><meta content="lxc/lxc" name="octolytics-dimension-repository_nwo" /><meta content="true" name="octolytics-dimension-repository_public" /><meta content="false" name="octolytics-dimension-repository_is_fork" /><meta content="5720995" name="octolytics-dimension-repository_network_root_id" /><meta content="lxc/lxc" name="octolytics-dimension-repository_network_root_nwo" /> <link href="https://github.com/lxc/lxc/commits/master.atom"; rel="alternate" title="Recent Commits to lxc:master" type="application/atom+xml"> </head> <body class="logged-out env-production vis-public"> <div id="js-pjax-loader-bar" class="pjax-loader-bar"></div> <a href="#start-of-content" tabindex="1" class="accessibility-aid js-skip-to-content">Skip to content</a> <header class="site-header js-details-container" role="banner"> <div class="container-responsive"> <a class="header-logo-invertocat" href="https://github.com/"; aria-label="Homepage" data-ga-click="(Logged out) Header, go to homepage, icon:logo-wordmark"> <svg aria-hidden="true" class="octicon octicon-mark-github" height="32" version="1.1" viewBox="0 0 16 16" width="32"><path d="M8 0C3.58 0 0 3.58 0 8c0 3.54 2.29 6.53 5.47 7.59.4.07.55-.17.55-.38 0-.19-.01-.82-.01-1.49-2.01.37-2.53-.49-2.69-.94-.09-.23-.48-.94-.82-1.13-.28-.15-.68-.52-.01-.53.63-.01 1.08.58 1.23.82.72 1.21 1.87.87 2.33.66.07-.52.28-.87.51-1.07-1.78-.2-3.64-.89-3.64-3.95 0-.87.31-1.59.82-2.15-.08-.2-.36-1.02.08-2.12 0 0 .67-.21 2.2.82.64-.18 1.32-.27 2-.27.68 0 1.36.09 2 .27 1.53-1.04 2.2-.82 2.2-.82.44 1.1.16 1.92.08 2.12.51.56.82 1.27.82 2.15 0 3.07-1.87 3.75-3.65 3.95.29.25.54.73.54 1.48 0 1.07-.01 1.93-.01 2.2 0 .21.15.46.55.38A8.013 8.013 0 0 0 16 8c0-4.42-3.58-8-8-8z"></path></svg> </a> <button class="btn-link right site-header-toggle js-details-target" type="button" aria-label="Toggle navigation"> <svg aria-hidden="true" class="octicon octicon-three-bars" height="24" version="1.1" viewBox="0 0 12 16" width="18"><path d="M11.41 9H.59C0 9 0 8.59 0 8c0-.59 0-1 .59-1H11.4c.59 0 .59.41.59 1 0 .59 0 1-.59 1h.01zm0-4H.59C0 5 0 4.59 0 4c0-.59 0-1 .59-1H11.4c.59 0 .59.41.59 1 0 .59 0 1-.59 1h.01zM.59 11H11.4c.59 0 .59.41.59 1 0 .59 0 1-.59 1H.59C0 13 0 12.59 0 12c0-.59 0-1 .59-1z"></path></svg> </button> <div class="site-header-menu"> <nav class="site-header-nav site-header-nav-main"> <a href="/personal" class="js-selected-navigation-item nav-item nav-item-personal" data-ga-click="Header, click, Nav menu - item:personal" data-selected-links="/personal /personal"> Personal </a> <a href="/open-source" class="js-selected-navigation-item nav-item nav-item-opensource" data-ga-click="Header, click, Nav menu - item:opensource" data-selected-links="/open-source /open-source"> Open source </a> <a href="/business" class="js-selected-navigation-item nav-item nav-item-business" data-ga-click="Header, click, Nav menu - item:business" data-selected-links="/business /business/features /business/customers /business"> Business </a> <a href="/explore" class="js-selected-navigation-item nav-item nav-item-explore" data-ga-click="Header, click, Nav menu - item:explore" data-selected-links="/explore /trending /trending/developers /integrations /integrations/feature/code /integrations/feature/collaborate /integrations/feature/ship /explore"> Explore </a> </nav> <div class="site-header-actions"> <a class="btn btn-primary site-header-actions-btn" href="/join?source=header-repo" data-ga-click="(Logged out) Header, clicked Sign up, text:sign-up">Sign up</a> <a class="btn site-header-actions-btn mr-2" href="/login?return_to=%2Flxc%2Flxc%2Fpull%2F1102" data-ga-click="(Logged out) Header, clicked Sign in, text:sign-in">Sign in</a> </div> <nav class="site-header-nav site-header-nav-secondary"> <a class="nav-item" href="/pricing">Pricing</a> <a class="nav-item" href="/blog">Blog</a> <a class="nav-item" href="https://help.github.com";>Support</a> <a class="nav-item header-search-link" href="https://github.com/search";>Search GitHub</a> <div class="header-search scoped-search site-scoped-search js-site-search" role="search"> <!-- </textarea> --><!-- '"` --><form accept-charset="UTF-8" action="/lxc/lxc/search" class="js-site-search-form" data-scoped-search-url="/lxc/lxc/search" data-unscoped-search-url="/search" method="get"><div style="margin:0;padding:0;display:inline"><input name="utf8" type="hidden" value="✓" /></div> <label class="form-control header-search-wrapper js-chromeless-input-container"> <div class="header-search-scope">This repository</div> <input type="text" class="form-control header-search-input js-site-search-focus js-site-search-field is-clearable" data-hotkey="s" name="q" placeholder="Search" aria-label="Search this repository" data-unscoped-placeholder="Search GitHub" data-scoped-placeholder="Search" autocapitalize="off"> </label> </form></div> </nav> </div> </div> </header> <div id="start-of-content" class="accessibility-aid"></div> <div id="js-flash-container"> </div> <div role="main"> <div itemscope itemtype="http://schema.org/SoftwareSourceCode";> <div id="js-repo-pjax-container" data-pjax-container> <div class="pagehead repohead instapaper_ignore readability-menu experiment-repo-nav"> <div class="container repohead-details-container"> <ul class="pagehead-actions"> <li> <a href="/login?return_to=%2Flxc%2Flxc" class="btn btn-sm btn-with-count tooltipped tooltipped-n" aria-label="You must be signed in to watch a repository" rel="nofollow"> <svg aria-hidden="true" class="octicon octicon-eye" height="16" version="1.1" viewBox="0 0 16 16" width="16"><path d="M8.06 2C3 2 0 8 0 8s3 6 8.06 6C13 14 16 8 16 8s-3-6-7.94-6zM8 12c-2.2 0-4-1.78-4-4 0-2.2 1.8-4 4-4 2.22 0 4 1.8 4 4 0 2.22-1.78 4-4 4zm2-4c0 1.11-.89 2-2 2-1.11 0-2-.89-2-2 0-1.11.89-2 2-2 1.11 0 2 .89 2 2z"></path></svg> Watch </a> <a class="social-count" href="/lxc/lxc/watchers"> 175 </a> </li> <li> <a href="/login?return_to=%2Flxc%2Flxc" class="btn btn-sm btn-with-count tooltipped tooltipped-n" aria-label="You must be signed in to star a repository" rel="nofollow"> <svg aria-hidden="true" class="octicon octicon-star" height="16" version="1.1" viewBox="0 0 14 16" width="14"><path d="M14 6l-4.9-.64L7 1 4.9 5.36 0 6l3.6 3.26L2.67 14 7 11.67 11.33 14l-.93-4.74z"></path></svg> Star </a> <a class="social-count js-social-count" href="/lxc/lxc/stargazers"> 1,491 </a> </li> <li> <a href="/login?return_to=%2Flxc%2Flxc" class="btn btn-sm btn-with-count tooltipped tooltipped-n" aria-label="You must be signed in to fork a repository" rel="nofollow"> <svg aria-hidden="true" class="octicon octicon-repo-forked" height="16" version="1.1" viewBox="0 0 10 16" width="10"><path d="M8 1a1.993 1.993 0 0 0-1 3.72V6L5 8 3 6V4.72A1.993 1.993 0 0 0 2 1a1.993 1.993 0 0 0-1 3.72V6.5l3 3v1.78A1.993 1.993 0 0 0 5 15a1.993 1.993 0 0 0 1-3.72V9.5l3-3V4.72A1.993 1.993 0 0 0 8 1zM2 4.2C1.34 4.2.8 3.65.8 3c0-.65.55-1.2 1.2-1.2.65 0 1.2.55 1.2 1.2 0 .65-.55 1.2-1.2 1.2zm3 10c-.66 0-1.2-.55-1.2-1.2 0-.65.55-1.2 1.2-1.2.65 0 1.2.55 1.2 1.2 0 .65-.55 1.2-1.2 1.2zm3-10c-.66 0-1.2-.55-1.2-1.2 0-.65.55-1.2 1.2-1.2.65 0 1.2.55 1.2 1.2 0 .65-.55 1.2-1.2 1.2z"></path></svg> Fork </a> <a href="/lxc/lxc/network" class="social-count"> 519 </a> </li> </ul> <h1 class="public "> <svg aria-hidden="true" class="octicon octicon-repo" height="16" version="1.1" viewBox="0 0 12 16" width="12"><path d="M4 9H3V8h1v1zm0-3H3v1h1V6zm0-2H3v1h1V4zm0-2H3v1h1V2zm8-1v12c0 .55-.45 1-1 1H6v2l-1.5-1.5L3 16v-2H1c-.55 0-1-.45-1-1V1c0-.55.45-1 1-1h10c.55 0 1 .45 1 1zm-1 10H1v2h2v-1h3v1h5v-2zm0-10H2v9h9V1z"></path></svg> <span class="author" itemprop="author"><a href="/lxc" class="url fn" rel="author">lxc</a></span><!-- --><span class="path-divider">/</span><!-- --><strong itemprop="name"><a href="/lxc/lxc" data-pjax="#js-repo-pjax-container">lxc</a></strong> </h1> </div> <div class="container"> <nav class="reponav js-repo-nav js-sidenav-container-pjax" itemscope itemtype="http://schema.org/BreadcrumbList"; role="navigation" data-pjax="#js-repo-pjax-container"> <span itemscope itemtype="http://schema.org/ListItem"; itemprop="itemListElement"> <a href="/lxc/lxc" class="js-selected-navigation-item reponav-item" data-hotkey="g c" data-selected-links="repo_source repo_downloads repo_commits repo_releases repo_tags repo_branches /lxc/lxc" itemprop="url"> <svg aria-hidden="true" class="octicon octicon-code" height="16" version="1.1" viewBox="0 0 14 16" width="14"><path d="M9.5 3L8 4.5 11.5 8 8 11.5 9.5 13 14 8 9.5 3zm-5 0L0 8l4.5 5L6 11.5 2.5 8 6 4.5 4.5 3z"></path></svg> <span itemprop="name">Code</span> <meta itemprop="position" content="1"> </a> </span> <span itemscope itemtype="http://schema.org/ListItem"; itemprop="itemListElement"> <a href="/lxc/lxc/issues" class="js-selected-navigation-item reponav-item" data-hotkey="g i" data-selected-links="repo_issues repo_labels repo_milestones /lxc/lxc/issues" itemprop="url"> <svg aria-hidden="true" class="octicon octicon-issue-opened" height="16" version="1.1" viewBox="0 0 14 16" width="14"><path d="M7 2.3c3.14 0 5.7 2.56 5.7 5.7s-2.56 5.7-5.7 5.7A5.71 5.71 0 0 1 1.3 8c0-3.14 2.56-5.7 5.7-5.7zM7 1C3.14 1 0 4.14 0 8s3.14 7 7 7 7-3.14 7-7-3.14-7-7-7zm1 3H6v5h2V4zm0 6H6v2h2v-2z"></path></svg> <span itemprop="name">Issues</span> <span class="counter">217</span> <meta itemprop="position" content="2"> </a> </span> <span itemscope itemtype="http://schema.org/ListItem"; itemprop="itemListElement"> <a href="/lxc/lxc/pulls" aria-selected="true" class="js-selected-navigation-item selected reponav-item" data-hotkey="g p" data-selected-links="repo_pulls /lxc/lxc/pulls" itemprop="url"> <svg aria-hidden="true" class="octicon octicon-git-pull-request" height="16" version="1.1" viewBox="0 0 12 16" width="12"><path d="M11 11.28V5c-.03-.78-.34-1.47-.94-2.06C9.46 2.35 8.78 2.03 8 2H7V0L4 3l3 3V4h1c.27.02.48.11.69.31.21.2.3.42.31.69v6.28A1.993 1.993 0 0 0 10 15a1.993 1.993 0 0 0 1-3.72zm-1 2.92c-.66 0-1.2-.55-1.2-1.2 0-.65.55-1.2 1.2-1.2.65 0 1.2.55 1.2 1.2 0 .65-.55 1.2-1.2 1.2zM4 3c0-1.11-.89-2-2-2a1.993 1.993 0 0 0-1 3.72v6.56A1.993 1.993 0 0 0 2 15a1.993 1.993 0 0 0 1-3.72V4.72c.59-.34 1-.98 1-1.72zm-.8 10c0 .66-.55 1.2-1.2 1.2-.65 0-1.2-.55-1.2-1.2 0-.65.55-1.2 1.2-1.2.65 0 1.2.55 1.2 1.2zM2 4.2C1.34 4.2.8 3.65.8 3c0-.65.55-1.2 1.2-1.2.65 0 1.2.55 1.2 1.2 0 .65-.55 1.2-1.2 1.2z"></path></svg> <span itemprop="name">Pull requests</span> <span class="counter">5</span> <meta itemprop="position" content="3"> </a> </span> <a href="/lxc/lxc/pulse" class="js-selected-navigation-item reponav-item" data-selected-links="pulse /lxc/lxc/pulse"> <svg aria-hidden="true" class="octicon octicon-pulse" height="16" version="1.1" viewBox="0 0 14 16" width="14"><path d="M11.5 8L8.8 5.4 6.6 8.5 5.5 1.6 2.38 8H0v2h3.6l.9-1.8.9 5.4L9 8.5l1.6 1.5H14V8z"></path></svg> Pulse </a> <a href="/lxc/lxc/graphs" class="js-selected-navigation-item reponav-item" data-selected-links="repo_graphs repo_contributors /lxc/lxc/graphs"> <svg aria-hidden="true" class="octicon octicon-graph" height="16" version="1.1" viewBox="0 0 16 16" width="16"><path d="M16 14v1H0V0h1v14h15zM5 13H3V8h2v5zm4 0H7V3h2v10zm4 0h-2V6h2v7z"></path></svg> Graphs </a> </nav> </div> </div> <div class="container new-discussion-timeline experiment-repo-nav"> <div class="repository-content"> <!-- base sha1: "813d7f1453e6e28adc0fdfac62d9c4597a87e430" --> <!-- head sha1: "607e7e0bb8173e0f8e4a9ee4a64d9eb286f87e8b" --> <div class="issues-listing" data-pjax> <div class="clearfix js-issues-results"> <div id="partial-discussion-header" class="gh-header js-details-container js-socket-channel js-updatable-content pull request" data-channel="tenant:1:pull_request:79041992" data-url="/lxc/lxc/pull/1102/show_partial?partial=pull_requests%2Ftitle"> <div class="gh-header-show "> <div class="gh-header-actions"> </div> <h1 class="gh-header-title"> <span class=" js-issue-title"> setns instead of unshare in lxc-attach </span> <span class="gh-header-number">#1102</span> </h1> </div> <div class="flex-table gh-header-meta"> <div class="flex-table-item"> <div class="state state-open"> <svg aria-hidden="true" class="octicon octicon-git-pull-request" height="16" version="1.1" viewBox="0 0 12 16" width="12"><path d="M11 11.28V5c-.03-.78-.34-1.47-.94-2.06C9.46 2.35 8.78 2.03 8 2H7V0L4 3l3 3V4h1c.27.02.48.11.69.31.21.2.3.42.31.69v6.28A1.993 1.993 0 0 0 10 15a1.993 1.993 0 0 0 1-3.72zm-1 2.92c-.66 0-1.2-.55-1.2-1.2 0-.65.55-1.2 1.2-1.2.65 0 1.2.55 1.2 1.2 0 .65-.55 1.2-1.2 1.2zM4 3c0-1.11-.89-2-2-2a1.993 1.993 0 0 0-1 3.72v6.56A1.993 1.993 0 0 0 2 15a1.993 1.993 0 0 0 1-3.72V4.72c.59-.34 1-.98 1-1.72zm-.8 10c0 .66-.55 1.2-1.2 1.2-.65 0-1.2-.55-1.2-1.2 0-.65.55-1.2 1.2-1.2.65 0 1.2.55 1.2 1.2zM2 4.2C1.34 4.2.8 3.65.8 3c0-.65.55-1.2 1.2-1.2.65 0 1.2.55 1.2 1.2 0 .65-.55 1.2-1.2 1.2z"></path></svg> Open </div> </div> <div class="flex-table-item flex-table-item-primary"> <a href="/chenhaiq" class="author pull-header-username css-truncate css-truncate-target expandable"> chenhaiq </a> wants to merge 1 commit into <span class="commit-ref current-branch css-truncate user-select-contain expandable" title="lxc/lxc:master"><span class="css-truncate-target user">lxc</span>:<span class="css-truncate-target">master</span></span> from <span class="commit-ref current-branch css-truncate user-select-contain expandable" title="chenhaiq/lxc:master"><span class="css-truncate-target user">chenhaiq</span>:<span class="css-truncate-target">master</span></span> </div> </div> </div> <div class="tabnav tabnav-pr"> <div class="tabnav-extra right"> <span class="diffstat" id="diffstat"> <span class="text-diff-added"> +3 </span> <span class="text-diff-deleted"> −12 </span> <span class="tooltipped tooltipped-s" aria-label="15 lines changed"> <span class="block-diff-added"></span><span class="block-diff-deleted"></span><span class="block-diff-deleted"></span><span class="block-diff-deleted"></span><span class="block-diff-deleted"></span> </span> </span> </div> <nav class="tabnav-tabs"> <a href="/lxc/lxc/pull/1102" class="tabnav-tab selected js-pjax-history-navigate"> <svg aria-hidden="true" class="octicon octicon-comment-discussion" height="16" version="1.1" viewBox="0 0 16 16" width="16"><path d="M15 1H6c-.55 0-1 .45-1 1v2H1c-.55 0-1 .45-1 1v6c0 .55.45 1 1 1h1v3l3-3h4c.55 0 1-.45 1-1V9h1l3 3V9h1c.55 0 1-.45 1-1V2c0-.55-.45-1-1-1zM9 11H4.5L3 12.5V11H1V5h4v3c0 .55.45 1 1 1h3v2zm6-3h-2v1.5L11.5 8H6V2h9v6z"></path></svg> Conversation <span id="conversation_tab_counter" class="counter"> 0 </span> </a> <a href="/lxc/lxc/pull/1102/commits" class="tabnav-tab js-pjax-history-navigate"> <svg aria-hidden="true" class="octicon octicon-git-commit" height="16" version="1.1" viewBox="0 0 14 16" width="14"><path d="M10.86 7c-.45-1.72-2-3-3.86-3-1.86 0-3.41 1.28-3.86 3H0v2h3.14c.45 1.72 2 3 3.86 3 1.86 0 3.41-1.28 3.86-3H14V7h-3.14zM7 10.2c-1.22 0-2.2-.98-2.2-2.2 0-1.22.98-2.2 2.2-2.2 1.22 0 2.2.98 2.2 2.2 0 1.22-.98 2.2-2.2 2.2z"></path></svg> Commits <span id="commits_tab_counter" class="counter"> 1 </span> </a> <link rel="pjax-prefetch" href="/lxc/lxc/pull/1102/files"> <a href="/lxc/lxc/pull/1102/files" class="tabnav-tab js-pjax-history-navigate"> <svg aria-hidden="true" class="octicon octicon-diff" height="16" version="1.1" viewBox="0 0 13 16" width="13"><path d="M6 7h2v1H6v2H5V8H3V7h2V5h1v2zm-3 6h5v-1H3v1zM7.5 2L11 5.5V15c0 .55-.45 1-1 1H1c-.55 0-1-.45-1-1V3c0-.55.45-1 1-1h6.5zM10 6L7 3H1v12h9V6zM8.5 0H3v1h5l4 4v8h1V4.5L8.5 0z"></path></svg> Files changed <span id="files_tab_counter" class="counter"> 1 </span> </a> </nav> </div> <div id="discussion_bucket" class="clearfix pull-request-tab-content is-visible"> <div class="discussion-sidebar js-sticky"> <div id="partial-discussion-sidebar" class="js-socket-channel js-updatable-content" data-channel="tenant:1:pull_request:79041992" data-url="/lxc/lxc/issues/1102/show_partial?partial=issues%2Fsidebar"> <div class="discussion-sidebar-item sidebar-labels js-discussion-sidebar-item"> <!-- </textarea> --><!-- '"` --><form accept-charset="UTF-8" action="/lxc/lxc/issues/1102?partial=issues%2Fsidebar%2Fshow%2Flabels" class="js-issue-sidebar-form" data-form-nonce="4a6252b86ab51151d851e7df9b4c8066b5c638f0" data-remote="true" method="post"><div style="margin:0;padding:0;display:inline"><input name="utf8" type="hidden" value="✓" /><input name="_method" type="hidden" value="put" /><input name="authenticity_token" type="hidden" value="nM7xg2/JHU9NsQVAi5WFM8fuzDCQDUB20NY0rKiHwG0SQ0ttAHT6rRgZ8CFOKbS+Wagnc++912V0LoY0D8X/Zw==" /></div> <h3 class="discussion-sidebar-heading"> Labels </h3> <div class="labels css-truncate"> None yet </div> </form></div> <div class="discussion-sidebar-item sidebar-milestone js-discussion-sidebar-item"> <!-- </textarea> --><!-- '"` --><form accept-charset="UTF-8" action="/lxc/lxc/issues/1102/set_milestone?partial=issues%2Fsidebar%2Fshow%2Fmilestone" class="js-issue-sidebar-form" data-form-nonce="4a6252b86ab51151d851e7df9b4c8066b5c638f0" data-remote="true" method="post"><div style="margin:0;padding:0;display:inline"><input name="utf8" type="hidden" value="✓" /><input name="_method" type="hidden" value="put" /><input name="authenticity_token" type="hidden" value="12BVJ4xtSadH690aB1Kg4oB8H74Xoz3iJVLIV9rkhUSxgFGXgLfQhxJzvBOYvwVqcJzTkdCQtf8aaL86IxmKJA==" /></div> <h3 class="discussion-sidebar-heading"> Milestone </h3> No milestone </form></div> <div class="discussion-sidebar-item sidebar-assignee js-discussion-sidebar-item"> <!-- </textarea> --><!-- '"` --><form accept-charset="UTF-8" action="/lxc/lxc/issues/1102?partial=issues%2Fsidebar%2Fshow%2Fassignees" class="js-issue-sidebar-form" data-form-nonce="4a6252b86ab51151d851e7df9b4c8066b5c638f0" data-remote="true" method="post"><div style="margin:0;padding:0;display:inline"><input name="utf8" type="hidden" value="✓" /><input name="_method" type="hidden" value="put" /><input name="authenticity_token" type="hidden" value="oBBn1mWeIRzSZaptxnLV4Lrxe4uqEAoUJoPUS3hxrPWTwZ2As9+/LE4IstZ7pqM00pU0RU6t46iVg/Y8tr2dpg==" /></div> <h3 class="discussion-sidebar-heading"> Assignees </h3> <span class="css-truncate"> No one assigned </span> </form></div> <div id="partial-users-participants" class="discussion-sidebar-item"> <div class="participation"> <h3 class="discussion-sidebar-heading"> 1 participant </h3> <div class="participation-avatars"> <a class="participant-avatar tooltipped tooltipped-n" aria-label="chenhaiq" href="/chenhaiq"><img alt="@chenhaiq" class="avatar" height="26" src="https://avatars0.githubusercontent.com/u/4373761?v=3&s=52"; width="26" /> </a> </div> </div> </div> </div> </div> <div class="discussion-timeline pull-discussion-timeline js-pull-discussion-timeline js-quote-selection-container js-review-state-classes "> <div class="js-discussion js-socket-channel" data-channel="tenant:1:marked-as-read:pull-request:79041992"> <div class="timeline-comment-wrapper js-comment-container"> <a href="/chenhaiq"><img alt="@chenhaiq" class="timeline-comment-avatar" height="48" src="https://avatars1.githubusercontent.com/u/4373761?v=3&s=96"; width="48" /></a> <div id="issue-167878784" class="comment previewable-edit timeline-comment js-comment js-task-list-container " data-body-version="7fad66fe24a4eab6ee36ecc63ddd36f8"> <div class="timeline-comment-header "> <div class="timeline-comment-actions"> </div> <div class="timeline-comment-header-text"> <strong> <a href="/chenhaiq" class="author">chenhaiq</a> </strong> commented <a href="#issue-167878784" class="timestamp"> <relative-time datetime="2016-07-27T15:09:53Z">Jul 27, 2016</relative-time> </a> </div> </div> <div class="edit-comment-hide"> <div class="comment-body markdown-body markdown-format js-comment-body"> <p>The process created by lxc-attach has incorrect cgroup ns. It fails lxc-checkpoint as reported in <a href="https://github.com/xemul/criu/issues/174";>criu issue</a>.<br> A real example for this issue, which is used to update ip address:</p> <ol> <li>start lxc instance with debian image</li> <li>lxc-attach -n -- service networking restart</li> <li>lxc-checkpoint -n -D </li> </ol> <p>lxc-checkpoint will fail because dhclient process has incorrect cgroup ns. It needs to use setns instead of unshare to set cgroup ns. "setns" already supports cgroup ns in kernel of ubuntu 16.04.</p> </div> </div> <div class="js-socket-channel js-updatable-content comment-reactions js-reactions-container" data-channel="tenant:1:reaction:issue:167878784" data-url="/lxc/lxc/reactions/issue/167878784"> </div> </div> </div> <div class="discussion-item discussion-commits" id="commits-pushed-607e7e0"> <div class="discussion-item-body"> <table class="timeline-commits"> <tr class="commit js-details-container js-socket-channel js-updatable-content" data-channel="tenant:1:repo:5720995:commit:607e7e0bb8173e0f8e4a9ee4a64d9eb286f87e8b" data-url="/lxc/lxc/pull/1102/commit/607e7e0bb8173e0f8e4a9ee4a64d9eb286f87e8b/show_partial?partial=commit%2Fpull_condensed"> <td class="commit-icon"> <svg aria-hidden="true" class="octicon octicon-git-commit" height="16" version="1.1" viewBox="0 0 14 16" width="14"><path d="M10.86 7c-.45-1.72-2-3-3.86-3-1.86 0-3.41 1.28-3.86 3H0v2h3.14c.45 1.72 2 3 3.86 3 1.86 0 3.41-1.28 3.86-3H14V7h-3.14zM7 10.2c-1.22 0-2.2-.98-2.2-2.2 0-1.22.98-2.2 2.2-2.2 1.22 0 2.2.98 2.2 2.2 0 1.22-.98 2.2-2.2 2.2z"></path></svg> </td> <td class="commit-gravatar"> <img alt="" class="avatar avatar-small" height="16" src="https://2.gravatar.com/avatar/328437404aefdc6584e63c933c56268f?d=https%3A%2F%2Fassets-cdn.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png&r=x&s=140"; width="16" /> </td> <td class="commit-author"> <strong><span class="author">oc</span></strong> </td> <td class="commit-message"> <code><a href="/lxc/lxc/pull/1102/commits/607e7e0bb8173e0f8e4a9ee4a64d9eb286f87e8b" class="message" data-pjax="true" title="setns instead of unshare in lxc-attach">setns instead of unshare in lxc-attach</a></code> </td> <td class="commit-sig-status"> </td> <td class="commit-ci-status"> </td> <td class="commit-meta"> <code><a href="/lxc/lxc/pull/1102/commits/607e7e0bb8173e0f8e4a9ee4a64d9eb286f87e8b" class="commit-id">607e7e0</a></code> </td> </tr> </table> </div> </div> <!-- Rendered timeline since 2016-07-27 07:43:58 --> <div id="partial-timeline-marker" class="js-timeline-marker js-socket-channel js-updatable-content" data-channel="tenant:1:pull_request:79041992" data-url="/lxc/lxc/pull/1102/show_partial?partial=pull_requests%2Ftimeline_marker&since=1469630638" data-last-modified="Wed, 27 Jul 2016 14:43:58 GMT"> <!-- </textarea> --><!-- '"` --><form accept-charset="UTF-8" action="/lxc/lxc/notifications/mark?ids=156839593" class="hidden js-timeline-marker-form" data-form-nonce="4a6252b86ab51151d851e7df9b4c8066b5c638f0" data-remote="true" method="post"><div style="margin:0;padding:0;display:inline"><input name="utf8" type="hidden" value="✓" /><input name="authenticity_token" type="hidden" value="cVWV7OfvgwMXBVdPWiFASngiGFAJ65q/aoXH2x6oAP/MjZBdpOoP1KT6mKV+oY0yLg7qzrGvKddY6gQbOJom0Q==" /></div> </form></div> </div> <div class="discussion-timeline-actions"> <div class="signed-out-comment"> <a href="/join?source=comment-repo" class="btn btn-primary" rel="nofollow">Sign up for free</a> <strong>to join this conversation on GitHub</strong>. Already have an account? <a href="/login?return_to=https%3A%2F%2Fgithub.com%2Flxc%2Flxc%2Fpull%2F1102" rel="nofollow">Sign in to comment</a> </div> </div> </div> </div> </div> </div> </div> <div class="modal-backdrop js-touch-events"></div> </div> </div> </div> </div> <div class="container site-footer-container"> <div class="site-footer" role="contentinfo"> <ul class="site-footer-links right"> <li><a href="https://github.com/contact"; data-ga-click="Footer, go to contact, text:contact">Contact GitHub</a></li> <li><a href="https://developer.github.com"; data-ga-click="Footer, go to api, text:api">API</a></li> <li><a href="https://training.github.com"; data-ga-click="Footer, go to training, text:training">Training</a></li> <li><a href="https://shop.github.com"; data-ga-click="Footer, go to shop, text:shop">Shop</a></li> <li><a href="https://github.com/blog"; data-ga-click="Footer, go to blog, text:blog">Blog</a></li> <li><a href="https://github.com/about"; data-ga-click="Footer, go to about, text:about">About</a></li> </ul> <a href="https://github.com"; aria-label="Homepage" class="site-footer-mark" title="GitHub"> <svg aria-hidden="true" class="octicon octicon-mark-github" height="24" version="1.1" viewBox="0 0 16 16" width="24"><path d="M8 0C3.58 0 0 3.58 0 8c0 3.54 2.29 6.53 5.47 7.59.4.07.55-.17.55-.38 0-.19-.01-.82-.01-1.49-2.01.37-2.53-.49-2.69-.94-.09-.23-.48-.94-.82-1.13-.28-.15-.68-.52-.01-.53.63-.01 1.08.58 1.23.82.72 1.21 1.87.87 2.33.66.07-.52.28-.87.51-1.07-1.78-.2-3.64-.89-3.64-3.95 0-.87.31-1.59.82-2.15-.08-.2-.36-1.02.08-2.12 0 0 .67-.21 2.2.82.64-.18 1.32-.27 2-.27.68 0 1.36.09 2 .27 1.53-1.04 2.2-.82 2.2-.82.44 1.1.16 1.92.08 2.12.51.56.82 1.27.82 2.15 0 3.07-1.87 3.75-3.65 3.95.29.25.54.73.54 1.48 0 1.07-.01 1.93-.01 2.2 0 .21.15.46.55.38A8.013 8.013 0 0 0 16 8c0-4.42-3.58-8-8-8z"></path></svg> </a> <ul class="site-footer-links"> <li>© 2016 <span title="0.22735s from github-fe124-cp1-prd.iad.github.net">GitHub</span>, Inc.</li> <li><a href="https://github.com/site/terms"; data-ga-click="Footer, go to terms, text:terms">Terms</a></li> <li><a href="https://github.com/site/privacy"; data-ga-click="Footer, go to privacy, text:privacy">Privacy</a></li> <li><a href="https://github.com/security"; data-ga-click="Footer, go to security, text:security">Security</a></li> <li><a href="https://status.github.com/"; data-ga-click="Footer, go to status, text:status">Status</a></li> <li><a href="https://help.github.com"; data-ga-click="Footer, go to help, text:help">Help</a></li> </ul> </div> </div> <div id="ajax-error-message" class="ajax-error-message flash flash-error"> <svg aria-hidden="true" class="octicon octicon-alert" height="16" version="1.1" viewBox="0 0 16 16" width="16"><path d="M8.865 1.52c-.18-.31-.51-.5-.87-.5s-.69.19-.87.5L.275 13.5c-.18.31-.18.69 0 1 .19.31.52.5.87.5h13.7c.36 0 .69-.19.86-.5.17-.31.18-.69.01-1L8.865 1.52zM8.995 13h-2v-2h2v2zm0-3h-2V6h2v4z"></path></svg> <button type="button" class="flash-close js-flash-close js-ajax-error-dismiss" aria-label="Dismiss error"> <svg aria-hidden="true" class="octicon octicon-x" height="16" version="1.1" viewBox="0 0 12 16" width="12"><path d="M7.48 8l3.75 3.75-1.48 1.48L6 9.48l-3.75 3.75-1.48-1.48L4.52 8 .77 4.25l1.48-1.48L6 6.52l3.75-3.75 1.48 1.48z"></path></svg> </button> Something went wrong with that request. Please try again. </div> <script crossorigin="anonymous" src="https://assets-cdn.github.com/assets/compat-7db58f8b7b91111107fac755dd8b178fe7db0f209ced51fc339c446ad3f8da2b.js";></script> <script crossorigin="anonymous" src="https://assets-cdn.github.com/assets/frameworks-404cdd1add1f710db016a02e5e31fff8a9089d14ff0c227df862b780886db7d5.js";></script> <script async="async" crossorigin="anonymous" src="https://assets-cdn.github.com/assets/github-3f5d9e94c6a78a31e0a2e7d99731e864821a0cdbd82d28bc6948ef8cc4675f0b.js";></script> <div class="js-stale-session-flash stale-session-flash flash flash-warn flash-banner hidden"> <svg aria-hidden="true" class="octicon octicon-alert" height="16" version="1.1" viewBox="0 0 16 16" width="16"><path d="M8.865 1.52c-.18-.31-.51-.5-.87-.5s-.69.19-.87.5L.275 13.5c-.18.31-.18.69 0 1 .19.31.52.5.87.5h13.7c.36 0 .69-.19.86-.5.17-.31.18-.69.01-1L8.865 1.52zM8.995 13h-2v-2h2v2zm0-3h-2V6h2v4z"></path></svg> <span class="signed-in-tab-flash">You signed in with another tab or window. <a href="">Reload</a> to refresh your session.</span> <span class="signed-out-tab-flash">You signed out in another tab or window. <a href="">Reload</a> to refresh your session.</span> </div> <div class="facebox" id="facebox" style="display:none;"> <div class="facebox-popup"> <div class="facebox-content" role="dialog" aria-labelledby="facebox-header" aria-describedby="facebox-description"> </div> <button type="button" class="facebox-close js-facebox-close" aria-label="Close modal"> <svg aria-hidden="true" class="octicon octicon-x" height="16" version="1.1" viewBox="0 0 12 16" width="12"><path d="M7.48 8l3.75 3.75-1.48 1.48L6 9.48l-3.75 3.75-1.48-1.48L4.52 8 .77 4.25l1.48-1.48L6 6.52l3.75-3.75 1.48 1.48z"></path></svg> </button> </div> </div> </body> </html>
_______________________________________________ lxc-devel mailing list lxc-devel@lists.linuxcontainers.org http://lists.linuxcontainers.org/listinfo/lxc-devel
![https://github.com/fluidicon.png"](https://github.com/fluidicon.png"){kind=link}
![https://assets-cdn.github.com/pinned-octocat.svg"](https://assets-cdn.github.com/pinned-octocat.svg"){kind=link}
![https://2.gravatar.com/avatar/328437404aefdc6584e63c933c56268f?d=https%3A%2F%2Fassets-cdn.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png&r=x&s=140"](https://2.gravatar.com/avatar/328437404aefdc6584e63c933c56268f?d=https%3A%2F%2Fassets-cdn.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png&r=x&s=140"){kind=link}