Re: [lxc-devel] [PATCH] Add common.conf.d

2015-01-20 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > Signed-off-by: Stéphane Graber Acked-by: Serge Hallyn > --- > config/templates/Makefile.am | 2 ++ > config/templates/common.conf.d/Makefile.am | 6 ++ > config/templates/common.conf.d/README | 6 ++ > config/templates/

Re: [lxc-devel] [PATCH] Add common.conf.d

2015-01-19 Thread Stéphane Graber
On Mon, Jan 19, 2015 at 09:44:09PM +0100, Michael Adam wrote: > On 2015-01-19 at 15:33 -0500, Stéphane Graber wrote: > > On Mon, Jan 19, 2015 at 09:25:48PM +0100, Michael Adam wrote: > > > Hi, > > > > > > just two minor comments inline below, > > > looks good to me, otherwise. > > > > > > Cheers

Re: [lxc-devel] [PATCH] Add common.conf.d

2015-01-19 Thread Michael Adam
On 2015-01-19 at 15:33 -0500, Stéphane Graber wrote: > On Mon, Jan 19, 2015 at 09:25:48PM +0100, Michael Adam wrote: > > Hi, > > > > just two minor comments inline below, > > looks good to me, otherwise. > > > > Cheers - Michael > > > > On 2015-01-19 at 15:16 -0500, Stéphane Graber wrote: > > >

Re: [lxc-devel] [PATCH] Add common.conf.d

2015-01-19 Thread Stéphane Graber
On Mon, Jan 19, 2015 at 09:25:48PM +0100, Michael Adam wrote: > Hi, > > just two minor comments inline below, > looks good to me, otherwise. > > Cheers - Michael > > On 2015-01-19 at 15:16 -0500, Stéphane Graber wrote: > > Signed-off-by: Stéphane Graber > > --- > > config/templates/Makefile.am

Re: [lxc-devel] [PATCH] Add common.conf.d

2015-01-19 Thread Michael Adam
Hi, just two minor comments inline below, looks good to me, otherwise. Cheers - Michael On 2015-01-19 at 15:16 -0500, Stéphane Graber wrote: > Signed-off-by: Stéphane Graber > --- > config/templates/Makefile.am | 2 ++ > config/templates/common.conf.d/Makefile.am | 6 ++ > co

[lxc-devel] [PATCH] Add common.conf.d

2015-01-19 Thread Stéphane Graber
Signed-off-by: Stéphane Graber --- config/templates/Makefile.am | 2 ++ config/templates/common.conf.d/Makefile.am | 6 ++ config/templates/common.conf.d/README | 6 ++ config/templates/common.conf.in| 3 +++ configure.ac | 1 +