Re: [lxc-devel] [PATCH] Fix to work lxc-destroy with unprivileged containers on recent kernel

2014-07-03 Thread S . Çağlar Onur
On Tue, Jul 1, 2014 at 11:45 PM, Serge Hallyn wrote: > Quoting S.Çağlar Onur (cag...@10ur.org): >> OK I think I'm seeing something but haven't found the real problem, >> yet. Looks like some caller (or the caller of the caller etc.) is not >> checking the return code of the chown_mapped_root (from

Re: [lxc-devel] [PATCH] Fix to work lxc-destroy with unprivileged containers on recent kernel

2014-07-01 Thread Serge Hallyn
Quoting S.Çağlar Onur (cag...@10ur.org): > OK I think I'm seeing something but haven't found the real problem, > yet. Looks like some caller (or the caller of the caller etc.) is not > checking the return code of the chown_mapped_root (from > src/lxc/conf.c) function and trying to progress. That se

Re: [lxc-devel] [PATCH] Fix to work lxc-destroy with unprivileged containers on recent kernel

2014-07-01 Thread S . Çağlar Onur
> >> I wonder what could be causing this issue for the Go binding, some weird >> threading bug again? > > Yeah it looks like it. Will try to dig in more over the weekend and > will let you know if I can find something or somehow able to reproduce > the issue outside of

Re: [lxc-devel] [PATCH] Fix to work lxc-destroy with unprivileged containers on recent kernel

2014-07-01 Thread S . Çağlar Onur
to dig in more over the weekend and will let you know if I can find something or somehow able to reproduce the issue outside of the go world. >> >> On Mon, Jun 30, 2014 at 10:46 AM, Serge Hallyn >> wrote: >> > Quoting KATOH Yasufumi (ka...@jazz.email.ne.jp): >> &g

Re: [lxc-devel] [PATCH] Fix to work lxc-destroy with unprivileged containers on recent kernel

2014-06-30 Thread Stéphane Graber
On Mon, Jun 30, 2014 at 10:46 AM, Serge Hallyn > wrote: > > Quoting KATOH Yasufumi (ka...@jazz.email.ne.jp): > >> Hi, > >> > >> I applied this patch and test. lxc-destroy work fine. :-) > >> > >> >>> On Sat, 28 Jun 2014 18:39

Re: [lxc-devel] [PATCH] Fix to work lxc-destroy with unprivileged containers on recent kernel

2014-06-30 Thread S . Çağlar Onur
at 10:46 AM, Serge Hallyn wrote: > Quoting KATOH Yasufumi (ka...@jazz.email.ne.jp): >> Hi, >> >> I applied this patch and test. lxc-destroy work fine. :-) >> >> >>> On Sat, 28 Jun 2014 18:39:54 +0900 >> in message "[lxc-devel] [PATCH] Fix t

Re: [lxc-devel] [PATCH] Fix to work lxc-destroy with unprivileged containers on recent kernel

2014-06-30 Thread Serge Hallyn
Quoting KATOH Yasufumi (ka...@jazz.email.ne.jp): > Hi, > > I applied this patch and test. lxc-destroy work fine. :-) > > >>> On Sat, 28 Jun 2014 18:39:54 +0900 > in message "[lxc-devel] [PATCH] Fix to work lxc-destroy with > unprivilege

Re: [lxc-devel] [PATCH] Fix to work lxc-destroy with unprivileged containers on recent kernel

2014-06-29 Thread KATOH Yasufumi
Hi, I applied this patch and test. lxc-destroy work fine. :-) >>> On Sat, 28 Jun 2014 18:39:54 +0900 in message "[lxc-devel] [PATCH] Fix to work lxc-destroy with unprivileged containers on recent kernel" TAMUKI Shoichi-san wrote: > Change idma

[lxc-devel] [PATCH] Fix to work lxc-destroy with unprivileged containers on recent kernel

2014-06-28 Thread TAMUKI Shoichi
Change idmap_add_id() to add both ID_TYPE_UID and ID_TYPE_GID entries to an existing lxc_conf, not just an ID_TYPE_UID entry, so as to work lxc-destroy with unprivileged containers on recent kernel. Signed-off-by: TAMUKI Shoichi --- src/lxc/conf.c | 49 ++-