Re: [lxc-devel] [PATCH] fix fd leak in test-concurrent

2014-03-10 Thread Serge Hallyn
Quoting S.Çağlar Onur (cag...@10ur.org): > On Mon, Mar 10, 2014 at 10:58 AM, Serge Hallyn > wrote: > > Quoting S.Çağlar Onur (cag...@10ur.org): > >> On Fri, Mar 7, 2014 at 5:12 PM, Serge Hallyn > >> wrote: > >> > Quoting Dwight Engen (dwight.en...@oracle.com): > >> >> Opening a debug log for ev

Re: [lxc-devel] [PATCH] fix fd leak in test-concurrent

2014-03-10 Thread S . Çağlar Onur
On Mon, Mar 10, 2014 at 10:58 AM, Serge Hallyn wrote: > Quoting S.Çağlar Onur (cag...@10ur.org): >> On Fri, Mar 7, 2014 at 5:12 PM, Serge Hallyn wrote: >> > Quoting Dwight Engen (dwight.en...@oracle.com): >> >> Opening a debug log for every thread at every iteration of test-concurrent >> >> cause

Re: [lxc-devel] [PATCH] fix fd leak in test-concurrent

2014-03-10 Thread Serge Hallyn
Quoting S.Çağlar Onur (cag...@10ur.org): > On Fri, Mar 7, 2014 at 5:12 PM, Serge Hallyn wrote: > > Quoting Dwight Engen (dwight.en...@oracle.com): > >> Opening a debug log for every thread at every iteration of test-concurrent > >> causes it to quickly run out of fd's because this fd is leaked. Fi

Re: [lxc-devel] [PATCH] fix fd leak in test-concurrent

2014-03-08 Thread S . Çağlar Onur
On Fri, Mar 7, 2014 at 5:12 PM, Serge Hallyn wrote: > Quoting Dwight Engen (dwight.en...@oracle.com): >> Opening a debug log for every thread at every iteration of test-concurrent >> causes it to quickly run out of fd's because this fd is leaked. Fix this >> by adding a new api: lxc_log_close(). >

Re: [lxc-devel] [PATCH] fix fd leak in test-concurrent

2014-03-08 Thread S . Çağlar Onur
Hey Dwight, On Sat, Mar 8, 2014 at 9:14 PM, S.Çağlar Onur wrote: > Hey Dwight, > > On Fri, Mar 7, 2014 at 6:48 PM, Dwight Engen wrote: >> On Fri, 7 Mar 2014 16:12:23 -0600 >> Serge Hallyn wrote: >> >>> Quoting Dwight Engen (dwight.en...@oracle.com): >>> > Opening a debug log for every thread at

Re: [lxc-devel] [PATCH] fix fd leak in test-concurrent

2014-03-08 Thread S . Çağlar Onur
Hey Dwight, On Fri, Mar 7, 2014 at 6:48 PM, Dwight Engen wrote: > On Fri, 7 Mar 2014 16:12:23 -0600 > Serge Hallyn wrote: > >> Quoting Dwight Engen (dwight.en...@oracle.com): >> > Opening a debug log for every thread at every iteration of >> > test-concurrent causes it to quickly run out of fd's

Re: [lxc-devel] [PATCH] fix fd leak in test-concurrent

2014-03-07 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > On Fri, 7 Mar 2014 16:12:23 -0600 > Serge Hallyn wrote: > > > Quoting Dwight Engen (dwight.en...@oracle.com): > > > Opening a debug log for every thread at every iteration of > > > test-concurrent causes it to quickly run out of fd's because this

Re: [lxc-devel] [PATCH] fix fd leak in test-concurrent

2014-03-07 Thread Dwight Engen
On Fri, 7 Mar 2014 16:12:23 -0600 Serge Hallyn wrote: > Quoting Dwight Engen (dwight.en...@oracle.com): > > Opening a debug log for every thread at every iteration of > > test-concurrent causes it to quickly run out of fd's because this > > fd is leaked. Fix this by adding a new api: lxc_log_clos

Re: [lxc-devel] [PATCH] fix fd leak in test-concurrent

2014-03-07 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > Opening a debug log for every thread at every iteration of test-concurrent > causes it to quickly run out of fd's because this fd is leaked. Fix this > by adding a new api: lxc_log_close(). > > As Caglar noted, the log handling is in general a bit

[lxc-devel] [PATCH] fix fd leak in test-concurrent

2014-03-07 Thread Dwight Engen
Opening a debug log for every thread at every iteration of test-concurrent causes it to quickly run out of fd's because this fd is leaked. Fix this by adding a new api: lxc_log_close(). As Caglar noted, the log handling is in general a bit "interesting" because a logfile can be opened through the