Re: [lxc-devel] [PATCH] handle unprivileged user calls more gracefully (v3)

2014-01-20 Thread Stéphane Graber
On Sun, Jan 19, 2014 at 03:28:05PM -0500, S.Çağlar Onur wrote: > Return an error if the function is not supposed to be called by an > unprivileged user. > Otherwise those calls fail in the middle of their execution with different > reasons. > > changes since v2: > - am_unpriv is now a simple get

[lxc-devel] [PATCH] handle unprivileged user calls more gracefully (v3)

2014-01-19 Thread S . Çağlar Onur
Return an error if the function is not supposed to be called by an unprivileged user. Otherwise those calls fail in the middle of their execution with different reasons. changes since v2: - am_unpriv is now a simple geteuid check, - API functions are now providing error messages, - lxc-info, lxc

Re: [lxc-devel] [PATCH] handle unprivileged user calls more gracefully (v2)

2014-01-18 Thread Stéphane Graber
On Sat, Jan 18, 2014 at 01:31:14PM -0500, S.Çağlar Onur wrote: > On Sat, Jan 18, 2014 at 12:38 AM, S.Çağlar Onur wrote: > > On Sat, Jan 18, 2014 at 12:12 AM, Stéphane Graber > > wrote: > >> On Sat, Jan 18, 2014 at 12:03:19AM -0500, S.Çağlar Onur wrote: > >>> On Sat, Jan 18, 2014 at 12:00 AM, Sté

Re: [lxc-devel] [PATCH] handle unprivileged user calls more gracefully (v2)

2014-01-18 Thread S . Çağlar Onur
On Sat, Jan 18, 2014 at 12:38 AM, S.Çağlar Onur wrote: > On Sat, Jan 18, 2014 at 12:12 AM, Stéphane Graber wrote: >> On Sat, Jan 18, 2014 at 12:03:19AM -0500, S.Çağlar Onur wrote: >>> On Sat, Jan 18, 2014 at 12:00 AM, Stéphane Graber >>> wrote: >>> > On Fri, Jan 17, 2014 at 11:58:17PM -0500, S.

Re: [lxc-devel] [PATCH] handle unprivileged user calls more gracefully (v2)

2014-01-17 Thread S . Çağlar Onur
On Sat, Jan 18, 2014 at 12:12 AM, Stéphane Graber wrote: > On Sat, Jan 18, 2014 at 12:03:19AM -0500, S.Çağlar Onur wrote: >> On Sat, Jan 18, 2014 at 12:00 AM, Stéphane Graber >> wrote: >> > On Fri, Jan 17, 2014 at 11:58:17PM -0500, S.Çağlar Onur wrote: >> >> On Fri, Jan 17, 2014 at 11:49 PM, Sté

Re: [lxc-devel] [PATCH] handle unprivileged user calls more gracefully (v2)

2014-01-17 Thread Stéphane Graber
On Sat, Jan 18, 2014 at 12:03:19AM -0500, S.Çağlar Onur wrote: > On Sat, Jan 18, 2014 at 12:00 AM, Stéphane Graber wrote: > > On Fri, Jan 17, 2014 at 11:58:17PM -0500, S.Çağlar Onur wrote: > >> On Fri, Jan 17, 2014 at 11:49 PM, Stéphane Graber > >> wrote: > >> > On Fri, Jan 17, 2014 at 11:34:50P

Re: [lxc-devel] [PATCH] handle unprivileged user calls more gracefully (v2)

2014-01-17 Thread S . Çağlar Onur
On Sat, Jan 18, 2014 at 12:00 AM, Stéphane Graber wrote: > On Fri, Jan 17, 2014 at 11:58:17PM -0500, S.Çağlar Onur wrote: >> On Fri, Jan 17, 2014 at 11:49 PM, Stéphane Graber >> wrote: >> > On Fri, Jan 17, 2014 at 11:34:50PM -0500, S.Çağlar Onur wrote: >> >> Return an error if the function is no

Re: [lxc-devel] [PATCH] handle unprivileged user calls more gracefully (v2)

2014-01-17 Thread Stéphane Graber
On Fri, Jan 17, 2014 at 11:58:17PM -0500, S.Çağlar Onur wrote: > On Fri, Jan 17, 2014 at 11:49 PM, Stéphane Graber wrote: > > On Fri, Jan 17, 2014 at 11:34:50PM -0500, S.Çağlar Onur wrote: > >> Return an error if the function is not supposed to be called by an > >> unprivileged user. > >> Otherwi

Re: [lxc-devel] [PATCH] handle unprivileged user calls more gracefully (v2)

2014-01-17 Thread S . Çağlar Onur
On Fri, Jan 17, 2014 at 11:49 PM, Stéphane Graber wrote: > On Fri, Jan 17, 2014 at 11:34:50PM -0500, S.Çağlar Onur wrote: >> Return an error if the function is not supposed to be called by an >> unprivileged user. >> Otherwise those calls fail in the middle of their execution with different >> r

Re: [lxc-devel] [PATCH] handle unprivileged user calls more gracefully (v2)

2014-01-17 Thread Stéphane Graber
On Fri, Jan 17, 2014 at 11:34:50PM -0500, S.Çağlar Onur wrote: > Return an error if the function is not supposed to be called by an > unprivileged user. > Otherwise those calls fail in the middle of their execution with different > reasons. > > changes since v1: > - am_unpriv is now a simple get

Re: [lxc-devel] [PATCH] handle unprivileged user calls more gracefully

2014-01-17 Thread S . Çağlar Onur
On Fri, Jan 17, 2014 at 7:34 PM, Stéphane Graber wrote: > On Fri, Jan 17, 2014 at 07:27:03PM -0500, S.Çağlar Onur wrote: >> Hey Stéphane, >> >> On Fri, Jan 17, 2014 at 3:18 PM, Stéphane Graber wrote: >> > On Fri, Jan 17, 2014 at 03:01:46PM -0500, S.Çağlar Onur wrote: >> >> Return an error if the

[lxc-devel] [PATCH] handle unprivileged user calls more gracefully (v2)

2014-01-17 Thread S . Çağlar Onur
Return an error if the function is not supposed to be called by an unprivileged user. Otherwise those calls fail in the middle of their execution with different reasons. changes since v1: - am_unpriv is now a simple geteuid check, - API functions are now providing error messages, - lxc-info, lxc

Re: [lxc-devel] [PATCH] handle unprivileged user calls more gracefully

2014-01-17 Thread Stéphane Graber
On Fri, Jan 17, 2014 at 07:27:03PM -0500, S.Çağlar Onur wrote: > Hey Stéphane, > > On Fri, Jan 17, 2014 at 3:18 PM, Stéphane Graber wrote: > > On Fri, Jan 17, 2014 at 03:01:46PM -0500, S.Çağlar Onur wrote: > >> Return an error if the function is not supposed to be called by an > >> unprivileged

Re: [lxc-devel] [PATCH] handle unprivileged user calls more gracefully

2014-01-17 Thread S . Çağlar Onur
Hey Stéphane, On Fri, Jan 17, 2014 at 3:18 PM, Stéphane Graber wrote: > On Fri, Jan 17, 2014 at 03:01:46PM -0500, S.Çağlar Onur wrote: >> Return an error if the function is not supposed to be called by an >> unprivileged user. >> Otherwise those calls fail in the middle of their execution with d

Re: [lxc-devel] [PATCH] handle unprivileged user calls more gracefully

2014-01-17 Thread Stéphane Graber
On Fri, Jan 17, 2014 at 03:01:46PM -0500, S.Çağlar Onur wrote: > Return an error if the function is not supposed to be called by an > unprivileged user. > Otherwise those calls fail in the middle of their execution with different > reasons. > > Signed-off-by: S.Çağlar Onur Hmm, so I have mixed

[lxc-devel] [PATCH] handle unprivileged user calls more gracefully

2014-01-17 Thread S . Çağlar Onur
Return an error if the function is not supposed to be called by an unprivileged user. Otherwise those calls fail in the middle of their execution with different reasons. Signed-off-by: S.Çağlar Onur --- src/lxc/lxccontainer.c | 33 - 1 file changed, 28 insertion