Re: [lxc-devel] [PATCH 1/3] cgroup: add cgroup_escape() call

2015-12-09 Thread Tycho Andersen
On Wed, Dec 09, 2015 at 02:58:20AM +, Serge Hallyn wrote: > Quoting Tycho Andersen (tycho.ander...@canonical.com): > > + bool ret = true, cgm_connected = false; > > Sorry, can you rename this disconnect_cgm or cgm_needs_disconnect ? Sure, see attached. Tycho >From

[lxc-devel] [PATCH 1/3] cgroup: add cgroup_escape() call

2015-12-08 Thread Tycho Andersen
We'll use this in the next patch to escape to the root cgroup before we exec criu. Signed-off-by: Tycho Andersen --- src/lxc/cgfs.c | 50 ++ src/lxc/cgmanager.c | 19 --- src/lxc/cgroup.c| 7

Re: [lxc-devel] [PATCH 1/3] cgroup: add cgroup_escape() call

2015-12-08 Thread Tycho Andersen
On Tue, Dec 08, 2015 at 04:08:09PM -0700, Tycho Andersen wrote: > Whoops, forgot the --compose flag. I should mention that this is on top of my already sent patches about adding the ->migrate API call. It probably doesn't matter except for patch 3, and even that git can probably figure out, but

Re: [lxc-devel] [PATCH 1/3] cgroup: add cgroup_escape() call

2015-12-08 Thread Serge Hallyn
Quoting Tycho Andersen (tycho.ander...@canonical.com): > We'll use this in the next patch to escape to the root cgroup before we > exec criu. > > Signed-off-by: Tycho Andersen > --- > src/lxc/cgfs.c | 50 ++ >